177049 2017-09-17 02:58:22 -0700 [Harfbuzz] adjustSelectionRectForComplexText() should also pass the character range when shaping 2017-09-27 12:31:57 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply commit-queue mcatanzaro mmaxfield webkit-bug-importer oldest_to_newest 1349738 0 cgarcia 2017-09-17 02:58:22 -0700 Now that the shaper support receiving a range we should use that also in adjustSelectionRectForComplexText(). This will ensure consistent results with getGlyphsAndAdvancesForComplexText(). 1349739 1 321040 cgarcia 2017-09-17 02:59:58 -0700 Created attachment 321040 Patch 1349744 2 321040 mcatanzaro 2017-09-17 06:02:16 -0700 Comment on attachment 321040 Patch What test does this fix? 1349844 3 cgarcia 2017-09-17 22:25:40 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 321040 [details] > Patch > > What test does this fix? This doesn't affect test results. 1349850 4 321040 commit-queue 2017-09-17 23:16:57 -0700 Comment on attachment 321040 Patch Rejecting attachment 321040 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 321040, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 6e14de628b80008549948a8e0122f4bf62c40f9a 86a8d7212f99ef652aa59bf346f93989ecd2afbd M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/4580742 1350256 5 cgarcia 2017-09-18 23:35:37 -0700 Committed r222202: <http://trac.webkit.org/changeset/222202> 1353452 6 webkit-bug-importer 2017-09-27 12:31:57 -0700 <rdar://problem/34693439> 321040 2017-09-17 02:59:58 -0700 2017-09-17 23:16:57 -0700 Patch wk-adjust-rect-complex-text.diff text/plain 2218 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3NWFjNGM5ZWEyNC4uYjkyZTA4ZDdmMDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wOS0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0hhcmZidXp6XSBhZGp1c3RTZWxlY3Rpb25SZWN0Rm9yQ29t cGxleFRleHQoKSBzaG91bGQgYWxzbyBwYXNzIHRoZSBjaGFyYWN0ZXIgcmFuZ2Ugd2hlbiBzaGFw aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzcw NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3cg dGhhdCB0aGUgc2hhcGVyIHN1cHBvcnQgcmVjZWl2aW5nIGEgcmFuZ2Ugd2Ugc2hvdWxkIHVzZSB0 aGF0IGFsc28gaW4KKyAgICAgICAgYWRqdXN0U2VsZWN0aW9uUmVjdEZvckNvbXBsZXhUZXh0KCku IFRoaXMgd2lsbCBlbnN1cmUgY29uc2lzdGVudCByZXN1bHRzIHdpdGgKKyAgICAgICAgZ2V0R2x5 cGhzQW5kQWR2YW5jZXNGb3JDb21wbGV4VGV4dCgpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vRm9udENhaXJvSGFyZmJ1enpORy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG b250Q2FzY2FkZTo6YWRqdXN0U2VsZWN0aW9uUmVjdEZvckNvbXBsZXhUZXh0IGNvbnN0KToKKwog MjAxNy0wOS0xNiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTihyMjIxOTc0KTogW0hhcmZidXp6XSBUZXN0IGZhc3QvdGV4dC9p bnRlcm5hdGlvbmFsL2hlYnJldy1zZWxlY3Rpb24uaHRtbCBpcyBmYWlsaW5nIHNpbmNlIHIyMjE5 NzQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0Zv bnRDYWlyb0hhcmZidXp6TkcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vRm9udENhaXJvSGFyZmJ1enpORy5jcHAKaW5kZXggODZkNmQwYWM1ZjguLmUxYTZlYjUy OTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9G b250Q2Fpcm9IYXJmYnV6ek5HLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9Gb250Q2Fpcm9IYXJmYnV6ek5HLmNwcApAQCAtOTIsMTMgKzkyLDE0IEBAIGlu dCBGb250Q2FzY2FkZTo6b2Zmc2V0Rm9yUG9zaXRpb25Gb3JDb21wbGV4VGV4dChjb25zdCBUZXh0 UnVuJiBydW4sIGZsb2F0IHgsIGJvCiB2b2lkIEZvbnRDYXNjYWRlOjphZGp1c3RTZWxlY3Rpb25S ZWN0Rm9yQ29tcGxleFRleHQoY29uc3QgVGV4dFJ1biYgcnVuLCBMYXlvdXRSZWN0JiBzZWxlY3Rp b25SZWN0LCB1bnNpZ25lZCBmcm9tLCB1bnNpZ25lZCB0bykgY29uc3QKIHsKICAgICBIYXJmQnV6 elNoYXBlciBzaGFwZXIodGhpcywgcnVuKTsKLSAgICBpZiAoc2hhcGVyLnNoYXBlKCkpIHsKLSAg ICAgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIG1pbWljIE1hYyBwb3J0LgotICAgICAgICBGbG9h dFJlY3QgcmVjdCA9IHNoYXBlci5zZWxlY3Rpb25SZWN0KEZsb2F0UG9pbnQoc2VsZWN0aW9uUmVj dC5sb2NhdGlvbigpKSwgc2VsZWN0aW9uUmVjdC5oZWlnaHQoKS50b0ludCgpLCBmcm9tLCB0byk7 Ci0gICAgICAgIHNlbGVjdGlvblJlY3QgPSBMYXlvdXRSZWN0KHJlY3QpOworICAgIEdseXBoQnVm ZmVyIGdseXBoQnVmZmVyOworICAgIGlmICghc2hhcGVyLnNoYXBlKCZnbHlwaEJ1ZmZlciwgZnJv bSwgdG8pKSB7CisgICAgICAgIExPR19FUlJPUigiU2hhcGVyIGNvdWxkbid0IHNoYXBlIHRleHQg cnVuLiIpOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIExPR19FUlJPUigiU2hhcGVyIGNv dWxkbid0IHNoYXBlIHRleHQgcnVuLiIpOworCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIG1p bWljIE1hYyBwb3J0LgorICAgIHNlbGVjdGlvblJlY3QgPSBMYXlvdXRSZWN0KHNoYXBlci5zZWxl Y3Rpb25SZWN0KHNlbGVjdGlvblJlY3QubG9jYXRpb24oKSwgc2VsZWN0aW9uUmVjdC5oZWlnaHQo KS50b0ludCgpLCBmcm9tLCB0bykpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==