177022 2017-09-15 13:08:47 -0700 Expose WKPageRef as a private property on WKWebView on Mac 2017-09-27 12:28:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen aestes ggaren jeffm webkit-bug-importer oldest_to_newest 1349486 0 achristensen 2017-09-15 13:08:47 -0700 Expose WKPageRef as a private property on WKWebView on Mac 1349489 1 320954 achristensen 2017-09-15 13:09:26 -0700 Created attachment 320954 Patch 1349539 2 ggaren 2017-09-15 14:35:19 -0700 CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.o mac/WK2BrowserWindowController.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler cd /Volumes/Data/EWS/WebKit/Tools/MiniBrowser export LANG=en_US.US-ASCII /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu99 -gmodules -Wno-trigraphs -fpascal-strings -Os -fno-common -Werror -Wno-missing-field-initializers -Wno-missing-prototypes -Wunreachable-code -Wno-implicit-atomic-properties -Wno-arc-repeated-use-of-weak -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wno-deprecated-implementations -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -mmacosx-version-min=10.11 -g -fvisibility=hidden -Wno-sign-conversion -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/MiniBrowser.hmap -I/Volumes/Data/EWS/WebKit/WebKitBuild/Release/include -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/DerivedSources/x86_64 -I/Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/DerivedSources -Wall -W -Wno-unused-parameter -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release -include /Volumes/Data/EWS/WebKit/WebKitBuild/PrecompiledHeaders/MiniBrowser_Prefix-azlouqjfvuumbxarszjzphftatda/MiniBrowser_Prefix.pch -MMD -MT dependencies -MF /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.dia -c /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m -o /Volumes/Data/EWS/WebKit/WebKitBuild/MiniBrowser.build/Release/MiniBrowser.build/Objects-normal/x86_64/WK2BrowserWindowController.o In file included from /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m:37: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKUIDelegatePrivate.h:32: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKWebViewPrivate.h:71:36: error: redefinition of typedef 'WKPageRef' is a C11 feature [-Werror,-Wtypedef-redefinition] typedef const struct OpaqueWKPage* WKPageRef; ^ In file included from /Volumes/Data/EWS/WebKit/Tools/MiniBrowser/mac/WK2BrowserWindowController.m:35: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKPreferencesPrivate.h:26: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKPreferencesRefPrivate.h:29: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKBase.h:111:36: note: previous definition is here typedef const struct OpaqueWKPage* WKPageRef; ^ 1 error generated. 1349981 3 321108 achristensen 2017-09-18 10:53:15 -0700 Created attachment 321108 Patch 1350388 4 achristensen 2017-09-19 10:45:19 -0700 http://trac.webkit.org/r222212 1353414 5 webkit-bug-importer 2017-09-27 12:28:31 -0700 <rdar://problem/34693346> 320954 2017-09-15 13:09:26 -0700 2017-09-18 10:53:14 -0700 Patch bug-177022-20170915130925.patch text/plain 2279 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjIxMDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRXhwb3NlIFdLUGFn ZVJlZiBhcyBhIHByaXZhdGUgcHJvcGVydHkgb24gV0tXZWJWaWV3IG9uIE1hYworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MDIyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDM0Mjc2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAg ICAgICAoLVtXS1dlYlZpZXcgX3BhZ2VSZWZGb3JUcmFuc2l0aW9uVG9XS1dlYlZpZXddKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwogMjAxNy0w OS0xNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIG1hY09TIENNYWtlIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlzaW9uIDIyMjAzMykKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAg LTU2NTMsNiArNTY1MywxMSBAQCAtIChOU0RpY3Rpb25hcnkgKilfcHJvcGVydGllc09mTGF5ZXJX aXRoCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQogCiAjaWYgUExBVEZPUk0oTUFDKQorLSAoV0tQ YWdlUmVmKV9wYWdlUmVmRm9yVHJhbnNpdGlvblRvV0tXZWJWaWV3Cit7CisgICAgcmV0dXJuIHRv QVBJKF9wYWdlLmdldCgpKTsKK30KKwogLSAoQk9PTClfaGFzQWN0aXZlVmlkZW9Gb3JDb250cm9s c01hbmFnZXIKIHsKICAgICByZXR1cm4gX3BhZ2UgJiYgX3BhZ2UtPmhhc0FjdGl2ZVZpZGVvRm9y Q29udHJvbHNNYW5hZ2VyKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHJldmlzaW9uIDIyMjAzMikKKysrIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHdvcmtp bmcgY29weSkKQEAgLTY3LDYgKzY3LDggQEAgdHlwZWRlZiBOU19FTlVNKE5TVUludGVnZXIsIF9X S0RyYWdJbnRlcgogICAgIF9XS0RyYWdJbnRlcmFjdGlvblBvbGljeUFsd2F5c0Rpc2FibGUKIH0g V0tfQVBJX0FWQUlMQUJMRShpb3MoMTEuMCkpOwogCisjZWxzZQordHlwZWRlZiBjb25zdCBzdHJ1 Y3QgT3BhcXVlV0tQYWdlKiBXS1BhZ2VSZWY7CiAjZW5kaWYKIAogI2lmICFUQVJHRVRfT1NfSVBI T05FCkBAIC0zODYsNiArMzg4LDcgQEAgdHlwZWRlZiBOU19PUFRJT05TKE5TSW50ZWdlciwgX1dL UmVjdEVkZwogI2VuZGlmIC8vIFRBUkdFVF9PU19JUEhPTkUKIAogI2lmICFUQVJHRVRfT1NfSVBI T05FCitAcHJvcGVydHkgKG5vbmF0b21pYywgcmVhZG9ubHkpIFdLUGFnZVJlZiBfcGFnZVJlZkZv clRyYW5zaXRpb25Ub1dLV2ViVmlldyAgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RC QSkpOwogQHByb3BlcnR5IChub25hdG9taWMsIHJlYWRvbmx5KSBCT09MIF9oYXNBY3RpdmVWaWRl b0ZvckNvbnRyb2xzTWFuYWdlciBXS19BUElfQVZBSUxBQkxFKG1hY29zeCgxMC4xMikpOwogLSAo dm9pZClfcmVxdWVzdENvbnRyb2xsZWRFbGVtZW50SUQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3go MTAuMTIuMykpOwogLSAodm9pZClfaGFuZGxlQ29udHJvbGxlZEVsZW1lbnRJRFJlc3BvbnNlOihO U1N0cmluZyAqKWlkZW50aWZpZXIgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIuMykpOwo= 321108 2017-09-18 10:53:15 -0700 2017-09-19 10:35:41 -0700 Patch bug-177022-20170918105314.patch text/plain 2259 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjIxMDYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTE1ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRXhwb3NlIFdLUGFn ZVJlZiBhcyBhIHByaXZhdGUgcHJvcGVydHkgb24gV0tXZWJWaWV3IG9uIE1hYworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3MDIyCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zNDM0Mjc2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAg ICAgICAoLVtXS1dlYlZpZXcgX3BhZ2VSZWZGb3JUcmFuc2l0aW9uVG9XS1dlYlZpZXddKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld1ByaXZhdGUuaDoKKwogMjAxNy0w OS0xNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggdGhlIG1hY09TIENNYWtlIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHJldmlzaW9uIDIyMjAzMykKKysrIFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAg LTU2NTMsNiArNTY1MywxMSBAQCAtIChOU0RpY3Rpb25hcnkgKilfcHJvcGVydGllc09mTGF5ZXJX aXRoCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TKQogCiAjaWYgUExBVEZPUk0oTUFDKQorLSAoV0tQ YWdlUmVmKV9wYWdlUmVmRm9yVHJhbnNpdGlvblRvV0tXZWJWaWV3Cit7CisgICAgcmV0dXJuIHRv QVBJKF9wYWdlLmdldCgpKTsKK30KKwogLSAoQk9PTClfaGFzQWN0aXZlVmlkZW9Gb3JDb250cm9s c01hbmFnZXIKIHsKICAgICByZXR1cm4gX3BhZ2UgJiYgX3BhZ2UtPmhhc0FjdGl2ZVZpZGVvRm9y Q29udHJvbHNNYW5hZ2VyKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3UHJpdmF0ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHJldmlzaW9uIDIyMjAzMikKKysrIFNv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdQcml2YXRlLmgJKHdvcmtp bmcgY29weSkKQEAgLTY3LDYgKzY3LDggQEAgdHlwZWRlZiBOU19FTlVNKE5TVUludGVnZXIsIF9X S0RyYWdJbnRlcgogICAgIF9XS0RyYWdJbnRlcmFjdGlvblBvbGljeUFsd2F5c0Rpc2FibGUKIH0g V0tfQVBJX0FWQUlMQUJMRShpb3MoMTEuMCkpOwogCisjZWxzZQorI2ltcG9ydCA8V2ViS2l0L1dL QmFzZS5oPgogI2VuZGlmCiAKICNpZiAhVEFSR0VUX09TX0lQSE9ORQpAQCAtMzg2LDYgKzM4OCw3 IEBAIHR5cGVkZWYgTlNfT1BUSU9OUyhOU0ludGVnZXIsIF9XS1JlY3RFZGcKICNlbmRpZiAvLyBU QVJHRVRfT1NfSVBIT05FCiAKICNpZiAhVEFSR0VUX09TX0lQSE9ORQorQHByb3BlcnR5IChub25h dG9taWMsIHJlYWRvbmx5KSBXS1BhZ2VSZWYgX3BhZ2VSZWZGb3JUcmFuc2l0aW9uVG9XS1dlYlZp ZXcgIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpKTsKIEBwcm9wZXJ0eSAobm9u YXRvbWljLCByZWFkb25seSkgQk9PTCBfaGFzQWN0aXZlVmlkZW9Gb3JDb250cm9sc01hbmFnZXIg V0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIpKTsKIC0gKHZvaWQpX3JlcXVlc3RDb250cm9s bGVkRWxlbWVudElEIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyLjMpKTsKIC0gKHZvaWQp X2hhbmRsZUNvbnRyb2xsZWRFbGVtZW50SURSZXNwb25zZTooTlNTdHJpbmcgKilpZGVudGlmaWVy IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyLjMpKTsK