177007 2017-09-15 09:07:08 -0700 [Win] Warning fix. 2018-01-30 20:48:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan fujii benjamin cdumez cmarcelo commit-queue dbates don.olmstead ews-watchlist fujii keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1349328 0 pvollan 2017-09-15 09:07:08 -0700 On Win64, MSVC is currently giving a warning about conversion from signed to unsigned. 1394476 1 fujii 2018-01-30 02:02:31 -0800 I saw following JSC compilation warnings by building WinCairo port. > [121/1324] Building CXX object Source\WTF\wtf\CMakeFiles\WTF.dir\ThreadingWin.cpp.obj > ..\..\Source\WTF\wtf\ThreadingWin.cpp(326): warning C4312: 'type cast': conversion from 'unsigned int' to 'WTF::Thread *' of greater size > ..\..\Source\WTF\wtf\ThreadingWin.cpp(362): warning C4312: 'type cast': conversion from 'unsigned int' to 'WTF::Thread *' of greater size > ..\..\Source\WTF\wtf\ThreadingWin.cpp(365): warning C4312: 'type cast': conversion from 'unsigned int' to 'WTF::Thread *' of greater size > [223/1324] Building CXX object Source\JavaScriptCore\CMake...ces\JavaScriptCore\unified-sources\UnifiedSource76.cpp.obj > C:\webkit\ga\Source\JavaScriptCore\interpreter/StackVisitor.cpp(464): warning C4312: 'reinterpret_cast': conversion from 'unsigned int' to 'void *' of greater size > [244/1324] Building CXX object Source\JavaScriptCore\CMake...es\JavaScriptCore\unified-sources\UnifiedSource100.cpp.obj > c:\webkit\ga\source\javascriptcore\runtime\intlnumberformat.cpp(395) : warning C4701: potentially uninitialized local variable 'style' used 1394480 2 fujii 2018-01-30 02:27:32 -0800 MSDN: Rules for Using Pointers (Windows) https://msdn.microsoft.com/library/windows/desktop/aa384242 1394481 3 332641 fujii 2018-01-30 02:27:53 -0800 Created attachment 332641 Patch 1394482 4 332642 fujii 2018-01-30 02:36:12 -0800 Created attachment 332642 Patch 1394484 5 332642 ysuzuki 2018-01-30 02:57:41 -0800 Comment on attachment 332642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332642&action=review > Source/WTF/wtf/ThreadingWin.cpp:270 > +#define InvalidThread ((Thread*)(UINT_PTR)(0xbbadbeef)) I like `uintptr_t` even in Windows only code. And we prefer C++ casts. `reinterpret_cast<Thread*>(static_cast<uintptr_t>(0xbbadbeef))` is better. 1394849 6 332642 fujii 2018-01-30 17:14:53 -0800 Comment on attachment 332642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332642&action=review Thank you for the review. >> Source/WTF/wtf/ThreadingWin.cpp:270 >> +#define InvalidThread ((Thread*)(UINT_PTR)(0xbbadbeef)) > > I like `uintptr_t` even in Windows only code. And we prefer C++ casts. > `reinterpret_cast<Thread*>(static_cast<uintptr_t>(0xbbadbeef))` is better. Agreed. 1394850 7 332730 fujii 2018-01-30 17:17:40 -0800 Created attachment 332730 Patch 1394896 8 332730 commit-queue 2018-01-30 20:47:49 -0800 Comment on attachment 332730 Patch Clearing flags on attachment: 332730 Committed r227872: <https://trac.webkit.org/changeset/227872> 1394897 9 commit-queue 2018-01-30 20:47:50 -0800 All reviewed patches have been landed. Closing bug. 1394899 10 webkit-bug-importer 2018-01-30 20:48:27 -0800 <rdar://problem/37055494> 332641 2018-01-30 02:27:53 -0800 2018-01-30 02:31:56 -0800 Patch bug-177007-20180130192752.patch text/plain 3245 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MTBhMWMzYTVkNWMxNjk4N2E5YjhhZWNkODM0ZWJjODkzZmI3OTFkLi5jMmFjODc0ZDA1NmM5ZTZh YjM4ZjYyNTMxMzAwMGU3OWZlMzEyNTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxOC0wMS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzAwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvU3RhY2tWaXNpdG9y LmNwcDoKKyAgICAgICAgKEpTQzo6U3RhY2tWaXNpdG9yOjpGcmFtZTo6ZHVtcCBjb25zdCk6IENo YW5nZWQgdGhlIHR5cGUgb2YgbG9jYXRpb25SYXdCaXRzIGZyb20gdW5zaWduZWQgdG8gdWludHB0 cl90LgorCiAyMDE4LTAxLTI5ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFtKU0NdIFJlbGF4IGxpbmUgdGVybWluYXRvcnMgaW4gU3RyaW5nIHRvIG1h a2UgSlNPTiBzdWJzZXQgb2YgSlMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIv U291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMTZmNjcxNTUyODBlODgwMTNmNGM0N2NiZjhiOTRh NGNiMDNmMzg2NS4uYTA2ZTRiODRhNDcwODhhNDhkMTJlZjY1N2UxNjA5MTdlNDZmZmQ1MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxOCBAQAorMjAxOC0wMS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5G dWppaUBzb255LmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzAwNworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEEgMzIgYml0IGludGVnZXIgc2hv dWxkIG5vdCBiZSBjYXN0ZWQgdG8gYSBwb2ludGVyIGRpcmVjdGx5IGluIDY0CisgICAgICAgIGJp dCBXaW5kb3dzLiBJdCBzaG91bGQgYmUgY2FzdGVkIHRvIGEgVUlOVF9QVFIgYmVmb3JlaGFuZC4K KworICAgICAgICBSdWxlcyBmb3IgVXNpbmcgUG9pbnRlcnMgKFdpbmRvd3MpCisgICAgICAgIGh0 dHBzOi8vbXNkbi5taWNyb3NvZnQuY29tL2xpYnJhcnkvd2luZG93cy9kZXNrdG9wL2FhMzg0MjQy CisKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nV2luLmNwcCAoSW52YWxpZFRocmVhZCk6IENhc3Rl ZCAweGJiYWRiZWVmIHRvIFVJTlRfUFRSLgorCiAyMDE4LTAxLTI2ICBNYXJrIExhbSAgPG1hcmsu bGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgaW5mcmFzdHJ1Y3R1cmUgZm9yIHBvaW50ZXIg cHJlcGFyYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvU3RhY2tWaXNpdG9yLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9T dGFja1Zpc2l0b3IuY3BwCmluZGV4IDMzYmY5OTU0ZmQ4NDM5YTY4MGI5NmVhNmI0MGE1OWQxYzRm OTgyMDEuLjFkMWZmNzNkZmRmOTM4YTU4NTdhYTNlOTM5MGIwYzVlOGM4Y2ViMTQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwCkBA IC00NTksOCArNDU5LDggQEAgdm9pZCBTdGFja1Zpc2l0b3I6OkZyYW1lOjpkdW1wKFByaW50U3Ry ZWFtJiBvdXQsIEluZGVudGVyIGluZGVudCwgc3RkOjpmdW5jdGlvbjwKICAgICAgICAgb3V0LnBy aW50KGluZGVudCwgImNhbGxlZTogIiwgUmF3UG9pbnRlcihjYWxsZWUoKS5yYXdQdHIoKSksICJc biIpOwogICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAicmV0dXJuUEM6ICIsIFJhd1BvaW50ZXIo cmV0dXJuUEMpLCAiXG4iKTsKICAgICAgICAgb3V0LnByaW50KGluZGVudCwgImNhbGxlckZyYW1l OiAiLCBSYXdQb2ludGVyKGNhbGxlckZyYW1lKSwgIlxuIik7Ci0gICAgICAgIHVuc2lnbmVkIGxv Y2F0aW9uUmF3Qml0cyA9IGNhbGxGcmFtZS0+Y2FsbFNpdGVBc1Jhd0JpdHMoKTsKLSAgICAgICAg b3V0LnByaW50KGluZGVudCwgInJhd0xvY2F0aW9uQml0czogIiwgc3RhdGljX2Nhc3Q8dWludHB0 cl90Pihsb2NhdGlvblJhd0JpdHMpLAorICAgICAgICB1aW50cHRyX3QgbG9jYXRpb25SYXdCaXRz ID0gY2FsbEZyYW1lLT5jYWxsU2l0ZUFzUmF3Qml0cygpOworICAgICAgICBvdXQucHJpbnQoaW5k ZW50LCAicmF3TG9jYXRpb25CaXRzOiAiLCBsb2NhdGlvblJhd0JpdHMsCiAgICAgICAgICAgICAi ICIsIFJhd1BvaW50ZXIocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4obG9jYXRpb25SYXdCaXRzKSks ICJcbiIpOwogICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAiY29kZUJsb2NrOiAiLCBSYXdQb2lu dGVyKGNvZGVCbG9jaykpOwogICAgICAgICBpZiAoY29kZUJsb2NrKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZGluZ1dp bi5jcHAKaW5kZXggYTgxNTkwNDA2OTY3ZDZlODU2NjkxNTM3ZTIwY2M1ZTgxZTFiOWMxNi4uNDFj Mjg4ZmEwNmJmZDk1OWMwYTRmYTA1YzE3ZmNhZDBlZGFkYjE5MiAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvVGhyZWFkaW5nV2luLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdX aW4uY3BwCkBAIC0yNjcsNyArMjY3LDcgQEAgdm9pZCBUaHJlYWQ6OmVzdGFibGlzaFBsYXRmb3Jt U3BlY2lmaWNIYW5kbGUoSEFORExFIGhhbmRsZSwgVGhyZWFkSWRlbnRpZmllciB0aHIKICAgICBt X2lkID0gdGhyZWFkSUQ7CiB9CiAKLSNkZWZpbmUgSW52YWxpZFRocmVhZCAoKFRocmVhZCopKDB4 YmJhZGJlZWYpKQorI2RlZmluZSBJbnZhbGlkVGhyZWFkICgoVGhyZWFkKikoVUlOVF9QVFIpKDB4 YmJhZGJlZWYpKQogCiBzdGF0aWMgc3RkOjptdXRleCYgdGhyZWFkTWFwTXV0ZXgoKQogewo= 332642 2018-01-30 02:36:12 -0800 2018-01-30 17:17:38 -0800 Patch bug-177007-20180130193611.patch text/plain 4046 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MTBhMWMzYTVkNWMxNjk4N2E5YjhhZWNkODM0ZWJjODkzZmI3OTFkLi40MTc0NTEyZmJlNzYzY2Fj M2JiM2M0OWZlMWIxMGRjM2RhYjYxYWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wMS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzAwNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJwcmV0ZXIvU3RhY2tWaXNpdG9y LmNwcDoKKyAgICAgICAgKEpTQzo6U3RhY2tWaXNpdG9yOjpGcmFtZTo6ZHVtcCBjb25zdCk6Cisg ICAgICAgIENoYW5nZWQgdGhlIHR5cGUgb2YgbG9jYXRpb25SYXdCaXRzIGZyb20gdW5zaWduZWQg dG8gdWludHB0cl90LgorICAgICAgICAqIHJ1bnRpbWUvSW50bE51bWJlckZvcm1hdC5jcHA6Cisg ICAgICAgIChKU0M6OkludGxOdW1iZXJGb3JtYXQ6OmNyZWF0ZU51bWJlckZvcm1hdCk6CisgICAg ICAgIEluaXRpYWxpemUgJ3N0eWxlJyB0byBhdm9pZCBwb3RlbnRpYWxseSB1bmluaXRpYWxpemVk IGxvY2FsIHZhcmlhYmxlIHdhcm5pbmcuCisKIDIwMTgtMDEtMjkgIFl1c3VrZSBTdXp1a2kgIDx1 dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gUmVsYXggbGluZSB0ZXJtaW5h dG9ycyBpbiBTdHJpbmcgdG8gbWFrZSBKU09OIHN1YnNldCBvZiBKUwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCAxNmY2NzE1NTI4 MGU4ODAxM2Y0YzQ3Y2JmOGI5NGE0Y2IwM2YzODY1Li5hMDZlNGI4NGE0NzA4OGE0OGQxMmVmNjU3 ZTE2MDkxN2U0NmZmZDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTAxLTMwICBGdWppaSBI aXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFdhcm5p bmcgZml4LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc3MDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QSAzMiBiaXQgaW50ZWdlciBzaG91bGQgbm90IGJlIGNhc3RlZCB0byBhIHBvaW50ZXIgZGlyZWN0 bHkgaW4gNjQKKyAgICAgICAgYml0IFdpbmRvd3MuIEl0IHNob3VsZCBiZSBjYXN0ZWQgdG8gYSBV SU5UX1BUUiBiZWZvcmVoYW5kLgorCisgICAgICAgIFJ1bGVzIGZvciBVc2luZyBQb2ludGVycyAo V2luZG93cykKKyAgICAgICAgaHR0cHM6Ly9tc2RuLm1pY3Jvc29mdC5jb20vbGlicmFyeS93aW5k b3dzL2Rlc2t0b3AvYWEzODQyNDIKKworICAgICAgICAqIHd0Zi9UaHJlYWRpbmdXaW4uY3BwIChJ bnZhbGlkVGhyZWFkKTogQ2FzdGVkIDB4YmJhZGJlZWYgdG8gVUlOVF9QVFIuCisKIDIwMTgtMDEt MjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbmZyYXN0 cnVjdHVyZSBmb3IgcG9pbnRlciBwcmVwYXJhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ludGVycHJldGVyL1N0YWNrVmlzaXRvci5jcHAKaW5kZXggMzNiZjk5NTRmZDg0Mzlh NjgwYjk2ZWE2YjQwYTU5ZDFjNGY5ODIwMS4uMWQxZmY3M2RmZGY5MzhhNTg1N2FhM2U5MzkwYjBj NWU4YzhjZWIxNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L1N0YWNrVmlzaXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L1N0YWNrVmlzaXRvci5jcHAKQEAgLTQ1OSw4ICs0NTksOCBAQCB2b2lkIFN0YWNrVmlzaXRvcjo6 RnJhbWU6OmR1bXAoUHJpbnRTdHJlYW0mIG91dCwgSW5kZW50ZXIgaW5kZW50LCBzdGQ6OmZ1bmN0 aW9uPAogICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAiY2FsbGVlOiAiLCBSYXdQb2ludGVyKGNh bGxlZSgpLnJhd1B0cigpKSwgIlxuIik7CiAgICAgICAgIG91dC5wcmludChpbmRlbnQsICJyZXR1 cm5QQzogIiwgUmF3UG9pbnRlcihyZXR1cm5QQyksICJcbiIpOwogICAgICAgICBvdXQucHJpbnQo aW5kZW50LCAiY2FsbGVyRnJhbWU6ICIsIFJhd1BvaW50ZXIoY2FsbGVyRnJhbWUpLCAiXG4iKTsK LSAgICAgICAgdW5zaWduZWQgbG9jYXRpb25SYXdCaXRzID0gY2FsbEZyYW1lLT5jYWxsU2l0ZUFz UmF3Qml0cygpOwotICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAicmF3TG9jYXRpb25CaXRzOiAi LCBzdGF0aWNfY2FzdDx1aW50cHRyX3Q+KGxvY2F0aW9uUmF3Qml0cyksCisgICAgICAgIHVpbnRw dHJfdCBsb2NhdGlvblJhd0JpdHMgPSBjYWxsRnJhbWUtPmNhbGxTaXRlQXNSYXdCaXRzKCk7Cisg ICAgICAgIG91dC5wcmludChpbmRlbnQsICJyYXdMb2NhdGlvbkJpdHM6ICIsIGxvY2F0aW9uUmF3 Qml0cywKICAgICAgICAgICAgICIgIiwgUmF3UG9pbnRlcihyZWludGVycHJldF9jYXN0PHZvaWQq Pihsb2NhdGlvblJhd0JpdHMpKSwgIlxuIik7CiAgICAgICAgIG91dC5wcmludChpbmRlbnQsICJj b2RlQmxvY2s6ICIsIFJhd1BvaW50ZXIoY29kZUJsb2NrKSk7CiAgICAgICAgIGlmIChjb2RlQmxv Y2spCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsTnVtYmVy Rm9ybWF0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3Jt YXQuY3BwCmluZGV4IGY0MTU5NzNiOGQwNGFmMDZhYjViN2EyYThiMjgxNzJhNDAzN2NhYjAuLjM0 NTZjMGJkZGE4YjZmYTJmNTdiNzUxNjMwZTkwMWM3NTVmZGIzM2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCkBAIC0zNjQsNyAr MzY0LDcgQEAgdm9pZCBJbnRsTnVtYmVyRm9ybWF0OjpjcmVhdGVOdW1iZXJGb3JtYXQoRXhlY1N0 YXRlJiBzdGF0ZSkKICAgICAgICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKICAgICB9CiAK LSAgICBVTnVtYmVyRm9ybWF0U3R5bGUgc3R5bGU7CisgICAgVU51bWJlckZvcm1hdFN0eWxlIHN0 eWxlID0gVU5VTV9ERUZBVUxUOwogICAgIHN3aXRjaCAobV9zdHlsZSkgewogICAgIGNhc2UgU3R5 bGU6OkRlY2ltYWw6CiAgICAgICAgIHN0eWxlID0gVU5VTV9ERUNJTUFMOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZGlu Z1dpbi5jcHAKaW5kZXggYTgxNTkwNDA2OTY3ZDZlODU2NjkxNTM3ZTIwY2M1ZTgxZTFiOWMxNi4u NDFjMjg4ZmEwNmJmZDk1OWMwYTRmYTA1YzE3ZmNhZDBlZGFkYjE5MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRp bmdXaW4uY3BwCkBAIC0yNjcsNyArMjY3LDcgQEAgdm9pZCBUaHJlYWQ6OmVzdGFibGlzaFBsYXRm b3JtU3BlY2lmaWNIYW5kbGUoSEFORExFIGhhbmRsZSwgVGhyZWFkSWRlbnRpZmllciB0aHIKICAg ICBtX2lkID0gdGhyZWFkSUQ7CiB9CiAKLSNkZWZpbmUgSW52YWxpZFRocmVhZCAoKFRocmVhZCop KDB4YmJhZGJlZWYpKQorI2RlZmluZSBJbnZhbGlkVGhyZWFkICgoVGhyZWFkKikoVUlOVF9QVFIp KDB4YmJhZGJlZWYpKQogCiBzdGF0aWMgc3RkOjptdXRleCYgdGhyZWFkTWFwTXV0ZXgoKQogewo= 332730 2018-01-30 17:17:40 -0800 2018-01-30 20:47:49 -0800 Patch bug-177007-20180131101739.patch text/plain 4074 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjI3Nzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl MTBhMWMzYTVkNWMxNjk4N2E5YjhhZWNkODM0ZWJjODkzZmI3OTFkLi43NGI3ODUzNmJjZjcyYmZk ZmFlYjkwNzI1MWIzZmE4ZjkxNmZmNmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOC0wMS0zMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbV2luXSBXYXJuaW5nIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzAwNworCisgICAgICAgIFJldmlld2Vk IGJ5IFl1c3VrZSBTdXp1a2kuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9TdGFja1Zpc2l0b3Iu Y3BwOgorICAgICAgICAoSlNDOjpTdGFja1Zpc2l0b3I6OkZyYW1lOjpkdW1wIGNvbnN0KToKKyAg ICAgICAgQ2hhbmdlZCB0aGUgdHlwZSBvZiBsb2NhdGlvblJhd0JpdHMgZnJvbSB1bnNpZ25lZCB0 byB1aW50cHRyX3QuCisgICAgICAgICogcnVudGltZS9JbnRsTnVtYmVyRm9ybWF0LmNwcDoKKyAg ICAgICAgKEpTQzo6SW50bE51bWJlckZvcm1hdDo6Y3JlYXRlTnVtYmVyRm9ybWF0KToKKyAgICAg ICAgSW5pdGlhbGl6ZSAnc3R5bGUnIHRvIGF2b2lkIHBvdGVudGlhbGx5IHVuaW5pdGlhbGl6ZWQg bG9jYWwgdmFyaWFibGUgd2FybmluZy4KKwogMjAxOC0wMS0yOSAgWXVzdWtlIFN1enVraSAgPHV0 YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBSZWxheCBsaW5lIHRlcm1pbmF0 b3JzIGluIFN0cmluZyB0byBtYWtlIEpTT04gc3Vic2V0IG9mIEpTCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDE2ZjY3MTU1Mjgw ZTg4MDEzZjRjNDdjYmY4Yjk0YTRjYjAzZjM4NjUuLmIzYzVkODZmYzgwMjYzYjI2YTY1OGVmMTNi MWU4OTY0MDc5ODkxYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDEtMzAgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gV2Fybmlu ZyBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzcwMDcKKworICAgICAgICBSZXZpZXdlZCBieSBZdXN1a2UgU3V6dWtpLgorCisgICAgICAgIEEg MzIgYml0IGludGVnZXIgc2hvdWxkIG5vdCBiZSBjYXN0ZWQgdG8gYSBwb2ludGVyIGRpcmVjdGx5 IGluIDY0CisgICAgICAgIGJpdCBXaW5kb3dzLiBJdCBzaG91bGQgYmUgY2FzdGVkIHRvIGEgdWlu dHB0cl90IGJlZm9yZWhhbmQuCisKKyAgICAgICAgUnVsZXMgZm9yIFVzaW5nIFBvaW50ZXJzIChX aW5kb3dzKQorICAgICAgICBodHRwczovL21zZG4ubWljcm9zb2Z0LmNvbS9saWJyYXJ5L3dpbmRv d3MvZGVza3RvcC9hYTM4NDI0MgorCisgICAgICAgICogd3RmL1RocmVhZGluZ1dpbi5jcHAgKElu dmFsaWRUaHJlYWQpOiBDYXN0ZWQgMHhiYmFkYmVlZiB0byB1aW50cHRyX3QuCisKIDIwMTgtMDEt MjYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBpbmZyYXN0 cnVjdHVyZSBmb3IgcG9pbnRlciBwcmVwYXJhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2ludGVycHJldGVyL1N0YWNrVmlzaXRvci5jcHAKaW5kZXggMzNiZjk5NTRmZDg0Mzlh NjgwYjk2ZWE2YjQwYTU5ZDFjNGY5ODIwMS4uMWQxZmY3M2RmZGY5MzhhNTg1N2FhM2U5MzkwYjBj NWU4YzhjZWIxNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L1N0YWNrVmlzaXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVy L1N0YWNrVmlzaXRvci5jcHAKQEAgLTQ1OSw4ICs0NTksOCBAQCB2b2lkIFN0YWNrVmlzaXRvcjo6 RnJhbWU6OmR1bXAoUHJpbnRTdHJlYW0mIG91dCwgSW5kZW50ZXIgaW5kZW50LCBzdGQ6OmZ1bmN0 aW9uPAogICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAiY2FsbGVlOiAiLCBSYXdQb2ludGVyKGNh bGxlZSgpLnJhd1B0cigpKSwgIlxuIik7CiAgICAgICAgIG91dC5wcmludChpbmRlbnQsICJyZXR1 cm5QQzogIiwgUmF3UG9pbnRlcihyZXR1cm5QQyksICJcbiIpOwogICAgICAgICBvdXQucHJpbnQo aW5kZW50LCAiY2FsbGVyRnJhbWU6ICIsIFJhd1BvaW50ZXIoY2FsbGVyRnJhbWUpLCAiXG4iKTsK LSAgICAgICAgdW5zaWduZWQgbG9jYXRpb25SYXdCaXRzID0gY2FsbEZyYW1lLT5jYWxsU2l0ZUFz UmF3Qml0cygpOwotICAgICAgICBvdXQucHJpbnQoaW5kZW50LCAicmF3TG9jYXRpb25CaXRzOiAi LCBzdGF0aWNfY2FzdDx1aW50cHRyX3Q+KGxvY2F0aW9uUmF3Qml0cyksCisgICAgICAgIHVpbnRw dHJfdCBsb2NhdGlvblJhd0JpdHMgPSBjYWxsRnJhbWUtPmNhbGxTaXRlQXNSYXdCaXRzKCk7Cisg ICAgICAgIG91dC5wcmludChpbmRlbnQsICJyYXdMb2NhdGlvbkJpdHM6ICIsIGxvY2F0aW9uUmF3 Qml0cywKICAgICAgICAgICAgICIgIiwgUmF3UG9pbnRlcihyZWludGVycHJldF9jYXN0PHZvaWQq Pihsb2NhdGlvblJhd0JpdHMpKSwgIlxuIik7CiAgICAgICAgIG91dC5wcmludChpbmRlbnQsICJj b2RlQmxvY2s6ICIsIFJhd1BvaW50ZXIoY29kZUJsb2NrKSk7CiAgICAgICAgIGlmIChjb2RlQmxv Y2spCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9JbnRsTnVtYmVy Rm9ybWF0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3Jt YXQuY3BwCmluZGV4IGY0MTU5NzNiOGQwNGFmMDZhYjViN2EyYThiMjgxNzJhNDAzN2NhYjAuLjM0 NTZjMGJkZGE4YjZmYTJmNTdiNzUxNjMwZTkwMWM3NTVmZGIzM2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxOdW1iZXJGb3JtYXQuY3BwCkBAIC0zNjQsNyAr MzY0LDcgQEAgdm9pZCBJbnRsTnVtYmVyRm9ybWF0OjpjcmVhdGVOdW1iZXJGb3JtYXQoRXhlY1N0 YXRlJiBzdGF0ZSkKICAgICAgICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsKICAgICB9CiAK LSAgICBVTnVtYmVyRm9ybWF0U3R5bGUgc3R5bGU7CisgICAgVU51bWJlckZvcm1hdFN0eWxlIHN0 eWxlID0gVU5VTV9ERUZBVUxUOwogICAgIHN3aXRjaCAobV9zdHlsZSkgewogICAgIGNhc2UgU3R5 bGU6OkRlY2ltYWw6CiAgICAgICAgIHN0eWxlID0gVU5VTV9ERUNJTUFMOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcCBiL1NvdXJjZS9XVEYvd3RmL1RocmVhZGlu Z1dpbi5jcHAKaW5kZXggYTgxNTkwNDA2OTY3ZDZlODU2NjkxNTM3ZTIwY2M1ZTgxZTFiOWMxNi4u YTVkYmJkZWRiNDliYzU2NGY0OGZhODU3NDNmYjMzZmY4N2YzZTVjYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRp bmdXaW4uY3BwCkBAIC0yNjcsNyArMjY3LDcgQEAgdm9pZCBUaHJlYWQ6OmVzdGFibGlzaFBsYXRm b3JtU3BlY2lmaWNIYW5kbGUoSEFORExFIGhhbmRsZSwgVGhyZWFkSWRlbnRpZmllciB0aHIKICAg ICBtX2lkID0gdGhyZWFkSUQ7CiB9CiAKLSNkZWZpbmUgSW52YWxpZFRocmVhZCAoKFRocmVhZCop KDB4YmJhZGJlZWYpKQorI2RlZmluZSBJbnZhbGlkVGhyZWFkIHJlaW50ZXJwcmV0X2Nhc3Q8VGhy ZWFkKj4oc3RhdGljX2Nhc3Q8dWludHB0cl90PigweGJiYWRiZWVmKSkKIAogc3RhdGljIHN0ZDo6 bXV0ZXgmIHRocmVhZE1hcE11dGV4KCkKIHsK