176970 2017-09-14 17:30:41 -0700 Should not mark a platform as missing in summary page if all expecting metrics are exlucded. 2017-09-27 12:28:10 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dewei_zhu webkit-unassigned commit-queue dewei_zhu rniwa webkit-bug-importer oldest_to_newest 1349122 0 dewei_zhu 2017-09-14 17:30:41 -0700 Should not mark a platform as missing in summary page if all expecting metrics are exlucded. 1349127 1 320853 dewei_zhu 2017-09-14 17:34:40 -0700 Created attachment 320853 Patch 1349164 2 320853 rniwa 2017-09-14 20:26:59 -0700 Comment on attachment 320853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320853&action=review > Websites/perf.webkit.org/public/v3/pages/summary-page.js:265 > var foundInSomeMetric = false; > + var excludedMerticCount = 0; Use let. > Websites/perf.webkit.org/public/v3/pages/summary-page.js:281 > - if (!foundInSomeMetric) > + if (!foundInSomeMetric && excludedMerticCount < metrics.length) Now we don't need foundInSomeMetric. You can just check excludedMerticCount < metrics.length since that condition also implies metrics.length. 1349215 3 320853 dewei_zhu 2017-09-15 00:53:22 -0700 Comment on attachment 320853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320853&action=review >> Websites/perf.webkit.org/public/v3/pages/summary-page.js:265 >> + var excludedMerticCount = 0; > > Use let. Should I replace all usages of 'var' in this function? >> Websites/perf.webkit.org/public/v3/pages/summary-page.js:281 >> + if (!foundInSomeMetric && excludedMerticCount < metrics.length) > > Now we don't need foundInSomeMetric. You can just check excludedMerticCount < metrics.length > since that condition also implies metrics.length. I don't think we can do this. excludedConfigurations[platform.id()] just specifies the expected missing combinations for a platform. So it could be a subset of metrics. In this case, removing foundInSomeMetric could result in marking a platform missing incorrectly. 1349216 4 320853 dewei_zhu 2017-09-15 00:54:28 -0700 Comment on attachment 320853 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320853&action=review >>> Websites/perf.webkit.org/public/v3/pages/summary-page.js:281 >>> + if (!foundInSomeMetric && excludedMerticCount < metrics.length) >> >> Now we don't need foundInSomeMetric. You can just check excludedMerticCount < metrics.length >> since that condition also implies metrics.length. > > I don't think we can do this. > excludedConfigurations[platform.id()] just specifies the expected missing combinations for a platform. So it could be a subset of metrics. In this case, removing foundInSomeMetric could result in marking a platform missing incorrectly. For 'excludedConfigurations[platform.id()] just specifies the expected missing combinations for a platform' I meant 'excludedConfigurations[platform.id()] just specifies the expected missing Metrics for a platform.' 1349593 5 320977 dewei_zhu 2017-09-15 17:28:08 -0700 Created attachment 320977 Patch for landing 1349601 6 320977 commit-queue 2017-09-15 18:11:31 -0700 Comment on attachment 320977 Patch for landing Clearing flags on attachment: 320977 Committed r222123: <http://trac.webkit.org/changeset/222123> 1349602 7 commit-queue 2017-09-15 18:11:32 -0700 All reviewed patches have been landed. Closing bug. 1353408 8 webkit-bug-importer 2017-09-27 12:28:10 -0700 <rdar://problem/34693333> 320853 2017-09-14 17:34:40 -0700 2017-09-15 17:28:06 -0700 Patch bug-176970-20170914173439.patch text/plain 2695 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMDY3CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0MDllYzI4MmJhOGVjYjBjNTJjYWUyNzE4N2UxYzQ0YjliMmFkYTcyLi5jZTk4NmI0OTIy Yzg5YTM0ZGQ1NDIzMWQyYzIwZDBmMWI4OWE5Yjk0IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOS0xNCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgbm90IG1hcmsgYSBwbGF0Zm9ybSBhcyBtaXNz aW5nIGluIHN1bW1hcnkgcGFnZSBpZiBhbGwgZXhwZWN0aW5nIG1ldHJpY3MgYXJlIGV4bHVjZGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2OTcw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gc3Vt bWFyeSBwYWdlLCBpZiBhbGwgbWV0cmljcyBmb3IgYSB0ZXN0IGFyZSBleGNsdWRlZCBpbiBleGNs dWRlZENvbmZpZ3VyYXRpb25zIGZvciBhIHBsYXRmb3JtLCB0aGlzIHBsYXRmb3JtIHNob3VsZCBu b3QgYmUgbWFya2VkIGFzIG1pc3NpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvdjMvcGFnZXMvc3Vt bWFyeS1wYWdlLmpzOgorICAgICAgICAoU3VtbWFyeVBhZ2VDb25maWd1cmF0aW9uR3JvdXApOgor CiAyMDE3LTA5LTExICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IEFuYWx5c2lzIHRhc2sgcGFnZSBzaG93cyBhbiBlbXB0eSByZXN1bHRzIGZvciBhbiBpcnJlbGV2 YW50IHRvcC1sZXZlbCB0ZXN0CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL3YzL3BhZ2VzL3N1bW1hcnktcGFnZS5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9y Zy9wdWJsaWMvdjMvcGFnZXMvc3VtbWFyeS1wYWdlLmpzCmluZGV4IDk1MTViMTczYWQwYWU5NjMz MjA0NDUxMWMxZTI3MmEwYzViNGNkNGIuLjZiNmE3ZjAxYzczNTRlZjg1ZTJlYzA0ODFhOGQ1NDQw OTY4Njg3YTIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMv cGFnZXMvc3VtbWFyeS1wYWdlLmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvcGFnZXMvc3VtbWFyeS1wYWdlLmpzCkBAIC0yNjIsMjAgKzI2MiwyMyBAQCBjbGFzcyBT dW1tYXJ5UGFnZUNvbmZpZ3VyYXRpb25Hcm91cCB7CiAgICAgICAgIGZvciAodmFyIHBsYXRmb3Jt IG9mIHBsYXRmb3JtcykgewogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQocGxhdGZvcm0gaW5z dGFuY2VvZiBQbGF0Zm9ybSk7CiAgICAgICAgICAgICB2YXIgZm91bmRJblNvbWVNZXRyaWMgPSBm YWxzZTsKKyAgICAgICAgICAgIHZhciBleGNsdWRlZE1lcnRpY0NvdW50ID0gMDsKICAgICAgICAg ICAgIGZvciAodmFyIG1ldHJpYyBvZiBtZXRyaWNzKSB7CiAgICAgICAgICAgICAgICAgY29uc29s ZS5hc3NlcnQobWV0cmljIGluc3RhbmNlb2YgTWV0cmljKTsKICAgICAgICAgICAgICAgICBjb25z b2xlLmFzc2VydCh0aGlzLl9zbWFsbGVySXNCZXR0ZXIgPT0gbWV0cmljLmlzU21hbGxlckJldHRl cigpKTsKICAgICAgICAgICAgICAgICBtZXRyaWMuaXNTbWFsbGVyQmV0dGVyKCk7CiAKLSAgICAg ICAgICAgICAgICBpZiAoZXhjbHVkZWRDb25maWd1cmF0aW9ucyAmJiBwbGF0Zm9ybS5pZCgpIGlu IGV4Y2x1ZGVkQ29uZmlndXJhdGlvbnMgJiYgZXhjbHVkZWRDb25maWd1cmF0aW9uc1twbGF0Zm9y bS5pZCgpXS5pbmNsdWRlcygrbWV0cmljLmlkKCkpKQorICAgICAgICAgICAgICAgIGlmIChleGNs dWRlZENvbmZpZ3VyYXRpb25zICYmIHBsYXRmb3JtLmlkKCkgaW4gZXhjbHVkZWRDb25maWd1cmF0 aW9ucyAmJiBleGNsdWRlZENvbmZpZ3VyYXRpb25zW3BsYXRmb3JtLmlkKCldLmluY2x1ZGVzKCtt ZXRyaWMuaWQoKSkpIHsKKyAgICAgICAgICAgICAgICAgICAgZXhjbHVkZWRNZXJ0aWNDb3VudCAr PSAxOwogICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICAgICAgaWYgKCFwbGF0Zm9ybS5oYXNNZXRyaWMobWV0cmljKSkKICAgICAgICAg ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICAgICAgZm91bmRJblNvbWVNZXRyaWMg PSB0cnVlOwogICAgICAgICAgICAgICAgIHRoaXMuX21lYXN1cmVtZW50U2V0cy5wdXNoKE1lYXN1 cmVtZW50U2V0LmZpbmRTZXQocGxhdGZvcm0uaWQoKSwgbWV0cmljLmlkKCksIHBsYXRmb3JtLmxh c3RNb2RpZmllZChtZXRyaWMpKSk7CiAgICAgICAgICAgICAgICAgdGhpcy5fY29uZmlndXJhdGlv bkxpc3QucHVzaChbcGxhdGZvcm0uaWQoKSwgbWV0cmljLmlkKCldKTsKICAgICAgICAgICAgIH0K LSAgICAgICAgICAgIGlmICghZm91bmRJblNvbWVNZXRyaWMpCisgICAgICAgICAgICBpZiAoIWZv dW5kSW5Tb21lTWV0cmljICYmIGV4Y2x1ZGVkTWVydGljQ291bnQgPCBtZXRyaWNzLmxlbmd0aCkK ICAgICAgICAgICAgICAgICB0aGlzLl9taXNzaW5nUGxhdGZvcm1zLmFkZChwbGF0Zm9ybSk7CiAg ICAgICAgIH0KICAgICB9Cg== 320977 2017-09-15 17:28:08 -0700 2017-09-15 18:11:31 -0700 Patch for landing bug-176970-20170915172807.patch text/plain 2951 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyMTIyCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCA0MDllYzI4MmJhOGVjYjBjNTJjYWUyNzE4N2UxYzQ0YjliMmFkYTcyLi5lMDY5YTIwN2Ey ZWNjZThlZTVhZmM2YTA0YjFhODk2MDc5MTJmMjE1IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOS0xNCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBTaG91bGQgbm90IG1hcmsgYSBwbGF0Zm9ybSBhcyBtaXNz aW5nIGluIHN1bW1hcnkgcGFnZSBpZiBhbGwgZXhwZWN0aW5nIG1ldHJpY3MgYXJlIGV4bHVjZGVk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2OTcw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAgICAgIEluIHN1bW1h cnkgcGFnZSwgaWYgYWxsIG1ldHJpY3MgZm9yIGEgdGVzdCBhcmUgZXhjbHVkZWQgaW4gZXhjbHVk ZWRDb25maWd1cmF0aW9ucyBmb3IgYSBwbGF0Zm9ybSwgdGhpcyBwbGF0Zm9ybSBzaG91bGQgbm90 IGJlIG1hcmtlZCBhcyBtaXNzaW5nLgorCisgICAgICAgICogcHVibGljL3YzL3BhZ2VzL3N1bW1h cnktcGFnZS5qczoKKyAgICAgICAgKFN1bW1hcnlQYWdlQ29uZmlndXJhdGlvbkdyb3VwKToKKwog MjAxNy0wOS0xMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBB bmFseXNpcyB0YXNrIHBhZ2Ugc2hvd3MgYW4gZW1wdHkgcmVzdWx0cyBmb3IgYW4gaXJyZWxldmFu dCB0b3AtbGV2ZWwgdGVzdApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1 YmxpYy92My9wYWdlcy9zdW1tYXJ5LXBhZ2UuanMgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcv cHVibGljL3YzL3BhZ2VzL3N1bW1hcnktcGFnZS5qcwppbmRleCA5NTE1YjE3M2FkMGFlOTYzMzIw NDQ1MTFjMWUyNzJhMGM1YjRjZDRiLi4wNWM2MDEzMTRlMWRlNTdiZmMwN2E2Mzk1YzYyOTA5ZDEw MzE0OGFjIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL3Bh Z2VzL3N1bW1hcnktcGFnZS5qcworKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGlj L3YzL3BhZ2VzL3N1bW1hcnktcGFnZS5qcwpAQCAtMjU5LDIzICsyNTksMjYgQEAgY2xhc3MgU3Vt bWFyeVBhZ2VDb25maWd1cmF0aW9uR3JvdXAgewogICAgICAgICB0aGlzLl9pc0ZldGNoaW5nID0g ZmFsc2U7CiAgICAgICAgIHRoaXMuX3NtYWxsZXJJc0JldHRlciA9IG1ldHJpY3MubGVuZ3RoID8g bWV0cmljc1swXS5pc1NtYWxsZXJCZXR0ZXIoKSA6IG51bGw7CiAKLSAgICAgICAgZm9yICh2YXIg cGxhdGZvcm0gb2YgcGxhdGZvcm1zKSB7CisgICAgICAgIGZvciAoY29uc3QgcGxhdGZvcm0gb2Yg cGxhdGZvcm1zKSB7CiAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChwbGF0Zm9ybSBpbnN0YW5j ZW9mIFBsYXRmb3JtKTsKLSAgICAgICAgICAgIHZhciBmb3VuZEluU29tZU1ldHJpYyA9IGZhbHNl OwotICAgICAgICAgICAgZm9yICh2YXIgbWV0cmljIG9mIG1ldHJpY3MpIHsKKyAgICAgICAgICAg IGxldCBmb3VuZEluU29tZU1ldHJpYyA9IGZhbHNlOworICAgICAgICAgICAgbGV0IGV4Y2x1ZGVk TWVydGljQ291bnQgPSAwOworICAgICAgICAgICAgZm9yIChjb25zdCBtZXRyaWMgb2YgbWV0cmlj cykgewogICAgICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KG1ldHJpYyBpbnN0YW5jZW9mIE1l dHJpYyk7CiAgICAgICAgICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5fc21hbGxlcklzQmV0 dGVyID09IG1ldHJpYy5pc1NtYWxsZXJCZXR0ZXIoKSk7CiAgICAgICAgICAgICAgICAgbWV0cmlj LmlzU21hbGxlckJldHRlcigpOwogCi0gICAgICAgICAgICAgICAgaWYgKGV4Y2x1ZGVkQ29uZmln dXJhdGlvbnMgJiYgcGxhdGZvcm0uaWQoKSBpbiBleGNsdWRlZENvbmZpZ3VyYXRpb25zICYmIGV4 Y2x1ZGVkQ29uZmlndXJhdGlvbnNbcGxhdGZvcm0uaWQoKV0uaW5jbHVkZXMoK21ldHJpYy5pZCgp KSkKKyAgICAgICAgICAgICAgICBpZiAoZXhjbHVkZWRDb25maWd1cmF0aW9ucyAmJiBwbGF0Zm9y bS5pZCgpIGluIGV4Y2x1ZGVkQ29uZmlndXJhdGlvbnMgJiYgZXhjbHVkZWRDb25maWd1cmF0aW9u c1twbGF0Zm9ybS5pZCgpXS5pbmNsdWRlcygrbWV0cmljLmlkKCkpKSB7CisgICAgICAgICAgICAg ICAgICAgIGV4Y2x1ZGVkTWVydGljQ291bnQgKz0gMTsKICAgICAgICAgICAgICAgICAgICAgY29u dGludWU7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGlmICghcGxhdGZvcm0u aGFzTWV0cmljKG1ldHJpYykpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICAgICAgICAgIGZvdW5kSW5Tb21lTWV0cmljID0gdHJ1ZTsKICAgICAgICAgICAgICAgICB0aGlz Ll9tZWFzdXJlbWVudFNldHMucHVzaChNZWFzdXJlbWVudFNldC5maW5kU2V0KHBsYXRmb3JtLmlk KCksIG1ldHJpYy5pZCgpLCBwbGF0Zm9ybS5sYXN0TW9kaWZpZWQobWV0cmljKSkpOwogICAgICAg ICAgICAgICAgIHRoaXMuX2NvbmZpZ3VyYXRpb25MaXN0LnB1c2goW3BsYXRmb3JtLmlkKCksIG1l dHJpYy5pZCgpXSk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAoIWZvdW5kSW5Tb21l TWV0cmljKQorICAgICAgICAgICAgaWYgKCFmb3VuZEluU29tZU1ldHJpYyAmJiBleGNsdWRlZE1l cnRpY0NvdW50IDwgbWV0cmljcy5sZW5ndGgpCiAgICAgICAgICAgICAgICAgdGhpcy5fbWlzc2lu Z1BsYXRmb3Jtcy5hZGQocGxhdGZvcm0pOwogICAgICAgICB9CiAgICAgfQo=