<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>176954</bug_id>
          
          <creation_ts>2017-09-14 13:41:25 -0700</creation_ts>
          <short_desc>Make dumping the graph print when both when exitOK and !exitOK</short_desc>
          <delta_ts>2017-09-27 12:36:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>rmorisset</cc>
    
    <cc>ticaiolima</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1348980</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-09-14 13:41:25 -0700</bug_when>
    <thetext>Currently, we only print when !exitOK. I think it&apos;d be helpful to also print when it&apos;s valid to make reading the dump more explicit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1349072</commentid>
    <comment_count>1</comment_count>
      <attachid>320839</attachid>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-09-14 16:17:35 -0700</bug_when>
    <thetext>Created attachment 320839
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1349073</commentid>
    <comment_count>2</comment_count>
      <attachid>320839</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2017-09-14 16:18:15 -0700</bug_when>
    <thetext>Comment on attachment 320839
patch

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1349102</commentid>
    <comment_count>3</comment_count>
      <attachid>320839</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-09-14 17:04:50 -0700</bug_when>
    <thetext>Comment on attachment 320839
patch

Clearing flags on attachment: 320839

Committed r222066: &lt;http://trac.webkit.org/changeset/222066&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1349103</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-09-14 17:04:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1353520</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-09-27 12:36:22 -0700</bug_when>
    <thetext>&lt;rdar://problem/34693583&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>320839</attachid>
            <date>2017-09-14 16:17:35 -0700</date>
            <delta_ts>2017-09-14 17:04:50 -0700</delta_ts>
            <desc>patch</desc>
            <filename>c-backup.diff</filename>
            <type>text/plain</type>
            <size>1332</size>
            <attacher name="Saam Barati">saam</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIyMDU4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDE3LTA5LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg
IE1ha2UgZHVtcGluZyB0aGUgZ3JhcGggcHJpbnQgd2hlbiBib3RoIHdoZW4gZXhpdE9LIGFuZCAh
ZXhpdE9LCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x
NzY5NTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq
IGRmZy9ERkdHcmFwaC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6R3JhcGg6OmR1bXApOgorCiAy
MDE3LTA5LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGRy
ZXNzU2FuaXRpemVyOiBzdGFjay1idWZmZXItdW5kZXJmbG93IGluIEpTQzo6UHJvYmU6OlBhZ2U6
OlBhZ2UKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCShyZXZpc2lv
biAyMjIwNTgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmNwcAkod29y
a2luZyBjb3B5KQpAQCAtMzkwLDggKzM5MCw3IEBAIHZvaWQgR3JhcGg6OmR1bXAoUHJpbnRTdHJl
YW0mIG91dCwgY29uc3QKICAgICAgICAgaWYgKG5vZGUtPm9yaWdpbi5zZW1hbnRpYyAhPSBub2Rl
LT5vcmlnaW4uZm9yRXhpdCAmJiBub2RlLT5vcmlnaW4uZm9yRXhpdC5pc1NldCgpKQogICAgICAg
ICAgICAgb3V0LnByaW50KGNvbW1hLCAiZXhpdDogIiwgbm9kZS0+b3JpZ2luLmZvckV4aXQpOwog
ICAgIH0KLSAgICBpZiAoIW5vZGUtPm9yaWdpbi5leGl0T0spCi0gICAgICAgIG91dC5wcmludChj
b21tYSwgIkV4aXRJbnZhbGlkIik7CisgICAgb3V0LnByaW50KGNvbW1hLCBub2RlLT5vcmlnaW4u
ZXhpdE9LID8gIkV4aXRWYWxpZCIgOiAiRXhpdEludmFsaWQiKTsKICAgICBpZiAobm9kZS0+b3Jp
Z2luLndhc0hvaXN0ZWQpCiAgICAgICAgIG91dC5wcmludChjb21tYSwgIldhc0hvaXN0ZWQiKTsK
ICAgICBvdXQucHJpbnQoIikiKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>