176952 2017-09-14 13:35:28 -0700 Layout test inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is flaky. 2017-09-27 12:31:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 webkit-unassigned joepeck mattbaker webkit-bug-importer oldest_to_newest 1348963 0 jlewis3 2017-09-14 13:35:28 -0700 inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is a flaky failure on macOS Sierra WK2 according to the flakiness dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fbreakpoints%2Fresolved-dump-all-pause-locations.html There doesn't appear to be a clear regression point on the dashboard however Results: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r222038%20(4294)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/4294 Diff: --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/inspector/debugger/breakpoints/resolved-dump-all-pause-locations-actual.txt @@ -1,5 +1,7 @@ Checking all resolved breakpoint locations in a script. +ERROR: No domain dispatcher registered for domain 'Memory' +ERROR: No domain dispatcher registered for domain 'Memory' == Running test suite: Debugger.resolvedBreakpoint.dumpAllLocations -- Running test case: Debugger.resolvedBreakpoint.dumpAllLocations.General 1348978 1 joepeck 2017-09-14 13:40:38 -0700 Yay! We caught an issue! Very easy fix. 1348987 2 320815 joepeck 2017-09-14 13:52:19 -0700 Created attachment 320815 [PATCH] Proposed Fix 1348989 3 320815 mattbaker 2017-09-14 13:54:45 -0700 Comment on attachment 320815 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=320815&action=review r=me, with a nit > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:289 > + console.error("No domain dispatcher registered for domain '" + this._domainName + "', for event '" + this._domainName + "." + eventName + "'"); This would be easier to read as a template string. 1349001 4 joepeck 2017-09-14 14:10:15 -0700 <https://trac.webkit.org/changeset/222052/webkit> 1353449 5 webkit-bug-importer 2017-09-27 12:31:48 -0700 <rdar://problem/34693432> 320815 2017-09-14 13:52:19 -0700 2017-09-14 14:07:15 -0700 [PATCH] Proposed Fix memory-1.patch text/plain 3814 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRiZDg5NzMwOWI1Li44N2EzYmZmMWExZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMDktMTQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBMYXlvdXQgdGVzdCBp bnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludHMvcmVzb2x2ZWQtZHVtcC1hbGwtcGF1c2UtbG9j YXRpb25zLmh0bWwgaXMgZmxha3kuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzY5NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVjdG9yQmFja2VuZC5q czoKKyAgICAgICAgKEluc3BlY3RvckJhY2tlbmQuQWdlbnQucHJvdG90eXBlLmRpc3BhdGNoRXZl bnQpOgorICAgICAgICBJbmNsdWRlIHRoZSBldmVudCBuYW1lIHNpbmNlIHRoYXQgbWF5IGJlIHVz ZWZ1bCBpbiB1bmRlcnN0YW5kaW5nIHdoYXQgaGFwcGVuZWQuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1Rlc3QuaHRtbDoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Rlc3QvVGVzdC5qczoK KyAgICAgICAgKFdJLmxvYWRlZCk6CisgICAgICAgIFJlZ2lzdGVyIGEgTWVtb3J5T2JzZXJ2ZXIg YW5kIGluY2x1ZGUgcG90ZW50aWFsbHkgbmVjZXNzYXJ5IE1vZGVsIG9iamVjdHMKKyAgICAgICAg Zm9yIHRoZSBNZW1vcnkgZG9tYWluLgorCisyMDE3LTA5LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmUgc2hv dWxkIHNob3cgd2hlbiBldmVudHMgcHJldmVudERlZmF1bHQoKSB3YXMgY2FsbGVkIG9uIGFuIGV2 ZW50IG9yIG5vdAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc2ODI0CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDI5MDkzMT4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Byb3RvY29sL0luc3BlY3RvckJh Y2tlbmQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Qcm90b2NvbC9J bnNwZWN0b3JCYWNrZW5kLmpzCmluZGV4IDBlZTllYWEzM2ViLi4xZDA0MWM1NWEwMSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvUHJvdG9jb2wvSW5zcGVj dG9yQmFja2VuZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Q cm90b2NvbC9JbnNwZWN0b3JCYWNrZW5kLmpzCkBAIC0yODYsNyArMjg2LDcgQEAgSW5zcGVjdG9y QmFja2VuZC5BZ2VudCA9IGNsYXNzIEluc3BlY3RvckJhY2tlbmRBZ2VudAogICAgIGRpc3BhdGNo RXZlbnQoZXZlbnROYW1lLCBldmVudEFyZ3VtZW50cykKICAgICB7CiAgICAgICAgIGlmICghdGhp cy5fZGlzcGF0Y2hlcikgewotICAgICAgICAgICAgY29uc29sZS5lcnJvcigiTm8gZG9tYWluIGRp c3BhdGNoZXIgcmVnaXN0ZXJlZCBmb3IgZG9tYWluICciICsgdGhpcy5fZG9tYWluTmFtZSArICIn Iik7CisgICAgICAgICAgICBjb25zb2xlLmVycm9yKCJObyBkb21haW4gZGlzcGF0Y2hlciByZWdp c3RlcmVkIGZvciBkb21haW4gJyIgKyB0aGlzLl9kb21haW5OYW1lICsgIicsIGZvciBldmVudCAn IiArIHRoaXMuX2RvbWFpbk5hbWUgKyAiLiIgKyBldmVudE5hbWUgKyAiJyIpOwogICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QuaHRtbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1Rlc3QuaHRtbAppbmRleCA1N2Y5Njk0ZjVhYS4uMzE4MzIyY2IxNDIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QuaHRtbAor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0Lmh0bWwKQEAgLTc4 LDYgKzc4LDcgQEAKICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvRE9NU3RvcmFnZU9ic2VydmVy LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvRGVidWdnZXJPYnNlcnZl ci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL0hlYXBPYnNlcnZlci5q cyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCBzcmM9IlByb3RvY29sL01lbW9yeU9ic2VydmVyLmpz Ij48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvTmV0d29ya09ic2VydmVyLmpz Ij48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvUGFnZU9ic2VydmVyLmpzIj48 L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iUHJvdG9jb2wvUmVtb3RlT2JqZWN0LmpzIj48L3Nj cmlwdD4KQEAgLTEzOSw2ICsxNDAsNyBAQAogICAgIDxzY3JpcHQgc3JjPSJNb2RlbHMvTGF6eVNv dXJjZUNvZGVMb2NhdGlvbi5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9Ik1vZGVscy9N ZW1vcnlDYXRlZ29yeS5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9Ik1vZGVscy9NZW1v cnlJbnN0cnVtZW50LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iTW9kZWxzL01lbW9y eVByZXNzdXJlRXZlbnQuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJNb2RlbHMvTWVt b3J5VGltZWxpbmUuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJNb2RlbHMvTWVtb3J5 VGltZWxpbmVSZWNvcmQuanMiPjwvc2NyaXB0PgogICAgIDxzY3JpcHQgc3JjPSJNb2RlbHMvTmV0 d29ya0luc3RydW1lbnQuanMiPjwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVGVzdC9UZXN0LmpzCmluZGV4IDVmZTA0MDg2Y2MwLi5mMWI1MDg5ZTAz ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVGVzdC9U ZXN0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Rlc3QvVGVz dC5qcwpAQCAtNDIsNiArNDIsNyBAQCBXSS5sb2FkZWQgPSBmdW5jdGlvbigpCiAgICAgSW5zcGVj dG9yQmFja2VuZC5yZWdpc3RlckRPTURpc3BhdGNoZXIobmV3IFdJLkRPTU9ic2VydmVyKTsKICAg ICBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVyRGVidWdnZXJEaXNwYXRjaGVyKG5ldyBXSS5EZWJ1 Z2dlck9ic2VydmVyKTsKICAgICBJbnNwZWN0b3JCYWNrZW5kLnJlZ2lzdGVySGVhcERpc3BhdGNo ZXIobmV3IFdJLkhlYXBPYnNlcnZlcik7CisgICAgSW5zcGVjdG9yQmFja2VuZC5yZWdpc3Rlck1l bW9yeURpc3BhdGNoZXIobmV3IFdJLk1lbW9yeU9ic2VydmVyKTsKICAgICBJbnNwZWN0b3JCYWNr ZW5kLnJlZ2lzdGVyRE9NU3RvcmFnZURpc3BhdGNoZXIobmV3IFdJLkRPTVN0b3JhZ2VPYnNlcnZl cik7CiAgICAgSW5zcGVjdG9yQmFja2VuZC5yZWdpc3RlclNjcmlwdFByb2ZpbGVyRGlzcGF0Y2hl cihuZXcgV0kuU2NyaXB0UHJvZmlsZXJPYnNlcnZlcik7CiAgICAgSW5zcGVjdG9yQmFja2VuZC5y ZWdpc3RlclRpbWVsaW5lRGlzcGF0Y2hlcihuZXcgV0kuVGltZWxpbmVPYnNlcnZlcik7Cg==