176907 2017-09-14 08:42:38 -0700 [FreeType] Complex text is enabled too often after r221909 2017-09-27 12:36:33 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply buildbot csaavedra mmaxfield svillar webkit-bug-importer oldest_to_newest 1348766 0 cgarcia 2017-09-14 08:42:38 -0700 In r221909 we enabled complex text by default following the same cocoa ifdefs, but I forgot another ifdef in the cpp file. This is going to require another rebaseline fo 2200 tests. I hope it will be the last one. 1348767 1 320769 cgarcia 2017-09-14 08:44:16 -0700 Created attachment 320769 Patch 1349200 2 cgarcia 2017-09-15 00:08:36 -0700 Committed r222077: <http://trac.webkit.org/changeset/222077> 1349240 3 csaavedra 2017-09-15 03:06:44 -0700 After this change there's massive WPE test failure in the bots. Not sure what's going on.. https://build.webkit.org/builders/WPE%20Linux%2064-bit%20Release%20%28Tests%29/builds/2820 1349241 4 csaavedra 2017-09-15 03:07:17 -0700 (In reply to Carlos Garcia Campos from comment #0) > In r221909 we enabled complex text by default following the same cocoa > ifdefs, but I forgot another ifdef in the cpp file. This is going to require > another rebaseline fo 2200 tests. I hope it will be the last one. > This is going to require another rebaseline fo 2200 tests. I hope it will be the last one. Ah, sorry. I should read before commenting. 1353524 5 webkit-bug-importer 2017-09-27 12:36:33 -0700 <rdar://problem/34693592> 320769 2017-09-14 08:44:16 -0700 2017-09-14 09:50:35 -0700 Patch wk-freetype-complex-text.diff text/plain 1700 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZmUzN2QyNjM5Ni4uMWFlYWU5N2E3MzkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wOS0xNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0ZyZWVUeXBlXSBDb21wbGV4IHRleHQgaXMgZW5hYmxlZCB0 b28gb2Z0ZW4gYWZ0ZXIgcjIyMTkwOQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc2OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSW4gcjIyMTkwOSB3ZSBlbmFibGVkIGNvbXBsZXggdGV4dCBieSBkZWZh dWx0IGZvbGxvd2luZyB0aGUgc2FtZSBjb2NvYSBpZmRlZnMsIGJ1dCBJIGZvcmdvdCBhbm90aGVy IGlmZGVmIGluIHRoZQorICAgICAgICBjcHAgZmlsZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL0ZvbnRDYXNjYWRlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYXNjYWRlOjpj b2RlUGF0aCBjb25zdCk6CisKIDIwMTctMDktMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtIYXJmYnV6el0gV3Jvbmcgb2Zmc2V0IHJldHVy bmVkIGJ5IEhhcmZCdXp6U2hhcGVyOjpvZmZzZXRGb3JQb3NpdGlvbigpIHdoZW4gdGFyZ2V0IHBv aW50IGlzIGF0IHRoZSBtaWRkbGUgb2YgYSBjaGFyYWN0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRDYXNjYWRlLmNwcAppbmRleCAyYzU0N2MxNmI4My4uOTFk MjQzZTFjODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRDYXNjYWRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250 Q2FzY2FkZS5jcHAKQEAgLTU5Nyw3ICs1OTcsNyBAQCBGb250Q2FzY2FkZTo6Q29kZVBhdGggRm9u dENhc2NhZGU6OmNvZGVQYXRoKGNvbnN0IFRleHRSdW4mIHJ1bikgY29uc3QKICAgICBpZiAoc19j b2RlUGF0aCAhPSBBdXRvKQogICAgICAgICByZXR1cm4gc19jb2RlUGF0aDsKIAotI2lmIFBMQVRG T1JNKENPQ09BKQorI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBVU0UoRlJFRVRZUEUpCiAgICAgLy8g QmVjYXVzZSBGb250OjphcHBseVRyYW5zZm9ybXMoKSBkb2Vzbid0IGtub3cgd2hpY2ggZmVhdHVy ZXMgdG8gZW5hYmxlL2Rpc2FibGUgaW4gdGhlIHNpbXBsZSBjb2RlIHBhdGgsIGl0IGNhbid0IHBy b3Blcmx5IGhhbmRsZSBmZWF0dXJlIG9yIHZhcmlhbnQgc2V0dGluZ3MuCiAgICAgLy8gRklYTUU6 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA3OTE6IEBmb250LWZh Y2UgZmVhdHVyZXMgc2hvdWxkIGFsc28gY2F1c2UgdGhpcyB0byBiZSBjb21wbGV4LgogICAgIGlm IChtX2ZvbnREZXNjcmlwdGlvbi5mZWF0dXJlU2V0dGluZ3MoKS5zaXplKCkgPiAwIHx8ICFtX2Zv bnREZXNjcmlwdGlvbi52YXJpYW50U2V0dGluZ3MoKS5pc0FsbE5vcm1hbCgpKQo=