176886 2017-09-13 18:07:40 -0700 [CMake] Detect harfbuzz without pkgconfig 2017-09-27 12:28:03 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead annulen buildbot commit-queue lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1348594 0 don.olmstead 2017-09-13 18:07:40 -0700 Currently harfbuzz is not able to be detected without pkgconfig which isn't typically used on windows. 1348597 1 320718 don.olmstead 2017-09-13 18:17:06 -0700 Created attachment 320718 Patch Detects harfbuzz without pkgconfig. Will determine the version from the header file directly. 1348598 2 buildbot 2017-09-13 18:20:16 -0700 Attachment 320718 did not pass style-queue: ERROR: Source/cmake/FindHarfBuzz.cmake:54: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] ERROR: Source/cmake/FindHarfBuzz.cmake:55: One space between command "endif" and its parentheses, should be "endif (" [whitespace/parentheses] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1348599 3 320719 don.olmstead 2017-09-13 18:23:28 -0700 Created attachment 320719 Patch 1348658 4 320719 commit-queue 2017-09-13 23:19:12 -0700 Comment on attachment 320719 Patch Clearing flags on attachment: 320719 Committed r222011: <http://trac.webkit.org/changeset/222011> 1348659 5 commit-queue 2017-09-13 23:19:13 -0700 All reviewed patches have been landed. Closing bug. 1353407 6 webkit-bug-importer 2017-09-27 12:28:03 -0700 <rdar://problem/34693329> 320718 2017-09-13 18:17:06 -0700 2017-09-13 18:23:28 -0700 Patch bug-176886.diff text/plain 3148 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5NmM3Y2VkODcwYy4uNWE3 MmYyNmI1OTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wOS0xMyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtDTWFrZV0gRGV0ZWN0IGhhcmZidXp6IHdpdGhvdXQgcGtnY29uZmlnCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY4ODYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9j bWFrZS9GaW5kSGFyZkJ1enouY21ha2U6CisKIDIwMTctMDktMDcgIEFkcmlhbiBQZXJleiBkZSBD YXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtDTWFrZV0gQWRkICJk aXN0IiBhbmQgImRpc3RjaGVjayIgdGFyZ2V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL0Zp bmRIYXJmQnV6ei5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKaW5kZXgg ODQ0MGM3YjJiNjguLjQ2MjM2YTU4OTkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEhh cmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKQEAgLTMx LDMxICszMSw1NSBAQAogIyBIQVJGQlVaWl9MSUJSQVJJRVMgLSBjb250YWluZyB0aGUgSGFyZkJ1 enogbGlicmFyeQogCiBpbmNsdWRlKEZpbmRQa2dDb25maWcpCitwa2dfY2hlY2tfbW9kdWxlcyhQ Q19IQVJGQlVaWiBRVUlFVCBoYXJmYnV6eikKIAotcGtnX2NoZWNrX21vZHVsZXMoUENfSEFSRkJV WlogaGFyZmJ1eno+PTAuOS43KQotCi1maW5kX3BhdGgoSEFSRkJVWlpfSU5DTFVERV9ESVJTIE5B TUVTIGhiLmgKLSAgICBISU5UUyAke1BDX0hBUkZCVVpaX0lOQ0xVREVfRElSU30gJHtQQ19IQVJG QlVaWl9JTkNMVURFRElSfQorZmluZF9wYXRoKEhBUkZCVVpaX0lOQ0xVREVfRElSUworICAgIE5B TUVTIGhiLmgKKyAgICBISU5UUyAke1BDX0hBUkZCVVpaX0lOQ0xVREVESVJ9CisgICAgICAgICAg JHtQQ19IQVJGQlVaWl9JTkNMVURFX0RJUlN9CisgICAgUEFUSF9TVUZGSVhFUyBoYXJmYnV6egog KQogCiBmaW5kX2xpYnJhcnkoSEFSRkJVWlpfTElCUkFSSUVTIE5BTUVTIGhhcmZidXp6Ci0gICAg SElOVFMgJHtQQ19IQVJGQlVaWl9MSUJSQVJZX0RJUlN9ICR7UENfSEFSRkJVWlpfTElCRElSfQor ICAgIEhJTlRTICR7UENfSEFSRkJVWlpfTElCRElSfQorICAgICAgICAgICR7UENfSEFSRkJVWlpf TElCUkFSWV9ESVJTfQogKQogCitpZiAoSEFSRkJVWlpfSU5DTFVERV9ESVJTKQorICAgIGlmIChF WElTVFMgIiR7SEFSRkJVWlpfSU5DTFVERV9ESVJTfS9oYi12ZXJzaW9uLmgiKQorICAgICAgICBm aWxlKFJFQUQgIiR7SEFSRkJVWlpfSU5DTFVERV9ESVJTfS9oYi12ZXJzaW9uLmgiIF9oYXJmYnV6 el92ZXJzaW9uX2NvbnRlbnQpCisKKyAgICAgICAgc3RyaW5nKFJFR0VYIE1BVENIICIjZGVmaW5l ICtIQl9WRVJTSU9OX1NUUklORyArXCIoWzAtOV0rXC5bMC05XStcLlswLTldKylcIiIgX2R1bW15 ICIke19oYXJmYnV6el92ZXJzaW9uX2NvbnRlbnR9IikKKyAgICAgICAgc2V0KEhBUkZCVVpaX1ZF UlNJT04gIiR7Q01BS0VfTUFUQ0hfMX0iKQorICAgIGVuZGlmKCkKK2VuZGlmKCkKKworaWYgKCIk e0hhcmZidXp6X0ZJTkRfVkVSU0lPTn0iIFZFUlNJT05fR1JFQVRFUiAiJHtIQVJGQlVaWl9WRVJT SU9OfSIpCisgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiUmVxdWlyZWQgdmVyc2lvbiAoIiAke0hh cmZidXp6X0ZJTkRfVkVSU0lPTn0gIikgaXMgaGlnaGVyIHRoYW4gZm91bmQgdmVyc2lvbiAoIiAk e0NBSVJPX1ZFUlNJT059ICIpIikKK2VuZGlmICgpCisKICMgSGFyZkJ1enogMC45LjE4IHNwbGl0 IElDVSBzdXBwb3J0IGludG8gYSBzZXBhcmF0ZSBoYXJmYnV6ei1pY3UgbGlicmFyeS4KLWlmICgi JHtQQ19IQVJGQlVaWl9WRVJTSU9OfSIgVkVSU0lPTl9HUkVBVEVSICIwLjkuMTciKQotICAgIHBr Z19jaGVja19tb2R1bGVzKFBDX0hBUkZCVVpaX0lDVSBoYXJmYnV6ei1pY3U+PTAuOS4xOCBSRVFV SVJFRCkKLSAgICBmaW5kX2xpYnJhcnkoSEFSRkJVWlpfSUNVX0xJQlJBUklFUyBOQU1FUyBoYXJm YnV6ei1pY3UKLSAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9JQ1VfTElCUkFSWV9ESVJTfSAk e1BDX0hBUkZCVVpaX0lDVV9MSUJESVJ9CitpZiAoIiR7SEFSRkJVWlpfVkVSU0lPTn0iIFZFUlNJ T05fR1JFQVRFUiAiMC45LjE3IikKKyAgICBwa2dfY2hlY2tfbW9kdWxlcyhQQ19IQVJGQlVaWl9J Q1UgUVVJRVQgaGFyZmJ1enotaWN1KQorCisgICAgZmluZF9saWJyYXJ5KEhBUkZCVVpaX0lDVV9M SUJSQVJJRVMgaGFyZmJ1enotaWN1CisgICAgICAgIEhJTlRTICR7UENfSEFSRkJVWlpfSUNVX0xJ QkRJUn0KKyAgICAgICAgICAgICAgJHtQQ19IQVJGQlVaWl9JQ1VfTElCUkFSWV9ESVJTfQogICAg ICkKKworICAgIGlmIChOT1QgSEFSRkJVWlpfSUNVX0xJQlJBUklFUykKKyAgICAgICAgbWVzc2Fn ZShGQVRBTF9FUlJPUiAiaGFyZmJ1enotaWN1IGxpYnJhcnkgbm90IGZvdW5kIikKKyAgICBlbmRp ZiAoKQorCiAgICAgbGlzdChBUFBFTkQgSEFSRkJVWlpfTElCUkFSSUVTICIke0hBUkZCVVpaX0lD VV9MSUJSQVJJRVN9IikKIGVuZGlmICgpCiAKIGluY2x1ZGUoRmluZFBhY2thZ2VIYW5kbGVTdGFu ZGFyZEFyZ3MpCi1GSU5EX1BBQ0tBR0VfSEFORExFX1NUQU5EQVJEX0FSR1MoSGFyZkJ1enogREVG QVVMVF9NU0cgSEFSRkJVWlpfSU5DTFVERV9ESVJTIEhBUkZCVVpaX0xJQlJBUklFUykKK0ZJTkRf UEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhIYXJmYnV6eiBSRVFVSVJFRF9WQVJTIEhBUkZC VVpaX0lOQ0xVREVfRElSUyBIQVJGQlVaWl9MSUJSQVJJRVMKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBWRVJTSU9OX1ZBUiBIQVJGQlVaWl9WRVJTSU9OKQogCiBt YXJrX2FzX2FkdmFuY2VkKAotICAgIEhBUkZCVVpaX0lDVV9MSUJSQVJJRVMKICAgICBIQVJGQlVa Wl9JTkNMVURFX0RJUlMKICAgICBIQVJGQlVaWl9MSUJSQVJJRVMKKyAgICBIQVJGQlVaWl9JQ1Vf TElCUkFSSUVTCiApCg== 320719 2017-09-13 18:23:28 -0700 2017-09-13 23:19:12 -0700 Patch bug-176886.diff text/plain 3150 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5NmM3Y2VkODcwYy4uNWE3 MmYyNmI1OTcgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0wOS0xMyAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29t PgorCisgICAgICAgIFtDTWFrZV0gRGV0ZWN0IGhhcmZidXp6IHdpdGhvdXQgcGtnY29uZmlnCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY4ODYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9j bWFrZS9GaW5kSGFyZkJ1enouY21ha2U6CisKIDIwMTctMDktMDcgIEFkcmlhbiBQZXJleiBkZSBD YXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXVtDTWFrZV0gQWRkICJk aXN0IiBhbmQgImRpc3RjaGVjayIgdGFyZ2V0cwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL0Zp bmRIYXJmQnV6ei5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKaW5kZXgg ODQ0MGM3YjJiNjguLjc4NDEyNDA1YzEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZEhh cmZCdXp6LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kSGFyZkJ1enouY21ha2UKQEAgLTMx LDMxICszMSw1NSBAQAogIyBIQVJGQlVaWl9MSUJSQVJJRVMgLSBjb250YWluZyB0aGUgSGFyZkJ1 enogbGlicmFyeQogCiBpbmNsdWRlKEZpbmRQa2dDb25maWcpCitwa2dfY2hlY2tfbW9kdWxlcyhQ Q19IQVJGQlVaWiBRVUlFVCBoYXJmYnV6eikKIAotcGtnX2NoZWNrX21vZHVsZXMoUENfSEFSRkJV WlogaGFyZmJ1eno+PTAuOS43KQotCi1maW5kX3BhdGgoSEFSRkJVWlpfSU5DTFVERV9ESVJTIE5B TUVTIGhiLmgKLSAgICBISU5UUyAke1BDX0hBUkZCVVpaX0lOQ0xVREVfRElSU30gJHtQQ19IQVJG QlVaWl9JTkNMVURFRElSfQorZmluZF9wYXRoKEhBUkZCVVpaX0lOQ0xVREVfRElSUworICAgIE5B TUVTIGhiLmgKKyAgICBISU5UUyAke1BDX0hBUkZCVVpaX0lOQ0xVREVESVJ9CisgICAgICAgICAg JHtQQ19IQVJGQlVaWl9JTkNMVURFX0RJUlN9CisgICAgUEFUSF9TVUZGSVhFUyBoYXJmYnV6egog KQogCiBmaW5kX2xpYnJhcnkoSEFSRkJVWlpfTElCUkFSSUVTIE5BTUVTIGhhcmZidXp6Ci0gICAg SElOVFMgJHtQQ19IQVJGQlVaWl9MSUJSQVJZX0RJUlN9ICR7UENfSEFSRkJVWlpfTElCRElSfQor ICAgIEhJTlRTICR7UENfSEFSRkJVWlpfTElCRElSfQorICAgICAgICAgICR7UENfSEFSRkJVWlpf TElCUkFSWV9ESVJTfQogKQogCitpZiAoSEFSRkJVWlpfSU5DTFVERV9ESVJTKQorICAgIGlmIChF WElTVFMgIiR7SEFSRkJVWlpfSU5DTFVERV9ESVJTfS9oYi12ZXJzaW9uLmgiKQorICAgICAgICBm aWxlKFJFQUQgIiR7SEFSRkJVWlpfSU5DTFVERV9ESVJTfS9oYi12ZXJzaW9uLmgiIF9oYXJmYnV6 el92ZXJzaW9uX2NvbnRlbnQpCisKKyAgICAgICAgc3RyaW5nKFJFR0VYIE1BVENIICIjZGVmaW5l ICtIQl9WRVJTSU9OX1NUUklORyArXCIoWzAtOV0rXC5bMC05XStcLlswLTldKylcIiIgX2R1bW15 ICIke19oYXJmYnV6el92ZXJzaW9uX2NvbnRlbnR9IikKKyAgICAgICAgc2V0KEhBUkZCVVpaX1ZF UlNJT04gIiR7Q01BS0VfTUFUQ0hfMX0iKQorICAgIGVuZGlmICgpCitlbmRpZiAoKQorCitpZiAo IiR7SGFyZmJ1enpfRklORF9WRVJTSU9OfSIgVkVSU0lPTl9HUkVBVEVSICIke0hBUkZCVVpaX1ZF UlNJT059IikKKyAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJSZXF1aXJlZCB2ZXJzaW9uICgiICR7 SGFyZmJ1enpfRklORF9WRVJTSU9OfSAiKSBpcyBoaWdoZXIgdGhhbiBmb3VuZCB2ZXJzaW9uICgi ICR7Q0FJUk9fVkVSU0lPTn0gIikiKQorZW5kaWYgKCkKKwogIyBIYXJmQnV6eiAwLjkuMTggc3Bs aXQgSUNVIHN1cHBvcnQgaW50byBhIHNlcGFyYXRlIGhhcmZidXp6LWljdSBsaWJyYXJ5LgotaWYg KCIke1BDX0hBUkZCVVpaX1ZFUlNJT059IiBWRVJTSU9OX0dSRUFURVIgIjAuOS4xNyIpCi0gICAg cGtnX2NoZWNrX21vZHVsZXMoUENfSEFSRkJVWlpfSUNVIGhhcmZidXp6LWljdT49MC45LjE4IFJF UVVJUkVEKQotICAgIGZpbmRfbGlicmFyeShIQVJGQlVaWl9JQ1VfTElCUkFSSUVTIE5BTUVTIGhh cmZidXp6LWljdQotICAgICAgICBISU5UUyAke1BDX0hBUkZCVVpaX0lDVV9MSUJSQVJZX0RJUlN9 ICR7UENfSEFSRkJVWlpfSUNVX0xJQkRJUn0KK2lmICgiJHtIQVJGQlVaWl9WRVJTSU9OfSIgVkVS U0lPTl9HUkVBVEVSICIwLjkuMTciKQorICAgIHBrZ19jaGVja19tb2R1bGVzKFBDX0hBUkZCVVpa X0lDVSBRVUlFVCBoYXJmYnV6ei1pY3UpCisKKyAgICBmaW5kX2xpYnJhcnkoSEFSRkJVWlpfSUNV X0xJQlJBUklFUyBoYXJmYnV6ei1pY3UKKyAgICAgICAgSElOVFMgJHtQQ19IQVJGQlVaWl9JQ1Vf TElCRElSfQorICAgICAgICAgICAgICAke1BDX0hBUkZCVVpaX0lDVV9MSUJSQVJZX0RJUlN9CiAg ICAgKQorCisgICAgaWYgKE5PVCBIQVJGQlVaWl9JQ1VfTElCUkFSSUVTKQorICAgICAgICBtZXNz YWdlKEZBVEFMX0VSUk9SICJoYXJmYnV6ei1pY3UgbGlicmFyeSBub3QgZm91bmQiKQorICAgIGVu ZGlmICgpCisKICAgICBsaXN0KEFQUEVORCBIQVJGQlVaWl9MSUJSQVJJRVMgIiR7SEFSRkJVWlpf SUNVX0xJQlJBUklFU30iKQogZW5kaWYgKCkKIAogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0 YW5kYXJkQXJncykKLUZJTkRfUEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhIYXJmQnV6eiBE RUZBVUxUX01TRyBIQVJGQlVaWl9JTkNMVURFX0RJUlMgSEFSRkJVWlpfTElCUkFSSUVTKQorRklO RF9QQUNLQUdFX0hBTkRMRV9TVEFOREFSRF9BUkdTKEhhcmZidXp6IFJFUVVJUkVEX1ZBUlMgSEFS RkJVWlpfSU5DTFVERV9ESVJTIEhBUkZCVVpaX0xJQlJBUklFUworICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFZFUlNJT05fVkFSIEhBUkZCVVpaX1ZFUlNJT04pCiAK IG1hcmtfYXNfYWR2YW5jZWQoCi0gICAgSEFSRkJVWlpfSUNVX0xJQlJBUklFUwogICAgIEhBUkZC VVpaX0lOQ0xVREVfRElSUwogICAgIEhBUkZCVVpaX0xJQlJBUklFUworICAgIEhBUkZCVVpaX0lD VV9MSUJSQVJJRVMKICkK