176879 2017-09-13 16:09:56 -0700 Web Inspector: Sort by size issues with Cookies and ApplicationCache DataGrids 2017-09-13 16:46:49 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1348541 0 joepeck 2017-09-13 16:09:56 -0700 Sort by size issues with Cookies and ApplicationCache DataGrids Steps to Reproduce: (Cookies) 1. Inspect a page with many cookies 2. Show Storage Tab 3. Select domain 4. Sort by size ascending => Works. 5. Reload => DataGrid shows sort by size but it isn't sorted by size Steps to Reproduce: (ApplicationCache) 1. Inspect a page with an AppCache manifest and resources 2. Show Storage Tab 3. Select ApplicationCache manifest 4. Sort by size => Does not work A few minor issues lurking in here. 1348542 1 joepeck 2017-09-13 16:10:06 -0700 <rdar://problem/34237096> 1348543 2 320705 joepeck 2017-09-13 16:14:02 -0700 Created attachment 320705 [PATCH] Proposed Fix 1348545 3 320705 mattbaker 2017-09-13 16:17:17 -0700 Comment on attachment 320705 [PATCH] Proposed Fix r=me 1348563 4 320705 commit-queue 2017-09-13 16:46:47 -0700 Comment on attachment 320705 [PATCH] Proposed Fix Clearing flags on attachment: 320705 Committed r222001: <http://trac.webkit.org/changeset/222001> 1348564 5 commit-queue 2017-09-13 16:46:49 -0700 All reviewed patches have been landed. Closing bug. 320705 2017-09-13 16:14:02 -0700 2017-09-13 16:46:47 -0700 [PATCH] Proposed Fix sort-fixes-1.patch text/plain 6674 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQxM2YwYjMxM2MyLi40YmMzYTI0Zjc4NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMTctMDktMTMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBTb3J0IGJ5IHNpemUgaXNzdWVzIHdpdGggQ29va2llcyBhbmQgQXBwbGljYXRpb25DYWNoZSBE YXRhR3JpZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3Njg3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQyMzcwOTY+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuQXBwbGlj YXRpb25DYWNoZUZyYW1lQ29udGVudFZpZXcucHJvdG90eXBlLl9zb3J0RGF0YUdyaWQpOgorICAg ICAgICAoV0kuQXBwbGljYXRpb25DYWNoZUZyYW1lQ29udGVudFZpZXcucHJvdG90eXBlLl9wb3B1 bGF0ZURhdGFHcmlkKToKKyAgICAgICAgVGhpcyB1c2VzIHZlcnkgZHVtYiBEYXRhR3JpZE5vZGVz IHdpdGggYSBwdXJlIGRhdGEgb2JqZWN0LiBJbiB0aGF0CisgICAgICAgIG9iamVjdCBgc2l6ZWAg aXMgYSBieXRlcyBzdHJpbmcgbm90IGEgbnVtYmVyLiBJbmNsdWRlIHRoZSBudW1iZXIgc2l6ZQor ICAgICAgICBpbiB0aGlzIGRhdGEgb2JqZWN0IHRoYXQgY2FuIGJlIHVzZWQgZHVyaW5nIHNvcnRp bmcuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Nvb2tpZVN0b3JhZ2VDb250ZW50 Vmlldy5qczoKKyAgICAgICAgKFdJLkNvb2tpZVN0b3JhZ2VDb250ZW50Vmlldy5wcm90b3R5cGUu X3JlYnVpbGRUYWJsZSk6CisgICAgICAgIFNpbXBsaWZ5IGNyZWF0aW9uLiBBbHNvIGRvbid0IHJl c2V0IHNvcnQgb3B0aW9ucy4gTm90ZSB0aGF0IGhlcmUgdGhlCisgICAgICAgIERhdGFHcmlkTm9k ZXMgaGF2ZSBhY2Nlc3MgdG8gdGhlIENvb2tpZSBvYmplY3QgYW5kIGNhbiBhbHJlYWR5IHNvcnQg c2l6ZQorICAgICAgICB1c2luZyB0aGUgY29va2llJ3Mgc2l6ZSAoYSBudW1iZXIpIGFuZCBub3Qg dGhlIGRhdGEncyBzaXplIChzdHJpbmcpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9EYXRhR3JpZC5qczoKKyAgICAgICAgKFdJLkRhdGFHcmlkLnByb3RvdHlwZS5zb3J0Tm9kZXMp OgorICAgICAgICAoV0kuRGF0YUdyaWQucHJvdG90eXBlLl9zb3J0Tm9kZXNDYWxsYmFjayk6Cisg ICAgICAgIElmIHNvcnROb2RlcyB3YXMgY2FsbGVkIHR3aWNlLCBpdCB3b3VsZCBkZWZlciB0aGUg c29ydCBhbmQgYWN0dWFsbHkKKyAgICAgICAgZG8gdGhlIHNvcnQgd2l0aCB0aGUgZmlyc3QgY29t cGFyYXRvciBhbmQgbm90IHRoZSBsYXRlc3QsIHByZWZlcnJlZAorICAgICAgICBjb21wYXJhdG9y LiBNYWtlIGl0IHVzZSB0aGUgbGF0ZXN0IGNvbXBhcmF0b3IuCisKIDIwMTctMDktMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZGQgRXhwZXJpbWVudGFsIHNldHRpbmcgZm9yIG5ldyBOZXR3b3JrIHRhYgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25D YWNoZUZyYW1lQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlRnJhbWVDb250ZW50Vmlldy5qcwppbmRleCBhNjYy ZWY2OTAyMi4uNWU3YmEzNGU0MzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0FwcGxpY2F0aW9u Q2FjaGVGcmFtZUNvbnRlbnRWaWV3LmpzCkBAIC0xODgsNyArMTg4LDcgQEAgV0kuQXBwbGljYXRp b25DYWNoZUZyYW1lQ29udGVudFZpZXcgPSBjbGFzcyBBcHBsaWNhdGlvbkNhY2hlRnJhbWVDb250 ZW50VmlldyBleHQKICAgICAgICAgdmFyIGNvbXBhcmF0b3I7CiAgICAgICAgIHN3aXRjaCAodGhp cy5fZGF0YUdyaWQuc29ydENvbHVtbklkZW50aWZpZXIpIHsKICAgICAgICAgICAgIGNhc2UgInR5 cGUiOiBjb21wYXJhdG9yID0gbG9jYWxlQ29tcGFyZS5iaW5kKHRoaXMsICJ0eXBlIik7IGJyZWFr OwotICAgICAgICAgICAgY2FzZSAic2l6ZSI6IGNvbXBhcmF0b3IgPSBudW1iZXJDb21wYXJlLmJp bmQodGhpcywgInNpemUiKTsgYnJlYWs7CisgICAgICAgICAgICBjYXNlICJzaXplIjogY29tcGFy YXRvciA9IG51bWJlckNvbXBhcmUuYmluZCh0aGlzLCAic2l6ZU51bWJlciIpOyBicmVhazsKICAg ICAgICAgICAgIGNhc2UgInVybCI6CiAgICAgICAgICAgICBkZWZhdWx0OiBjb21wYXJhdG9yID0g bG9jYWxlQ29tcGFyZS5iaW5kKHRoaXMsICJ1cmwiKTsgYnJlYWs7CiAgICAgICAgIH0KQEAgLTIw NCw3ICsyMDQsOCBAQCBXSS5BcHBsaWNhdGlvbkNhY2hlRnJhbWVDb250ZW50VmlldyA9IGNsYXNz IEFwcGxpY2F0aW9uQ2FjaGVGcmFtZUNvbnRlbnRWaWV3IGV4dAogICAgICAgICAgICAgdmFyIGRh dGEgPSB7CiAgICAgICAgICAgICAgICAgdXJsOiByZXNvdXJjZS51cmwsCiAgICAgICAgICAgICAg ICAgdHlwZTogcmVzb3VyY2UudHlwZSwKLSAgICAgICAgICAgICAgICBzaXplOiBOdW1iZXIuYnl0 ZXNUb1N0cmluZyhyZXNvdXJjZS5zaXplKQorICAgICAgICAgICAgICAgIHNpemU6IE51bWJlci5i eXRlc1RvU3RyaW5nKHJlc291cmNlLnNpemUpLAorICAgICAgICAgICAgICAgIHNpemVOdW1iZXI6 IHJlc291cmNlLnNpemUsCiAgICAgICAgICAgICB9OwogICAgICAgICAgICAgdmFyIG5vZGUgPSBu ZXcgV0kuRGF0YUdyaWROb2RlKGRhdGEpOwogICAgICAgICAgICAgdGhpcy5fZGF0YUdyaWQuYXBw ZW5kQ2hpbGQobm9kZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMK aW5kZXggZDczMTBmMmExZmQuLmEyYzljM2JmYTVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db29raWVTdG9yYWdlQ29udGVudFZpZXcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29va2llU3Rv cmFnZUNvbnRlbnRWaWV3LmpzCkBAIC0xMTUsNiArMTE1LDggQEAgV0kuQ29va2llU3RvcmFnZUNv bnRlbnRWaWV3ID0gY2xhc3MgQ29va2llU3RvcmFnZUNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29u dGVudFYKICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkID0gbmV3IFdJLkRhdGFHcmlkKGNvbHVt bnMsIG51bGwsIHRoaXMuX2RlbGV0ZUNhbGxiYWNrLmJpbmQodGhpcykpOwogICAgICAgICAgICAg dGhpcy5fZGF0YUdyaWQuY29sdW1uQ2hvb3NlckVuYWJsZWQgPSB0cnVlOwogICAgICAgICAgICAg dGhpcy5fZGF0YUdyaWQuYWRkRXZlbnRMaXN0ZW5lcihXSS5EYXRhR3JpZC5FdmVudC5Tb3J0Q2hh bmdlZCwgdGhpcy5fc29ydERhdGFHcmlkLCB0aGlzKTsKKyAgICAgICAgICAgIHRoaXMuX2RhdGFH cmlkLnNvcnRDb2x1bW5JZGVudGlmaWVyID0gIm5hbWUiOworICAgICAgICAgICAgdGhpcy5fZGF0 YUdyaWQuY3JlYXRlU2V0dGluZ3MoImNvb2tpZS1zdG9yYWdlLWNvbnRlbnQtdmlldyIpOwogCiAg ICAgICAgICAgICB0aGlzLmFkZFN1YnZpZXcodGhpcy5fZGF0YUdyaWQpOwogICAgICAgICAgICAg dGhpcy5fZGF0YUdyaWQudXBkYXRlTGF5b3V0KCk7CkBAIC0xMjYsMTQgKzEyOCwxNCBAQCBXSS5D b29raWVTdG9yYWdlQ29udGVudFZpZXcgPSBjbGFzcyBDb29raWVTdG9yYWdlQ29udGVudFZpZXcg ZXh0ZW5kcyBXSS5Db250ZW50VgogICAgICAgICBmb3IgKHZhciBjb29raWUgb2YgdGhpcy5fY29v a2llcykgewogICAgICAgICAgICAgY29uc3QgY2hlY2ttYXJrID0gIlx1MjcxMyI7CiAgICAgICAg ICAgICB2YXIgZGF0YSA9IHsKLSAgICAgICAgICAgICAgICAibmFtZSI6IGNvb2tpZS5uYW1lLAot ICAgICAgICAgICAgICAgICJ2YWx1ZSI6IGNvb2tpZS52YWx1ZSwKLSAgICAgICAgICAgICAgICAi ZG9tYWluIjogY29va2llLmRvbWFpbiB8fCAiIiwKLSAgICAgICAgICAgICAgICAicGF0aCI6IGNv b2tpZS5wYXRoIHx8ICIiLAotICAgICAgICAgICAgICAgICJleHBpcmVzIjogIiIsCi0gICAgICAg ICAgICAgICAgInNpemUiOiBOdW1iZXIuYnl0ZXNUb1N0cmluZyhjb29raWUuc2l6ZSksCi0gICAg ICAgICAgICAgICAgImh0dHAiOiBjb29raWUuaHR0cE9ubHkgPyBjaGVja21hcmsgOiAiIiwKLSAg ICAgICAgICAgICAgICAic2VjdXJlIjogY29va2llLnNlY3VyZSA/IGNoZWNrbWFyayA6ICIiLAor ICAgICAgICAgICAgICAgIG5hbWU6IGNvb2tpZS5uYW1lLAorICAgICAgICAgICAgICAgIHZhbHVl OiBjb29raWUudmFsdWUsCisgICAgICAgICAgICAgICAgZG9tYWluOiBjb29raWUuZG9tYWluIHx8 ICIiLAorICAgICAgICAgICAgICAgIHBhdGg6IGNvb2tpZS5wYXRoIHx8ICIiLAorICAgICAgICAg ICAgICAgIGV4cGlyZXM6ICIiLAorICAgICAgICAgICAgICAgIHNpemU6IE51bWJlci5ieXRlc1Rv U3RyaW5nKGNvb2tpZS5zaXplKSwKKyAgICAgICAgICAgICAgICBodHRwOiBjb29raWUuaHR0cE9u bHkgPyBjaGVja21hcmsgOiAiIiwKKyAgICAgICAgICAgICAgICBzZWN1cmU6IGNvb2tpZS5zZWN1 cmUgPyBjaGVja21hcmsgOiAiIiwKICAgICAgICAgICAgIH07CiAKICAgICAgICAgICAgIGlmIChj b29raWUudHlwZSAhPT0gV0kuQ29va2llVHlwZS5SZXF1ZXN0KQpAQCAtMTQ0LDkgKzE0Niw2IEBA IFdJLkNvb2tpZVN0b3JhZ2VDb250ZW50VmlldyA9IGNsYXNzIENvb2tpZVN0b3JhZ2VDb250ZW50 VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWCiAKICAgICAgICAgICAgIHRoaXMuX2RhdGFHcmlkLmFw cGVuZENoaWxkKG5vZGUpOwogICAgICAgICB9Ci0KLSAgICAgICAgdGhpcy5fZGF0YUdyaWQuc29y dENvbHVtbklkZW50aWZpZXIgPSAibmFtZSI7Ci0gICAgICAgIHRoaXMuX2RhdGFHcmlkLmNyZWF0 ZVNldHRpbmdzKCJjb29raWUtc3RvcmFnZS1jb250ZW50LXZpZXciKTsKICAgICB9CiAKICAgICBf ZmlsdGVyQ29va2llcyhjb29raWVzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwppbmRleCA2ZWI2YzcyY2Q1My4uYTAyYWVh MWJiYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC0xMjg0LDEwICsxMjg0LDE2IEBAIFdJLkRhdGFHcmlkID0g Y2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXSS5WaWV3CiAKICAgICBzb3J0Tm9kZXMoY29tcGFyYXRv cikKICAgICB7CisgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNob3VsZCB1c2UgdGhlIGxheW91dCBs b29wIGFuZCBub3QgaXRzIG93biByZXF1ZXN0QW5pbWF0aW9uRnJhbWUuCisgICAgICAgIHRoaXMu X3NvcnROb2Rlc0NvbXBhcmF0b3IgPSBjb21wYXJhdG9yOworCiAgICAgICAgIGlmICh0aGlzLl9z b3J0Tm9kZXNSZXF1ZXN0SWQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdGhpcy5f c29ydE5vZGVzUmVxdWVzdElkID0gd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZSh0aGlzLl9z b3J0Tm9kZXNDYWxsYmFjay5iaW5kKHRoaXMsIGNvbXBhcmF0b3IpKTsKKyAgICAgICAgdGhpcy5f c29ydE5vZGVzUmVxdWVzdElkID0gd2luZG93LnJlcXVlc3RBbmltYXRpb25GcmFtZSgoKSA9PiB7 CisgICAgICAgICAgICBpZiAodGhpcy5fc29ydE5vZGVzQ29tcGFyYXRvcikKKyAgICAgICAgICAg ICAgICB0aGlzLl9zb3J0Tm9kZXNDYWxsYmFjayh0aGlzLl9zb3J0Tm9kZXNDb21wYXJhdG9yKTsK KyAgICAgICAgfSk7CiAgICAgfQogCiAgICAgc29ydE5vZGVzSW1tZWRpYXRlbHkoY29tcGFyYXRv cikKQEAgLTEzMTIsNiArMTMxOCw3IEBAIFdJLkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0 ZW5kcyBXSS5WaWV3CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl9zb3J0Tm9kZXNSZXF1ZXN0 SWQgPSB1bmRlZmluZWQ7CisgICAgICAgIHRoaXMuX3NvcnROb2Rlc0NvbXBhcmF0b3IgPSBudWxs OwogCiAgICAgICAgIGlmICh0aGlzLl9lZGl0aW5nKSB7CiAgICAgICAgICAgICB0aGlzLl9zb3J0 QWZ0ZXJFZGl0aW5nQ2FsbGJhY2sgPSB0aGlzLnNvcnROb2Rlcy5iaW5kKHRoaXMsIGNvbXBhcmF0 b3IpOwo=