17685 2008-03-05 14:00:53 -0800 CSS3 Selector Test: attribute selector failing to match empty string 2008-03-23 14:09:46 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://disruptive-innovations.com/zoo/css3tests/selectorTest.html#target HasReduction P2 Normal --- 1 eric webkit webkit oldest_to_newest 72839 0 eric 2008-03-05 14:00:53 -0800 CSS3 Selector Test: attribute selector failing to match empty string .blox9[foo~=""] { background-color: red; } <div class="blox9 unitTest" foo="" title="[~=] attribute selector looking for empty string in empty attribute"></div> 72848 1 19559 webkit 2008-03-05 15:20:27 -0800 Created attachment 19559 test case 74872 2 19985 webkit 2008-03-23 13:14:07 -0700 Created attachment 19985 patch for the bug Patch with test case for layout tests attached. 74875 3 19985 eric 2008-03-23 13:29:56 -0700 Comment on attachment 19985 patch for the bug Looks good to me. I'll fix the comment when landing. // The selector's value can't contain a space, neither can be empty, or it's totally bogus. should be: // Empty selectors or selectors containing spaces are bogus. 74882 4 eric 2008-03-23 14:09:46 -0700 r31238 19559 2008-03-05 15:20:27 -0800 2008-03-05 15:20:27 -0800 test case test-case.html text/html 213 webkit PCFET0NUWVBFIGh0bWw+PHN0eWxlIHR5cGU9InRleHQvY3NzIj5kaXZbZm9vfj0iIl0geyBiYWNr Z3JvdW5kLWNvbG9yOiByZWQ7IH08L3N0eWxlPgo8ZGl2IGZvbz0iIj5bfj1dIGF0dHJpYnV0ZSBz ZWxlY3RvciBsb29raW5nIGZvciBlbXB0eSBzdHJpbmcgaW4gZW1wdHkgYXR0cmlidXRlICh0aGUg dGV4dCBzaG91bGQgbm90IGhhdmUgcmVkIGJhY2tncm91bmQpPC9kaXY+ 19985 2008-03-23 13:14:07 -0700 2008-03-23 13:29:56 -0700 patch for the bug selector-patch1.txt text/plain 3178 webkit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMTIzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMtMjMgIFJvYmVydCBCbGF1dCAgPHdlYmtpdEBibGF1dC5i aXo+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVn IDE3Njg1OiBbfj1dIGF0dHJpYnV0ZSBzZWxlY3RvciBmYWlsaW5nIHRvIG1hdGNoIGVtcHR5IHN0 cmluZworICAgICAgICA8aHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2 ODU+CisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvYXR0cmlidXRlLXNlbGVjdG9yLWVtcHR5LXZh bHVlLmh0bWwKKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmNoZWNrT25lU2VsZWN0b3IpOgorCiAyMDA4LTAz LTIyICBNYXJjbyBCYXJpc2lvbmUgIDxtYXJjby5iYXJpc2lvbmVAY29sbGFib3JhLmNvLnVrPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9jc3MvQ1NT U3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxl Y3Rvci5jcHAJKHJldmlzaW9uIDMxMjM2KQorKysgV2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rv ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0NjQsOCArMTQ2NCw4IEBAIGJvb2wgQ1NTU3R5bGVT ZWxlY3Rvcjo6Y2hlY2tPbmVTZWxlY3RvcigKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBj YXNlIENTU1NlbGVjdG9yOjpMaXN0OgogICAgICAgICB7Ci0gICAgICAgICAgICAvLyBUaGUgc2Vs ZWN0b3IncyB2YWx1ZSBjYW4ndCBjb250YWluIGEgc3BhY2UsIG9yIGl0J3MgdG90YWxseSBib2d1 cy4KLSAgICAgICAgICAgIGlmIChzZWwtPm1fdmFsdWUuY29udGFpbnMoJyAnKSkKKyAgICAgICAg ICAgIC8vIFRoZSBzZWxlY3RvcidzIHZhbHVlIGNhbid0IGNvbnRhaW4gYSBzcGFjZSwgbmVpdGhl ciBjYW4gYmUgZW1wdHksIG9yIGl0J3MgdG90YWxseSBib2d1cy4KKyAgICAgICAgICAgIGlmIChz ZWwtPm1fdmFsdWUuY29udGFpbnMoJyAnKSB8fCBzZWwtPm1fdmFsdWUuaXNFbXB0eSgpKQogICAg ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgICAgICAgICAgaW50IHN0YXJ0U2VhcmNo QXQgPSAwOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMzEyMzYpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMSBAQAorMjAwOC0wMy0yMyAgUm9iZXJ0IEJs YXV0ICA8d2Via2l0QGJsYXV0LmJpej4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0IHRvIGVuc3VyZSBbfj1dIGF0dHJpYnV0ZSBzZWxlY3RvciBk b2Vzbid0IG1hdGNoIGVtcHR5IHN0cmluZworCisgICAgICAgICogZmFzdC9jc3MvYXR0cmlidXRl LXNlbGVjdG9yLWVtcHR5LXZhbHVlLmh0bWw6IEFkZGVkLgorCiAyMDA4LTAzLTIzICBPbGl2ZXIg SHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqLgpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9jc3MvYXR0cmlidXRlLXNlbGVjdG9yLWVtcHR5LXZhbHVl Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jc3MvYXR0cmlidXRlLXNlbGVj dG9yLWVtcHR5LXZhbHVlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nz cy9hdHRyaWJ1dGUtc2VsZWN0b3ItZW1wdHktdmFsdWUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSwyIEBACis8IURPQ1RZUEUgaHRtbD48c3R5bGUgdHlwZT0idGV4dC9jc3MiPmRpdltmb29+ PSIiXSB7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgfTwvc3R5bGU+Cis8ZGl2IGZvbz0iIj5bfj1d IGF0dHJpYnV0ZSBzZWxlY3RvciBsb29raW5nIGZvciBlbXB0eSBzdHJpbmcgaW4gZW1wdHkgYXR0 cmlidXRlICh0aGUgdGV4dCBzaG91bGQgbm90IGhhdmUgcmVkIGJhY2tncm91bmQpPC9kaXY+Cklu ZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9jc3MvYXR0cmlidXRlLXNlbGVjdG9y LWVtcHR5LXZhbHVlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZmFzdC9jc3MvYXR0cmlidXRlLXNlbGVjdG9yLWVtcHR5LXZhbHVlLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2Nzcy9h dHRyaWJ1dGUtc2VsZWN0b3ItZW1wdHktdmFsdWUtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDggQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3 IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MzQKKyAgUmVu ZGVyQmxvY2sge0hUTUx9IGF0ICgwLDApIHNpemUgODAweDM0CisgICAgUmVuZGVyQm9keSB7Qk9E WX0gYXQgKDgsOCkgc2l6ZSA3ODR4MTgKKyAgICAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgwLDAp IHNpemUgNzg0eDE4CisgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDY3 MngxOAorICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDY3MjogIlt+PV0gYXR0cmli dXRlIHNlbGVjdG9yIGxvb2tpbmcgZm9yIGVtcHR5IHN0cmluZyBpbiBlbXB0eSBhdHRyaWJ1dGUg KHRoZSB0ZXh0IHNob3VsZCBub3QgaGF2ZSByZWQgYmFja2dyb3VuZCkiCg==