176826 2017-09-13 01:03:47 -0700 [JSC] Fix Array allocation in Object.keys 2022-09-07 08:27:57 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue fpizlo keith_miller mark.lam msaboff saam thisiskatewinslet webkit-bug-importer oldest_to_newest 1348228 0 ysuzuki 2017-09-13 01:03:47 -0700 [JSC] Fix Array allocation in Object.keys 1348231 1 320624 ysuzuki 2017-09-13 01:05:42 -0700 Created attachment 320624 Patch 1348291 2 320624 ysuzuki 2017-09-13 08:19:03 -0700 Comment on attachment 320624 Patch Thanks! 1348296 3 320624 commit-queue 2017-09-13 08:48:23 -0700 Comment on attachment 320624 Patch Clearing flags on attachment: 320624 Committed r221970: <http://trac.webkit.org/changeset/221970> 1348297 4 commit-queue 2017-09-13 08:48:25 -0700 All reviewed patches have been landed. Closing bug. 1353527 5 webkit-bug-importer 2017-09-27 12:36:55 -0700 <rdar://problem/34693605> 320624 2017-09-13 01:05:42 -0700 2017-09-13 08:48:23 -0700 Patch bug-176826-20170913170541.patch text/plain 4910 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxOTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy YmIxMTY0NmQwYmQ2ZWQzODliMTRjYjQ1NzAyNDBkOGViMzcxMDEzLi5lMmZhMWViZTUzZDJiYWVm MDZmNTAzMTJmNTVmYTQ2ODA5NDEyM2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wOS0xMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBGaXggQXJyYXkgYWxsb2NhdGlvbiBpbiBPYmplY3Qua2V5 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2ODI2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBp c0hhdmluZ0FCYWRUaW1lKCkgaXMgdHJ1ZSwgYXJyYXkgYWxsb2NhdGlvbiBkb2VzIG5vdCBiZWNv bWUgQXJyYXlXaXRoQ29udGlndW91cy4KKyAgICAgICAgV2UgY2hlY2sgaXNIYXZpbmdBQmFkVGlt ZSgpIGluIG93blByb3BlcnR5S2V5cyBmYXN0IHBhdGguCisgICAgICAgIEFuZCB3ZSBhbHNvIGVu c3VyZXMgdGhhdCBvd25Qcm9wZXJ0eUtleXMgdXNlcyBwdXREaXJlY3Qgb3BlcmF0aW9uIGluc3Rl YWQgb2YgcHV0IGJ5IGEgdGVzdC4KKworICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0 b3IuY3BwOgorICAgICAgICAoSlNDOjpvd25Qcm9wZXJ0eUtleXMpOgorCiAyMDE3LTA5LTEyICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkddIE9w dGltaXplIFdlYWtNYXA6OmdldCBieSBhZGRpbmcgaW50cmluc2ljIGFuZCBmaXh1cApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwCmlu ZGV4IDlkMDdjNTg3NzFhOTNjNGVlOTBiNmVmM2M4OWVmMTM1NjgxNWFmMjQuLjdiMGQ3MGQ0Mjkw Y2YyOTBiODg4MDdkZDFjYTE1NjQ4MzQyYWIwYTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rvci5jcHAKQEAgLTg1NSwxNSArODU1LDE4 IEBAIEpTQXJyYXkqIG93blByb3BlcnR5S2V5cyhFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBv YmplY3QsIFByb3BlcnR5TmFtZU1vZGUgcHJvCiAgICAgLy8gSWYgIW11c3RGaWx0ZXJQcm9wZXJ0 eSBhbmQgUHJvcGVydHlOYW1lTW9kZTo6U3RyaW5ncyBtb2RlLCB3ZSBkbyBub3QgbmVlZCB0byBm aWx0ZXIgb3V0IGFueSBlbnRyaWVzIGluIFByb3BlcnR5TmFtZUFycmF5LgogICAgIC8vIFdlIGNh biB1c2UgZmFzdCBhbGxvY2F0aW9uIGFuZCBpbml0aWFsaXphdGlvbi4KICAgICBpZiAoIW11c3RG aWx0ZXJQcm9wZXJ0eSAmJiBwcm9wZXJ0eU5hbWVNb2RlID09IFByb3BlcnR5TmFtZU1vZGU6OlN0 cmluZ3MgJiYgcHJvcGVydGllcy5zaXplKCkgPCBNSU5fU1BBUlNFX0FSUkFZX0lOREVYKSB7Ci0g ICAgICAgIHNpemVfdCBudW1Qcm9wZXJ0aWVzID0gcHJvcGVydGllcy5zaXplKCk7Ci0gICAgICAg IEpTQXJyYXkqIGtleXMgPSBKU0FycmF5OjpjcmVhdGUodm0sIGV4ZWMtPmxleGljYWxHbG9iYWxP YmplY3QoKS0+YXJyYXlTdHJ1Y3R1cmVGb3JJbmRleGluZ1R5cGVEdXJpbmdBbGxvY2F0aW9uKEFy cmF5V2l0aENvbnRpZ3VvdXMpLCBudW1Qcm9wZXJ0aWVzKTsKLSAgICAgICAgV3JpdGVCYXJyaWVy PFVua25vd24+KiBidWZmZXIgPSBrZXlzLT5idXR0ZXJmbHkoKS0+Y29udGlndW91cygpLmRhdGEo KTsKLSAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1Qcm9wZXJ0aWVzOyBpKyspIHsK LSAgICAgICAgICAgIGNvbnN0IGF1dG8mIGlkZW50aWZpZXIgPSBwcm9wZXJ0aWVzW2ldOwotICAg ICAgICAgICAgQVNTRVJUKCFpZGVudGlmaWVyLmlzU3ltYm9sKCkpOwotICAgICAgICAgICAgYnVm ZmVyW2ldLnNldCh2bSwga2V5cywganNPd25lZFN0cmluZygmdm0sIGlkZW50aWZpZXIuc3RyaW5n KCkpKTsKKyAgICAgICAgYXV0byogZ2xvYmFsT2JqZWN0ID0gZXhlYy0+bGV4aWNhbEdsb2JhbE9i amVjdCgpOworICAgICAgICBpZiAoTElLRUxZKCFnbG9iYWxPYmplY3QtPmlzSGF2aW5nQUJhZFRp bWUoKSkpIHsKKyAgICAgICAgICAgIHNpemVfdCBudW1Qcm9wZXJ0aWVzID0gcHJvcGVydGllcy5z aXplKCk7CisgICAgICAgICAgICBKU0FycmF5KiBrZXlzID0gSlNBcnJheTo6Y3JlYXRlKHZtLCBn bG9iYWxPYmplY3QtPmFycmF5U3RydWN0dXJlRm9ySW5kZXhpbmdUeXBlRHVyaW5nQWxsb2NhdGlv bihBcnJheVdpdGhDb250aWd1b3VzKSwgbnVtUHJvcGVydGllcyk7CisgICAgICAgICAgICBXcml0 ZUJhcnJpZXI8VW5rbm93bj4qIGJ1ZmZlciA9IGtleXMtPmJ1dHRlcmZseSgpLT5jb250aWd1b3Vz KCkuZGF0YSgpOworICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1Qcm9wZXJ0 aWVzOyBpKyspIHsKKyAgICAgICAgICAgICAgICBjb25zdCBhdXRvJiBpZGVudGlmaWVyID0gcHJv cGVydGllc1tpXTsKKyAgICAgICAgICAgICAgICBBU1NFUlQoIWlkZW50aWZpZXIuaXNTeW1ib2wo KSk7CisgICAgICAgICAgICAgICAgYnVmZmVyW2ldLnNldCh2bSwga2V5cywganNPd25lZFN0cmlu Zygmdm0sIGlkZW50aWZpZXIuc3RyaW5nKCkpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAg IHJldHVybiBrZXlzOwogICAgICAgICB9Ci0gICAgICAgIHJldHVybiBrZXlzOwogICAgIH0KIAog ICAgIEpTQXJyYXkqIGtleXMgPSBjb25zdHJ1Y3RFbXB0eUFycmF5KGV4ZWMsIG51bGxwdHIpOwpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBh NjkxMjUxZDhhN2Y1MjcxNTcyYzczZTMyZTQyNTZjZGNlZjVhNGE0Li5kYjE3ZjU4ODE5MTFjMjgz MmRkNjBjMDBjMTgyNmI0NWI5MWEwOWUxIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZwor KysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTEzICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFtKU0NdIEZpeCBB cnJheSBhbGxvY2F0aW9uIGluIE9iamVjdC5rZXlzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY4MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9vYmplY3Qtb3duLXByb3BlcnR5LWtleXMu anM6IEFkZGVkLgorICAgICAgICAoc2hvdWxkQmUpOgorCiAyMDE3LTA5LTEyICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkddIE9wdGltaXplIFdl YWtNYXA6OmdldCBieSBhZGRpbmcgaW50cmluc2ljIGFuZCBmaXh1cApkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9zdHJlc3Mvb2JqZWN0LW93bi1wcm9wZXJ0eS1rZXlzLmpzIGIvSlNUZXN0cy9zdHJlc3Mv b2JqZWN0LW93bi1wcm9wZXJ0eS1rZXlzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBkMzY0MjY4NDI1MGViYjBh ODg4MDViMjBiZDY1MTY3N2VkMzU2YTgKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVz cy9vYmplY3Qtb3duLXByb3BlcnR5LWtleXMuanMKQEAgLTAsMCArMSw0NSBAQAorZnVuY3Rpb24g c2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVk KQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFjdHVhbCk7Cit9CisK K09iamVjdC5kZWZpbmVQcm9wZXJ0eShBcnJheS5wcm90b3R5cGUsICcwJywgeworICAgIGdldCgp IHsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCdvdXQnKTsKKyAgICB9LAorICAgIHNldCh2YWx1 ZSkgeworICAgICAgICB0aHJvdyBuZXcgRXJyb3IoJ291dCcpOworICAgIH0KK30pOworCit7Cisg ICAgbGV0IG9iamVjdCA9IHsKKyAgICAgICAgYTogNDIsCisgICAgICAgIGI6IDQyLAorICAgICAg ICBjOiA0MgorICAgIH07CisgICAgeworICAgICAgICBsZXQgcmVzdWx0ID0gT2JqZWN0LmtleXMo b2JqZWN0KTsKKyAgICAgICAgc2hvdWxkQmUoSlNPTi5zdHJpbmdpZnkocmVzdWx0KSwgYFsiYSIs ImIiLCJjIl1gKTsKKyAgICB9CisgICAgeworICAgICAgICBsZXQgcmVzdWx0ID0gT2JqZWN0LnZh bHVlcyhvYmplY3QpOworICAgICAgICBzaG91bGRCZShKU09OLnN0cmluZ2lmeShyZXN1bHQpLCBg WzQyLDQyLDQyXWApOworICAgIH0KK30KK3sKKyAgICBsZXQgb2JqZWN0ID0geworICAgICAgICBb U3ltYm9sLml0ZXJhdG9yXTogNDIsCisgICAgICAgIGI6IDQyLAorICAgICAgICBjOiA0MgorICAg IH07CisgICAgeworICAgICAgICBsZXQgcmVzdWx0ID0gT2JqZWN0LmdldE93blByb3BlcnR5TmFt ZXMob2JqZWN0KTsKKyAgICAgICAgc2hvdWxkQmUoSlNPTi5zdHJpbmdpZnkocmVzdWx0KSwgYFsi YiIsImMiXWApOworICAgIH0KKyAgICB7CisgICAgICAgIGxldCByZXN1bHQgPSBPYmplY3QuZ2V0 T3duUHJvcGVydHlTeW1ib2xzKG9iamVjdCk7CisgICAgICAgIHNob3VsZEJlKHJlc3VsdC5sZW5n dGgsIDEpOworICAgICAgICBzaG91bGRCZShyZXN1bHRbMF0sIFN5bWJvbC5pdGVyYXRvcik7Cisg ICAgfQorfQo=