176820 2017-09-12 17:53:34 -0700 [WPE] Test fast/dom/Document/CaretRangeFromPoint/replace-element.html fails since r221909 2022-09-07 08:27:50 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 156579 1 clopez Ms2ger bugs-noreply commit-queue Ms2ger thisiskatewinslet oldest_to_newest 1348134 0 clopez 2017-09-12 17:53:34 -0700 The diff is the following: --- /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt +++ /home/clopez/webkit/wpe/layout-test-results/fast/dom/Document/CaretRangeFromPoint/replace-element-actual.txt @@ -1,6 +1,6 @@ Testing left of the image PASS: range.startContainer == image.previousSibling. -PASS: range.startOffset == 34. +FAIL: range.startOffset == 35. Testing right of the image PASS: range.startContainer == image.nextSibling. PASS: range.startOffset == 1. Not sure if this needs a rebaseline (with the FAIL string, ugly), the test needs to be reworked to be less sensive to the offset or it indicates a real failure caused by r221909. 1374393 1 327495 Ms2ger 2017-11-23 04:36:17 -0800 Created attachment 327495 Patch 1374395 2 327495 commit-queue 2017-11-23 05:09:30 -0800 Comment on attachment 327495 Patch Clearing flags on attachment: 327495 Committed r225114: <https://trac.webkit.org/changeset/225114> 1374396 3 commit-queue 2017-11-23 05:09:31 -0800 All reviewed patches have been landed. Closing bug. 327495 2017-11-23 04:36:17 -0800 2017-11-23 05:09:30 -0800 Patch bug-176820-20171123133616.patch text/plain 1518 Ms2ger U3VidmVyc2lvbiBSZXZpc2lvbjogMjI1MTEzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGRmZTYzYzJjMjViNzU2ZDM2MThm MTRkODU0ZDk3MTQzNmNmYjA0Yi4uODkwOGZkYWJhY2IwNWQ4MjFkMmFkMWZkODVlZTU5ZDIzODM0 ZmE2OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTExLTIzICBNczJnZXIgIDxNczJnZXJA aWdhbGlhLmNvbT4KIAorICAgICAgICBbV1BFXSBSZS1lbmFibGUgZmFzdC9kb20vRG9jdW1lbnQv Q2FyZXRSYW5nZUZyb21Qb2ludC9yZXBsYWNlLWVsZW1lbnQuaHRtbC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjgyMAorCisgICAgICAgIFVucmV2 aWV3ZWQgdGVzdCBnYXJkZW5pbmcuCisKKyAgICAgICAgVGhlIHRlc3Qgc3RhcnRlZCBwYXNzaW5n IGFnYWluIGluIHIyMjE5NzQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0 aW9uczoKKworMjAxNy0xMS0yMyAgTXMyZ2VyICA8TXMyZ2VyQGlnYWxpYS5jb20+CisKICAgICAg ICAgW1dQRV0gRW5hYmxlIHNvbWUgbW9yZSB3cHQgdGVzdHMuCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzk5MzkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS93cGUvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBjOGMyZDA2ZGM4YzI2NDE0NTc5ZmUwMjI5NWE4 MDdjYWU0MTYzMzU3Li41NGYxZjBmNDZhYTA5OGYyNTEwNDQ1NDg1ZTcyMGRiMjdhMzhkYjc1IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93cGUvVGVzdEV4cGVjdGF0aW9ucwpAQCAtOTA3LDggKzkw Nyw2IEBAIHdlYmtpdC5vcmcvYi8xNzcyMjYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0 cy9XZWJDcnlwdG9BUEkvd3JhcEtleV91bndyYXBLCiAjIEFwcGFyZW50bHkgZmFpbHMgb24gTWFj LCBidXQgSSBkb24ndCBrbm93IGZvciB3aGF0IHJlYXNvbnMuIEl0IHBhc3NlcyBvbiBHVEsvV1BF Lgogd2Via2l0Lm9yZy9iLzEzODY3NiBpbXBvcnRlZC93M2MvY2FudmFzLzJkLmxpbmUuY2FwLnJv dW5kLmh0bWwgWyBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzE3NjgyMCBmYXN0L2RvbS9Eb2N1bWVu dC9DYXJldFJhbmdlRnJvbVBvaW50L3JlcGxhY2UtZWxlbWVudC5odG1sIFsgRmFpbHVyZSBdCi0K ICMgQWNjZXNzaWJpbGl0eSBzdXBwb3J0IGlzbid0IGdsdWVkIHRvIGFueSBBUEkgeWV0LgogQnVn KFdQRSkgYWNjZXNzaWJpbGl0eS8gWyBTa2lwIF0KIEJ1ZyhXUEUpIHBlcmYvYWNjZXNzaWJpbGl0 eS10aXRsZS11aS1lbGVtZW50Lmh0bWwgWyBGYWlsdXJlIF0K