176764 2017-09-11 21:01:25 -0700 Web Inspector: Escape in global search field should clear it 2017-09-27 12:39:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1347784 0 joepeck 2017-09-11 21:01:25 -0700 Escape in global search field should clear it Steps to reproduce: 1. Focus global search 2. Input some text 3. Press Escape => Expected search field to clear, but nothing happened 1347785 1 320512 joepeck 2017-09-11 21:02:42 -0700 Created attachment 320512 [PATCH] Proposed Fix 1348458 2 320512 commit-queue 2017-09-13 13:24:59 -0700 Comment on attachment 320512 [PATCH] Proposed Fix Clearing flags on attachment: 320512 Committed r221990: <http://trac.webkit.org/changeset/221990> 1348459 3 commit-queue 2017-09-13 13:25:00 -0700 All reviewed patches have been landed. Closing bug. 1353567 4 webkit-bug-importer 2017-09-27 12:39:02 -0700 <rdar://problem/34693684> 320512 2017-09-11 21:02:42 -0700 2017-09-13 13:24:59 -0700 [PATCH] Proposed Fix escape-1.patch text/plain 3066 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcxNjQ5NjcyZTlmLi4zZTg2OWRjY2ViMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTctMDktMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBFc2NhcGUgaW4gZ2xvYmFsIHNlYXJjaCBmaWVsZCBzaG91bGQgY2xlYXIgaXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Njc2NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9W aWV3cy9RdWlja0NvbnNvbGUuanM6CisgICAgICAgIChXSS5RdWlja0NvbnNvbGUucHJvdG90eXBl Ll90b2dnbGVPckZvY3VzKToKKyAgICAgICAgRG9uJ3QgaW1wbGljaXRseSBwcmV2ZW50IGRlZmF1 bHQuIFNvIGlmIHdlIGRpZG4ndCBjYXVzZSBhbiBhY3Rpb24gd2UKKyAgICAgICAgY2FuIGxldCB0 aGUgZGVmYXVsdCBzeXN0ZW0gYWN0aW9uIGhhcHBlbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvU2VhcmNoQmFyLmpzOgorICAgICAgICAoV0kuU2VhcmNoQmFyKToKKyAgICAgICAg UmVtb3ZlIHVudXNlZCBrZXlib2FyZCBzaG9ydGN1dHMuCisKKzIwMTctMDktMTEgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBN YWtlIERhc2hib2FyZCBUaW1lbGluZSBpY29uIGFuZCBUaW1lbGluZSB0YWIgaWNvbiBtb3JlIHNp bWlsYXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjU4MgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9RdWlja0NvbnNvbGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9RdWlja0NvbnNvbGUuanMKaW5kZXggOGQ1ZDYyODYxODMuLmNmMWJmNzIxNWEwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9RdWlj a0NvbnNvbGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvUXVpY2tDb25zb2xlLmpzCkBAIC0zMCw2ICszMCw3IEBAIFdJLlF1aWNrQ29uc29sZSA9IGNs YXNzIFF1aWNrQ29uc29sZSBleHRlbmRzIFdJLlZpZXcKICAgICAgICAgc3VwZXIoZWxlbWVudCk7 CiAKICAgICAgICAgdGhpcy5fdG9nZ2xlT3JGb2N1c0tleWJvYXJkU2hvcnRjdXQgPSBuZXcgV0ku S2V5Ym9hcmRTaG9ydGN1dChudWxsLCBXSS5LZXlib2FyZFNob3J0Y3V0LktleS5Fc2NhcGUsIHRo aXMuX3RvZ2dsZU9yRm9jdXMuYmluZCh0aGlzKSk7CisgICAgICAgIHRoaXMuX3RvZ2dsZU9yRm9j dXNLZXlib2FyZFNob3J0Y3V0LmltcGxpY2l0bHlQcmV2ZW50c0RlZmF1bHQgPSBmYWxzZTsKIAog ICAgICAgICB0aGlzLl9tYWluRXhlY3V0aW9uQ29udGV4dFBhdGhDb21wb25lbnQgPSB0aGlzLl9j cmVhdGVFeGVjdXRpb25Db250ZXh0UGF0aENvbXBvbmVudChXSS5tYWluVGFyZ2V0LmV4ZWN1dGlv bkNvbnRleHQpOwogCkBAIC0zMzAsMTAgKzMzMSwxMyBAQCBXSS5RdWlja0NvbnNvbGUgPSBjbGFz cyBRdWlja0NvbnNvbGUgZXh0ZW5kcyBXSS5WaWV3CiAKICAgICBfdG9nZ2xlT3JGb2N1cyhldmVu dCkKICAgICB7Ci0gICAgICAgIGlmICh0aGlzLnByb21wdC5mb2N1c2VkKQorICAgICAgICBpZiAo dGhpcy5wcm9tcHQuZm9jdXNlZCkgewogICAgICAgICAgICAgV0kudG9nZ2xlU3BsaXRDb25zb2xl KCk7Ci0gICAgICAgIGVsc2UgaWYgKCFXSS5pc0VkaXRpbmdBbnlGaWVsZCgpICYmICFXSS5pc0V2 ZW50VGFyZ2V0QW5FZGl0YWJsZUZpZWxkKGV2ZW50KSkKKyAgICAgICAgICAgIGV2ZW50LnByZXZl bnREZWZhdWx0KCk7CisgICAgICAgIH0gZWxzZSBpZiAoIVdJLmlzRWRpdGluZ0FueUZpZWxkKCkg JiYgIVdJLmlzRXZlbnRUYXJnZXRBbkVkaXRhYmxlRmllbGQoZXZlbnQpKSB7CiAgICAgICAgICAg ICB0aGlzLnByb21wdC5mb2N1cygpOworICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQo KTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIF91cGRhdGVTdHlsZXMoKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzCmlu ZGV4IGI0OGI5NjY1NTkyLi4xYjE4Y2QzZmQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaEJhci5qcwpAQCAtMzEsOSArMzEs NiBAQCBXSS5TZWFyY2hCYXIgPSBjbGFzcyBTZWFyY2hCYXIgZXh0ZW5kcyBXSS5OYXZpZ2F0aW9u SXRlbQogCiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgic2VhcmNoLWJhciIp OwogCi0gICAgICAgIHRoaXMuX2tleWJvYXJkU2hvcnRjdXRFc2MgPSBuZXcgV0kuS2V5Ym9hcmRT aG9ydGN1dChudWxsLCBXSS5LZXlib2FyZFNob3J0Y3V0LktleS5Fc2NhcGUpOwotICAgICAgICB0 aGlzLl9rZXlib2FyZFNob3J0Y3V0RW50ZXIgPSBuZXcgV0kuS2V5Ym9hcmRTaG9ydGN1dChudWxs LCBXSS5LZXlib2FyZFNob3J0Y3V0LktleS5FbnRlcik7Ci0KICAgICAgICAgdGhpcy5fc2VhcmNo SW5wdXQgPSB0aGlzLl9lbGVtZW50LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImlucHV0IikpOwogICAgICAgICB0aGlzLl9zZWFyY2hJbnB1dC50eXBlID0gInNlYXJjaCI7CiAg ICAgICAgIHRoaXMuX3NlYXJjaElucHV0LnNwZWxsY2hlY2sgPSBmYWxzZTsK