176755 2017-09-11 16:56:40 -0700 [WPE][GTK] Run tests with G_DEBUG=fatal-criticals 2018-03-05 06:49:19 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=183330 P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply buildbot cgarcia commit-queue glenn mcatanzaro oldest_to_newest 1347737 0 mcatanzaro 2017-09-11 16:56:40 -0700 Our bots are too green. Make more tests fail by running with G_DEBUG=fatal-warnings. This is expected to break two GTK+ API tests and <50 layout tests (but only due to a couple different bugs that affect many tests). I'm investigating the API tests now. It's too hard to update layout test expectations before the patch lands, so I'll handle that after landing. This will be particularly useful for layout tests as right now we have some criticals that are hard to file bug reports for without accompanying backtraces. I really want to use fatal-warnings, but if this gets rejected, we should *definitely* use fatal-criticals. 1347739 1 mcatanzaro 2017-09-11 17:04:05 -0700 Actually I think we can't be this strict for API tests, looks like they're testing stuff that actually needs to emit warnings. E.g.: // There can't be more than one context with automation enabled GRefPtr<WebKitWebContext> otherContext = adoptGRef(webkit_web_context_new()); test->removeLogFatalFlag(G_LOG_LEVEL_WARNING); webkit_web_context_set_automation_allowed(otherContext.get(), TRUE); test->addLogFatalFlag(G_LOG_LEVEL_WARNING); g_assert(!webkit_web_context_is_automation_allowed(otherContext.get())); But API tests should still always crash on criticals. No exceptions to that. Let's use fatal-criticals for layout tests to be consistent. I'm not aware of any warnings being printed in layout tests, and the important part of this change is to get backtraces to criticals. 1347741 2 320507 mcatanzaro 2017-09-11 17:07:02 -0700 Created attachment 320507 Patch 1347818 3 320507 cgarcia 2017-09-11 23:07:48 -0700 Comment on attachment 320507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320507&action=review > Tools/Scripts/run-gtk-tests:220 > + self._test_env["G_DEBUG"] = "fatal-criticals" This is not needed, glib tests are already run with both warnings and criticals fatal, that's why we need to change the flags in some test when we want to actually check the warnings. This is done by g_test_init using g_log_set_always_fatal(). 1347892 4 320546 mcatanzaro 2017-09-12 07:32:01 -0700 Created attachment 320546 Patch 1347905 5 320546 cgarcia 2017-09-12 08:25:41 -0700 Comment on attachment 320546 Patch Ok, let's try 1347948 6 320546 commit-queue 2017-09-12 09:59:27 -0700 Comment on attachment 320546 Patch Clearing flags on attachment: 320546 Committed r221925: <http://trac.webkit.org/changeset/221925> 1347949 7 commit-queue 2017-09-12 09:59:29 -0700 All reviewed patches have been landed. Closing bug. 1348023 8 mcatanzaro 2017-09-12 13:44:39 -0700 Committed r221938: <http://trac.webkit.org/changeset/221938> 320507 2017-09-11 17:07:02 -0700 2017-09-12 07:31:59 -0700 Patch bug-176755-20170911190701.patch text/plain 3871 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxODcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzVhZmE5ZTY5OTUzZTI1ZGY5YzgxZGZmM2FhODE4NzU4 ODVhOWQyMi4uNjNmYzZjMzFjZjA3OWE4N2Q2Y2M0YmZkZmEyN2FhMmI0MDRhODFmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDE3LTA5LTExICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXVtHVEtdIFJ1biB0ZXN0cyB3aXRoIEdfREVCVUc9ZmF0YWwtY3Jp dGljYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzY3NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvcnVuLWd0ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIuX3NldHVwX3Rlc3Rp bmdfZW52aXJvbm1lbnQpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHk6 CisgICAgICAgIChHdGtQb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcik6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5weToKKyAgICAgICAgKFdQRVBvcnQuc2V0dXBfZW52 aXJvbl9mb3Jfc2VydmVyKToKKwogMjAxNy0wOS0xMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hz aWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TIERuRF0gRWxlbWVudHMgaW4gdGhlIERPTSB3 aXRoIHRoZSBgZHJhZ2dhYmxlYCBhdHRyaWJ1dGUgc2hvdWxkIGJlIGRyYWdnYWJsZQpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tZ3Rr LXRlc3RzCmluZGV4IDZjYTM4ZWZmMzE0NWYyOTE2Njg0NGY2NGZjMTNhNjljMmQ4MzExZDEuLmVj YmRkMzhiMWUwMzk3MWZjN2YzNjVlOTBhZjMzZDIxZDA3MWNkM2UgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMK QEAgLTIxNyw2ICsyMTcsNyBAQCBjbGFzcyBUZXN0UnVubmVyOgogCiAgICAgZGVmIF9zZXR1cF90 ZXN0aW5nX2Vudmlyb25tZW50KHNlbGYpOgogICAgICAgICBzZWxmLl90ZXN0X2VudiA9IHNlbGYu X2RyaXZlci5fc2V0dXBfZW52aXJvbl9mb3JfdGVzdCgpCisgICAgICAgIHNlbGYuX3Rlc3RfZW52 WyJHX0RFQlVHIl0gPSAiZmF0YWwtY3JpdGljYWxzIgogICAgICAgICBzZWxmLl90ZXN0X2Vudlsi VEVTVF9XRUJLSVRfQVBJX1dFQktJVDJfUkVTT1VSQ0VTX1BBVEgiXSA9IGNvbW1vbi50b3BfbGV2 ZWxfcGF0aCgiVG9vbHMiLCAiVGVzdFdlYktpdEFQSSIsICJUZXN0cyIsICJXZWJLaXQiKQogICAg ICAgICBzZWxmLl90ZXN0X2VudlsiVEVTVF9XRUJLSVRfQVBJX1dFQktJVDJfSU5KRUNURURfQlVO RExFX1BBVEgiXSA9IGNvbW1vbi5saWJyYXJ5X2J1aWxkX3BhdGgoKQogICAgICAgICBzZWxmLl90 ZXN0X2VudlsiV0VCS0lUX0VYRUNfUEFUSCJdID0gc2VsZi5fcHJvZ3JhbXNfcGF0aApkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC9ndGsucHkKaW5kZXggMjZiOTM3MjVmMTNlMDNhYjIxYzYxYmFmOTZmNTU4 MWM4OTk3ZDc5NC4uMzcxZTIzYWJhMTJiNTQ4ZTc4NjViYTQyNDIzYjlmNzU4ZTNiYWZiOCAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CkBAIC0xMTYsNiArMTE2LDcgQEAgY2xhc3MgR3Rr UG9ydChQb3J0KToKIAogICAgIGRlZiBzZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2ZXIoc2VsZiwgc2Vy dmVyX25hbWU9Tm9uZSk6CiAgICAgICAgIGVudmlyb25tZW50ID0gc3VwZXIoR3RrUG9ydCwgc2Vs Zikuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlcnZlcl9uYW1lKQorICAgICAgICBlbnZpcm9u bWVudFsnR19ERUJVRyddID0gJ2ZhdGFsLWNyaXRpY2FscycKICAgICAgICAgZW52aXJvbm1lbnRb J0dTRVRUSU5HU19CQUNLRU5EJ10gPSAnbWVtb3J5JwogICAgICAgICBlbnZpcm9ubWVudFsnTElC T1ZFUkxBWV9TQ1JPTExCQVInXSA9ICcwJwogICAgICAgICBlbnZpcm9ubWVudFsnVEVTVF9SVU5O RVJfSU5KRUNURURfQlVORExFX0ZJTEVOQU1FJ10gPSBzZWxmLl9idWlsZF9wYXRoKCdsaWInLCAn bGliVGVzdFJ1bm5lckluamVjdGVkQnVuZGxlLnNvJykKQEAgLTEzOCw5ICsxMzksOSBAQCBjbGFz cyBHdGtQb3J0KFBvcnQpOgogICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAgICAgICAg X2xvZy53YXJuaW5nKCJDYW4ndCBmaW5kIEdhbGxpdW0gbGx2bXBpcGUgZHJpdmVyLiBUcnkgdG8g cnVuIHVwZGF0ZS13ZWJraXRndGstbGlicyIpCiAgICAgICAgIGlmIHNlbGYuZ2V0X29wdGlvbigi bGVha3MiKToKLSAgICAgICAgICAgICMgIFR1cm4gb2ZmIEdMaWIgbWVtb3J5IG9wdGltaXNhdGlv bnMgaHR0cHM6Ly93aWtpLmdub21lLm9yZy9WYWxncmluZC4KKyAgICAgICAgICAgICMgVHVybiBv ZmYgR0xpYiBtZW1vcnkgb3B0aW1pc2F0aW9ucyBodHRwczovL3dpa2kuZ25vbWUub3JnL1ZhbGdy aW5kLgogICAgICAgICAgICAgZW52aXJvbm1lbnRbJ0dfU0xJQ0UnXSA9ICdhbHdheXMtbWFsbG9j JwotICAgICAgICAgICAgZW52aXJvbm1lbnRbJ0dfREVCVUcnXSA9ICdnYy1mcmllbmRseScKKyAg ICAgICAgICAgIGVudmlyb25tZW50WydHX0RFQlVHJ10gKz0gJyxnYy1mcmllbmRseScKICAgICAg ICAgICAgIHhtbGZpbGVuYW1lID0gIiIuam9pbigoImRydC0lcC0iLCB1dWlkLnV1aWQxKCkuaGV4 LCAiLWxlYWtzLnhtbCIpKQogICAgICAgICAgICAgeG1sZmlsZSA9IG9zLnBhdGguam9pbihzZWxm LnJlc3VsdHNfZGlyZWN0b3J5KCksIHhtbGZpbGVuYW1lKQogICAgICAgICAgICAgc3VwcHJlc3Np b25zZmlsZSA9IHNlbGYucGF0aF9mcm9tX3dlYmtpdF9iYXNlKCdUb29scycsICdTY3JpcHRzJywg J3ZhbGdyaW5kJywgJ3N1cHByZXNzaW9ucy50eHQnKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L3dwZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC93cGUu cHkKaW5kZXggNDM1ZmVmZGZhNDI5ZmY2MGYyNDJkMmJmNTU0NDE1MjBlNGMxY2RmMS4uYzBmMWYx NzUxMzkwNTgzMWQ1NjA2N2YyZDI0NjNmOWZkNGFhY2I5NiAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L3dwZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvd3BlLnB5CkBAIC02Myw2ICs2Myw3IEBAIGNsYXNzIFdQRVBvcnQoUG9ydCk6CiAKICAgICBk ZWYgc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlbGYsIHNlcnZlcl9uYW1lPU5vbmUpOgogICAg ICAgICBlbnZpcm9ubWVudCA9IHN1cGVyKFdQRVBvcnQsIHNlbGYpLnNldHVwX2Vudmlyb25fZm9y X3NlcnZlcihzZXJ2ZXJfbmFtZSkKKyAgICAgICAgZW52aXJvbm1lbnRbJ0dfREVCVUcnXSA9ICdm YXRhbC1jcml0aWNhbHMnCiAgICAgICAgIGVudmlyb25tZW50WydHU0VUVElOR1NfQkFDS0VORCdd ID0gJ21lbW9yeScKICAgICAgICAgZW52aXJvbm1lbnRbJ1RFU1RfUlVOTkVSX0lOSkVDVEVEX0JV TkRMRV9GSUxFTkFNRSddID0gc2VsZi5fYnVpbGRfcGF0aCgnbGliJywgJ2xpYlRlc3RSdW5uZXJJ bmplY3RlZEJ1bmRsZS5zbycpCiAgICAgICAgIGVudmlyb25tZW50WydURVNUX1JVTk5FUl9URVNU X1BMVUdJTl9QQVRIJ10gPSBzZWxmLl9idWlsZF9wYXRoKCdsaWInLCAncGx1Z2lucycpCg== 320546 2017-09-12 07:32:01 -0700 2017-09-12 09:59:27 -0700 Patch bug-176755-20170912093201.patch text/plain 3011 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxOTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTYxNjZkZWQ1Yzc1Yzc2NGIxNGMzMWVlODdiMjRhYzQ5 Mjk2NDE0ZS4uNDg3NjJmMDEwZTVjOTBlMTU2ZGY1ZTA1M2IyMTM5ZDE2MWMwNDc2YSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA5LTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbV1BFXVtHVEtdIFJ1biB0ZXN0cyB3aXRoIEdfREVCVUc9ZmF0YWwtY3Jp dGljYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzY3NTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHk6CisgICAgICAgIChHdGtQb3J0LnNldHVwX2Vu dmlyb25fZm9yX3NlcnZlcik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3dwZS5w eToKKyAgICAgICAgKFdQRVBvcnQuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKToKKwogMjAxNy0w OS0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg ICAgW0ZyZWV0eXBlXSBEb2Vzbid0IHN1cHBvcnQgY29sb3VyZWQgZm9udHMKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZ3RrLnB5CmluZGV4IDI2YjkzNzI1ZjEzZTAzYWIyMWM2MWJhZjk2ZjU1ODFjODk5 N2Q3OTQuLjM3MWUyM2FiYTEyYjU0OGU3ODY1YmE0MjQyM2I5Zjc1OGUzYmFmYjggMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2d0ay5weQpAQCAtMTE2LDYgKzExNiw3IEBAIGNsYXNzIEd0a1BvcnQo UG9ydCk6CiAKICAgICBkZWYgc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVyKHNlbGYsIHNlcnZlcl9u YW1lPU5vbmUpOgogICAgICAgICBlbnZpcm9ubWVudCA9IHN1cGVyKEd0a1BvcnQsIHNlbGYpLnNl dHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZXJ2ZXJfbmFtZSkKKyAgICAgICAgZW52aXJvbm1lbnRb J0dfREVCVUcnXSA9ICdmYXRhbC1jcml0aWNhbHMnCiAgICAgICAgIGVudmlyb25tZW50WydHU0VU VElOR1NfQkFDS0VORCddID0gJ21lbW9yeScKICAgICAgICAgZW52aXJvbm1lbnRbJ0xJQk9WRVJM QVlfU0NST0xMQkFSJ10gPSAnMCcKICAgICAgICAgZW52aXJvbm1lbnRbJ1RFU1RfUlVOTkVSX0lO SkVDVEVEX0JVTkRMRV9GSUxFTkFNRSddID0gc2VsZi5fYnVpbGRfcGF0aCgnbGliJywgJ2xpYlRl c3RSdW5uZXJJbmplY3RlZEJ1bmRsZS5zbycpCkBAIC0xMzgsOSArMTM5LDkgQEAgY2xhc3MgR3Rr UG9ydChQb3J0KToKICAgICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgICAgIF9sb2cu d2FybmluZygiQ2FuJ3QgZmluZCBHYWxsaXVtIGxsdm1waXBlIGRyaXZlci4gVHJ5IHRvIHJ1biB1 cGRhdGUtd2Via2l0Z3RrLWxpYnMiKQogICAgICAgICBpZiBzZWxmLmdldF9vcHRpb24oImxlYWtz Iik6Ci0gICAgICAgICAgICAjICBUdXJuIG9mZiBHTGliIG1lbW9yeSBvcHRpbWlzYXRpb25zIGh0 dHBzOi8vd2lraS5nbm9tZS5vcmcvVmFsZ3JpbmQuCisgICAgICAgICAgICAjIFR1cm4gb2ZmIEdM aWIgbWVtb3J5IG9wdGltaXNhdGlvbnMgaHR0cHM6Ly93aWtpLmdub21lLm9yZy9WYWxncmluZC4K ICAgICAgICAgICAgIGVudmlyb25tZW50WydHX1NMSUNFJ10gPSAnYWx3YXlzLW1hbGxvYycKLSAg ICAgICAgICAgIGVudmlyb25tZW50WydHX0RFQlVHJ10gPSAnZ2MtZnJpZW5kbHknCisgICAgICAg ICAgICBlbnZpcm9ubWVudFsnR19ERUJVRyddICs9ICcsZ2MtZnJpZW5kbHknCiAgICAgICAgICAg ICB4bWxmaWxlbmFtZSA9ICIiLmpvaW4oKCJkcnQtJXAtIiwgdXVpZC51dWlkMSgpLmhleCwgIi1s ZWFrcy54bWwiKSkKICAgICAgICAgICAgIHhtbGZpbGUgPSBvcy5wYXRoLmpvaW4oc2VsZi5yZXN1 bHRzX2RpcmVjdG9yeSgpLCB4bWxmaWxlbmFtZSkKICAgICAgICAgICAgIHN1cHByZXNzaW9uc2Zp bGUgPSBzZWxmLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgnVG9vbHMnLCAnU2NyaXB0cycsICd2YWxn cmluZCcsICdzdXBwcmVzc2lvbnMudHh0JykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC93cGUucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd3BlLnB5Cmlu ZGV4IDQzNWZlZmRmYTQyOWZmNjBmMjQyZDJiZjU1NDQxNTIwZTRjMWNkZjEuLmMwZjFmMTc1MTM5 MDU4MzFkNTYwNjdmMmQyNDYzZjlmZDRhYWNiOTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcG9ydC93cGUucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dw ZS5weQpAQCAtNjMsNiArNjMsNyBAQCBjbGFzcyBXUEVQb3J0KFBvcnQpOgogCiAgICAgZGVmIHNl dHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZWxmLCBzZXJ2ZXJfbmFtZT1Ob25lKToKICAgICAgICAg ZW52aXJvbm1lbnQgPSBzdXBlcihXUEVQb3J0LCBzZWxmKS5zZXR1cF9lbnZpcm9uX2Zvcl9zZXJ2 ZXIoc2VydmVyX25hbWUpCisgICAgICAgIGVudmlyb25tZW50WydHX0RFQlVHJ10gPSAnZmF0YWwt Y3JpdGljYWxzJwogICAgICAgICBlbnZpcm9ubWVudFsnR1NFVFRJTkdTX0JBQ0tFTkQnXSA9ICdt ZW1vcnknCiAgICAgICAgIGVudmlyb25tZW50WydURVNUX1JVTk5FUl9JTkpFQ1RFRF9CVU5ETEVf RklMRU5BTUUnXSA9IHNlbGYuX2J1aWxkX3BhdGgoJ2xpYicsICdsaWJUZXN0UnVubmVySW5qZWN0 ZWRCdW5kbGUuc28nKQogICAgICAgICBlbnZpcm9ubWVudFsnVEVTVF9SVU5ORVJfVEVTVF9QTFVH SU5fUEFUSCddID0gc2VsZi5fYnVpbGRfcGF0aCgnbGliJywgJ3BsdWdpbnMnKQo=