176742 2017-09-11 14:51:10 -0700 More exception check book-keeping needed found by 32-bit JSC test failures. 2017-09-27 13:01:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam buildbot keith_miller msaboff ryanhaddad saam webkit-bug-importer oldest_to_newest 1347636 0 mark.lam 2017-09-11 14:51:10 -0700 Patch coming. 1347638 1 mark.lam 2017-09-11 14:51:54 -0700 For example, see https://build.webkit.org/builders/Apple%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/1814. 1347655 2 320483 mark.lam 2017-09-11 15:12:32 -0700 Created attachment 320483 proposed patch. 1347658 3 320483 msaboff 2017-09-11 15:14:04 -0700 Comment on attachment 320483 proposed patch. r=me 1347660 4 320483 keith_miller 2017-09-11 15:14:29 -0700 Comment on attachment 320483 proposed patch. r=me. 1347661 5 mark.lam 2017-09-11 15:17:18 -0700 Thanks for the review. Landed in r221881: <http://trac.webkit.org/r221881>. 1353769 6 webkit-bug-importer 2017-09-27 13:01:18 -0700 <rdar://problem/34694487> 320483 2017-09-11 15:12:32 -0700 2017-09-11 15:14:04 -0700 proposed patch. bug-176742.patch text/plain 1963 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxODgwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE3LTA5LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN b3JlIGV4Y2VwdGlvbiBjaGVjayBib29rLWtlZXBpbmcgbmVlZGVkIGZvdW5kIGJ5IDMyLWJpdCBK U0MgdGVzdCBmYWlsdXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3Njc0MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogZGZnL0RGR09wZXJhdGlvbnMuY3BwOgorCiAyMDE3LTA5LTExICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIGpzYyBkdW1wIHRoZSBjb21t YW5kIGxpbmUgaWYgSlNDX2R1bXBPcHRpb24gZW52aXJvbm1lbnQgdmFyaWFibGUgaXMgc2V0IHdp dGggYSBub24temVybyB2YWx1ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH T3BlcmF0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdPcGVyYXRpb25zLmNwcAkocmV2aXNpb24gMjIxODc5KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdPcGVyYXRpb25zLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcxLDEzICs1NzEs MTcgQEAgRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZQogCiAgICAgSlNW YWx1ZSBwcm9wZXJ0eSA9IEpTVmFsdWU6OmRlY29kZShlbmNvZGVkUHJvcGVydHkpOwogCi0gICAg aWYgKHByb3BlcnR5LmlzVUludDMyKCkpCisgICAgaWYgKHByb3BlcnR5LmlzVUludDMyKCkpIHsK KyAgICAgICAgc2NvcGUucmVsZWFzZSgpOwogICAgICAgICByZXR1cm4gZ2V0QnlWYWwoZXhlYywg YmFzZSwgcHJvcGVydHkuYXNVSW50MzIoKSk7CisgICAgfQogICAgIGlmIChwcm9wZXJ0eS5pc0Rv dWJsZSgpKSB7CiAgICAgICAgIGRvdWJsZSBwcm9wZXJ0eUFzRG91YmxlID0gcHJvcGVydHkuYXNE b3VibGUoKTsKICAgICAgICAgdWludDMyX3QgcHJvcGVydHlBc1VJbnQzMiA9IHN0YXRpY19jYXN0 PHVpbnQzMl90Pihwcm9wZXJ0eUFzRG91YmxlKTsKLSAgICAgICAgaWYgKHByb3BlcnR5QXNVSW50 MzIgPT0gcHJvcGVydHlBc0RvdWJsZSkKKyAgICAgICAgaWYgKHByb3BlcnR5QXNVSW50MzIgPT0g cHJvcGVydHlBc0RvdWJsZSkgeworICAgICAgICAgICAgc2NvcGUucmVsZWFzZSgpOwogICAgICAg ICAgICAgcmV0dXJuIGdldEJ5VmFsKGV4ZWMsIGJhc2UsIHByb3BlcnR5QXNVSW50MzIpOworICAg ICAgICB9CiAgICAgfSBlbHNlIGlmIChwcm9wZXJ0eS5pc1N0cmluZygpKSB7CiAgICAgICAgIFN0 cnVjdHVyZSYgc3RydWN0dXJlID0gKmJhc2UtPnN0cnVjdHVyZSh2bSk7CiAgICAgICAgIGlmIChK U0NlbGw6OmNhblVzZUZhc3RHZXRPd25Qcm9wZXJ0eShzdHJ1Y3R1cmUpKSB7CkBAIC01OTAsNiAr NTk0LDcgQEAgRW5jb2RlZEpTVmFsdWUgSklUX09QRVJBVElPTiBvcGVyYXRpb25HZQogCiAgICAg YXV0byBwcm9wZXJ0eU5hbWUgPSBwcm9wZXJ0eS50b1Byb3BlcnR5S2V5KGV4ZWMpOwogICAgIFJF VFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGVuY29kZWRKU1ZhbHVlKCkpOworICAgIHNjb3BlLnJl bGVhc2UoKTsKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKEpTVmFsdWUoYmFzZSkuZ2V0KGV4 ZWMsIHByb3BlcnR5TmFtZSkpOwogfQogCg==