176738 2017-09-11 14:26:51 -0700 Web Inspector: Remove unused parameter to UIString 2017-09-27 12:34:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1347620 0 joepeck 2017-09-11 14:26:51 -0700 Remove unused parameter to UIString UIString used to take variable arguments but we've moved to using String.format: WI.UIString("foo %s").format(...) So this parameter is no longer needed. 1347621 1 320478 joepeck 2017-09-11 14:27:39 -0700 Created attachment 320478 [PATCH] Proposed Fix 1347631 2 320478 mattbaker 2017-09-11 14:42:48 -0700 Comment on attachment 320478 [PATCH] Proposed Fix r=me 1347668 3 320478 commit-queue 2017-09-11 15:22:15 -0700 Comment on attachment 320478 [PATCH] Proposed Fix Clearing flags on attachment: 320478 Committed r221884: <http://trac.webkit.org/changeset/221884> 1347669 4 commit-queue 2017-09-11 15:22:16 -0700 All reviewed patches have been landed. Closing bug. 1353492 5 webkit-bug-importer 2017-09-27 12:34:40 -0700 <rdar://problem/34693518> 320478 2017-09-11 14:27:39 -0700 2017-09-11 15:22:15 -0700 [PATCH] Proposed Fix localized-string-1.patch text/plain 1338 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcxNjQ5NjcyZTlmLi4yNTRkMjZiNjc4OCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAKIDIwMTctMDktMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZW1vdmUgdW51c2VkIHBhcmFtZXRlciB0byBVSVN0cmluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NzM4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTG9hZExv Y2FsaXplZFN0cmluZ3MuanM6CisgICAgICAgIChXSS5VSVN0cmluZyk6CisgICAgICAgIFJlbW92 ZSB1bnVzZWQgcGFyYW1ldGVyLiBXZSBtb3ZlZCB0byBTdHJpbmcuZm9ybWF0IGZvciB0aGlzIGJl aGF2aW9yIGEgd2hpbGUgYWdvLgorCisyMDE3LTA5LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBEYXNoYm9hcmQg VGltZWxpbmUgaWNvbiBhbmQgVGltZWxpbmUgdGFiIGljb24gbW9yZSBzaW1pbGFyCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY1ODIKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9Mb2FkTG9jYWxp emVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv TG9hZExvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggOTVjMjg5OTFhNmQuLmYwZmQ4Y2Q2ZWEwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0xvYWRM b2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvTG9hZExvY2FsaXplZFN0cmluZ3MuanMKQEAgLTQxLDcgKzQxLDcgQEAgV0kudW5s b2NhbGl6ZWRTdHJpbmcgPSBmdW5jdGlvbihzdHJpbmcpCiAgICAgcmV0dXJuIHN0cmluZzsKIH07 CiAKLVdJLlVJU3RyaW5nID0gZnVuY3Rpb24oc3RyaW5nLCB2YXJhcmcpCitXSS5VSVN0cmluZyA9 IGZ1bmN0aW9uKHN0cmluZykKIHsKICAgICBpZiAoV0kuZG9udExvY2FsaXplVXNlckludGVyZmFj ZSkKICAgICAgICAgcmV0dXJuIHN0cmluZzsK