176726 2017-09-11 13:19:41 -0700 Web Inspector: Do not allow the split console in the Settings tab 2017-09-27 12:31:54 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1347565 0 joepeck 2017-09-11 13:19:41 -0700 Do not allow the split console in the Settings tab Like the New Tab tab it doesn't make much sense to show the split console in the Settings tab. That said, we'd like to make the Split console available more often in other tabs (like Network). I'll address that in upcoming patches. 1347566 1 320462 joepeck 2017-09-11 13:20:15 -0700 Created attachment 320462 [PATCH] Proposed Fix 1347633 2 320462 mattbaker 2017-09-11 14:50:07 -0700 Comment on attachment 320462 [PATCH] Proposed Fix r=me 1347663 3 320462 commit-queue 2017-09-11 15:18:49 -0700 Comment on attachment 320462 [PATCH] Proposed Fix Clearing flags on attachment: 320462 Committed r221882: <http://trac.webkit.org/changeset/221882> 1347664 4 commit-queue 2017-09-11 15:18:51 -0700 All reviewed patches have been landed. Closing bug. 1353451 5 webkit-bug-importer 2017-09-27 12:31:54 -0700 <rdar://problem/34693436> 320462 2017-09-11 13:20:15 -0700 2017-09-11 15:18:49 -0700 [PATCH] Proposed Fix settings-tab-1.patch text/plain 1435 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcxNjQ5NjcyZTlmLi44MTE1Y2U0N2NiZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTctMDktMTEgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBEbyBub3QgYWxsb3cgdGhlIHNwbGl0IGNvbnNvbGUgaW4gdGhlIFNldHRpbmdzIHRhYgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NzI2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5TZXR0aW5n c1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5nZXQgc3VwcG9ydHNTcGxpdENvbnRlbnRCcm93c2Vy KToKKworMjAxNy0wOS0xMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IE1ha2UgRGFzaGJvYXJkIFRpbWVsaW5lIGljb24gYW5k IFRpbWVsaW5lIHRhYiBpY29uIG1vcmUgc2ltaWxhcgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NTgyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNv bnRlbnRWaWV3LmpzCmluZGV4IDc1ZDdmNmJmN2Y1Li42NmRhY2M5M2UzYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJDb250 ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCkBAIC02MSw2ICs2MSwxMSBAQCBXSS5TZXR0aW5n c1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJ LlRhYkNvbnRlbnRWaQogCiAgICAgZ2V0IHR5cGUoKSB7IHJldHVybiBXSS5TZXR0aW5nc1RhYkNv bnRlbnRWaWV3LlR5cGU7IH0KIAorICAgIGdldCBzdXBwb3J0c1NwbGl0Q29udGVudEJyb3dzZXIo KQorICAgIHsKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKwogICAgIGdldCBzZWxlY3Rl ZFNldHRpbmdzVmlldygpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fc2VsZWN0ZWRTZXR0 aW5nc1ZpZXc7Cg==