176722 2017-09-11 12:46:30 -0700 Make jsc dump the command line if JSC_dumpOption environment variable is set with a non-zero value. 2017-09-27 12:33:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam buildbot commit-queue jfbastien keith_miller lforschler msaboff saam webkit-bug-importer oldest_to_newest 1347549 0 mark.lam 2017-09-11 12:46:30 -0700 Currently, specifying the JSC_dumpOption=<non zero value> environment variable will cause JSC options to be dumped via dataLog. This is useful for debugging what options are used for any specific test run. This patch adds the dumping of the command line as well so that it's easier to determine the command line that test scripts invoked jsc with for any given test run (without needing to decode the layers of test scripts). 1347550 1 320457 mark.lam 2017-09-11 12:48:55 -0700 Created attachment 320457 proposed patch. 1347554 2 320457 jfbastien 2017-09-11 12:51:53 -0700 Comment on attachment 320457 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=320457&action=review > Source/JavaScriptCore/jsc.cpp:3846 > + if (dumpOptionsOption && strcmp(dumpOptionsOption, "0")) { OptionsOptionOptionsOptionsOptionOptions Code seems to usually do: !strcasecmp(string, "none") || !strcasecmp(string, "no") || !strcasecmp(string, "false") || !strcmp(string, "0") ? 1347559 3 320457 saam 2017-09-11 12:56:43 -0700 Comment on attachment 320457 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=320457&action=review >> Source/JavaScriptCore/jsc.cpp:3846 >> + if (dumpOptionsOption && strcmp(dumpOptionsOption, "0")) { > > OptionsOptionOptionsOptionsOptionOptions > > Code seems to usually do: > !strcasecmp(string, "none") || !strcasecmp(string, "no") || !strcasecmp(string, "false") || !strcmp(string, "0") > > ? let's use strncmp Also, Options seems to allow for "false" and "False" 1347560 4 320457 saam 2017-09-11 12:58:14 -0700 Comment on attachment 320457 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=320457&action=review >>> Source/JavaScriptCore/jsc.cpp:3846 >>> + if (dumpOptionsOption && strcmp(dumpOptionsOption, "0")) { >> >> OptionsOptionOptionsOptionsOptionOptions >> >> Code seems to usually do: >> !strcasecmp(string, "none") || !strcasecmp(string, "no") || !strcasecmp(string, "false") || !strcmp(string, "0") >> >> ? > > let's use strncmp > Also, Options seems to allow for "false" and "False" I think you should do this after Options::initialize so you can just write code like: if (Options::dumpOptions()) .... 1347583 5 320457 mark.lam 2017-09-11 13:48:41 -0700 Comment on attachment 320457 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=320457&action=review >>>> Source/JavaScriptCore/jsc.cpp:3846 >>>> + if (dumpOptionsOption && strcmp(dumpOptionsOption, "0")) { >>> >>> OptionsOptionOptionsOptionsOptionOptions >>> >>> Code seems to usually do: >>> !strcasecmp(string, "none") || !strcasecmp(string, "no") || !strcasecmp(string, "false") || !strcmp(string, "0") >>> >>> ? >> >> let's use strncmp >> Also, Options seems to allow for "false" and "False" > > I think you should do this after Options::initialize so you can just write code like: > if (Options::dumpOptions()) .... I'll change to checking Options::dumpOptions() in CommandLine instead. BTW, JSC_dumpOptions can only be set to an integer 0 to 3. "false", "False", "none", etc are all invalid options. 1347587 6 320469 mark.lam 2017-09-11 13:53:23 -0700 Created attachment 320469 proposed patch. 1347588 7 320469 mark.lam 2017-09-11 13:55:33 -0700 Comment on attachment 320469 proposed patch. Thanks for the review. 1347618 8 320469 commit-queue 2017-09-11 14:24:51 -0700 Comment on attachment 320469 proposed patch. Clearing flags on attachment: 320469 Committed r221878: <http://trac.webkit.org/changeset/221878> 1347619 9 commit-queue 2017-09-11 14:24:53 -0700 All reviewed patches have been landed. Closing bug. 1353470 10 webkit-bug-importer 2017-09-27 12:33:27 -0700 <rdar://problem/34693481> 320457 2017-09-11 12:48:55 -0700 2017-09-11 13:53:23 -0700 proposed patch. bug-176722.patch text/plain 1375 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxODcyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE3LTA5LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN YWtlIGpzYyBkdW1wIHRoZSBjb21tYW5kIGxpbmUgaWYgSlNDX2R1bXBPcHRpb24gZW52aXJvbm1l bnQgdmFyaWFibGUgaXMgc2V0IHdpdGggYSBub24temVybyB2YWx1ZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjcyMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganNjLmNwcDoKKyAgICAgICAgKGpz Y21haW4pOgorCiAyMDE3LTA5LTAzICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtERkddIE9wdGltaXplIFdlYWtNYXA6OmdldCBieSBhZGRpbmcgaW50 cmluc2ljIGFuZCBmaXh1cApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHJldmlzaW9uIDIyMTg2 NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z ODQyLDYgKzM4NDIsMTQgQEAgaW50IHJ1bkpTQyhDb21tYW5kTGluZSBvcHRpb25zLCBib29sIGlz VwogCiBpbnQganNjbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCiB7CisgICAgY29uc3QgY2hh ciogZHVtcE9wdGlvbnNPcHRpb24gPSBnZXRlbnYoIkpTQ19kdW1wT3B0aW9ucyIpOworICAgIGlm IChkdW1wT3B0aW9uc09wdGlvbiAmJiBzdHJjbXAoZHVtcE9wdGlvbnNPcHRpb24sICIwIikpIHsK KyAgICAgICAgcHJpbnRmKCJDb21tYW5kIGxpbmU6Iik7CisgICAgICAgIGZvciAoaW50IGkgPSAw OyBpIDwgYXJnYzsgKytpKQorICAgICAgICAgICAgcHJpbnRmKCIgJXMiLCBhcmd2W2ldKTsKKyAg ICAgICAgcHJpbnRmKHN0ZGVyciwgIlxuIik7CisgICAgfQorCiAgICAgLy8gTmVlZCB0byBvdmVy cmlkZSBhbmQgZW5hYmxlIHJlc3RyaWN0ZWQgb3B0aW9ucyBiZWZvcmUgd2Ugc3RhcnQgcGFyc2lu ZyBvcHRpb25zIGJlbG93LgogICAgIE9wdGlvbnM6OmVuYWJsZVJlc3RyaWN0ZWRPcHRpb25zKHRy dWUpOwogCg== 320469 2017-09-11 13:53:23 -0700 2017-09-11 14:24:51 -0700 proposed patch. bug-176722.patch text/plain 1945 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxODczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE3LTA5LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN YWtlIGpzYyBkdW1wIHRoZSBjb21tYW5kIGxpbmUgaWYgSlNDX2R1bXBPcHRpb24gZW52aXJvbm1l bnQgdmFyaWFibGUgaXMgc2V0IHdpdGggYSBub24temVybyB2YWx1ZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjcyMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBQTEFURk9STShDT0NPQSksIEkg YWxzbyBkdW1wZWQgdGhlIEpTQ18qIGVudmlyb25tZW50YWwgdmFyaWFibGVzIHRoYXQgYXJlCisg ICAgICAgIGluIGVmZmVjdCB3aGVuIGpzYyBpcyBpbnZva2VkLgorCisgICAgICAgICoganNjLmNw cDoKKyAgICAgICAgKENvbW1hbmRMaW5lOjpwYXJzZUFyZ3VtZW50cyk6CisKIDIwMTctMDktMDMg IFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0RGR10g T3B0aW1pemUgV2Vha01hcDo6Z2V0IGJ5IGFkZGluZyBpbnRyaW5zaWMgYW5kIGZpeHVwCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvanNjLmNwcAkocmV2aXNpb24gMjIxODY3KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2pzYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwMyw2ICsxMDMsMTAgQEAKICNpbmNs dWRlIDx1bmlzdGQuaD4KICNlbmRpZgogCisjaWYgUExBVEZPUk0oQ09DT0EpCisjaW5jbHVkZSA8 Y3J0X2V4dGVybnMuaD4KKyNlbmRpZgorCiAjaWYgSEFWRShSRUFETElORSkKIC8vIHJlYWRsaW5l L2hpc3RvcnkuaCBoYXMgYSBGdW5jdGlvbiB0eXBlZGVmIHdoaWNoIGNvbmZsaWN0cyB3aXRoIHRo ZSBXVEY6OkZ1bmN0aW9uIHRlbXBsYXRlIGZyb20gV1RGL0ZvcndhcmQuaAogLy8gV2UgI2RlZmlu ZSBpdCB0byBzb21ldGhpbmcgZWxzZSB0byBhdm9pZCB0aGlzIGNvbmZsaWN0LgpAQCAtMzU5NSw2 ICszNTk5LDIwIEBAIHZvaWQgQ29tbWFuZExpbmU6OnBhcnNlQXJndW1lbnRzKGludCBhcmcKIHsK ICAgICBPcHRpb25zOjppbml0aWFsaXplKCk7CiAgICAgCisgICAgaWYgKE9wdGlvbnM6OmR1bXBP cHRpb25zKCkpIHsKKyAgICAgICAgcHJpbnRmKCJDb21tYW5kIGxpbmU6Iik7CisjaWYgUExBVEZP Uk0oQ09DT0EpCisgICAgICAgIGZvciAoY2hhcioqIGVudnAgPSAqX05TR2V0RW52aXJvbigpOyAq ZW52cDsgZW52cCsrKSB7CisgICAgICAgICAgICBjb25zdCBjaGFyKiBlbnYgPSAqZW52cDsKKyAg ICAgICAgICAgIGlmICghc3RybmNtcCgiSlNDXyIsIGVudiwgNCkpCisgICAgICAgICAgICAgICAg cHJpbnRmKCIgJXMiLCBlbnYpOworICAgICAgICB9CisjZW5kaWYgLy8gUExBVEZPUk0oQ09DT0Ep CisgICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgYXJnYzsgKytpKQorICAgICAgICAgICAgcHJp bnRmKCIgJXMiLCBhcmd2W2ldKTsKKyAgICAgICAgcHJpbnRmKCJcbiIpOworICAgIH0KKwogICAg IGludCBpID0gMTsKICAgICBKU0M6Ok9wdGlvbnM6OkR1bXBMZXZlbCBkdW1wT3B0aW9uc0xldmVs ID0gSlNDOjpPcHRpb25zOjpEdW1wTGV2ZWw6Ok5vbmU7CiAgICAgYm9vbCBuZWVkVG9FeGl0ID0g ZmFsc2U7Cg==