176699 2017-09-11 09:08:13 -0700 Older versions should adopt newer version's expectations on mac 2017-11-14 16:52:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=179711 InRadar P2 Normal --- 176463 1 jbedard jbedard ap buildbot commit-queue glenn lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1347411 0 jbedard 2017-09-11 09:08:13 -0700 In https://bugs.webkit.org/show_bug.cgi?id=174472, test expectation inheritance for Mac was modified so it was more in-line with other platforms. There was an aspect of this test inheritance, however, which should be retained to make incrementing versions easier. Consider El Capitan as we transition to High Sierra: If test expectation inheritance looks like this for El Capitan: mac-add-elcapitan-wk2 => mac-elcapitan => mac-sierra-wk2 => mac-sierra => mac-wk2 => mac => wk2 Then we can move any Sierra/El Capitan expectations into mac-sierra, and general High Sierra expectations into Mac (since such expectations will likely apply to future operating systems as well). Before r219507, this was the technique used. However, general mac overrode version specific expectations before r219507 (which is definitely incorrect). See the ChangeLog of <https://trac.webkit.org/changeset/219507/webkit> for details. 1347412 1 webkit-bug-importer 2017-09-11 09:08:37 -0700 <rdar://problem/34367907> 1347414 2 320432 jbedard 2017-09-11 09:16:00 -0700 Created attachment 320432 Patch 1347593 3 320432 commit-queue 2017-09-11 14:02:32 -0700 Comment on attachment 320432 Patch Rejecting attachment 320432 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 320432, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 221872 = 8af2268a70bf54353a9d2d586ef20842d13588ca r221873 = 52fffebf9340ce45308b469d58249c4e9c41a60d r221874 = 3e36c33d1a9fd59bc8f66681346174d194164729 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4515570 1347602 4 jbedard 2017-09-11 14:13:21 -0700 Committed r221877: <http://trac.webkit.org/changeset/221877> 320432 2017-09-11 09:16:00 -0700 2017-09-11 14:02:32 -0700 Patch bug-176699-20170911091600.patch text/plain 3392 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTg1NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMzIEBACisyMDE3LTA5LTExICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBPbGRlciB2ZXJzaW9ucyBzaG91bGQgYWRvcHQgbmV3ZXIgdmVyc2lvbidz IGV4cGVjdGF0aW9ucyBvbiBtYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NjY5OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQzNjc5MDc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmVmb3JlOgor ICAgICAgICAgICAgICAgIG1hYy1lbGNhcGl0YW4td2syCisgICAgICAgICAgICAgICAgbWFjLWVs Y2FwaXRhbgorICAgICAgICAgICAgICAgIG1hYy13azIKKyAgICAgICAgICAgICAgICBtYWMKKyAg ICAgICAgICAgICAgICB3azIKKyAgICAgICAgQWZ0ZXI6CisgICAgICAgICAgICAgICAgbWFjLWVs Y2FwaXRhbi13azIKKyAgICAgICAgICAgICAgICBtYWMtZWxjYXBpdGFuCisgICAgICAgICAgICAg ICAgbWFjLXNpZXJyYS13azIKKyAgICAgICAgICAgICAgICBtYWMtc2llcnJhCisgICAgICAgICAg ICAgICAgbWFjLXdrMgorICAgICAgICAgICAgICAgIG1hYworICAgICAgICAgICAgICAgIHdrMgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weToKKyAgICAgICAgKE1hY1Bv cnQuZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCk6IFVzZSBWRVJTSU9OX0ZBTExCQUNLX09S REVSIHRvIGhhdmUgb2xkCisgICAgICAgIHZlcnNpb25zIGluaGVyaXQgZXhwZWN0YXRpb25zIGZy b20gbmV3ZXIgdmVyc2lvbnMuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191 bml0dGVzdC5weToKKyAgICAgICAgKE1hY1Rlc3QudGVzdF9sYXlvdXRfdGVzdF9zZWFyY2hwYXRo X3dpdGhfYXBwbGVfYWRkaXRpb25zKTogQ2hlY2sgbmV3IGJlaGF2aW9yCisgICAgICAgIHdpdGgg b2xkZXIgdmVyc2lvbnMgaW5oZXJpdGluZyBleHBlY3RhdGlvbnMgZnJvbSBuZXdlciB2ZXJzaW9u cy4KKwogMjAxNy0wOS0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogW0dUS10gR2VuZXJhdGVkIEhUTUwgQVBJIGRvY3Vt ZW50YXRpb24gaXMgbWlzc2luZyBkZXNjcmlwdGlvbnMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvcG9ydC9tYWMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L21hYy5weQkocmV2aXNpb24gMjIxNjY5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L21hYy5weQkod29ya2luZyBjb3B5KQpAQCAtNzQsMTIgKzc0LDIwIEBAIGNsYXNzIE1hY1Bv cnQoRGFyd2luUG9ydCk6CiAKICAgICBAbWVtb2l6ZWQKICAgICBkZWYgZGVmYXVsdF9iYXNlbGlu ZV9zZWFyY2hfcGF0aChzZWxmKToKKyAgICAgICAgbWFjX3ZlcnNpb24gPSAnbWFjLXt9Jy5mb3Jt YXQoc2VsZi5fb3NfdmVyc2lvbikKKyAgICAgICAgaWYgbWFjX3ZlcnNpb24uZW5kc3dpdGgoc2Vs Zi5GVVRVUkVfVkVSU0lPTikgb3IgbWFjX3ZlcnNpb24gbm90IGluIHNlbGYuVkVSU0lPTl9GQUxM QkFDS19PUkRFUjoKKyAgICAgICAgICAgIHZlcnNpb25fZmFsbGJhY2sgPSBbc2VsZi5fb3NfdmVy c2lvbl0KKyAgICAgICAgZWxzZToKKyAgICAgICAgICAgIHZlcnNpb25fZmFsbGJhY2sgPSBzZWxm LlZFUlNJT05fRkFMTEJBQ0tfT1JERVJbc2VsZi5WRVJTSU9OX0ZBTExCQUNLX09SREVSLmluZGV4 KG1hY192ZXJzaW9uKTotMV0KICAgICAgICAgd2tfc3RyaW5nID0gJ3drMScKICAgICAgICAgaWYg c2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRfdGVzdF9ydW5uZXInKToKICAgICAgICAgICAgIHdrX3N0 cmluZyA9ICd3azInCi0gICAgICAgIGZhbGxiYWNrX25hbWVzID0gWwotICAgICAgICAgICAgJ3t9 LXt9LXt9Jy5mb3JtYXQoc2VsZi5wb3J0X25hbWUsIHNlbGYuX29zX3ZlcnNpb24sIHdrX3N0cmlu ZyksCi0gICAgICAgICAgICAne30te30nLmZvcm1hdChzZWxmLnBvcnRfbmFtZSwgc2VsZi5fb3Nf dmVyc2lvbiksCisKKyAgICAgICAgZmFsbGJhY2tfbmFtZXMgPSBbXQorICAgICAgICBmb3IgdmVy c2lvbiBpbiB2ZXJzaW9uX2ZhbGxiYWNrOgorICAgICAgICAgICAgZmFsbGJhY2tfbmFtZXMuYXBw ZW5kKCd7fS17fScuZm9ybWF0KHZlcnNpb24sIHdrX3N0cmluZykpCisgICAgICAgICAgICBmYWxs YmFja19uYW1lcy5hcHBlbmQodmVyc2lvbikKKyAgICAgICAgZmFsbGJhY2tfbmFtZXMgPSBmYWxs YmFja19uYW1lcyArIFsKICAgICAgICAgICAgICd7fS17fScuZm9ybWF0KHNlbGYucG9ydF9uYW1l LCB3a19zdHJpbmcpLAogICAgICAgICAgICAgc2VsZi5wb3J0X25hbWUsCiAgICAgICAgIF0KSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWNfdW5pdHRlc3QucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191bml0dGVzdC5weQkocmV2aXNp b24gMjIxNjY5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hY191bml0dGVzdC5w eQkod29ya2luZyBjb3B5KQpAQCAtMTUwLDMgKzE1MCw1IEBAIGNsYXNzIE1hY1Rlc3QoZGFyd2lu X3Rlc3RjYXNlLkRhcndpblRlc3QKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWFyY2hfcGF0 aFsxXSwgJy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1saW9uLXdrMScp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VhcmNoX3BhdGhbMl0sICcvYWRkaXRpb25hbF90 ZXN0aW5nX3BhdGgvbWFjLWFkZC1saW9uJykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWFy Y2hfcGF0aFszXSwgJy9tb2NrLWNoZWNrb3V0L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1saW9u JykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWFyY2hfcGF0aFs0XSwgJy9hZGRpdGlvbmFs X3Rlc3RpbmdfcGF0aC9tYWMtYWRkLW1vdW50YWlubGlvbi13azEnKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFsKHNlYXJjaF9wYXRoWzVdLCAnL21vY2stY2hlY2tvdXQvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjLW1vdW50YWlubGlvbi13azEnKQo=