176680 2017-09-10 19:51:32 -0700 webkitbot should recognize commands even when colon is omitted 2017-09-27 12:36:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 176752 1 rniwa webkit-unassigned bburg beidson buildbot commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1347340 0 rniwa 2017-09-10 19:51:32 -0700 Right now, webkitbot doesn't recognize a command when : is omitted as in: webkitbot rollout r999999 introduced a build failure Fix this, and also enhance "hi!" command so that it can respond with "hi!" even when the bot name is omitted. 1347341 1 rniwa 2017-09-10 19:51:44 -0700 <rdar://problem/29933898> 1347342 2 320414 rniwa 2017-09-10 19:54:41 -0700 Created attachment 320414 Fixe the bug Actually, let's do "hi!" enhancement in a aspirate patch since the bug fix is one liner. 1347415 3 320414 dbates 2017-09-11 09:20:11 -0700 Comment on attachment 320414 Fixe the bug View in context: https://bugs.webkit.org/attachment.cgi?id=320414&action=review > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > request = request.split(':', 1) > elif vocative_separator == ',': > request = request.split(',', 1) > + elif vocative_separator == ' ': > + request = request.split(' ', 1) We could simplify this code by using an array and the "in" operator 1347416 4 dbates 2017-09-11 09:22:00 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 320414 [details] > Fixe the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320414&action=review > > > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > > request = request.split(':', 1) > > elif vocative_separator == ',': > > request = request.split(',', 1) > > + elif vocative_separator == ' ': > > + request = request.split(' ', 1) > > We could simplify this code by using an array and the "in" operator This is not necessary to do in this patch. Feel free to commit as-is/mark cq+. 1347523 5 rniwa 2017-09-11 11:55:31 -0700 (In reply to Daniel Bates from comment #3) > Comment on attachment 320414 [details] > Fixe the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320414&action=review > > > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:92 > > request = request.split(':', 1) > > elif vocative_separator == ',': > > request = request.split(',', 1) > > + elif vocative_separator == ' ': > > + request = request.split(' ', 1) > > We could simplify this code by using an array and the "in" operator That's a good point, let's do that. 1347714 6 rniwa 2017-09-11 16:28:27 -0700 Committed r221892: <http://trac.webkit.org/changeset/221892> 1347721 7 commit-queue 2017-09-11 16:32:08 -0700 Re-opened since this is blocked by bug 176752 1353526 8 webkit-bug-importer 2017-09-27 12:36:46 -0700 <rdar://problem/34693601> 320414 2017-09-10 19:54:41 -0700 2017-09-11 17:21:20 -0700 Fixe the bug fix176680.patch text/plain 1294 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTg0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA5LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIHdlYmtpdGJvdCBzaG91bGQgcmVjb2duaXplIGNvbW1hbmRzIGV2ZW4gd2hlbiBj b2xvbiBpcyBvbWl0dGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzY2ODAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5OTMzODk4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlY29nbml6ZSB0aGUg SVJDIGNvbW1hbmQgZXZlbiB3aGVuIDogYW5kICwgd2VyZSBub3QgcHJlc2VudC4KKyAgICAgICAg VW5mb3J0dW5hdGVseSwgdGhlcmUgaXMgbm8gdW5pdCB0ZXN0IGZvciB0aGlzIGNvZGUgYXQgdGhl IG1vbWVudC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9pcmMvaXJj Ym90LnB5OgorICAgICAgICAoSVJDQm90Lm9uX3B1Ym1zZyk6CisKIDIwMTctMDktMTAgIE15bGVz IEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBXU0wgc2hvdWxk IHN1cHBvcnQgd2hpbGUgbG9vcHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L25ldC9pcmMvaXJjYm90LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9pcmMvaXJjYm90LnB5CShyZXZpc2lvbiAyMjE2NjQpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvaXJjL2lyY2JvdC5weQkod29ya2luZyBjb3B5KQpAQCAt ODgsNiArODgsOCBAQAogICAgICAgICAgICAgcmVxdWVzdCA9IHJlcXVlc3Quc3BsaXQoJzonLCAx KQogICAgICAgICBlbGlmIHZvY2F0aXZlX3NlcGFyYXRvciA9PSAnLCc6CiAgICAgICAgICAgICBy ZXF1ZXN0ID0gcmVxdWVzdC5zcGxpdCgnLCcsIDEpCisgICAgICAgIGVsaWYgdm9jYXRpdmVfc2Vw YXJhdG9yID09ICcgJzoKKyAgICAgICAgICAgIHJlcXVlc3QgPSByZXF1ZXN0LnNwbGl0KCcgJywg MSkKICAgICAgICAgZWxzZToKICAgICAgICAgICAgIHJldHVybgogCg==