17667 2008-03-04 04:13:56 -0800 REGRESSION (r30587): Document::implicitClose() not called when done loading page (Image does not get scaled to fit) 2008-03-04 13:13:57 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED http://factoryjoe.com/blog/2007/08/25/groups-for-twitter-or-a-proposal-for-twitter-tag-channels/ InRadar P2 Normal --- 1 oliver mitz bdakin hyatt mitz oliver oldest_to_newest 72676 0 oliver 2008-03-04 04:13:56 -0800 The image at the top of the post is not correctly scaled 72679 1 oliver 2008-03-04 04:22:12 -0800 Looking in inspector one difference i noticed was that there was no listing for the img elements inline style... 72693 2 mitz 2008-03-04 07:14:44 -0800 The script library the page uses does not alter the inline style when running in Safari. I hit this assertion failure when navigating away from this page: void FrameView::scheduleRelayout() { ASSERT(!m_frame->document() || !m_frame->document()->inPageCache()); 72706 3 mitz 2008-03-04 08:48:57 -0800 I cannot reproduce either problem with a low-bandwidth connection. 72709 4 mitz 2008-03-04 09:27:30 -0800 Setting a breakpoint at Document::implicitClose() confirms that the load event is never dispatched when the page finishes loading, thus the script that's supposed to resize the images doesn't run. The load event *is* dispatched when you navigate out. By then the page is in the page cache and scripts really should not be executing. The event handler runs, resizes the image, and triggers a layout of a now-cached page, which causes the assertion failure. 72710 5 mitz 2008-03-04 09:30:45 -0800 Indeed, you can force the images to resize by entering javascript: document.close() in the address bar after the page has finished loading. 72711 6 mitz 2008-03-04 10:13:45 -0800 The page links to a 404 style sheet, <http://factoryjoe.com/blog/wp-content/plugins/diso-profile/profile.css>, so I highly suspect <http://trac.webkit.org/projects/webkit/changeset/30587>. 72712 7 mitz 2008-03-04 10:29:58 -0800 <rdar://problem/5779658> 72713 8 19526 mitz 2008-03-04 10:38:15 -0800 Created attachment 19526 Call setLoadInProgress(false) in the 4xx case 72718 9 19526 oliver 2008-03-04 12:03:06 -0800 Comment on attachment 19526 Call setLoadInProgress(false) in the 4xx case r=me, though what's with "\ No newline at end of file" in the middle of the testcase? 72719 10 ggaren 2008-03-04 12:04:25 -0800 r=me too, but I noticed another potential problem: do we need to surround the call to object->error() inside Loader::didReceiveData with calls to setLoadInProgress(true) and then setLoadInProgress(false)? 72724 11 mitz 2008-03-04 12:16:57 -0800 (In reply to comment #10) > r=me too, but I noticed another potential problem: do we need to surround the > call to object->error() inside Loader::didReceiveData with calls to > setLoadInProgress(true) and then setLoadInProgress(false)? I think so but I do not know how to make a test case to prove it. 72725 12 mitz 2008-03-04 12:18:05 -0800 (In reply to comment #9) > (From update of attachment 19526 [edit]) > r=me, though what's with "\ No newline at end of file" in the middle of the > testcase? There used not to be a newline, now there should be. 72732 13 mitz 2008-03-04 13:13:57 -0800 Landed in <http://trac.webkit.org/projects/webkit/changeset/30762>. 19526 2008-03-04 10:38:15 -0800 2008-03-04 12:03:06 -0800 Call setLoadInProgress(false) in the 4xx case 17667_r1.diff text/plain 3665 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDc1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMtMDQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY2NworICAgICAgICAg IDxyZGFyOi8vcHJvYmxlbS81Nzc5NjU4PiBSRUdSRVNTSU9OIChyMzA1ODcpOiBEb2N1bWVudDo6 aW1wbGljaXRDbG9zZSgpIG5vdCBjYWxsZWQgd2hlbiBkb25lIGxvYWRpbmcgcGFnZSAoSW1hZ2Ug ZG9lcyBub3QgZ2V0IHNjYWxlZCB0byBmaXQpCisKKyAgICAgICAgKiBsb2FkZXIvbG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxvYWRlcjo6ZGlkRmluaXNoTG9hZGluZyk6IENoYW5nZWQg dG8gY2FsbAorICAgICAgICBzZXRMb2FkSW5Qcm9ncmVzcyhmYWxzZSkgZXZlbiBmb3IgNHh4IGVy cm9ycywgYmVjYXVzZSB0aGF0IHRyaWdnZXJzCisgICAgICAgIGxvYWQgY29tcGxldGlvbiBjaGVj ay4KKwogMjAwOC0wMy0wNCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAg IEdUSysgYnVpbGQgZml4LgpJbmRleDogV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9sb2FkZXIuY3BwCShyZXZpc2lvbiAzMDc1NSkKKysrIFdl YkNvcmUvbG9hZGVyL2xvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExNCwxMCArMTE0LDEx IEBAIHZvaWQgTG9hZGVyOjpkaWRGaW5pc2hMb2FkaW5nKFN1YnJlc291cmMKICAgICBpZiAoIW9i amVjdC0+ZXJyb3JPY2N1cnJlZCgpKSB7CiAgICAgICAgIGRvY0xvYWRlci0+c2V0TG9hZEluUHJv Z3Jlc3ModHJ1ZSk7CiAgICAgICAgIG9iamVjdC0+ZGF0YShsb2FkZXItPnJlc291cmNlRGF0YSgp LCB0cnVlKTsKLSAgICAgICAgZG9jTG9hZGVyLT5zZXRMb2FkSW5Qcm9ncmVzcyhmYWxzZSk7CiAg ICAgICAgIG9iamVjdC0+ZmluaXNoKCk7CiAgICAgfQogCisgICAgZG9jTG9hZGVyLT5zZXRMb2Fk SW5Qcm9ncmVzcyhmYWxzZSk7CisKICAgICBkZWxldGUgcmVxOwogCiAgICAgc2VydmVQZW5kaW5n UmVxdWVzdHMoKTsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDMwNzU4KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDMtMDQgIERhbiBC ZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAtIGV4dGVuZGVkIHRlc3QgdG8gY292ZXIgaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjcKKyAgICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTc3OTY1OD4gUkVHUkVTU0lPTiAocjMwNTg3KTogRG9jdW1lbnQ6OmltcGxpY2l0Q2xvc2Uo KSBub3QgY2FsbGVkIHdoZW4gZG9uZSBsb2FkaW5nIHBhZ2UgKEltYWdlIGRvZXMgbm90IGdldCBz Y2FsZWQgdG8gZml0KQorCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL21pc3Npbmctc3R5bGUt c2hlZXQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9taXNzaW5nLXN0 eWxlLXNoZWV0Lmh0bWw6CisKIDIwMDgtMDMtMDQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxl LmNvbT4KIAogICAgICAgICAtIHRlc3QgZm9yIDxyZGFyOi8vcHJvYmxlbS81NjIyMzM2PiBCdXJt ZXNlIHRleHQgZG9lcyBub3QgcmVuZGVyIG9uIGh0dHA6Ly93d3cubXlhbm1hcmJpYmxlLmNvbS9i aWJsZS9KdWRzb24vaHRtbC9pbmRleC5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L21pc2MvbWlzc2luZy1zdHlsZS1zaGVldC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL21pc3Npbmctc3R5bGUtc2hlZXQtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAzMDc1NSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9taXNzaW5n LXN0eWxlLXNoZWV0LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSArMSwyIEBACi1U aGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IEFTU0VSVCB0aGF0IHRoZSBkb2N1bWVudCdz IHBlbmRpbmcgc3R5bGUgc2hlZXQgY291bnQgaXMgbGVzcyB0aGFuIDAuCitUaGlzIHRlc3QgcGFz c2VzIGlmIGl0IGRvZXMgbm90IEFTU0VSVCB0aGF0IHRoZSBkb2N1bWVudCdzIHBlbmRpbmcgc3R5 bGUgc2hlZXQgY291bnQgaXMgbGVzcyB0aGFuIDAsIGFuZCB0aGUgbG9hZCBldmVudCBmaXJlcy4K K1BBU1M6IExvYWQgZXZlbnQgZmlyZWQuCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21p c2MvbWlzc2luZy1zdHlsZS1zaGVldC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWlzYy9taXNzaW5nLXN0eWxlLXNoZWV0Lmh0bWwJKHJldmlzaW9uIDMwNzU1KQor KysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL21pc3Npbmctc3R5bGUtc2hlZXQuaHRtbAko d29ya2luZyBjb3B5KQpAQCAtMSw5ICsxLDE2IEBACiA8c2NyaXB0PgogICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKKyAgICBmdW5jdGlvbiBkaWRMb2FkKCkKKyAgICB7CisgICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJsb2FkU3RhdHVzIikuaW5uZXJUZXh0ID0gIlBBU1M6IExvYWQgZXZl bnQgZmlyZWQuIjsKKyAgICB9CisgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBk aWRMb2FkKTsKIDwvc2NyaXB0PgogCiA8bGluayBocmVmPSIvYWRlbGVhbmRiZXRocm9jay5jc3Mi IHJlbD0ic3R5bGVzaGVldCIgdHlwZT0idGV4dC9jc3MiPgogCi1UaGlzIHRlc3QgcGFzc2VzIGlm IGl0IGRvZXMgbm90IEFTU0VSVCB0aGF0IHRoZSBkb2N1bWVudCdzIHBlbmRpbmcgc3R5bGUgc2hl ZXQgY291bnQgaXMgbGVzcyB0aGFuIDAuICAKLSAKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxl CitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IEFTU0VSVCB0aGF0IHRoZSBkb2N1bWVu dCdzIHBlbmRpbmcgc3R5bGUgc2hlZXQgY291bnQgaXMgbGVzcyB0aGFuIDAsIGFuZCB0aGUgbG9h ZCBldmVudCBmaXJlcy4KKzxwIGlkPSJsb2FkU3RhdHVzIj4KK0ZBSUw6IExvYWQgZXZlbnQgZGlk IG5vdCBmaXJlLgorPC9wPgo=