176666 2017-09-10 01:00:02 -0700 [WebGL macOS] No need to multisample when blitting into WebGLLayer 2017-09-11 12:40:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino sam oldest_to_newest 1347223 0 dino 2017-09-10 01:00:02 -0700 [WebGL macOS] No need to multisample when blitting into WebGLLayer 1347224 1 dino 2017-09-10 01:00:27 -0700 <rdar://problem/27774626> 1347227 2 320387 dino 2017-09-10 01:14:08 -0700 Created attachment 320387 Patch 1347548 3 dino 2017-09-11 12:40:49 -0700 Committed r221872: <http://trac.webkit.org/changeset/221872> 320387 2017-09-10 01:14:08 -0700 2017-09-10 07:51:10 -0700 Patch bug-176666-20170910181406.patch text/plain 4553 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ2YTQ5ZTc2ZjQ5MzQx YzQzOWYwMjhhYTRjMTMzMDEyZGRiMzQ3NS4uMmM1YTgxYTg5NTZjMzQyYjRhZGI2NTVkMWEyYTg3 NGQwMjgyYjcyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDE3LTA5LTEwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViR0wgbWFjT1NdIE5vIG5l ZWQgdG8gbXVsdGlzYW1wbGUgd2hlbiBibGl0dGluZyBpbnRvIFdlYkdMTGF5ZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjY2NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjc3NzQ2MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSBzZWVpbmcgcGVyZm9ybWFuY2UgcHJvZmlsZXMgc3Vn Z2VzdGluZyBXZWJHTCB3YXMKKyAgICAgICAgZG9pbmcgOHggTVNBQSwgZXZlbiB0aG91Z2ggd2Ug ZXhwbGljaXRseSBzZXQgaXQgdG8gb25seQorICAgICAgICB1c2UgNCBzYW1wbGVzIGluIHRoZSBH TFBpeGVsRm9ybWF0T2JqIHVzZWQgdG8gY3JlYXRlCisgICAgICAgIHRoZSBXZWJHTCBDR0xDb250 ZXh0T2JqLiBIb3dldmVyLCB0aGF0IHNhbWUgQ0dMUGl4ZWxGb3JtYXRPYmoKKyAgICAgICAgd2Fz IGFsc28gdXNlZCBmb3IgdGhlIFdlYkdMTGF5ZXIncyBDR0xDb250ZXh0T2JqLCBtZWFuaW5nIHRo ZQorICAgICAgICBibGl0IG9mIHRoZSBXZWJHTCBGQk8gaW50byB0aGUgV2ViR0xMYXllcidzIGJh Y2tpbmcgc3RvcmUgd2FzCisgICAgICAgIG11bHRpc2FtcGxpbmcgYXMgd2VsbCAtLSBzbyBhbiBl eHRyYSA0IHNhbXBsZXMgb24gdG9wIG9mIHRoZQorICAgICAgICBvcmlnaW5hbCA0LCBtYWtpbmcg aXQgbG9vayBsaWtlIHdlIHdlcmUgZG9pbmcgOHguCisKKyAgICAgICAgVGhpcyB3YXMgb2J2aW91 c2x5IHVubmVjZXNzYXJ5LCBzaW5jZSB3ZSBhbHJlYWR5IGhhdmUgdGhlCisgICAgICAgIG11bHRp c2FtcGxlZCBGQk8gYW5kIGp1c3Qgd2FudCB0byBjb3B5IGl0LCBhcyBpcywgaW50byB0aGUgbGF5 ZXIuCisKKyAgICAgICAgTm93LCBpbnN0ZWFkIG9mIGNvcHlpbmcgdGhlIENHTFBpeGVsRm9ybWF0 T2JqLCB3ZSBjcmVhdGUKKyAgICAgICAgYSBuZXcgb25lIGFuZCBjb3B5IG1vc3Qgb2YgdGhlIGF0 dHJpYnV0ZXMsIGxlYXZpbmcgb3V0CisgICAgICAgIHRoZSBtdWx0aXNhbXBsZSBmbGFncyAoYW5k IHRoZSBkZXB0aCBidWZmZXIsIHNpbmNlIHdlJ3JlCisgICAgICAgIG9ubHkgZG9pbmcgMmQgYmxp dHMpLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgV2ViR0wgdGVzdHMsIHNpbmNlIHRo ZXJlIHNob3VsZCBiZSBubworICAgICAgICB2aXNpYmxlIGNoYW5nZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2NvY29hL1dlYkdMTGF5ZXIubW06CisgICAgICAgICgtW1dlYkdMTGF5 ZXIgY29weUNHTFBpeGVsRm9ybWF0Rm9yRGlzcGxheU1hc2s6XSk6IENyZWF0ZSBhIG5ldworICAg ICAgICBDR0xQaXhlbEZvcm1hdE9iaiB0aGF0IGNvcGllcyBtb3N0IG9mIHRoZSB2YWx1ZXMgZnJv bQorICAgICAgICB0aGUgY29ycmVzcG9uZGluZyBvYmplY3Qgb24gdGhlIFdlYkdMJ3MgYmFja2lu ZyBDR0xDb250ZXh0T2JqLgorCiAyMDE3LTA5LTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBBbGlnbiBGZXRjaFJlc3BvbnNlIGFuZCBGZXRjaFJlcXVlc3Qg Ym9keSBoYW5kbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY29jb2EvV2ViR0xMYXllci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NvY29hL1dlYkdMTGF5ZXIubW0KaW5kZXggYjEzNjgxZmRhNGU4Y2RiYzg0NjU1OWI4OTk2MGVk OTRjMTJhMDc2My4uMzZhN2M0OWJjZTFkMjYzZjRiY2QzOGUzMGZjNDhjMGJmM2QxZWU3NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvV2ViR0xMYXll ci5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9XZWJHTExh eWVyLm1tCkBAIC02MiwxNCArNjIsNDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAjaWYg IVBMQVRGT1JNKElPUykKIC0oQ0dMUGl4ZWxGb3JtYXRPYmopY29weUNHTFBpeGVsRm9ybWF0Rm9y RGlzcGxheU1hc2s6KHVpbnQzMl90KW1hc2sKIHsKLSAgICAvLyBGSVhNRTogVGhlIG1hc2sgcGFy YW0gdGVsbHMgeW91IHdoaWNoIGRpc3BsYXkgKG9uIGEgbXVsdGktZGlzcGxheSBzeXN0ZW0pCi0g ICAgLy8gaXMgdG8gYmUgdXNlZC4gQnV0IHNpbmNlIHdlIGFyZSBub3cgZ2V0dGluZyB0aGUgcGl4 ZWwgZm9ybWF0IGZyb20gdGhlCi0gICAgLy8gQ2FudmFzIENHTCBjb250ZXh0LCB3ZSBkb24ndCB1 c2UgaXQuIFRoaXMgc2VlbXMgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIG9uCi0gICAgLy8gb25lIG11 bHRpLWRpc3BsYXkgc3lzdGVtLiBCdXQgdGhlcmUgbWF5IGJlIGNhc2VzIHdoZXJlIHRoaXMgaXMg bm90IHRoZSBjYXNlLgotICAgIC8vIElmIG5lZWRlZCB3ZSB3aWxsIGhhdmUgdG8gc2V0IHRoZSBk aXNwbGF5IG1hc2sgaW4gdGhlIENhbnZhcyBDR0xDb250ZXh0IGFuZAotICAgIC8vIG1ha2Ugc3Vy ZSBpdCBtYXRjaGVzLgorICAgIC8vIFdlJ3JlIGJhc2ljYWxseSBjb3B5aW5nIHRoZSBwaXhlbCBm b3JtYXQgb2JqZWN0IGZyb20gdGhlIGV4aXN0aW5nCisgICAgLy8gV2ViR0wgY29udGV4dCwgc28g d2UgZG9uJ3QgbmVlZCB0byB1c2UgdGhlIGRpc3BsYXkgbWFzay4KICAgICBVTlVTRURfUEFSQU0o bWFzayk7Ci0gICAgcmV0dXJuIENHTFJldGFpblBpeGVsRm9ybWF0KENHTEdldFBpeGVsRm9ybWF0 KF9jb250ZXh0LT5wbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEKCkpKTsKKworICAgIENHTFBpeGVs Rm9ybWF0T2JqIHdlYmdsUGl4ZWxGb3JtYXQgPSBDR0xHZXRQaXhlbEZvcm1hdChfY29udGV4dC0+ cGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCgpKTsKKworICAgIFZlY3RvcjxDR0xQaXhlbEZvcm1h dEF0dHJpYnV0ZT4gYXR0cmliczsKKyAgICBHTGludCB2YWx1ZTsKKworICAgIENHTERlc2NyaWJl UGl4ZWxGb3JtYXQod2ViZ2xQaXhlbEZvcm1hdCwgMCwga0NHTFBGQUNvbG9yU2l6ZSwgJnZhbHVl KTsKKyAgICBhdHRyaWJzLmFwcGVuZChrQ0dMUEZBQ29sb3JTaXplKTsKKyAgICBhdHRyaWJzLmFw cGVuZChzdGF0aWNfY2FzdDxDR0xQaXhlbEZvcm1hdEF0dHJpYnV0ZT4odmFsdWUpKTsKKworICAg IC8vIFdlIGRvbid0IG5lZWQgdG8gc3BlY2lmeSBhIGRlcHRoIHNpemUgc2luY2Ugd2UncmUgb25s eQorICAgIC8vIHVzaW5nIHRoaXMgY29udGV4dCBhcyBhIDJkIGJsaXQgZGVzdGluYXRpb24gZm9y IHRoZSBXZWJHTCBGQk8uCisgICAgYXR0cmlicy5hcHBlbmQoa0NHTFBGQURlcHRoU2l6ZSk7Cisg ICAgYXR0cmlicy5hcHBlbmQoc3RhdGljX2Nhc3Q8Q0dMUGl4ZWxGb3JtYXRBdHRyaWJ1dGU+KDAp KTsKKworICAgIENHTERlc2NyaWJlUGl4ZWxGb3JtYXQod2ViZ2xQaXhlbEZvcm1hdCwgMCwga0NH TFBGQUFsbG93T2ZmbGluZVJlbmRlcmVycywgJnZhbHVlKTsKKyAgICBpZiAodmFsdWUpCisgICAg ICAgIGF0dHJpYnMuYXBwZW5kKGtDR0xQRkFBbGxvd09mZmxpbmVSZW5kZXJlcnMpOworCisgICAg Q0dMRGVzY3JpYmVQaXhlbEZvcm1hdCh3ZWJnbFBpeGVsRm9ybWF0LCAwLCBrQ0dMUEZBQWNjZWxl cmF0ZWQsICZ2YWx1ZSk7CisgICAgaWYgKHZhbHVlKQorICAgICAgICBhdHRyaWJzLmFwcGVuZChr Q0dMUEZBQWNjZWxlcmF0ZWQpOworCisgICAgQ0dMRGVzY3JpYmVQaXhlbEZvcm1hdCh3ZWJnbFBp eGVsRm9ybWF0LCAwLCBrQ0dMUEZBT3BlbkdMUHJvZmlsZSwgJnZhbHVlKTsKKyAgICBpZiAodmFs dWUpIHsKKyAgICAgICAgYXR0cmlicy5hcHBlbmQoa0NHTFBGQU9wZW5HTFByb2ZpbGUpOworICAg ICAgICBhdHRyaWJzLmFwcGVuZChzdGF0aWNfY2FzdDxDR0xQaXhlbEZvcm1hdEF0dHJpYnV0ZT4o dmFsdWUpKTsKKyAgICB9CisKKyAgICBhdHRyaWJzLmFwcGVuZChzdGF0aWNfY2FzdDxDR0xQaXhl bEZvcm1hdEF0dHJpYnV0ZT4oMCkpOworCisgICAgQ0dMUGl4ZWxGb3JtYXRPYmogcGl4ZWxGb3Jt YXQ7CisgICAgR0xpbnQgbnVtUGl4ZWxGb3JtYXRzID0gMDsKKyAgICBDR0xDaG9vc2VQaXhlbEZv cm1hdChhdHRyaWJzLmRhdGEoKSwgJnBpeGVsRm9ybWF0LCAmbnVtUGl4ZWxGb3JtYXRzKTsKKwor ICAgIEFTU0VSVChwaXhlbEZvcm1hdCk7CisgICAgQVNTRVJUKG51bVBpeGVsRm9ybWF0cyk7CisK KyAgICByZXR1cm4gcGl4ZWxGb3JtYXQ7CiB9CiAKIC0oQ0dMQ29udGV4dE9iailjb3B5Q0dMQ29u dGV4dEZvclBpeGVsRm9ybWF0OihDR0xQaXhlbEZvcm1hdE9iailwaXhlbEZvcm1hdAo=