17665 2008-03-03 23:31:24 -0800 determineSourceDir() dies if $sourceDir has a trailing backslash 2008-03-31 13:19:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P4 Normal --- 1 Dmitry.Kazachkov webkit-unassigned jchaffraix oldest_to_newest 72662 0 Dmitry.Kazachkov 2008-03-03 23:31:24 -0800 Linux: version 3.4.3 20041212 (Red Hat 3.4.3-9.EL4)) #1 SMP Wed Jan 5 19:30:39 EST 2005 Compiler: gcc (GCC) 3.4.3 20041212 (Red Hat 3.4.3-9.EL4) Product: WebKit nightly build (03.03.2008) Command: WebKit/WebKitTools/Scripts/build-webkit --qt What I got: "Could not find top level webkit directory above source directory using FindBin." Comment: The root cause is extra slash at the end of the path returned by FindBin. How to avoid: 1)open webkitdirs.pm (in the Scripts folder) 2) in the function determineSourceDir after line $sourceDir = $FindBin::Bin; insert $sourceDir=s|/$||; 75864 1 jchaffraix 2008-03-30 15:34:55 -0700 Confirming bug as it seems a pretty common issue with $FindBin. Switching it to "Tools / Tests". 75868 2 jchaffraix 2008-03-30 15:46:13 -0700 I should add that our code checks just after for s|/[^/]+$|| which will fail if $FindBin::Bin ends with a '/' (and this is the common issue I was mentioning). 75871 3 20225 jchaffraix 2008-03-30 16:24:03 -0700 Created attachment 20225 trivial fix 75874 4 20225 darin 2008-03-30 16:39:51 -0700 Comment on attachment 20225 trivial fix Seems like we should remove any number of trailing / characters, not just one, but the change seems fine. r=me 75975 5 jchaffraix 2008-03-31 13:19:19 -0700 Committed in r31469 with Darin's comment. 20225 2008-03-30 16:24:03 -0700 2008-03-30 16:39:51 -0700 trivial fix bug17665.patch text/plain 1272 jchaffraix ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0OTQ4YzJmLi42M2NiYmIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMt MzAgIEp1bGllbiBDaGFmZnJhaXggIDxqdWxpZW4uY2hhZmZyYWl4QGdtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMTc2NjU6IGRl dGVybWluZVNvdXJjZURpcigpIGRpZXMgaWYgJHNvdXJjZURpciBoYXMgYSB0cmFpbGluZyBiYWNr c2xhc2gKKworICAgICAgICBSZW1vdmUgdHJhaWxpbmcgJy8nIGluICRzb3VyY2VEaXIgaW4gZGV0 ZXJtaW5lU291cmNlRGlyKCkuCisKKyAgICAgICAgRml4IHN1Z2dlc3RlZCBieSBEbWl0cml5IEth emFjaGtvdi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKwogMjAwOC0wMy0y NiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgQW5kZXJzLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDQ0MDdhZjkuLjBlZTA1 NWUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTY1LDcgKzY1LDggQEAgc3ViIGRl dGVybWluZVNvdXJjZURpcgogewogICAgIHJldHVybiBpZiAkc291cmNlRGlyOwogICAgICRzb3Vy Y2VEaXIgPSAkRmluZEJpbjo6QmluOwotICAgIAorICAgICRzb3VyY2VEaXIgPX4gc3wvJHx8OyAj IFJlbW92ZSB0cmFpbGluZyAnLycgYXMgd2Ugd291bGQgZGllIGxhdGVyCisKICAgICAjIHdhbGtz IHVwIHBhdGggY2hlY2tpbmcgZWFjaCBkaXJlY3RvcnkgdG8gc2VlIGlmIGl0IGlzIHRoZSBtYWlu IFdlYktpdCBwcm9qZWN0IGRpciwgCiAgICAgIyBkZWZpbmVkIGJ5IGNvbnRhaW5pbmcgSmF2YVNj cmlwdENvcmUsIFdlYkNvcmUsIGFuZCBXZWJLaXQKICAgICB1bnRpbCAoKC1kICIkc291cmNlRGly L0phdmFTY3JpcHRDb3JlIiAmJiAtZCAiJHNvdXJjZURpci9XZWJDb3JlIiAmJiAtZCAiJHNvdXJj ZURpci9XZWJLaXQiKSB8fCAoLWQgIiRzb3VyY2VEaXIvSW50ZXJuYWwiICYmIC1kICIkc291cmNl RGlyL09wZW5Tb3VyY2UiKSkK