176646 2017-09-09 03:26:30 -0700 [GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline 2017-09-27 13:02:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan calvaris cgarcia eocanha webkit-bug-importer oldest_to_newest 1347079 0 zan 2017-09-09 03:26:30 -0700 [GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline 1347080 1 320340 zan 2017-09-09 03:31:16 -0700 Created attachment 320340 Patch 1347081 2 320340 cgarcia 2017-09-09 03:47:01 -0700 Comment on attachment 320340 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320340&action=review > Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:464 > + GRefPtr<GstPad> srcPad = adoptGRef(sinkPad ? gst_pad_get_peer(sinkPad.get()) : nullptr); adoptGref(nullptr) looks weird, I would write this as: GRefPtr<GstPad> srcPad = sinkPad ? adoptGRef(gst_pad_get_peer(sinkPad.get())) : nullptr; 1347084 3 zan 2017-09-09 05:38:51 -0700 Committed r221815: <http://trac.webkit.org/changeset/221815> 1353779 4 webkit-bug-importer 2017-09-27 13:02:14 -0700 <rdar://problem/34694520> 320340 2017-09-09 03:31:16 -0700 2017-09-09 03:47:01 -0700 Patch bug-176646-20170909123114.patch text/plain 3143 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxODA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWIxYzkxMzE4ZWNkYzJk Y2FiYjQ3YjBjNjE0ZWU4ZmEzMTczZmRkZC4uYTVhNTkyYzQ2ZGJjOTRiNDkyY2U5ZTE3ZmMwNjE0 MWQxM2JmMWMwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA5LTA5ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVyXSBN aXNzaW5nIEdSZWZQdHIgYWRvcHRpb25zIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJh c2UsIFBsYXliYWNrUGlwZWxpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NjY0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVnaXN0ZXJXZWJLaXRH U3RyZWFtZXJFbGVtZW50cyk6IEFkb3B0IHRoZSByZXR1cm4gdmFsdWUKKyAgICAgICAgb2YgZ3N0 X2VsZW1lbnRfZmFjdG9yeV9maW5kKCksIHdoaWNoIGlzIHRyYW5zZmVycmVkIGluIGZ1bGwuCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5l LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrUGlwZWxpbmU6OmZsdXNoKTogQWRvcHQg dGhlIHJldHVybiB2YWx1ZXMKKyAgICAgICAgb2YgZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQo KSBhbmQgZ3N0X3BhZF9nZXRfcGVlcigpLCBib3RoIGJlaW5nCisgICAgICAgIHRyYW5zZmVycmVk IGluIGZ1bGwuCisKIDIwMTctMDktMDggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXBsYWNlIEpTIGJ1aWx0aW4gaW1wbGVtZW50YXRpb24gb2YgdGhlIEZldGNoUmVz cG9uc2UgY29uc3RydWN0b3Igd2l0aCBhIEMrKyBvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAppbmRleCA4MTZiY2JiODU2Y2QwNzYw NDIzMzdkOGU5YzJlOWU3M2E0MDQ1N2U0Li43MmFhYjY3MDA5ZmE0OGNjNzQ1OGYyZmFhMjM2OGM3 NmI4ZDllYmNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n c3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2UuY3BwCkBAIC0xMzAsNyArMTMwLDcgQEAgdm9pZCByZWdpc3RlcldlYktpdEdT dHJlYW1lckVsZW1lbnRzKCkKICAgICBpZiAoIXdlYmtpdEdzdENoZWNrVmVyc2lvbigxLCA2LCAx KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgR1JlZlB0cjxHc3RFbGVtZW50RmFjdG9yeT4gY2xl YXJLZXlEZWNyeXB0b3JGYWN0b3J5ID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9maW5kKCJ3ZWJraXRj bGVhcmtleSIpOworICAgIEdSZWZQdHI8R3N0RWxlbWVudEZhY3Rvcnk+IGNsZWFyS2V5RGVjcnlw dG9yRmFjdG9yeSA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9mYWN0b3J5X2ZpbmQoIndlYmtpdGNs ZWFya2V5IikpOwogICAgIGlmICghY2xlYXJLZXlEZWNyeXB0b3JGYWN0b3J5KQogICAgICAgICBn c3RfZWxlbWVudF9yZWdpc3RlcihudWxscHRyLCAid2Via2l0Y2xlYXJrZXkiLCBHU1RfUkFOS19Q UklNQVJZICsgMTAwLCBXRUJLSVRfVFlQRV9NRURJQV9DS19ERUNSWVBUKTsKICNlbmRpZgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9Q bGF5YmFja1BpcGVsaW5lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9tc2UvUGxheWJhY2tQaXBlbGluZS5jcHAKaW5kZXggM2ZlNjJjZjU5NzNmNDVkYzU2 ZjNlNjUyNmM4NGVjMDM5OWI0OTg5NC4uZjkyMDY4ZWZjYjA2MjczOGJhNWFjYWNiNThhYWUyZWMz MGEwNmE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL21zZS9QbGF5YmFja1BpcGVsaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1BsYXliYWNrUGlwZWxpbmUuY3BwCkBAIC00NjAs OCArNDYwLDggQEAgdm9pZCBQbGF5YmFja1BpcGVsaW5lOjpmbHVzaChBdG9taWNTdHJpbmcgdHJh Y2tJZCkKICAgICBnc3Rfc2VnbWVudF9kb19zZWVrKHNlZ21lbnQuZ2V0KCksIHJhdGUsIEdTVF9G T1JNQVRfVElNRSwgR1NUX1NFRUtfRkxBR19OT05FLAogICAgICAgICBHU1RfU0VFS19UWVBFX1NF VCwgcG9zaXRpb24sIEdTVF9TRUVLX1RZUEVfU0VULCBzdG9wLCBudWxscHRyKTsKIAotICAgIEdS ZWZQdHI8R3N0UGFkPiBzaW5rUGFkID0gZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQoYXBwc3Jj LCAic3JjIik7Ci0gICAgR1JlZlB0cjxHc3RQYWQ+IHNyY1BhZCA9IHNpbmtQYWQgPyBnc3RfcGFk X2dldF9wZWVyKHNpbmtQYWQuZ2V0KCkpIDogbnVsbHB0cjsKKyAgICBHUmVmUHRyPEdzdFBhZD4g c2lua1BhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChhcHBzcmMsICJz cmMiKSk7CisgICAgR1JlZlB0cjxHc3RQYWQ+IHNyY1BhZCA9IGFkb3B0R1JlZihzaW5rUGFkID8g Z3N0X3BhZF9nZXRfcGVlcihzaW5rUGFkLmdldCgpKSA6IG51bGxwdHIpOwogICAgIGlmIChzcmNQ YWQpCiAgICAgICAgIGdzdF9wYWRfYWRkX3Byb2JlKHNyY1BhZC5nZXQoKSwgR1NUX1BBRF9QUk9C RV9UWVBFX0VWRU5UX0RPV05TVFJFQU0sIHNlZ21lbnRGaXhlclByb2JlLCBudWxscHRyLCBudWxs cHRyKTsKIAo=