176639 2017-09-08 17:07:42 -0700 QualifiedName::init should assume AtomicStrings::init was already called 2017-09-27 12:33:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen ap benjamin buildbot cdumez cmarcelo commit-queue dbates esprehn+autocc joepeck kangil.han sam webkit-bug-importer oldest_to_newest 1347004 0 joepeck 2017-09-08 17:07:42 -0700 QualifiedName::init should assume AtomicStrings::init was already called All clients of QualifiedName::init() already call AtomicString::init(), QualifiedName doesn't need to do it itself. $ ack 'QualifiedName::init' -B 2 WebKit/UIProcess/API/APIContentRuleListStore.cpp 429-{ 430- AtomicString::init(); 431: WebCore::QualifiedName::init(); WebCore/page/Frame.cpp 174- AtomicString::init(); 175- HTMLNames::init(); 176: QualifiedName::init(); WebCore/contentextensions/ContentExtensionParser.cpp 235-{ 236- AtomicString::init(); 237: QualifiedName::init(); 1347005 1 320317 joepeck 2017-09-08 17:10:02 -0700 Created attachment 320317 [PATCH] Proposed Fix 1347006 2 320317 joepeck 2017-09-08 17:10:26 -0700 Comment on attachment 320317 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=320317&action=review > Source/WebCore/ChangeLog:10 > + All callers of QualifiedName::init preceed it with their own call to Typo: preceed => precede 1347009 3 320318 joepeck 2017-09-08 17:10:59 -0700 Created attachment 320318 [PATCH] Proposed Fix 1347019 4 320318 sam 2017-09-08 17:46:52 -0700 Comment on attachment 320318 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=320318&action=review > Source/WebCore/dom/QualifiedName.cpp:-48 > - AtomicString::init(); Can we assert this instead? 1347020 5 320318 joepeck 2017-09-08 17:48:20 -0700 Comment on attachment 320318 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=320318&action=review >> Source/WebCore/dom/QualifiedName.cpp:-48 >> - AtomicString::init(); > > Can we assert this instead? The next line uses nullAtom / starAtom which will assert if AtomicString::init has not happened. I figured that was enough, albeit a little obtuse. 1347040 6 sam 2017-09-08 20:05:38 -0700 (In reply to Joseph Pecoraro from comment #5) > Comment on attachment 320318 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320318&action=review > > >> Source/WebCore/dom/QualifiedName.cpp:-48 > >> - AtomicString::init(); > > > > Can we assert this instead? > > The next line uses nullAtom / starAtom which will assert if > AtomicString::init has not happened. I figured that was enough, albeit a > little obtuse. Seems like an explicit assert would document intent much better. 1347678 7 320489 joepeck 2017-09-11 15:29:56 -0700 Created attachment 320489 [PATCH] Proposed Fix 1347742 8 320489 joepeck 2017-09-11 17:08:29 -0700 Comment on attachment 320489 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=320489&action=review > Source/WTF/wtf/NeverDestroyed.h:114 > + bool isConstructed() const { return m_isConstructed; } Needs !ASSERT_DISABLED like the member. 1347743 9 320508 joepeck 2017-09-11 17:09:53 -0700 Created attachment 320508 [PATCH] Proposed Fix 1348125 10 320508 commit-queue 2017-09-12 17:31:23 -0700 Comment on attachment 320508 [PATCH] Proposed Fix Clearing flags on attachment: 320508 Committed r221951: <http://trac.webkit.org/changeset/221951> 1348126 11 commit-queue 2017-09-12 17:31:24 -0700 All reviewed patches have been landed. Closing bug. 1353475 12 webkit-bug-importer 2017-09-27 12:33:41 -0700 <rdar://problem/34693488> 320317 2017-09-08 17:10:02 -0700 2017-09-08 17:10:59 -0700 [PATCH] Proposed Fix qualified-name-1.patch text/plain 1263 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDc5YTZlNjdhMS4uYmMwNjdmODUyOTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0wOS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIFF1YWxpZmllZE5hbWU6OmluaXQgc2hvdWxkIGFzc3VtZSBBdG9taWNT dHJpbmdzOjppbml0IHdhcyBhbHJlYWR5IGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vUXVhbGlmaWVkTmFtZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpRdWFsaWZpZWROYW1lOjppbml0KToKKyAgICAgICAgQWxsIGNhbGxlcnMgb2Yg UXVhbGlmaWVkTmFtZTo6aW5pdCBwcmVjZWVkIGl0IHdpdGggdGhlaXIgb3duIGNhbGwgdG8KKyAg ICAgICAgQXRvbWljU3RyaW5nOjppbml0LCBzbyBRdWFsaWZpZWROYW1lIGRvZXNuJ3QgbmVlZCB0 byBkbyBpdC4KKworMjAxNy0wOS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCiAgICAgICAgIEZldGNoJ3MgUmVzcG9uc2Uuc3RhdHVzVGV4dCBpcyB1bmV4cGVjdGVk bHkgdGhlIGZ1bGwgaHR0cCBzdGF0dXMgbGluZSBmb3IgSFRUUC8yIHJlc3BvbnNlcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDc5CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcAppbmRleCAyYzQ2MzAzNjI2OS4uMGU5YzE5NWJiNTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vUXVhbGlmaWVkTmFtZS5jcHAKQEAgLTQ1LDcgKzQ1LDYgQEAgdm9p ZCBRdWFsaWZpZWROYW1lOjppbml0KCkKICAgICBpZiAoaW5pdGlhbGl6ZWQpCiAgICAgICAgIHJl dHVybjsKIAotICAgIEF0b21pY1N0cmluZzo6aW5pdCgpOwogICAgIGFueU5hbWUuY29uc3RydWN0 KG51bGxBdG9tKCksIHN0YXJBdG9tKCksIHN0YXJBdG9tKCkpOwogICAgIGluaXRpYWxpemVkID0g dHJ1ZTsKIH0K 320318 2017-09-08 17:10:59 -0700 2017-09-11 15:29:56 -0700 [PATCH] Proposed Fix qualified-name-2.patch text/plain 1263 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZDc5YTZlNjdhMS4uMjNiMDE2NmI1MWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0wOS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIFF1YWxpZmllZE5hbWU6OmluaXQgc2hvdWxkIGFzc3VtZSBBdG9taWNT dHJpbmdzOjppbml0IHdhcyBhbHJlYWR5IGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vUXVhbGlmaWVkTmFtZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpRdWFsaWZpZWROYW1lOjppbml0KToKKyAgICAgICAgQWxsIGNhbGxlcnMgb2Yg UXVhbGlmaWVkTmFtZTo6aW5pdCBwcmVjZWRlIGl0IHdpdGggdGhlaXIgb3duIGNhbGwgdG8KKyAg ICAgICAgQXRvbWljU3RyaW5nOjppbml0LCBzbyBRdWFsaWZpZWROYW1lIGRvZXNuJ3QgbmVlZCB0 byBkbyBpdC4KKworMjAxNy0wOS0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCiAgICAgICAgIEZldGNoJ3MgUmVzcG9uc2Uuc3RhdHVzVGV4dCBpcyB1bmV4cGVjdGVk bHkgdGhlIGZ1bGwgaHR0cCBzdGF0dXMgbGluZSBmb3IgSFRUUC8yIHJlc3BvbnNlcwogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDc5CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcAppbmRleCAyYzQ2MzAzNjI2OS4uMGU5YzE5NWJiNTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vUXVhbGlmaWVkTmFtZS5jcHAKQEAgLTQ1LDcgKzQ1LDYgQEAgdm9p ZCBRdWFsaWZpZWROYW1lOjppbml0KCkKICAgICBpZiAoaW5pdGlhbGl6ZWQpCiAgICAgICAgIHJl dHVybjsKIAotICAgIEF0b21pY1N0cmluZzo6aW5pdCgpOwogICAgIGFueU5hbWUuY29uc3RydWN0 KG51bGxBdG9tKCksIHN0YXJBdG9tKCksIHN0YXJBdG9tKCkpOwogICAgIGluaXRpYWxpemVkID0g dHJ1ZTsKIH0K 320489 2017-09-11 15:29:56 -0700 2017-09-11 17:09:53 -0700 [PATCH] Proposed Fix v2.patch text/plain 2316 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYWY4NWY1ZjNjZDQuLmRiNGVmOWQ0MDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3 LTA5LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAg UXVhbGlmaWVkTmFtZTo6aW5pdCBzaG91bGQgYXNzdW1lIEF0b21pY1N0cmluZ3M6OmluaXQgd2Fz IGFscmVhZHkgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzY2MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9OZXZlckRlc3Ryb3llZC5oOgorICAgICAgICAoV1RGOjpMYXp5TmV2ZXJE ZXN0cm95ZWQ6OmlzQ29uc3RydWN0ZWQgY29uc3QpOgorCiAyMDE3LTA5LTAzICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkddIE9wdGltaXplIFdl YWtNYXA6OmdldCBieSBhZGRpbmcgaW50cmluc2ljIGFuZCBmaXh1cApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaCBiL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJv eWVkLmgKaW5kZXggYzJiNDg0MmQxMmQuLjZiOGU5YzRjODUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJv eWVkLmgKQEAgLTExMSw2ICsxMTEsOCBAQCBwdWJsaWM6CiAKICAgICBjb25zdCBUKiBvcGVyYXRv ci0+KCkgY29uc3QgeyByZXR1cm4gc3RvcmFnZVBvaW50ZXIoKTsgfQogCisgICAgYm9vbCBpc0Nv bnN0cnVjdGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc0NvbnN0cnVjdGVkOyB9CisKIHByaXZhdGU6 CiAgICAgdXNpbmcgUG9pbnRlclR5cGUgPSB0eXBlbmFtZSBzdGQ6OnJlbW92ZV9jb25zdDxUPjo6 dHlwZSo7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMTAwNmQyMmFjZS4uOGU3ZWYyYmZjMTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wOS0xMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgorCisgICAgICAgIFF1YWxpZmllZE5hbWU6OmluaXQgc2hvdWxkIGFzc3Vt ZSBBdG9taWNTdHJpbmdzOjppbml0IHdhcyBhbHJlYWR5IGNhbGxlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjM5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkb20vUXVhbGlmaWVkTmFtZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpRdWFsaWZpZWROYW1lOjppbml0KToKKyAgICAgICAgQWxsIGNh bGxlcnMgb2YgUXVhbGlmaWVkTmFtZTo6aW5pdCBwcmVjZWRlIGl0IHdpdGggdGhlaXIgb3duIGNh bGwgdG8KKyAgICAgICAgQXRvbWljU3RyaW5nOjppbml0LCBzbyBRdWFsaWZpZWROYW1lIGRvZXNu J3QgbmVlZCB0byBkbyBpdC4KKwogMjAxNy0wOS0xMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYkdMIG1hY09TXSBObyBuZWVkIHRvIG11bHRpc2FtcGxlIHdo ZW4gYmxpdHRpbmcgaW50byBXZWJHTExheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vUXVhbGlmaWVkTmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vUXVhbGlmaWVkTmFtZS5j cHAKaW5kZXggMmM0NjMwMzYyNjkuLmNiMDU0YzdiNTFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vUXVhbGlmaWVkTmFtZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1F1YWxp ZmllZE5hbWUuY3BwCkBAIC00NSw3ICs0NSw3IEBAIHZvaWQgUXVhbGlmaWVkTmFtZTo6aW5pdCgp CiAgICAgaWYgKGluaXRpYWxpemVkKQogICAgICAgICByZXR1cm47CiAKLSAgICBBdG9taWNTdHJp bmc6OmluaXQoKTsKKyAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKFdURjo6bnVsbEF0b21EYXRhLmlz Q29uc3RydWN0ZWQoKSwgIkF0b21pY1N0cmluZzo6aW5pdCBzaG91bGQgaGF2ZSBiZWVuIGNhbGxl ZCIpOwogICAgIGFueU5hbWUuY29uc3RydWN0KG51bGxBdG9tKCksIHN0YXJBdG9tKCksIHN0YXJB dG9tKCkpOwogICAgIGluaXRpYWxpemVkID0gdHJ1ZTsKIH0K 320508 2017-09-11 17:09:53 -0700 2017-09-12 17:31:23 -0700 [PATCH] Proposed Fix init-3.patch text/plain 2347 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggYWY4NWY1ZjNjZDQuLmRiNGVmOWQ0MDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3 LTA5LTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAg UXVhbGlmaWVkTmFtZTo6aW5pdCBzaG91bGQgYXNzdW1lIEF0b21pY1N0cmluZ3M6OmluaXQgd2Fz IGFscmVhZHkgY2FsbGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzY2MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9OZXZlckRlc3Ryb3llZC5oOgorICAgICAgICAoV1RGOjpMYXp5TmV2ZXJE ZXN0cm95ZWQ6OmlzQ29uc3RydWN0ZWQgY29uc3QpOgorCiAyMDE3LTA5LTAzICBZdXN1a2UgU3V6 dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtERkddIE9wdGltaXplIFdl YWtNYXA6OmdldCBieSBhZGRpbmcgaW50cmluc2ljIGFuZCBmaXh1cApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvTmV2ZXJEZXN0cm95ZWQuaCBiL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJv eWVkLmgKaW5kZXggYzJiNDg0MmQxMmQuLmIyM2FmMDAwOGI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V1RGL3d0Zi9OZXZlckRlc3Ryb3llZC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL05ldmVyRGVzdHJv eWVkLmgKQEAgLTExMSw2ICsxMTEsMTAgQEAgcHVibGljOgogCiAgICAgY29uc3QgVCogb3BlcmF0 b3ItPigpIGNvbnN0IHsgcmV0dXJuIHN0b3JhZ2VQb2ludGVyKCk7IH0KIAorI2lmICFBU1NFUlRf RElTQUJMRUQKKyAgICBib29sIGlzQ29uc3RydWN0ZWQoKSBjb25zdCB7IHJldHVybiBtX2lzQ29u c3RydWN0ZWQ7IH0KKyNlbmRpZgorCiBwcml2YXRlOgogICAgIHVzaW5nIFBvaW50ZXJUeXBlID0g dHlwZW5hbWUgc3RkOjpyZW1vdmVfY29uc3Q8VD46OnR5cGUqOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzEw MDZkMjJhY2UuLjhlN2VmMmJmYzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTct MDktMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBR dWFsaWZpZWROYW1lOjppbml0IHNob3VsZCBhc3N1bWUgQXRvbWljU3RyaW5nczo6aW5pdCB3YXMg YWxyZWFkeSBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NjYzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogZG9tL1F1YWxpZmllZE5hbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVhbGlm aWVkTmFtZTo6aW5pdCk6CisgICAgICAgIEFsbCBjYWxsZXJzIG9mIFF1YWxpZmllZE5hbWU6Omlu aXQgcHJlY2VkZSBpdCB3aXRoIHRoZWlyIG93biBjYWxsIHRvCisgICAgICAgIEF0b21pY1N0cmlu Zzo6aW5pdCwgc28gUXVhbGlmaWVkTmFtZSBkb2Vzbid0IG5lZWQgdG8gZG8gaXQuCisKIDIwMTct MDktMTEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHTCBt YWNPU10gTm8gbmVlZCB0byBtdWx0aXNhbXBsZSB3aGVuIGJsaXR0aW5nIGludG8gV2ViR0xMYXll cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3BwCmluZGV4IDJjNDYzMDM2MjY5Li5jYjA1 NGM3YjUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1F1YWxpZmllZE5hbWUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9RdWFsaWZpZWROYW1lLmNwcApAQCAtNDUsNyArNDUs NyBAQCB2b2lkIFF1YWxpZmllZE5hbWU6OmluaXQoKQogICAgIGlmIChpbml0aWFsaXplZCkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgQXRvbWljU3RyaW5nOjppbml0KCk7CisgICAgQVNTRVJUX1dJ VEhfTUVTU0FHRShXVEY6Om51bGxBdG9tRGF0YS5pc0NvbnN0cnVjdGVkKCksICJBdG9taWNTdHJp bmc6OmluaXQgc2hvdWxkIGhhdmUgYmVlbiBjYWxsZWQiKTsKICAgICBhbnlOYW1lLmNvbnN0cnVj dChudWxsQXRvbSgpLCBzdGFyQXRvbSgpLCBzdGFyQXRvbSgpKTsKICAgICBpbml0aWFsaXplZCA9 IHRydWU7CiB9Cg==