176638 2017-09-08 16:48:28 -0700 [Cocoa] Add a modern WKPreferences switch to disable WebRTC 2017-09-26 16:35:46 -0700 1 1 1 Unclassified WebKit WebKit API Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz youennf achristensen commit-queue thorton youennf oldest_to_newest 1347000 0 mitz 2017-09-08 16:48:28 -0700 <rdar://problem/34335158> We should have a modern equivalent of WKPreferencesSetPeerConnectionEnabled. 1352760 1 321846 youennf 2017-09-26 11:15:30 -0700 Created attachment 321846 Patch 1352773 2 321846 thorton 2017-09-26 11:44:45 -0700 Comment on attachment 321846 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=321846&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:105 > +@property (nonatomic, setter=_setPeerConnectionEnabled:) BOOL _peerConnectionEnabled WK_API_AVAILABLE(macosx(10.13), ios(11.0)); Given that they have shipped, I don't think this can possibly be available in 10.13 or 11.0. Use the WK_TBA magic. 1352774 3 321852 youennf 2017-09-26 11:47:50 -0700 Created attachment 321852 Patch 1352907 4 321852 commit-queue 2017-09-26 16:35:44 -0700 Comment on attachment 321852 Patch Clearing flags on attachment: 321852 Committed r222533: <http://trac.webkit.org/changeset/222533> 1352908 5 commit-queue 2017-09-26 16:35:46 -0700 All reviewed patches have been landed. Closing bug. 321846 2017-09-26 11:15:30 -0700 2017-09-26 11:47:49 -0700 Patch bug-176638-20170926111529.patch text/plain 2735 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRlNmI2MjM0MmZhMGZlYjFm ZWI2ZDg1YzVjZmYxMWFmMDE0YzM0ODguLmY5OWYzMTFlYTliMTFlZTRlYTU4Yjg3MzZmMDZmNGYy ZTBjYzk1MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDktMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gQWRkIGEgbW9kZXJu IFdLUHJlZmVyZW5jZXMgc3dpdGNoIHRvIGRpc2FibGUgV2ViUlRDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY2MzgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM0MzM1MTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIF9wZWVyQ29ubmVjdGlvbkVuYWJsZWRdKToKKyAgICAgICAgKC1b V0tQcmVmZXJlbmNlcyBfc2V0UGVlckNvbm5lY3Rpb25FbmFibGVkOl0pOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaDoKKwogMjAxNy0wOS0yMiAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xvc2UgV2ViUlRD IHNvY2tldHMgd2hlbiBtYXJrZWQgYXMgZGVmdW5jdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQppbmRleCBhYTg3MTI4NzNmZWRmZjIx ZDk1MmEyYmJhYzQxY2EzOGFiMDgyY2VhLi44MDRiNDY4YmRkYzNhMDAzMTcxYTY1MDM0OTJiZjBh NTU3NmI3YWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQpAQCAtNTYyLDYgKzU2MiwxNiBAQCAtICh2b2lkKV9zZXRMb2Fkc0lt YWdlc0F1dG9tYXRpY2FsbHk6KEJPT0wpbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5CiAgICAgX3By ZWZlcmVuY2VzLT5zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkobG9hZHNJbWFnZXNBdXRvbWF0 aWNhbGx5KTsKIH0KIAorLSAoQk9PTClfcGVlckNvbm5lY3Rpb25FbmFibGVkCit7CisgICAgcmV0 dXJuIF9wcmVmZXJlbmNlcy0+cGVlckNvbm5lY3Rpb25FbmFibGVkKCk7Cit9CisKKy0gKHZvaWQp X3NldFBlZXJDb25uZWN0aW9uRW5hYmxlZDooQk9PTCllbmFibGVkCit7CisgICAgX3ByZWZlcmVu Y2VzLT5zZXRQZWVyQ29ubmVjdGlvbkVuYWJsZWQoZW5hYmxlZCk7Cit9CisKIC0gKEJPT0wpX21l ZGlhRGV2aWNlc0VuYWJsZWQKIHsKICAgICByZXR1cm4gX3ByZWZlcmVuY2VzLT5tZWRpYURldmlj ZXNFbmFibGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmluZGV4IGJiNzFmZWE1YzcyOGNmMDNhNWJkN2Ri N2M0MzQwODhmYWRmYmQ1MmUuLjQ0NDQ4NDg2M2NlNjgwYjAxM2JjNDI2MTczMzEzMzY3ZGNiYzM1 ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZl cmVuY2VzUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzUHJpdmF0ZS5oCkBAIC0xMDIsNiArMTAyLDcgQEAgdHlwZWRlZiBOU19PUFRJ T05TKE5TVUludGVnZXIsIF9XS0phdmFTY3JpcHRSdW50aW1lRmxhZ3MpIHsKIAogQHByb3BlcnR5 IChub25hdG9taWMsIHNldHRlcj1fc2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5OikgQk9PTCBf bG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwg aW9zKDExLjApKTsKIAorQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0UGVlckNvbm5l Y3Rpb25FbmFibGVkOikgQk9PTCBfcGVlckNvbm5lY3Rpb25FbmFibGVkIFdLX0FQSV9BVkFJTEFC TEUobWFjb3N4KDEwLjEzKSwgaW9zKDExLjApKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0 ZXI9X3NldE1lZGlhRGV2aWNlc0VuYWJsZWQ6KSBCT09MIF9tZWRpYURldmljZXNFbmFibGVkIFdL X0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwgaW9zKDExLjApKTsKIEBwcm9wZXJ0eSAobm9u YXRvbWljLCBzZXR0ZXI9X3NldE1vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQ6KSBCT09MIF9tb2Nr Q2FwdHVyZURldmljZXNFbmFibGVkIFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwgaW9z KDExLjApKTsKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBzZXR0ZXI9X3NldE1vY2tDYXB0dXJlRGV2 aWNlc1Byb21wdEVuYWJsZWQ6KSBCT09MIF9tb2NrQ2FwdHVyZURldmljZXNQcm9tcHRFbmFibGVk IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwo= 321852 2017-09-26 11:47:50 -0700 2017-09-26 16:35:44 -0700 Patch bug-176638-20170926114749.patch text/plain 2746 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRlNmI2MjM0MmZhMGZlYjFm ZWI2ZDg1YzVjZmYxMWFmMDE0YzM0ODguLmY5OWYzMTFlYTliMTFlZTRlYTU4Yjg3MzZmMDZmNGYy ZTBjYzk1MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDktMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gQWRkIGEgbW9kZXJu IFdLUHJlZmVyZW5jZXMgc3dpdGNoIHRvIGRpc2FibGUgV2ViUlRDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY2MzgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzM0MzM1MTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZlcmVuY2VzLm1tOgorICAgICAg ICAoLVtXS1ByZWZlcmVuY2VzIF9wZWVyQ29ubmVjdGlvbkVuYWJsZWRdKToKKyAgICAgICAgKC1b V0tQcmVmZXJlbmNlcyBfc2V0UGVlckNvbm5lY3Rpb25FbmFibGVkOl0pOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaDoKKwogMjAxNy0wOS0yMiAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xvc2UgV2ViUlRD IHNvY2tldHMgd2hlbiBtYXJrZWQgYXMgZGVmdW5jdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLUHJlZmVyZW5jZXMubW0gYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tQcmVmZXJlbmNlcy5tbQppbmRleCBhYTg3MTI4NzNmZWRmZjIx ZDk1MmEyYmJhYzQxY2EzOGFiMDgyY2VhLi44MDRiNDY4YmRkYzNhMDAzMTcxYTY1MDM0OTJiZjBh NTU3NmI3YWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tQcmVmZXJlbmNlcy5tbQpAQCAtNTYyLDYgKzU2MiwxNiBAQCAtICh2b2lkKV9zZXRMb2Fkc0lt YWdlc0F1dG9tYXRpY2FsbHk6KEJPT0wpbG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5CiAgICAgX3By ZWZlcmVuY2VzLT5zZXRMb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkobG9hZHNJbWFnZXNBdXRvbWF0 aWNhbGx5KTsKIH0KIAorLSAoQk9PTClfcGVlckNvbm5lY3Rpb25FbmFibGVkCit7CisgICAgcmV0 dXJuIF9wcmVmZXJlbmNlcy0+cGVlckNvbm5lY3Rpb25FbmFibGVkKCk7Cit9CisKKy0gKHZvaWQp X3NldFBlZXJDb25uZWN0aW9uRW5hYmxlZDooQk9PTCllbmFibGVkCit7CisgICAgX3ByZWZlcmVu Y2VzLT5zZXRQZWVyQ29ubmVjdGlvbkVuYWJsZWQoZW5hYmxlZCk7Cit9CisKIC0gKEJPT0wpX21l ZGlhRGV2aWNlc0VuYWJsZWQKIHsKICAgICByZXR1cm4gX3ByZWZlcmVuY2VzLT5tZWRpYURldmlj ZXNFbmFibGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tQcmVmZXJlbmNlc1ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9D b2NvYS9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oCmluZGV4IGJiNzFmZWE1YzcyOGNmMDNhNWJkN2Ri N2M0MzQwODhmYWRmYmQ1MmUuLmYxOGIwMDYyM2JjZGE5ZTI3OGY1YTIyNTEwZDdmYjgxMDFmYjUz MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1ByZWZl cmVuY2VzUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1ByZWZlcmVuY2VzUHJpdmF0ZS5oCkBAIC0xMDIsNiArMTAyLDcgQEAgdHlwZWRlZiBOU19PUFRJ T05TKE5TVUludGVnZXIsIF9XS0phdmFTY3JpcHRSdW50aW1lRmxhZ3MpIHsKIAogQHByb3BlcnR5 IChub25hdG9taWMsIHNldHRlcj1fc2V0TG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5OikgQk9PTCBf bG9hZHNJbWFnZXNBdXRvbWF0aWNhbGx5IFdLX0FQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEzKSwg aW9zKDExLjApKTsKIAorQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0UGVlckNvbm5l Y3Rpb25FbmFibGVkOikgQk9PTCBfcGVlckNvbm5lY3Rpb25FbmFibGVkIFdLX0FQSV9BVkFJTEFC TEUobWFjb3N4KFdLX01BQ19UQkEpLCBpb3MoV0tfSU9TX1RCQSkpOwogQHByb3BlcnR5IChub25h dG9taWMsIHNldHRlcj1fc2V0TWVkaWFEZXZpY2VzRW5hYmxlZDopIEJPT0wgX21lZGlhRGV2aWNl c0VuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTMpLCBpb3MoMTEuMCkpOwogQHBy b3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0TW9ja0NhcHR1cmVEZXZpY2VzRW5hYmxlZDop IEJPT0wgX21vY2tDYXB0dXJlRGV2aWNlc0VuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3go MTAuMTMpLCBpb3MoMTEuMCkpOwogQHByb3BlcnR5IChub25hdG9taWMsIHNldHRlcj1fc2V0TW9j a0NhcHR1cmVEZXZpY2VzUHJvbXB0RW5hYmxlZDopIEJPT0wgX21vY2tDYXB0dXJlRGV2aWNlc1By b21wdEVuYWJsZWQgV0tfQVBJX0FWQUlMQUJMRShtYWNvc3goV0tfTUFDX1RCQSksIGlvcyhXS19J T1NfVEJBKSk7Cg==