176630 2017-09-08 13:55:48 -0700 REGRESSION: 3 stress/op_mod (and op_div) tests timing out on Debug JSC bots 2017-09-27 12:33:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad mark.lam ap jfbastien jlewis3 mark.lam webkit-bug-importer oldest_to_newest 1346940 0 ryanhaddad 2017-09-08 13:55:48 -0700 ** The following JSC stress test failures have been introduced: stress/op_mod-ConstVar.js.misc-ftl-no-cjit stress/op_mod-VarConst.js.misc-ftl-no-cjit stress/op_mod-VarVar.js.misc-ftl-no-cjit https://build.webkit.org/builders/Apple%20Sierra%20Debug%20JSC%20%28Tests%29/builds/971 1346945 1 ryanhaddad 2017-09-08 14:00:18 -0700 Looking at the regression range, this may be related to https://trac.webkit.org/changeset/221774/webkit 1346947 2 ryanhaddad 2017-09-08 14:00:50 -0700 (In reply to Ryan Haddad from comment #1) > Looking at the regression range, this may be related to > https://trac.webkit.org/changeset/221774/webkit *The regression range being r221773 - r221779 1347116 3 mark.lam 2017-09-09 09:51:20 -0700 I'll break these tests into smaller chunks. 1347924 4 ryanhaddad 2017-09-12 09:31:27 -0700 The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20%28BuildAndTest%29/builds/1476 1347942 5 mark.lam 2017-09-12 09:50:06 -0700 (In reply to Ryan Haddad from comment #4) > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > bit%20JSC%20%28BuildAndTest%29/builds/1476 These are for op_div (not op_mod). Anyway, let me trying increasing their timeout allowance and see if that helps. 1347955 6 ryanhaddad 2017-09-12 10:18:42 -0700 (In reply to Mark Lam from comment #5) > (In reply to Ryan Haddad from comment #4) > > The tests are timing out on El Capitan 32-bit (but not Sierra 32-bit): > > https://build.webkit.org/builders/Apple%20El%20Capitan%2032- > > bit%20JSC%20%28BuildAndTest%29/builds/1476 > > These are for op_div (not op_mod). Anyway, let me trying increasing their > timeout allowance and see if that helps. Oops, sorry for missing that detail. 1347992 7 320562 mark.lam 2017-09-12 12:42:57 -0700 Created attachment 320562 proposed patch. 1347993 8 320562 jfbastien 2017-09-12 12:44:17 -0700 Comment on attachment 320562 proposed patch. r=me 1347995 9 mark.lam 2017-09-12 12:47:35 -0700 Thanks for the review. Landed in r221935: <http://trac.webkit.org/r221935>. 1353478 10 webkit-bug-importer 2017-09-27 12:33:53 -0700 <rdar://problem/34693492> 320562 2017-09-12 12:42:57 -0700 2017-09-12 12:44:17 -0700 proposed patch. bug-176630.patch text/plain 4072 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjE5MzMpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDIzIEBACisyMDE3LTA5LTEyICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiAzIHN0cmVzcy9vcF9tb2QgKGFuZCBvcF9kaXYpIHRl c3RzIHRpbWluZyBvdXQgb24gRGVidWcgSlNDIGJvdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzY2MzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWJ1ZyBidWlsZHMgYXJlIGp1c3Qgc2xvdywgYW5k IHRoZXNlIHRlc3RzIGRvIGEgbG90LiAgVGhleSBwYXNzIHdoZW4gSSBydW4gdGhlbQorICAgICAg ICBsb2NhbGx5IG9uIG15IE1hY0Jvb2sgUHJvLiAgU28sIEknbSBidW1waW5nIHRoZWlyIHRpbWlu ZyBtdWx0aXBsaWVyIHRvIDIuMHggYXMKKyAgICAgICAgYSBzcGVjdWxhdGl2ZSBmaXggZm9yIHRo ZSBib3RzIHRoYXQgYXJlIHNlZWluZyB0aGVzZSBmYWlsLgorCisgICAgICAgIEkgYWxzbyB1bmRp ZCB0aGUgc2tpcHBpbmcgb2YgdGhlIG9wX21vZCB0ZXN0cyBmb3IgZGVidWcgYnVpbGRzLgorCisg ICAgICAgICogc3RyZXNzL29wX2Rpdi1Db25zdFZhci5qczoKKyAgICAgICAgKiBzdHJlc3Mvb3Bf ZGl2LVZhckNvbnN0LmpzOgorICAgICAgICAqIHN0cmVzcy9vcF9kaXYtVmFyVmFyLmpzOgorICAg ICAgICAqIHN0cmVzcy9vcF9tb2QtQ29uc3RWYXIuanM6CisgICAgICAgICogc3RyZXNzL29wX21v ZC1WYXJDb25zdC5qczoKKyAgICAgICAgKiBzdHJlc3Mvb3BfbW9kLVZhclZhci5qczoKKwogMjAx Ny0wOS0xMiAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBT a2lwIHN0cmVzcy92YWx1ZS10by1ib29sZWFuLmpzIG9uIERlYnVnIGJvdHMuCkluZGV4OiBKU1Rl c3RzL3N0cmVzcy9vcF9kaXYtQ29uc3RWYXIuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9zdHJl c3Mvb3BfZGl2LUNvbnN0VmFyLmpzCShyZXZpc2lvbiAyMjE5MjcpCisrKyBKU1Rlc3RzL3N0cmVz cy9vcF9kaXYtQ29uc3RWYXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi0vL0Ag cnVuRlRMTm9DSklUKCItLXRpbWVvdXRNdWx0aXBsaWVyPTEuNSIpCisvL0AgcnVuRlRMTm9DSklU KCItLXRpbWVvdXRNdWx0aXBsaWVyPTIuMCIpCiAKIC8vIElmIGFsbCBnb2VzIHdlbGwsIHRoaXMg dGVzdCBtb2R1bGUgd2lsbCB0ZXJtaW5hdGUgc2lsZW50bHkuIElmIG5vdCwgaXQgd2lsbCBwcmlu dAogLy8gZXJyb3JzLiBTZWUgYmluYXJ5LW9wLXRlc3QuanMgZm9yIGRlYnVnZ2luZyBvcHRpb25z IGlmIG5lZWRlZC4KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL29wX2Rpdi1WYXJDb25zdC5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtVmFyQ29uc3QuanMJKHJldmlzaW9uIDIy MTkyNykKKysrIEpTVGVzdHMvc3RyZXNzL29wX2Rpdi1WYXJDb25zdC5qcwkod29ya2luZyBjb3B5 KQpAQCAtMSw0ICsxLDQgQEAKLS8vQCBydW5GVExOb0NKSVQoIi0tdGltZW91dE11bHRpcGxpZXI9 MS41IikKKy8vQCBydW5GVExOb0NKSVQoIi0tdGltZW91dE11bHRpcGxpZXI9Mi4wIikKIAogLy8g SWYgYWxsIGdvZXMgd2VsbCwgdGhpcyB0ZXN0IG1vZHVsZSB3aWxsIHRlcm1pbmF0ZSBzaWxlbnRs eS4gSWYgbm90LCBpdCB3aWxsIHByaW50CiAvLyBlcnJvcnMuIFNlZSBiaW5hcnktb3AtdGVzdC5q cyBmb3IgZGVidWdnaW5nIG9wdGlvbnMgaWYgbmVlZGVkLgpJbmRleDogSlNUZXN0cy9zdHJlc3Mv b3BfZGl2LVZhclZhci5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtVmFy VmFyLmpzCShyZXZpc2lvbiAyMjE5MjcpCisrKyBKU1Rlc3RzL3N0cmVzcy9vcF9kaXYtVmFyVmFy LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotLy9AIHJ1bkZUTE5vQ0pJVCgiLS10 aW1lb3V0TXVsdGlwbGllcj0xLjUiKQorLy9AIHJ1bkZUTE5vQ0pJVCgiLS10aW1lb3V0TXVsdGlw bGllcj0yLjAiKQogCiAvLyBJZiBhbGwgZ29lcyB3ZWxsLCB0aGlzIHRlc3QgbW9kdWxlIHdpbGwg dGVybWluYXRlIHNpbGVudGx5LiBJZiBub3QsIGl0IHdpbGwgcHJpbnQKIC8vIGVycm9ycy4gU2Vl IGJpbmFyeS1vcC10ZXN0LmpzIGZvciBkZWJ1Z2dpbmcgb3B0aW9ucyBpZiBuZWVkZWQuCkluZGV4 OiBKU1Rlc3RzL3N0cmVzcy9vcF9tb2QtQ29uc3RWYXIuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0 cy9zdHJlc3Mvb3BfbW9kLUNvbnN0VmFyLmpzCShyZXZpc2lvbiAyMjE5MjcpCisrKyBKU1Rlc3Rz L3N0cmVzcy9vcF9tb2QtQ29uc3RWYXIuanMJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBA Ci0vL0AgaWYgJGJ1aWxkVHlwZSA9PSAicmVsZWFzZSIgdGhlbiBydW5GVExOb0NKSVQoIi0tdGlt ZW91dE11bHRpcGxpZXI9MS41IikgZWxzZSBza2lwIGVuZAorLy9AIHJ1bkZUTE5vQ0pJVCgiLS10 aW1lb3V0TXVsdGlwbGllcj0yLjAiKQogCiAvLyBJZiBhbGwgZ29lcyB3ZWxsLCB0aGlzIHRlc3Qg bW9kdWxlIHdpbGwgdGVybWluYXRlIHNpbGVudGx5LiBJZiBub3QsIGl0IHdpbGwgcHJpbnQKIC8v IGVycm9ycy4gU2VlIGJpbmFyeS1vcC10ZXN0LmpzIGZvciBkZWJ1Z2dpbmcgb3B0aW9ucyBpZiBu ZWVkZWQuCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9vcF9tb2QtVmFyQ29uc3QuanMKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gSlNUZXN0cy9zdHJlc3Mvb3BfbW9kLVZhckNvbnN0LmpzCShyZXZpc2lvbiAyMjE5Mjcp CisrKyBKU1Rlc3RzL3N0cmVzcy9vcF9tb2QtVmFyQ29uc3QuanMJKHdvcmtpbmcgY29weSkKQEAg LTEsNCArMSw0IEBACi0vL0AgaWYgJGJ1aWxkVHlwZSA9PSAicmVsZWFzZSIgdGhlbiBydW5GVExO b0NKSVQoIi0tdGltZW91dE11bHRpcGxpZXI9MS41IikgZWxzZSBza2lwIGVuZAorLy9AIHJ1bkZU TE5vQ0pJVCgiLS10aW1lb3V0TXVsdGlwbGllcj0yLjAiKQogCiAvLyBJZiBhbGwgZ29lcyB3ZWxs LCB0aGlzIHRlc3QgbW9kdWxlIHdpbGwgdGVybWluYXRlIHNpbGVudGx5LiBJZiBub3QsIGl0IHdp bGwgcHJpbnQKIC8vIGVycm9ycy4gU2VlIGJpbmFyeS1vcC10ZXN0LmpzIGZvciBkZWJ1Z2dpbmcg b3B0aW9ucyBpZiBuZWVkZWQuCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9vcF9tb2QtVmFyVmFyLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL29wX21vZC1WYXJWYXIuanMJKHJldmlzaW9u IDIyMTkyNykKKysrIEpTVGVzdHMvc3RyZXNzL29wX21vZC1WYXJWYXIuanMJKHdvcmtpbmcgY29w eSkKQEAgLTEsNCArMSw0IEBACi0vL0AgaWYgJGJ1aWxkVHlwZSA9PSAicmVsZWFzZSIgdGhlbiBy dW5GVExOb0NKSVQoIi0tdGltZW91dE11bHRpcGxpZXI9MS41IikgZWxzZSBza2lwIGVuZAorLy9A IHJ1bkZUTE5vQ0pJVCgiLS10aW1lb3V0TXVsdGlwbGllcj0yLjAiKQogCiAvLyBJZiBhbGwgZ29l cyB3ZWxsLCB0aGlzIHRlc3QgbW9kdWxlIHdpbGwgdGVybWluYXRlIHNpbGVudGx5LiBJZiBub3Qs IGl0IHdpbGwgcHJpbnQKIC8vIGVycm9ycy4gU2VlIGJpbmFyeS1vcC10ZXN0LmpzIGZvciBkZWJ1 Z2dpbmcgb3B0aW9ucyBpZiBuZWVkZWQuCg==