176541 2017-09-07 10:36:55 -0700 [Win] tests/security/contentSecurityPolicy/report-only.php is flaky. 2017-09-27 13:02:44 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan ap bfulgham buildbot commit-queue dbates lforschler mkwst webkit-bug-importer oldest_to_newest 1346395 0 pvollan 2017-09-07 10:36:55 -0700 From the httpd error log: [Thu Sep 07 01:50:11.131370 2017] [:error] [pid 4576:tid 824] [client 127.0.0.1:61925] PHP Warning: rename(C:\\Users\\buildbot\\AppData\\Local\\Temp/-security-contentSecurityPolicy-report-only.php.csp-report.txt.tmp,C:\\Users\\buildbot\\AppData\\Local\\Temp/-security-contentSecurityPolicy-report-only.php.csp-report.txt): The process cannot access the file because it is being used by another process. (code: 32) in C:\\cygwin\\home\\buildbot\\slave\\win-release-tests\\build\\LayoutTests\\http\\tests\\security\\contentSecurityPolicy\\resources\\save-report.php on line 24, referer: http://127.0.0.1:8000/security/contentSecurityPolicy/report-only.php 1346468 1 320154 pvollan 2017-09-07 12:20:08 -0700 Created attachment 320154 Patch 1346469 2 pvollan 2017-09-07 12:20:56 -0700 This is not the most elegant solution, maybe there are better approaches? 1346473 3 320154 bfulgham 2017-09-07 12:27:42 -0700 Comment on attachment 320154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320154&action=review This isn't very elegant, but it's worth a try to get the Windows tests to work consistently. > LayoutTests/http/tests/security/contentSecurityPolicy/resources/save-report.php:27 > + sleep(1); Is there a way we could do the loop for Windows only? We don't seem to need it on other platforms. 1346492 4 pvollan 2017-09-07 12:47:33 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 320154 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=320154&action=review > > This isn't very elegant, but it's worth a try to get the Windows tests to > work consistently. > > > LayoutTests/http/tests/security/contentSecurityPolicy/resources/save-report.php:27 > > + sleep(1); > > Is there a way we could do the loop for Windows only? We don't seem to need > it on other platforms. I think we possibly can add a platform check? Thanks for reviewing! 1346510 5 320154 commit-queue 2017-09-07 13:13:00 -0700 Comment on attachment 320154 Patch Clearing flags on attachment: 320154 Committed r221752: <http://trac.webkit.org/changeset/221752> 1346511 6 commit-queue 2017-09-07 13:13:02 -0700 All reviewed patches have been landed. Closing bug. 1353785 7 webkit-bug-importer 2017-09-27 13:02:44 -0700 <rdar://problem/34694536> 320154 2017-09-07 12:20:08 -0700 2017-09-07 13:13:00 -0700 Patch bug-176541-20170907122007.patch text/plain 1738 pvollan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyMTc0NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTA3ICBQZXIgQXJuZSBWb2xsYW4g IDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSB0ZXN0cy9zZWN1cml0eS9jb250 ZW50U2VjdXJpdHlQb2xpY3kvcmVwb3J0LW9ubHkucGhwIGlzIGZsYWt5LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NTQxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGZ1bmN0aW9uIGNhbGwgcmVu YW1lIHdpbGwgc29tZXRpbWVzIGZhaWwgb24gV2luZG93cyBiZWNhdXNlIG9uZSBvZiB0aGUgZmls ZXMgaXMKKyAgICAgICAgb3BlbmVkIGJ5IGFub3RoZXIgcHJvY2Vzcy4gSWYgcmVuYW1lIGZhaWxz LCB3YWl0LCBhbmQgdHJ5IGFnYWluLgorCisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9j b250ZW50U2VjdXJpdHlQb2xpY3kvcmVzb3VyY2VzL3NhdmUtcmVwb3J0LnBocDoKKwogMjAxNy0w OS0wNyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFy a2VkIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvZW1iZWRk ZWQtY29udGVudC90aGUtaWZyYW1lLWVsZW1lbnQvY3Jvc3Nfb3JpZ2luX3BhcmVudGFnZS5odG1s IGFzIHNsb3cuCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRT ZWN1cml0eVBvbGljeS9yZXNvdXJjZXMvc2F2ZS1yZXBvcnQucGhwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3Jlc291 cmNlcy9zYXZlLXJlcG9ydC5waHAJKHJldmlzaW9uIDIyMTc0MykKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L3Jlc291cmNlcy9zYXZlLXJl cG9ydC5waHAJKHdvcmtpbmcgY29weSkKQEAgLTIxLDcgKzIxLDEwIEBAIGZvcmVhY2ggKCRodHRw SGVhZGVycyBhcyAkbmFtZSA9PiAkdmFsdWUKIGZ3cml0ZSgkcmVwb3J0RmlsZSwgIj09PSBQT1NU IERBVEEgPT09XG4iKTsKIGZ3cml0ZSgkcmVwb3J0RmlsZSwgZmlsZV9nZXRfY29udGVudHMoInBo cDovL2lucHV0IikpOwogZmNsb3NlKCRyZXBvcnRGaWxlKTsKLXJlbmFtZSgkcmVwb3J0RmlsZVBh dGggLiAiLnRtcCIsICRyZXBvcnRGaWxlUGF0aCk7CisKKy8vIE9uIFdpbmRvd3MsIHJlbmFtZSB3 aWxsIHNvbWV0aW1lcyBmYWlsIGJlY2F1c2Ugb25lIG9mIHRoZSBmaWxlcyBpcyB1c2VkIGJ5IGFu b3RoZXIgcHJvY2Vzcy4KK3doaWxlICghcmVuYW1lKCRyZXBvcnRGaWxlUGF0aCAuICIudG1wIiwg JHJlcG9ydEZpbGVQYXRoKSkKKyAgICBzbGVlcCgxKTsKIAogaWYgKCFpc3NldCgkRE9fTk9UX0NM RUFSX0NPT0tJRVMpIHx8ICEkRE9fTk9UX0NMRUFSX0NPT0tJRVMpIHsKICAgICBmb3JlYWNoICgk X0NPT0tJRSBhcyAkbmFtZSA9PiAkdmFsdWUpCg==