176527 2017-09-07 08:56:26 -0700 [Win] Skip dashboard tests, which require WebKitTestRunner 2017-09-27 12:41:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan aakash_jain achristensen ap bfulgham commit-queue jbedard jmarcell lforschler webkit-bug-importer oldest_to_newest 1346324 0 pvollan 2017-09-07 08:56:26 -0700 07:12:58.330 3608 Using port 'win-future-wk2' 07:12:58.330 3608 Test configuration: <future, x86, release> 07:12:58.330 3608 Placing test results in /home/buildbot/slave/win-release-tests/build/layout-test-results/dashboard-layout-test-results 07:12:58.330 3608 Baseline search path: platform/win-wk2 -> platform/win -> platform/mac-wk2 -> platform/mac -> generic 07:12:58.330 3608 Using Release build 07:12:58.330 3608 Pixel tests disabled 07:12:58.330 3608 Regular timeout: 30000, slow test timeout: 150000 07:12:58.330 3608 No WPT config file found 07:12:58.330 3608 No WPT config file found 07:12:58.330 3608 Command line: WebKitBuild/release/bin32/WebKitTestRunner - 07:12:58.330 3608 07:12:58.330 3608 Collecting tests ... 07:12:58.330 3608 Parsing expectations ... 07:12:58.330 3608 Found 1 test; running 1, skipping 0. 07:12:58.330 3608 07:12:58.330 3608 Running 1 test 07:12:58.330 3608 07:12:58.346 3608 Checking build ... 07:12:58.346 3608 WebKitTestRunner was not found at WebKitBuild/release/bin32/WebKitTestRunner 07:12:58.346 3608 Build check failed 07:12:58.346 3608 Testing completed, Exit status: -1 1346329 1 320118 pvollan 2017-09-07 09:03:47 -0700 Created attachment 320118 Patch 1346332 2 320118 bfulgham 2017-09-07 09:09:52 -0700 Comment on attachment 320118 Patch r=me 1346336 3 320118 pvollan 2017-09-07 09:13:00 -0700 Comment on attachment 320118 Patch Thanks for reviewing! 1346355 4 320118 commit-queue 2017-09-07 09:43:13 -0700 Comment on attachment 320118 Patch Clearing flags on attachment: 320118 Committed r221737: <http://trac.webkit.org/changeset/221737> 1346356 5 commit-queue 2017-09-07 09:43:15 -0700 All reviewed patches have been landed. Closing bug. 1346362 6 ap 2017-09-07 09:50:06 -0700 Do the tests fail if you switch them to WebKitLegacy? I don't think there is anything specific to modern WebKit there. 1346372 7 pvollan 2017-09-07 10:04:31 -0700 (In reply to Alexey Proskuryakov from comment #6) > Do the tests fail if you switch them to WebKitLegacy? I don't think there is > anything specific to modern WebKit there. That's a good point, I will look into that. 1346850 8 jbedard 2017-09-08 10:18:53 -0700 Quick note about this change: it will not be reflected on buildbot until buildbot is restarted. 1353598 9 webkit-bug-importer 2017-09-27 12:41:22 -0700 <rdar://problem/34693761> 320118 2017-09-07 09:03:47 -0700 2017-09-07 09:43:13 -0700 Patch bug-176527-20170907180347.patch text/plain 1394 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTczNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA5LTA3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBEYXNoYm9hcmQgdGVzdCBpcyBmYWlsaW5nLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NTI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2tpcCB0ZXN0IG9uIFdpbmRv d3Mgc2luY2UgV2ViS2l0VGVzdFJ1bm5lciBpcyByZXF1aXJlZCwgYnV0IG5vdCBidWlsdCBvbiBX aW5kb3dzLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvbWFzdGVyLmNmZzoKKyAgICAgICAgKFRlc3RGYWN0b3J5Ll9faW5pdF9fKToKKwogMjAx Ny0wOS0wNyAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtXUEVdW0NNYWtlXSBBZGQgImRpc3QiIGFuZCAiZGlzdGNoZWNrIiB0YXJnZXRzCklu ZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0 ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDIyMTczMykKKysrIFRvb2xzL0J1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdvcmtpbmcg Y29weSkKQEAgLTkyMSw3ICs5MjEsOCBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAg ICAgICAgc2VsZi5hZGRTdGVwKFJ1blBlcmxUZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAo UnVuQmluZGluZ3NUZXN0cygpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuQnVpbHRpbnNUZXN0 cygpKQotICAgICAgICBzZWxmLmFkZFN0ZXAoUnVuRGFzaGJvYXJkVGVzdHMoKSkKKyAgICAgICAg aWYgcGxhdGZvcm0gIT0gJ3dpbicKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5EYXNoYm9h cmRUZXN0cygpKQogICAgICAgICBpZiBzZWxmLkxheW91dFRlc3RDbGFzczoKICAgICAgICAgICAg IHNlbGYuYWRkU3RlcChBcmNoaXZlVGVzdFJlc3VsdHMoKSkKICAgICAgICAgICAgIHNlbGYuYWRk U3RlcChVcGxvYWRUZXN0UmVzdWx0cygpKQo=