176497 2017-09-07 01:20:40 -0700 [GTK] Bring back line height rounding when computing font metrics 2017-09-07 20:52:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply buildbot mcatanzaro mmaxfield tpopela zan oldest_to_newest 1346245 0 cgarcia 2017-09-07 01:20:40 -0700 In r221670 we changed the way we get the metrics to avoid rounding that was causing a negative line gap to be computed. Since the font metrics value is indeed a float value, we also removed the rounding when setting the line height. However, this caused some test failures because now we report non integer line heights, see for example: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r221719%20(3018)/fast/css/font-calculated-value-pretty-diff.html https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r221719%20(3018)/fast/ruby/ruby-line-height-pretty-diff.html I think it would be better to bring back the rounding for consistency with all other ports, but also with other browsers. This will require another rebaseline, but a lot smaller :-) 1346246 1 320103 cgarcia 2017-09-07 01:22:33 -0700 Created attachment 320103 Patch 1346248 2 cgarcia 2017-09-07 01:52:49 -0700 Committed r221724: <http://trac.webkit.org/changeset/221724> 1346325 3 mcatanzaro 2017-09-07 08:58:08 -0700 Tom, did this reintroduce the bug with Evolution? Is it OK? 1346701 4 tpopela 2017-09-07 20:52:27 -0700 (In reply to Michael Catanzaro from comment #3) > Tom, did this reintroduce the bug with Evolution? Is it OK? I don't know about Evolution (I don't work on it, nor use it anymore), but the testcase that made for bug 149703 was running fine when I tested it yesterday. It was running fine with and without this change. I will probably add it as a layout test, so we are sure, that it works in the future. 320103 2017-09-07 01:22:33 -0700 2017-09-07 01:40:47 -0700 Patch wk2-line-height.diff text/plain 2693 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzN2YzMGZhODczYi4uMTAzZDE3NzIzNWMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wOS0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gQnJpbmcgYmFjayBsaW5lIGhlaWdodCByb3VuZGlu ZyB3aGVuIGNvbXB1dGluZyBmb250IG1ldHJpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMjE2NzAgd2UgY2hhbmdlZCB0aGUgd2F5IHdlIGdl dCB0aGUgbWV0cmljcyB0byBhdm9pZCByb3VuZGluZyB0aGF0IHdhcyBjYXVzaW5nIGEgbmVnYXRp dmUgbGluZSBnYXAgdG8gYmUKKyAgICAgICAgY29tcHV0ZWQuIFNpbmNlIHRoZSBmb250IG1ldHJp Y3MgdmFsdWUgaXMgaW5kZWVkIGEgZmxvYXQgdmFsdWUsIHdlIGFsc28gcmVtb3ZlZCB0aGUgcm91 bmRpbmcgd2hlbiBzZXR0aW5nIHRoZQorICAgICAgICBsaW5lIGhlaWdodC4gSG93ZXZlciwgdGhp cyBjYXVzZWQgc29tZSB0ZXN0IGZhaWx1cmVzIGJlY2F1c2Ugbm93IHdlIHJlcG9ydCBub24gaW50 ZWdlciBsaW5lIGhlaWdodHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlw ZS9TaW1wbGVGb250RGF0YUZyZWVUeXBlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OnBs YXRmb3JtSW5pdCk6CisKIDIwMTctMDktMDYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFRlbXBvcmFyeSBkaXNhYmxlIHRo ZSBjaGFuZ2VzIGludHJvZHVjZWQgaW4gcjIyMTY3MCBmb3IgV1BFLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvU2ltcGxlRm9udERhdGFGcmVl VHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9TaW1w bGVGb250RGF0YUZyZWVUeXBlLmNwcAppbmRleCAyNTEzNzA4MzdlMC4uODVlNjgwZDMzNTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL1NpbXBs ZUZvbnREYXRhRnJlZVR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2ZyZWV0eXBlL1NpbXBsZUZvbnREYXRhRnJlZVR5cGUuY3BwCkBAIC01NCw3ICs1NCw3IEBA CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotLy8gRklYTUU6IFJlbW92ZSB0aGlzIGlmZGVmIG9u Y2UgV1BFIHVwZ3JxYWRlcyB0byBGcmVldHlwZSAyLjggYW5kIHJlbW92ZXMgdGhlIHBhdGNoIGZv ciAyLjQuMTEuCisvLyBGSVhNRTogUmVtb3ZlIHRoaXMgaWZkZWYgb25jZSBXUEUgdXBncmFkZXMg dG8gRnJlZXR5cGUgMi44IGFuZCByZW1vdmVzIHRoZSBwYXRjaCBmb3IgMi40LjExLgogI2lmICFQ TEFURk9STShXUEUpCiBzdGF0aWMgUmVmUHRyPGNhaXJvX3NjYWxlZF9mb250X3Q+IHNjYWxlZEZv bnRXaXRob3V0TWV0cmljc0hpbnRpbmcoY2Fpcm9fc2NhbGVkX2ZvbnRfdCogc2NhbGVkRm9udCkK IHsKQEAgLTc1LDcgKzc1LDcgQEAgdm9pZCBGb250OjpwbGF0Zm9ybUluaXQoKQogICAgICAgICBy ZXR1cm47CiAKICAgICBBU1NFUlQobV9wbGF0Zm9ybURhdGEuc2NhbGVkRm9udCgpKTsKLSAgICAv LyBGSVhNRTogUmVtb3ZlIHRoaXMgaWZkZWYgb25jZSBXUEUgdXBncnFhZGVzIHRvIEZyZWV0eXBl IDIuOCBhbmQgcmVtb3ZlcyB0aGUgcGF0Y2ggZm9yIDIuNC4xMS4KKyAgICAvLyBGSVhNRTogUmVt b3ZlIHRoaXMgaWZkZWYgb25jZSBXUEUgdXBncmFkZXMgdG8gRnJlZXR5cGUgMi44IGFuZCByZW1v dmVzIHRoZSBwYXRjaCBmb3IgMi40LjExLgogI2lmIFBMQVRGT1JNKFdQRSkKICAgICBjYWlyb19m b250X2V4dGVudHNfdCBmb250RXh0ZW50czsKICAgICBjYWlyb19zY2FsZWRfZm9udF9leHRlbnRz KG1fcGxhdGZvcm1EYXRhLnNjYWxlZEZvbnQoKSwgJmZvbnRFeHRlbnRzKTsKQEAgLTExNSwxMiAr MTE1LDcgQEAgdm9pZCBGb250OjpwbGF0Zm9ybUluaXQoKQogICAgIG1fZm9udE1ldHJpY3Muc2V0 QXNjZW50KGFzY2VudCk7CiAgICAgbV9mb250TWV0cmljcy5zZXREZXNjZW50KGRlc2NlbnQpOwog ICAgIG1fZm9udE1ldHJpY3Muc2V0Q2FwSGVpZ2h0KGNhcEhlaWdodCk7Ci0gICAgLy8gRklYTUU6 IFJlbW92ZSB0aGlzIGlmZGVmIG9uY2UgV1BFIHVwZ3JxYWRlcyB0byBGcmVldHlwZSAyLjggYW5k IHJlbW92ZXMgdGhlIHBhdGNoIGZvciAyLjQuMTEuCi0jaWYgUExBVEZPUk0oV1BFKQogICAgIG1f Zm9udE1ldHJpY3Muc2V0TGluZVNwYWNpbmcobHJvdW5kZihhc2NlbnQpICsgbHJvdW5kZihkZXNj ZW50KSArIGxyb3VuZGYobGluZUdhcCkpOwotI2Vsc2UKLSAgICBtX2ZvbnRNZXRyaWNzLnNldExp bmVTcGFjaW5nKGFzY2VudCArIGRlc2NlbnQgKyBsaW5lR2FwKTsKLSNlbmRpZgogICAgIG1fZm9u dE1ldHJpY3Muc2V0TGluZUdhcChsaW5lR2FwKTsKIAogICAgIGNhaXJvX3RleHRfZXh0ZW50c190 IHRleHRFeHRlbnRzOwo=