176495 2017-09-06 23:56:26 -0700 [EME] CDMClearKey: implement remaining methods of CDMPrivate derivative 2017-09-27 12:35:21 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zan zan calvaris jer.noble webkit-bug-importer oldest_to_newest 1346235 0 zan 2017-09-06 23:56:26 -0700 [EME] CDMClearKey: implement CDMPrivate derivative 1346240 1 320100 zan 2017-09-07 00:27:17 -0700 Created attachment 320100 Patch 1346258 2 320100 calvaris 2017-09-07 04:03:41 -0700 Comment on attachment 320100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320100&action=review > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:167 > + // Server certificates are not supported. This is a bit redundant, but it does not harm. > Source/WebCore/platform/encryptedmedia/clearkey/CDMClearKey.cpp:173 > + // Sessions are supported. This is a bit redundant, but it does not harm. 1346280 3 320100 zan 2017-09-07 05:57:16 -0700 Comment on attachment 320100 Patch Clearing flags on attachment: 320100 Committed r221728: <http://trac.webkit.org/changeset/221728> 1346281 4 zan 2017-09-07 05:57:20 -0700 All reviewed patches have been landed. Closing bug. 1353504 5 webkit-bug-importer 2017-09-27 12:35:21 -0700 <rdar://problem/34693543> 320100 2017-09-07 00:27:17 -0700 2017-09-07 05:57:16 -0700 Patch bug-176495-20170907092716.patch text/plain 4573 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWRiNzZlYzU4OWQwZjg4 YjkyNmMyNGUyY2Y5Y2I0YmYzYzNjNTU1NS4uMmY4MzE1MjRlNDE4MmQzNTljYzRmOGIyODA2MDAw MjEzMjQ2ODRmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE3LTA5LTA3ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbRU1FXSBDRE1DbGVh cktleTogaW1wbGVtZW50IHJlbWFpbmluZyBtZXRob2RzIG9mIENETVByaXZhdGUgZGVyaXZhdGl2 ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDk1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVt ZW50IHRoZSByZW1haW5pbmcgQ0RNUHJpdmF0ZUNsZWFyS2V5IG1ldGhvZHMsIGZvbGxvd2luZyB0 aGUKKyAgICAgICAgQ2xlYXJLZXkgc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgIC0gc2VydmVyIGNl cnRpZmljYXRlcyBhcmUgbm90IHN1cHBvcnRlZCwgYnV0IHNlc3Npb25zIGFyZTsKKyAgICAgICAg IC0gJ2tleWlkcycgaW5pdCBkYXRhIGluIEpTT04gZm9ybWF0IGlzIGFjY2VwdGFibGU7CisgICAg ICAgICAtIEpTT04gcmVzcG9uc2VzIGFyZSBhY2NlcHRhYmxlOworICAgICAgICAgLSBzZXNzaW9u IElEcyBtdXN0IHVzZSB0aGUgMzItYml0IGludGVnZXIgZm9ybWF0LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyAtLSBjb3ZlcmVkIGJ5IGltcG9ydGVkIFczQyB0ZXN0cyB0aGF0IHV0aWxpemUgQ2xl YXJLZXkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9jbGVhcmtleS9DRE1D bGVhcktleS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpwYXJzZUpTT05PYmplY3QpOgorICAgICAg ICAoV2ViQ29yZTo6Q0RNUHJpdmF0ZUNsZWFyS2V5Ojpsb2FkQW5kSW5pdGlhbGl6ZSk6CisgICAg ICAgIChXZWJDb3JlOjpDRE1Qcml2YXRlQ2xlYXJLZXk6OnN1cHBvcnRzU2VydmVyQ2VydGlmaWNh dGVzIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNETVByaXZhdGVDbGVhcktleTo6c3VwcG9y dHNTZXNzaW9ucyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpDRE1Qcml2YXRlQ2xlYXJLZXk6 OnN1cHBvcnRzSW5pdERhdGEgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6Q0RNUHJpdmF0ZUNs ZWFyS2V5OjpzYW5pdGl6ZVJlc3BvbnNlIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkNETVBy aXZhdGVDbGVhcktleTo6c2FuaXRpemVTZXNzaW9uSWQgY29uc3QpOgorCiAyMDE3LTA5LTA2ICBa YW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVy XSBJbXBsZW1lbnQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFOjphdHRlbXBUb0RlY3J5 cHRXaXRoSW5zdGFuY2UoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZW5j cnlwdGVkbWVkaWEvY2xlYXJrZXkvQ0RNQ2xlYXJLZXkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZW5jcnlwdGVkbWVkaWEvY2xlYXJrZXkvQ0RNQ2xlYXJLZXkuY3BwCmluZGV4IGU3OGZj ODE0MGZiMWQxMTcyNTg3MjVmN2E5MGQyMmZkYTMzMDcyNzguLjgzMDk1OTk4YWM0NjgxMzJkMjhh NzBjOTIxMDRmYzA0MDYzM2M3MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VuY3J5cHRlZG1lZGlhL2NsZWFya2V5L0NETUNsZWFyS2V5LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9lbmNyeXB0ZWRtZWRpYS9jbGVhcmtleS9DRE1DbGVhcktleS5jcHAKQEAg LTM1LDkgKzM1LDI5IEBACiAjaW5jbHVkZSAiQ0RNUmVzdHJpY3Rpb25zLmgiCiAjaW5jbHVkZSAi Q0RNU2Vzc2lvblR5cGUuaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIuaCIKKyNpbmNsdWRlIDxp bnNwZWN0b3IvSW5zcGVjdG9yVmFsdWVzLmg+CisKK3VzaW5nIG5hbWVzcGFjZSBJbnNwZWN0b3I7 CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gcGFyc2VK U09OT2JqZWN0KGNvbnN0IFNoYXJlZEJ1ZmZlciYgYnVmZmVyKQoreworICAgIC8vIEZhaWwgb24g bGFyZ2UgYnVmZmVycyB3aG9zZSBzaXplIGRvZXNuJ3QgZml0IGludG8gYSAzMi1iaXQgdW5zaWdu ZWQgaW50ZWdlci4KKyAgICBzaXplX3Qgc2l6ZSA9IGJ1ZmZlci5zaXplKCk7CisgICAgaWYgKHNp emUgPiBzdGQ6Om51bWVyaWNfbGltaXRzPHVuc2lnbmVkPjo6bWF4KCkpCisgICAgICAgIHJldHVy biBudWxscHRyOworCisgICAgLy8gUGFyc2UgdGhlIGJ1ZmZlciBjb250ZW50cyBhcyBKU09OLCBy ZXR1cm5pbmcgdGhlIHJvb3Qgb2JqZWN0IChpZiBhbnkpLgorICAgIFN0cmluZyBqc29uIHsgYnVm ZmVyLmRhdGEoKSwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHNpemUpIH07CisgICAgUmVmUHRyPElu c3BlY3RvclZhbHVlPiB2YWx1ZTsKKyAgICBSZWZQdHI8SW5zcGVjdG9yT2JqZWN0PiBvYmplY3Q7 CisgICAgaWYgKCFJbnNwZWN0b3JWYWx1ZTo6cGFyc2VKU09OKGpzb24sIHZhbHVlKSB8fCAhdmFs dWUtPmFzT2JqZWN0KG9iamVjdCkpCisgICAgICAgIHJldHVybiBudWxscHRyOworCisgICAgcmV0 dXJuIG9iamVjdDsKK30KKwogQ0RNRmFjdG9yeUNsZWFyS2V5JiBDRE1GYWN0b3J5Q2xlYXJLZXk6 OnNpbmdsZXRvbigpCiB7CiAgICAgc3RhdGljIENETUZhY3RvcnlDbGVhcktleSBzX2ZhY3Rvcnk7 CkBAIC0xMzksMzEgKzE1OSw1MSBAQCBSZWZQdHI8Q0RNSW5zdGFuY2U+IENETVByaXZhdGVDbGVh cktleTo6Y3JlYXRlSW5zdGFuY2UoKQogCiB2b2lkIENETVByaXZhdGVDbGVhcktleTo6bG9hZEFu ZEluaXRpYWxpemUoKQogeworICAgIC8vIE5vLW9wLgogfQogCiBib29sIENETVByaXZhdGVDbGVh cktleTo6c3VwcG9ydHNTZXJ2ZXJDZXJ0aWZpY2F0ZXMoKSBjb25zdAogeworICAgIC8vIFNlcnZl ciBjZXJ0aWZpY2F0ZXMgYXJlIG5vdCBzdXBwb3J0ZWQuCiAgICAgcmV0dXJuIGZhbHNlOwogfQog CiBib29sIENETVByaXZhdGVDbGVhcktleTo6c3VwcG9ydHNTZXNzaW9ucygpIGNvbnN0CiB7Ci0g ICAgcmV0dXJuIGZhbHNlOworICAgIC8vIFNlc3Npb25zIGFyZSBzdXBwb3J0ZWQuCisgICAgcmV0 dXJuIHRydWU7CiB9CiAKLWJvb2wgQ0RNUHJpdmF0ZUNsZWFyS2V5OjpzdXBwb3J0c0luaXREYXRh KGNvbnN0IEF0b21pY1N0cmluZyYsIGNvbnN0IFNoYXJlZEJ1ZmZlciYpIGNvbnN0Citib29sIENE TVByaXZhdGVDbGVhcktleTo6c3VwcG9ydHNJbml0RGF0YShjb25zdCBBdG9taWNTdHJpbmcmIGlu aXREYXRhVHlwZSwgY29uc3QgU2hhcmVkQnVmZmVyJiBpbml0RGF0YSkgY29uc3QKIHsKLSAgICBy ZXR1cm4gZmFsc2U7CisgICAgLy8gRmFpbCBmb3IgaW5pdCBkYXRhIHR5cGVzIG90aGVyIHRoYW4g J2tleWlkcycuCisgICAgaWYgKCFlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShpbml0RGF0 YVR5cGUsICJrZXlpZHMiKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gVmFsaWRh dGUgdGhlIGluaXREYXRhIGJ1ZmZlciBhcyBhbiBKU09OIG9iamVjdC4KKyAgICBpZiAoIXBhcnNl SlNPTk9iamVjdChpbml0RGF0YSkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHJldHVy biB0cnVlOwogfQogCi1SZWZQdHI8U2hhcmVkQnVmZmVyPiBDRE1Qcml2YXRlQ2xlYXJLZXk6OnNh bml0aXplUmVzcG9uc2UoY29uc3QgU2hhcmVkQnVmZmVyJikgY29uc3QKK1JlZlB0cjxTaGFyZWRC dWZmZXI+IENETVByaXZhdGVDbGVhcktleTo6c2FuaXRpemVSZXNwb25zZShjb25zdCBTaGFyZWRC dWZmZXImIHJlc3BvbnNlKSBjb25zdAogewotICAgIHJldHVybiBudWxscHRyOworICAgIC8vIFZh bGlkYXRlIHRoZSByZXNwb25zZSBidWZmZXIgYXMgYW4gSlNPTiBvYmplY3QuCisgICAgaWYgKCFw YXJzZUpTT05PYmplY3QocmVzcG9uc2UpKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKworICAg IHJldHVybiByZXNwb25zZS5jb3B5KCk7CiB9CiAKLXN0ZDo6b3B0aW9uYWw8U3RyaW5nPiBDRE1Q cml2YXRlQ2xlYXJLZXk6OnNhbml0aXplU2Vzc2lvbklkKGNvbnN0IFN0cmluZyYpIGNvbnN0Citz dGQ6Om9wdGlvbmFsPFN0cmluZz4gQ0RNUHJpdmF0ZUNsZWFyS2V5OjpzYW5pdGl6ZVNlc3Npb25J ZChjb25zdCBTdHJpbmcmIHNlc3Npb25JZCkgY29uc3QKIHsKLSAgICByZXR1cm4gc3RkOjpudWxs b3B0OworICAgIC8vIFZhbGlkYXRlIHRoZSBzZXNzaW9uIElEIHN0cmluZyBhcyBhbiAzMi1iaXQg aW50ZWdlci4KKyAgICBib29sIG9rOworICAgIHNlc3Npb25JZC50b1VJbnRTdHJpY3QoJm9rKTsK KyAgICBpZiAoIW9rKQorICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OworICAgIHJldHVybiBz ZXNzaW9uSWQ7CiB9CiAKIENETUluc3RhbmNlQ2xlYXJLZXk6OkNETUluc3RhbmNlQ2xlYXJLZXko KSA9IGRlZmF1bHQ7Cg==