176493 2017-09-06 19:31:36 -0700 Remove new-run-webkit-httpd as it appears to be old 2017-09-27 13:02:55 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck ap commit-queue joepeck lforschler webkit-bug-importer oldest_to_newest 1346206 0 joepeck 2017-09-06 19:31:36 -0700 Remove new-run-webkit-httpd as it appears to be old. > # FIXME: currently this code only works with the Chromium ports and LigHTTPd. > # It should be made to work on all ports. It hits an error when I run it. I'll leave in other LigHTTPd code since it seemed like it might be used for Tools/Scripts testing code. 1346207 1 320093 joepeck 2017-09-06 19:32:00 -0700 Created attachment 320093 [PATCH] Proposed Fix 1346214 2 320093 ap 2017-09-06 20:29:28 -0700 Comment on attachment 320093 [PATCH] Proposed Fix It’s quite sad to keep underlying code in, but this is an improvement anyway 1346217 3 joepeck 2017-09-06 20:34:00 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 320093 [details] > [PATCH] Proposed Fix > > It’s quite sad to keep underlying code in, but this is an improvement anyway If I had any way to figure out if it was used or not I'd remove it. As it is I can barely understand the python code that uses it. I find it very hard to follow. 1346220 4 320093 commit-queue 2017-09-06 21:02:20 -0700 Comment on attachment 320093 [PATCH] Proposed Fix Clearing flags on attachment: 320093 Committed r221715: <http://trac.webkit.org/changeset/221715> 1346221 5 commit-queue 2017-09-06 21:02:21 -0700 All reviewed patches have been landed. Closing bug. 1346337 6 ap 2017-09-07 09:14:11 -0700 What happens if you simply delete all functions with "lighttpd" in the name, and then all files that are solely devoted to this server implementation? From brief grepping, it looks like the only non-mechanical case is websocket_server.py, which for some reason uses http_server.Lighttpd - I expect that moving a few lines of code will eliminate it from inheritance chain. 1353786 7 webkit-bug-importer 2017-09-27 13:02:55 -0700 <rdar://problem/34694544> 320093 2017-09-06 19:32:00 -0700 2017-09-06 21:02:20 -0700 [PATCH] Proposed Fix rm-1.patch text/plain 5146 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzQ4 NTY1OGNlNy4uZDYyNTQ0MjNjZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxNy0wOS0wNiAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFJlbW92ZSBuZXctcnVuLXdlYmtp dC1odHRwZCBhcyBpdCBhcHBlYXJzIHRvIGJlIG9sZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL25ldy1ydW4td2Via2l0LWh0dHBkOiBS ZW1vdmVkLgorCisyMDE3LTA5LTA2ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5j b20+CisKICAgICAgICAgV2ViS2l0IHNob3VsZCBjbGFpbSB0aGF0IGl0IGNhbiBzaG93IHJlc3Bv bnNlcyBhIGJyb2FkZXIgcmFuZ2Ugb2YgSlNPTiBNSU1FVHlwZXMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjI1MgogICAgICAgICA8cmRhcjovL3By b2JsZW0vMzQyMTI4ODU+CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL25ldy1ydW4td2Via2l0 LWh0dHBkIGIvVG9vbHMvU2NyaXB0cy9uZXctcnVuLXdlYmtpdC1odHRwZApkZWxldGVkIGZpbGUg bW9kZSAxMDA3NTUKaW5kZXggOTIxZTc3OTcxNjAuLjAwMDAwMDAwMDAwCi0tLSBhL1Rvb2xzL1Nj cmlwdHMvbmV3LXJ1bi13ZWJraXQtaHR0cGQKKysrIC9kZXYvbnVsbApAQCAtMSw5OSArMCwwIEBA Ci0jIS91c3IvYmluL2VudiBweXRob24KLSMgQ29weXJpZ2h0IChDKSAyMDEwIEdvb2dsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0jCi0jIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291 cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAotIyBtb2RpZmljYXRpb24sIGFy ZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCi0j IG1ldDoKLSMKLSMgICAgICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0 YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSMgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9u cyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMg aW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0jIGNvcHlyaWdodCBub3Rp Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIK LSMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZQotIyBkaXN0cmlidXRpb24uCi0jICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29v Z2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBpdHMKLSMgY29udHJpYnV0b3JzIG1heSBiZSB1c2Vk IHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KLSMgdGhpcyBzb2Z0 d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KLSMKLSMgVEhJ UyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRS SUJVVE9SUwotIyAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMs IElOQ0xVRElORywgQlVUIE5PVAotIyBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVT IE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IKLSMgQSBQQVJUSUNVTEFSIFBVUlBP U0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKLSMgT1dO RVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElO Q0lERU5UQUwsCi0jIFNQRUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VT IChJTkNMVURJTkcsIEJVVCBOT1QKLSMgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCi0jIERBVEEsIE9SIFBST0ZJVFM7 IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQotIyBU SEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZ LCBPUiBUT1JUCi0jIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcg SU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotCi0iIiJBIHV0aWxpdHkg c2NyaXB0IGZvciBzdGFydGluZyBhbmQgc3RvcHBpbmcgdGhlIEhUVFAgc2VydmVyIHdpdGggdGhl Ci0gICBzYW1lIGNvbmZpZ3VyYXRpb24gYXMgdXNlZCBpbiB0aGUgbGF5b3V0IHRlc3RzLiIiIgot Ci0jCi0jIEZJWE1FOiBjdXJyZW50bHkgdGhpcyBjb2RlIG9ubHkgd29ya3Mgd2l0aCB0aGUgQ2hy b21pdW0gcG9ydHMgYW5kIExpZ0hUVFBkLgotIyBJdCBzaG91bGQgYmUgbWFkZSB0byB3b3JrIG9u IGFsbCBwb3J0cy4KLSMKLSMgVGhpcyBzY3JpcHQgaXMgYWxzbyB1c2VkIGJ5IENocm9taXVtJ3Mg dWlfdGVzdHMgdG8gcnVuIGh0dHAgbGF5b3V0IHRlc3RzCi0jIGluIGEgYnJvd3Nlci4KLSMKLWlt cG9ydCBvcHRwYXJzZQotaW1wb3J0IG9zCi1pbXBvcnQgc3lzCi1pbXBvcnQgdGVtcGZpbGUKLQot aW1wb3J0IHdlYmtpdHB5LmNvbW1vbi52ZXJzaW9uX2NoZWNrCi0KLWZyb20gd2Via2l0cHkuY29t bW9uLmhvc3QgaW1wb3J0IEhvc3QKLWZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLnNlcnZlcnMg aW1wb3J0IGh0dHBfc2VydmVyCi0KLQotZGVmIHJ1bihvcHRpb25zKToKLSAgICBpZiBub3Qgb3B0 aW9ucy5zZXJ2ZXI6Ci0gICAgICAgIHByaW50ICgnVXNhZ2U6ICVzIC0tc2VydmVyIHtzdGFydHxz dG9wfSBbLS1yb290PXJvb3RfZGlyXScKLSAgICAgICAgICAgICAgICcgWy0tcG9ydD1wb3J0X251 bWJlcl0nICUgc3lzLmFyZ3ZbMF0pCi0gICAgZWxzZToKLSAgICAgICAgaWYgKG9wdGlvbnMucm9v dCBpcyBOb25lKSBhbmQgKG9wdGlvbnMucG9ydCBpcyBub3QgTm9uZSk6Ci0gICAgICAgICAgICAj IHNwZWNpZnlpbmcgcm9vdCBidXQgbm90IHBvcnQgbWVhbnMgd2Ugd2FudCBodHRwZCBvbiBkZWZh dWx0Ci0gICAgICAgICAgICAjIHNldCBvZiBwb3J0cyB0aGF0IExheW91dFRlc3QgdXNlLCBidXQg cG9pbnRpbmcgdG8gYSBkaWZmZXJlbnQKLSAgICAgICAgICAgICMgc291cmNlIG9mIHRlc3RzLiBT cGVjaWZ5aW5nIHBvcnQgYnV0IG5vIHJvb3QgZG9lcyBub3Qgc2VlbQotICAgICAgICAgICAgIyBt ZWFuaW5nZnVsLgotICAgICAgICAgICAgcmFpc2UgJ1NwZWNpZnlpbmcgcG9ydCByZXF1aXJlcyBh bHNvIGEgcm9vdC4nCi0gICAgICAgIGhvc3QgPSBIb3N0KCkKLSAgICAgICAgIyBGSVhNRTogTWFr ZSB0aGlzIHdvcmsgd2l0aCBvdGhlciBwb3J0cyBhcyB3ZWxsLgotICAgICAgICBwb3J0X29iaiA9 IGhvc3QucG9ydF9mYWN0b3J5LmdldChwb3J0X25hbWU9J3dpbicsIG9wdGlvbnM9b3B0aW9ucykK LSAgICAgICAgaHR0cGQgPSBodHRwX3NlcnZlci5MaWdodHRwZChwb3J0X29iaiwKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0ZW1wZmlsZS5nZXR0ZW1wZGlyKCksCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcG9ydD1vcHRpb25zLnBvcnQsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcm9vdD1vcHRpb25zLnJvb3QsCi0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcnVuX2JhY2tncm91bmQ9b3B0aW9ucy5y dW5fYmFja2dyb3VuZCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXlv dXRfdGVzdHNfZGlyPW9wdGlvbnMubGF5b3V0X3Rlc3RzX2RpcikKLSAgICAgICAgaWYgb3B0aW9u cy5zZXJ2ZXIgPT0gJ3N0YXJ0JzoKLSAgICAgICAgICAgIGh0dHBkLnN0YXJ0KCkKLSAgICAgICAg ZWxzZToKLSAgICAgICAgICAgIGh0dHBkLnN0b3AoKQotCi0KLWRlZiBtYWluKCk6Ci0gICAgb3B0 aW9uX3BhcnNlciA9IG9wdHBhcnNlLk9wdGlvblBhcnNlcigpCi0gICAgb3B0aW9uX3BhcnNlci5h ZGRfb3B0aW9uKCctaycsICctLXNlcnZlcicsCi0gICAgICAgIGhlbHA9J1NlcnZlciBhY3Rpb24g KHN0YXJ0fHN0b3ApJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy1wJywgJy0tcG9y dCcsCi0gICAgICAgIGhlbHA9J1BvcnQgdG8gbGlzdGVuIG9uIChvdmVycmlkZXMgbGF5b3V0IHRl c3QgcG9ydHMpJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy1yJywgJy0tcm9vdCcs Ci0gICAgICAgIGhlbHA9J0Fic29sdXRlIHBhdGggdG8gRG9jdW1lbnRSb290IChvdmVycmlkZXMg bGF5b3V0IHRlc3Qgcm9vdHMpJykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy0tcmVn aXN0ZXJfY3lnd2luJywgYWN0aW9uPSJzdG9yZV90cnVlIiwKLSAgICAgICAgZGVzdD0icmVnaXN0 ZXJfY3lnd2luIiwgaGVscD0nUmVnaXN0ZXIgQ3lnd2luIHBhdGhzIChvbiBXaW4gdHJ5IGJvdHMp JykKLSAgICBvcHRpb25fcGFyc2VyLmFkZF9vcHRpb24oJy0tcnVuX2JhY2tncm91bmQnLCBhY3Rp b249InN0b3JlX3RydWUiLAotICAgICAgICBkZXN0PSJydW5fYmFja2dyb3VuZCIsCi0gICAgICAg IGhlbHA9J1J1biBvbiBiYWNrZ3JvdW5kIChmb3IgcnVubmluZyBhcyBVSSB0ZXN0KScpCi0gICAg b3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctLWxheW91dF90ZXN0c19kaXInLAotICAgICAgICBk ZXN0PSJsYXlvdXRfdGVzdHNfZGlyIiwKLSAgICAgICAgaGVscD0nQWJzb2x1dGUgcGF0aCB0byBM YXlvdXRUZXN0cyByb290JykKLSAgICBvcHRpb25zLCBhcmdzID0gb3B0aW9uX3BhcnNlci5wYXJz ZV9hcmdzKCkKLQotICAgIHJ1bihvcHRpb25zKQotCi0KLWlmICdfX21haW5fXycgPT0gX19uYW1l X186Ci0gICAgbWFpbigpCg==