176478 2017-09-06 15:57:11 -0700 bisect-builds started failing with invalid json 2018-01-15 12:51:12 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 lforschler lforschler aakash_jain ap lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1346130 0 lforschler 2017-09-06 15:57:11 -0700 the json retrieval portion of the API gateway recently started returning invalid json. After doing some google searching, it turns out they limit it to 1000 'things' returned. This breaks our use case. https://forums.aws.amazon.com/thread.jspa?messageID=702451&#702451 1346131 1 webkit-bug-importer 2017-09-06 15:57:38 -0700 <rdar://problem/34293921> 1346139 2 lforschler 2017-09-06 16:20:24 -0700 Apparently this has recently been documented here: http://docs.aws.amazon.com/apigateway/latest/developerguide/limits.html 1346173 3 lforschler 2017-09-06 17:32:39 -0700 I have a fix that I'm iterating on now... basically we need to avoid using the foreach loop in the AWS body mapping template. Instead, I can just pass along the raw JSON without mapping it to a new output format. 1346406 4 320135 lforschler 2017-09-07 10:46:45 -0700 Created attachment 320135 Update the json parsing implementation 1346410 5 aakash_jain 2017-09-07 10:49:28 -0700 rs=me assuming it is tested properly. It would be good to mention the links to AWS rest API v2 either in ChangeLog or in comments here. 1346419 6 lforschler 2017-09-07 10:55:15 -0700 Note, I have bumped our REST API implementation from v1 to v2. This is to avoid breaking anything currently relying on v1. Note, there is nothing else currently using this tool at the moment, but this should be done moving forward as a good engineering practice. old: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v1/' new: REST_API_URL = 'https://q1tzqfy48e.execute-api.us-west-2.amazonaws.com/v2/' 1346422 7 lforschler 2017-09-07 10:56:43 -0700 Committed revision 221741. 320135 2017-09-07 10:46:45 -0700 2018-01-15 12:51:12 -0800 Update the json parsing implementation 176478.patch text/plain 1842 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTczOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE3LTA5LTA3ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzIHN0YXJ0ZWQgZmFpbGluZyB3aXRoIGludmFs aWQganNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc2NDc4CisgICAgICAgIAorICAgICAgICBPbmNlIHdlIGhpdCAxMDAwIGl0ZW1zIGluIG91ciBk eW5hbW9EQiwgd2UgcmFuIGludG8gYW4gdXBwZXIgbGltaXQgb24gdGhlIEFXUyBBUEkgR2F0ZXdh eSBsb29waW5nIG1lY2hhbmlzbS4gCisgICAgICAgIFRoaXMgcHJldmVudGVkIHVzIGZyb20gZG9p bmcgYSBib2R5IG1hcHBpbmcgdGVtcGxhdGUgdG8gcmVmb3JtYXQgdGhlIGpzb24uIFRoaXMgZml4 IGlzIHRvIHNpbXBseSByZXR1cm4gdGhlIHJhdyBqc29uLCAKKyAgICAgICAgYW5kIGFkanVzdCB0 aGUganNvbiBwYXJzaW5nIGluIG91ciBjb2RlLiBUaGUgQVdTIHJlc3QgQVBJIGhhcyBiZWVuIGZp eGVkLCBhbmQgdXBkYXRlZCB0byB2Mi4gCisgICAgICAgIAorICAgICAgICBUaGlzIGNoYW5nZSBp cyBmb3IgdGhlIHNjcmlwdCB3aGljaCBvcGVyYXRlcyBhZ2FpbnN0IHRoZSBlbmRwb2ludC4KKyAg ICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9iaXNlY3QtYnVpbGRzOgorICAgICAgICAoZ2V0X3NvcnRlZF9yZXZpc2lvbnMpOgor CiAyMDE3LTA5LTA3ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbV2luXSBEYXNoYm9hcmQgdGVzdCBpcyBmYWlsaW5nLgpJbmRleDogVG9vbHMvU2NyaXB0 cy9iaXNlY3QtYnVpbGRzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxk cwkocmV2aXNpb24gMjIxNzM5KQorKysgVG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVpbGRzCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNyw3ICszNyw3IEBAIGltcG9ydCBzeXMKIGltcG9ydCB0ZW1wZmlsZQog aW1wb3J0IHVybHBhcnNlCiAKLVJFU1RfQVBJX1VSTCA9ICdodHRwczovL3ExdHpxZnk0OGUuZXhl Y3V0ZS1hcGkudXMtd2VzdC0yLmFtYXpvbmF3cy5jb20vdjEvJworUkVTVF9BUElfVVJMID0gJ2h0 dHBzOi8vcTF0enFmeTQ4ZS5leGVjdXRlLWFwaS51cy13ZXN0LTIuYW1hem9uYXdzLmNvbS92Mi8n CiBSRVNUX0FQSV9FTkRQT0lOVCA9ICdhcmNoaXZlcy8nCiBSRVNUX0FQSV9NSU5JRklFRF9FTkRQ T0lOVCA9ICdtaW5pZmllZC1hcmNoaXZlcy8nCiAKQEAgLTEyMCw3ICsxMjAsNyBAQCBkZWYgZ2V0 X2luZGljZXNfZnJvbV9yZXZpc2lvbnMocmV2aXNpb25fCiAKIAogZGVmIGdldF9zb3J0ZWRfcmV2 aXNpb25zKHJldmlzaW9uc19kaWN0KToKLSAgICByZXZpc2lvbnMgPSBbaW50KHJldmlzaW9uWydy ZXZpc2lvbiddKSBmb3IgcmV2aXNpb24gaW4gcmV2aXNpb25zX2RpY3RbJ3JldmlzaW9ucyddXQor ICAgIHJldmlzaW9ucyA9IFtpbnQoaXRlbVsncmV2aXNpb24nXVsnTiddKSBmb3IgaXRlbSBpbiBy ZXZpc2lvbnNfZGljdFsncmV2aXNpb25zJ11bJ0l0ZW1zJ11dCiAgICAgcmV0dXJuIHNvcnRlZChy ZXZpc2lvbnMpCiAgICAgCiAK