176475 2017-09-06 13:42:57 -0700 [WPE][CMake] The “install” target should install all public API headers 2017-10-10 04:30:46 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178100 https://bugs.webkit.org/show_bug.cgi?id=178104 P2 Normal --- 178125 1 aperez aperez achristensen bugs-noreply cgarcia clopez commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1346084 0 aperez 2017-09-06 13:42:57 -0700 Today while working in bug #176448 I noticed that the “install” target for WPE only installs the JavaScriptCore headers (see the log below). The rest of the public API headers should be installed as well. --- [100%] Built target WebProcess Install the project... -- Install configuration: "Release" -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSBase.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSContextRef.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSObjectRef.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSStringRef.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSTypedArray.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JSValueRef.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/JavaScript.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/include/wpe-0.1/WPE/JavaScriptCore/WebKitAvailability.h -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/lib/libWPEWebInspectorResources.so -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPEStorageProcess -- Set runtime path of "/home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPEStorageProcess" to "" -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/lib/libWPEWebKit.so.0.0.20170728 -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/lib/libWPEWebKit.so.0 -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/lib/libWPEWebKit.so -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPEWebProcess -- Set runtime path of "/home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPEWebProcess" to "" -- Installing: /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPENetworkProcess -- Set runtime path of "/home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728/_install/bin/WPENetworkProcess" to "" /home/aperez/devel/wpe/WebKit/WebKitBuild/Release/wpewebkit-0.0.20170728.tar (1/1) 1358441 1 323226 aperez 2017-10-09 14:53:27 -0700 Created attachment 323226 Patch 1358455 2 aperez 2017-10-09 15:16:22 -0700 With the patch applied, the “tree” command generates the output below. The idea is that programs using the WPE WebKit port would use: #include <wpe/webkit.h> The deprecated WebKit2 C API is still around and disabled by default. It can be installed in parallel passing “-DEXPORT_DEPRECATED_WEBKIT2_C_API” to CMake when configuring. ----8<----------------- tree output -------------------8<---- /home/aperez/devel/wpe/buildroot/output/target/usr/include/wpe-0.1/ └── WPE ├── JavaScriptCore │ ├── JavaScript.h │ ├── JSBase.h │ ├── JSContextRef.h │ ├── JSObjectRef.h │ ├── JSStringRef.h │ ├── JSTypedArray.h │ ├── JSValueRef.h │ └── WebKitAvailability.h └── wpe ├── WebKitApplicationInfo.h ├── WebKitAuthenticationRequest.h ├── WebKitAutomationSession.h ├── WebKitBackForwardList.h ├── WebKitBackForwardListItem.h ├── WebKitContextMenuActions.h ├── WebKitContextMenu.h ├── WebKitContextMenuItem.h ├── WebKitCookieManager.h ├── WebKitCredential.h ├── WebKitDefines.h ├── WebKitDownload.h ├── WebKitEditingCommands.h ├── WebKitEditorState.h ├── WebKitEnumTypes.h ├── WebKitError.h ├── WebKitFaviconDatabase.h ├── WebKitFindController.h ├── WebKitFormSubmissionRequest.h ├── WebKitGeolocationPermissionRequest.h ├── webkit.h ├── WebKitHitTestResult.h ├── WebKitInstallMissingMediaPluginsPermissionRequest.h ├── WebKitJavascriptResult.h ├── WebKitMimeInfo.h ├── WebKitNavigationAction.h ├── WebKitNavigationPolicyDecision.h ├── WebKitNetworkProxySettings.h ├── WebKitNotification.h ├── WebKitNotificationPermissionRequest.h ├── WebKitPermissionRequest.h ├── WebKitPlugin.h ├── WebKitPolicyDecision.h ├── WebKitResponsePolicyDecision.h ├── WebKitSecurityManager.h ├── WebKitSecurityOrigin.h ├── WebKitSettings.h ├── WebKitURIRequest.h ├── WebKitURIResponse.h ├── WebKitURISchemeRequest.h ├── WebKitUserContent.h ├── WebKitUserContentManager.h ├── WebKitUserMediaPermissionRequest.h ├── WebKitWebContext.h ├── WebKitWebResource.h ├── WebKitWebsiteData.h ├── WebKitWebsiteDataManager.h ├── WebKitWebView.h ├── WebKitWebViewSessionState.h └── WebKitWindowProperties.h 3 directories, 58 files 1358704 3 cgarcia 2017-10-10 03:51:46 -0700 (In reply to Adrian Perez from comment #2) > With the patch applied, the “tree” command generates the output below. > The idea is that programs using the WPE WebKit port would use: > > #include <wpe/webkit.h> > > The deprecated WebKit2 C API is still around and disabled by default. > It can be installed in parallel passing “-DEXPORT_DEPRECATED_WEBKIT2_C_API” > to CMake when configuring. We should not allow to install the C API in any case in upstream. > ----8<----------------- tree output -------------------8<---- > > /home/aperez/devel/wpe/buildroot/output/target/usr/include/wpe-0.1/ > └── WPE > ├── JavaScriptCore > │ ├── JavaScript.h > │ ├── JSBase.h > │ ├── JSContextRef.h > │ ├── JSObjectRef.h > │ ├── JSStringRef.h > │ ├── JSTypedArray.h > │ ├── JSValueRef.h > │ └── WebKitAvailability.h > └── wpe > ├── WebKitApplicationInfo.h > ├── WebKitAuthenticationRequest.h > ├── WebKitAutomationSession.h > ├── WebKitBackForwardList.h > ├── WebKitBackForwardListItem.h > ├── WebKitContextMenuActions.h > ├── WebKitContextMenu.h > ├── WebKitContextMenuItem.h > ├── WebKitCookieManager.h > ├── WebKitCredential.h > ├── WebKitDefines.h > ├── WebKitDownload.h > ├── WebKitEditingCommands.h > ├── WebKitEditorState.h > ├── WebKitEnumTypes.h > ├── WebKitError.h > ├── WebKitFaviconDatabase.h > ├── WebKitFindController.h > ├── WebKitFormSubmissionRequest.h > ├── WebKitGeolocationPermissionRequest.h > ├── webkit.h > ├── WebKitHitTestResult.h > ├── WebKitInstallMissingMediaPluginsPermissionRequest.h > ├── WebKitJavascriptResult.h > ├── WebKitMimeInfo.h > ├── WebKitNavigationAction.h > ├── WebKitNavigationPolicyDecision.h > ├── WebKitNetworkProxySettings.h > ├── WebKitNotification.h > ├── WebKitNotificationPermissionRequest.h > ├── WebKitPermissionRequest.h > ├── WebKitPlugin.h > ├── WebKitPolicyDecision.h > ├── WebKitResponsePolicyDecision.h > ├── WebKitSecurityManager.h > ├── WebKitSecurityOrigin.h > ├── WebKitSettings.h > ├── WebKitURIRequest.h > ├── WebKitURIResponse.h > ├── WebKitURISchemeRequest.h > ├── WebKitUserContent.h > ├── WebKitUserContentManager.h > ├── WebKitUserMediaPermissionRequest.h > ├── WebKitWebContext.h > ├── WebKitWebResource.h > ├── WebKitWebsiteData.h > ├── WebKitWebsiteDataManager.h > ├── WebKitWebView.h > ├── WebKitWebViewSessionState.h > └── WebKitWindowProperties.h > > 3 directories, 58 files 1358713 4 aperez 2017-10-10 04:27:08 -0700 (In reply to Carlos Garcia Campos from comment #3) > (In reply to Adrian Perez from comment #2) > > With the patch applied, the “tree” command generates the output below. > > The idea is that programs using the WPE WebKit port would use: > > > > #include <wpe/webkit.h> > > > > The deprecated WebKit2 C API is still around and disabled by default. > > It can be installed in parallel passing “-DEXPORT_DEPRECATED_WEBKIT2_C_API” > > to CMake when configuring. > > We should not allow to install the C API in any case in upstream. I completely agree with this, but I was afraid that there might be someone still using the C API so it seemed better to leave it around for now and handle its removal in a separate bug+patch. I have just filed bug #178125 for that. 1358714 5 323226 commit-queue 2017-10-10 04:27:43 -0700 Comment on attachment 323226 Patch Clearing flags on attachment: 323226 Committed r223128: <http://trac.webkit.org/changeset/223128> 1358715 6 commit-queue 2017-10-10 04:27:45 -0700 All reviewed patches have been landed. Closing bug. 323226 2017-10-09 14:53:27 -0700 2017-10-10 04:27:43 -0700 Patch bug-176475-20171009235326.patch text/plain 1801 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ3OTZmODk0YWYxMjBmYTIz Zjg3YmJjMjI4NGE0Yjc5YzVjYWRlZWEuLjhlMDFiNzUyZDVmNWUwNmJjYjFlZTMyZDhkOTYzYjA0 NzA1ODcwMTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTAtMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtDTWFr ZV0gVGhlIOKAnGluc3RhbGzigJ0gdGFyZ2V0IHNob3VsZCBpbnN0YWxsIGFsbCBwdWJsaWMgQVBJ IGhlYWRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NjQ3NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluc3RhbGwgdGhlIFdQRSBwb3J0IEdMaWItYmFzZWQgQVBJIGhlYWRlcnMuIFRoZSBkZXByZWNh dGVkIEMgQVBJIGlzIHN0aWxsIGF2YWlsYWJsZSwKKyAgICAgICAgYnV0IGRpc2FibGVkIGJ5IGRl ZmF1bHQgYmVoaW5kIHRoZSAiRVhQT1JUX0RFUFJFQ0FURURfV0VCS0lUMl9DX0FQSSIgQ01ha2Ug b3B0aW9uLgorCisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6IEFsd2F5cyBpbnN0YWxsICJ3 cGUtd2Via2l0LnBjIiBhbmQgdGhlIEdMaWIgQyBBUEkgZm9yIFdQRS4KKwogMjAxNy0xMC0wOSAg U2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgSGFzaE1hcDo6a2V5 cygpIGFuZCBIYXNoTWFwOjp2YWx1ZXMoKSB3b3JrIHdpdGggV1RGOjptYXAvV1RGOjpjb3B5VG9W ZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UgYi9Tb3Vy Y2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGE1YjYzMDM4ZjI1NzY0MTgyYmVmZWFi YTc2ODhiNDJjMDIzZDcwZWYuLmQ0MWZlMzdhOWUxYjhjMzRkM2RmOGVjOWVmODgxYTdhZTFjM2Rh ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291 cmNlL1dlYktpdC9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtNjI5LDkgKzYyOSwxNCBAQCBpZiAoRVhQ T1JUX0RFUFJFQ0FURURfV0VCS0lUMl9DX0FQSSkKICAgICAgICAgREVTVElOQVRJT04gIiR7Q01B S0VfSU5TVEFMTF9JTkNMVURFRElSfS93cGUtJHtXUEVfQVBJX1ZFUlNJT059L1dQRSIKICAgICAg ICAgQ09NUE9ORU5UICJEZXZlbG9wbWVudCIKICAgICApCi0KLSAgICBpbnN0YWxsKEZJTEVTICR7 Q01BS0VfQklOQVJZX0RJUn0vd3BlLXdlYmtpdC5wYwotICAgICAgICBERVNUSU5BVElPTiAiJHtD TUFLRV9JTlNUQUxMX0xJQkRJUn0vcGtnY29uZmlnIgotICAgICAgICBDT01QT05FTlQgIkRldmVs b3BtZW50IgotICAgICkKIGVuZGlmICgpCisKK2luc3RhbGwoRklMRVMgIiR7Q01BS0VfQklOQVJZ X0RJUn0vd3BlLXdlYmtpdC5wYyIKKyAgICBERVNUSU5BVElPTiAiJHtDTUFLRV9JTlNUQUxMX0xJ QkRJUn0vcGtnY29uZmlnIgorICAgIENPTVBPTkVOVCAiRGV2ZWxvcG1lbnQiCispCisKK2luc3Rh bGwoRklMRVMgJHtXUEVfQVBJX0lOU1RBTExFRF9IRUFERVJTfQorICAgIERFU1RJTkFUSU9OICIk e0NNQUtFX0lOU1RBTExfSU5DTFVERURJUn0vd3BlLSR7V1BFX0FQSV9WRVJTSU9OfS9XUEUvd3Bl IgorICAgIENPTVBPTkVOVCAiRGV2ZWxvcG1lbnQiCispCg==