176471 2017-09-06 11:05:34 -0700 [Win] test-webkitpy test timeout_context_unittest is failing. 2017-09-27 13:03:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham buildbot commit-queue glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1346014 0 pvollan 2017-09-06 11:05:34 -0700 Traceback (most recent call last): File "/home/buildbot/slave/win-release-tests/build/Tools/Scripts/webkitpy/common/timeout_context_unittest.py", line 47, in test_timeout_data self.assertGreater(time.time() + 1, tmp.data.alarm_time) AssertionError: 1504671591.995077 not greater than 1504671591.995077 1346016 1 320042 pvollan 2017-09-06 11:16:15 -0700 Created attachment 320042 Patch 1346031 2 jbedard 2017-09-06 11:57:53 -0700 What platform was this failing on? I'm really surprised this is an issue. 1346037 3 pvollan 2017-09-06 12:05:14 -0700 (In reply to Jonathan Bedard from comment #2) > What platform was this failing on? > > I'm really surprised this is an issue. It is failing on Windows. Do you think differences in time(r) resolution can cause this? 1346038 4 jbedard 2017-09-06 12:08:48 -0700 (In reply to Per Arne Vollan from comment #3) > (In reply to Jonathan Bedard from comment #2) > > What platform was this failing on? > > > > I'm really surprised this is an issue. > > It is failing on Windows. Do you think differences in time(r) resolution can > cause this? Looking closer at that test, yes. time(r) resolution could cause this. I'm less surprised now that I've looked closer. Unofficial R+ from me (No a reviewer yet). 1346045 5 pvollan 2017-09-06 12:33:11 -0700 (In reply to Jonathan Bedard from comment #4) > (In reply to Per Arne Vollan from comment #3) > > (In reply to Jonathan Bedard from comment #2) > > > What platform was this failing on? > > > > > > I'm really surprised this is an issue. > > > > It is failing on Windows. Do you think differences in time(r) resolution can > > cause this? > > Looking closer at that test, yes. time(r) resolution could cause this. I'm > less surprised now that I've looked closer. > > Unofficial R+ from me (No a reviewer yet). Ok, thanks! 1346047 6 320042 bfulgham 2017-09-06 12:36:46 -0700 Comment on attachment 320042 Patch r=me. I wish Windows had better time resolution! 1346072 7 pvollan 2017-09-06 13:19:12 -0700 (In reply to Brent Fulgham from comment #6) > Comment on attachment 320042 [details] > Patch > > r=me. I wish Windows had better time resolution! Thanks for reviewing! 1346086 8 320042 commit-queue 2017-09-06 13:48:04 -0700 Comment on attachment 320042 Patch Clearing flags on attachment: 320042 Committed r221700: <http://trac.webkit.org/changeset/221700> 1346087 9 commit-queue 2017-09-06 13:48:06 -0700 All reviewed patches have been landed. Closing bug. 1353788 10 webkit-bug-importer 2017-09-27 13:03:02 -0700 <rdar://problem/34694550> 320042 2017-09-06 11:16:15 -0700 2017-09-06 13:48:04 -0700 Patch bug-176471-20170906201616.patch text/plain 1478 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTY4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTA5LTA2ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSB0ZXN0LXdlYmtpdHB5IHRlc3QgdGltZW91dF9jb250ZXh0X3Vu aXR0ZXN0IGlzIGZhaWxpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzY0NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGFzc2VydCBmYWlsdXJlIGlzIHBvc3NpYmx5IGNhdXNlZCBieSBkaWZm ZXJlbnQgdGltZSByZXNvbHV0aW9uIG9uCisgICAgICAgIHZhcmlvdXMgcGxhdGZvcm1zLgorIAor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3RpbWVvdXRfY29udGV4dF91bml0dGVz dC5weToKKyAgICAgICAgKFRpbWVvdXRDb250ZXh0VGVzdHMudGVzdF90aW1lb3V0X2RhdGEpOgor CiAyMDE3LTA5LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAg ICBDb3B5IFdlYktpdCBQZXJtYWxpbmsgbWF5IGdlbmVyYXRlIHdyb25nIFVSTCB3aXRoIFNWTiBj aGVja291dApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGltZW91dF9jb250 ZXh0X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3RpbWVvdXRfY29udGV4dF91bml0dGVzdC5weQkocmV2aXNpb24gMjIxNjg0KQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGltZW91dF9jb250ZXh0X3VuaXR0ZXN0LnB5CSh3 b3JraW5nIGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIGNsYXNzIFRpbWVvdXRDb250ZXh0VGVzdHMo dW5pdHRlc3QuVGVzdEMKICAgICAgICAgd2l0aCB0bXA6CiAgICAgICAgICAgICBzZWxmLmFzc2Vy dE5vdEVxdWFsKE5vbmUsIHRtcC5kYXRhKQogICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbCh0 aHJlYWRpbmcuY3VycmVudF90aHJlYWQoKS5pZGVudCwgdG1wLmRhdGEudGhyZWFkX2lkKQotICAg ICAgICAgICAgc2VsZi5hc3NlcnRHcmVhdGVyKHRpbWUudGltZSgpICsgMSwgdG1wLmRhdGEuYWxh cm1fdGltZSkKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSh0aW1lLnRpbWUoKSArIDEgPj0g dG1wLmRhdGEuYWxhcm1fdGltZSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChOb25lLCB0bXAu ZGF0YSkKIAogICAgIGRlZiB0ZXN0X25lc3RlZF9pbm5lcl9wcmVjZWRlbmNlKHNlbGYpOgo=