176470 2017-09-06 11:02:38 -0700 ASSERTION FAILED: op() == CheckStructure in Source/JavaScriptCore/dfg/DFGNode.h(443) 2017-09-27 12:34:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ryanhaddad saam ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1346012 0 jlewis3 2017-09-06 11:02:38 -0700 The test stress/phantom-spread-forward-varargs.js.ftl-eager has had a flaky assertion failure on El Capitan JSC Debug testers ASSERTION FAILED: op() == CheckStructure /Volumes/Data/slave/elcapitan-debug/build/Source/JavaScriptCore/dfg/DFGNode.h(443) : void JSC::DFG::Node::convertToCheckStructureImmediate(JSC::DFG::Node *) 1 0x1066ecd40 WTFCrash 2 0x105b04ec0 JSC::DFG::Node::convertToCheckStructureImmediate(JSC::DFG::Node*) 3 0x105afa3be void JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::handleNode<JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::promoteLocalHeap()::'lambda1'(JSC::DFG::PromotedHeapLocation, JSC::DFG::LazyNode), JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::promoteLocalHeap()::'lambda1'(JSC::DFG::PromotedHeapLocation)>(JSC::DFG::Node*, JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::promoteLocalHeap()::'lambda1'(JSC::DFG::PromotedHeapLocation, JSC::DFG::LazyNode) const&, JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::promoteLocalHeap()::'lambda1'(JSC::DFG::PromotedHeapLocation) const&) 4 0x105ae0338 JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::promoteLocalHeap() 5 0x105adcc03 JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::performSinking() 6 0x105adc852 JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase::run() 7 0x105adc2a2 bool JSC::DFG::runAndLog<JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase>(JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase&) 8 0x105adc1fe bool JSC::DFG::runPhase<JSC::DFG::(anonymous namespace)::ObjectAllocationSinkingPhase>(JSC::DFG::Graph&) 9 0x105adc1c5 JSC::DFG::performObjectAllocationSinking(JSC::DFG::Graph&) 10 0x105b90c58 JSC::DFG::Plan::compileInThreadImpl() 11 0x105b8cc5d JSC::DFG::Plan::compileInThread(JSC::DFG::ThreadData*) 12 0x105d1fece JSC::DFG::Worklist::ThreadBody::work() 13 0x1066fa82e WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0::operator()() const 14 0x1066fa50c WTF::Function<void ()>::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0>::call() 15 0x10672647e WTF::Function<void ()>::operator()() const 16 0x106775f0a WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) 17 0x10677b8f5 WTF::wtfThreadEntryPoint(void*) 18 0x7fff8513b99d _pthread_body 19 0x7fff8513b91a _pthread_body 20 0x7fff85139351 thread_start test_script_16221: line 2: 33007 Segmentation fault: 11 ( "$@" ../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --maxPerThreadStackUsage\=1572864 --airForceBriggsAllocator\=true --useFTLJIT\=true --thresholdForJITAfterWarmUp\=10 --thresholdForJITSoon\=10 --thresholdForOptimizeAfterWarmUp\=20 --thresholdForOptimizeAfterLongWarmUp\=20 --thresholdForOptimizeSoon\=20 --thresholdForFTLOptimizeAfterWarmUp\=20 --thresholdForFTLOptimizeSoon\=20 --maximumEvalCacheableSourceLength\=150000 --useEagerCodeBlockJettisonTiming\=true phantom-spread-forward-varargs.js ) ERROR: Unexpected exit code: 139 1346029 1 saam 2017-09-06 11:54:24 -0700 This seems like it's my bug. Will fix. 1346035 2 320045 saam 2017-09-06 12:03:39 -0700 Created attachment 320045 patch 1346053 3 320045 mark.lam 2017-09-06 12:55:49 -0700 Comment on attachment 320045 patch r=me 1346088 4 320045 commit-queue 2017-09-06 13:51:05 -0700 Comment on attachment 320045 patch Clearing flags on attachment: 320045 Committed r221701: <http://trac.webkit.org/changeset/221701> 1346089 5 commit-queue 2017-09-06 13:51:07 -0700 All reviewed patches have been landed. Closing bug. 1353494 6 webkit-bug-importer 2017-09-27 12:34:46 -0700 <rdar://problem/34693520> 320045 2017-09-06 12:03:39 -0700 2017-09-06 13:51:05 -0700 patch c-backup.diff text/plain 1361 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxNjg5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE3LTA5LTA2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEFTU0VSVElPTiBGQUlMRUQ6IG9wKCkgPT0gQ2hlY2tTdHJ1Y3R1cmUgaW4gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdOb2RlLmgoNDQzKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NDcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIE5vZGU6OmNvbnZlcnRUb0NoZWNrU3RydWN0dXJl SW1tZWRpYXRlJ3MgYXNzZXJ0aW9uIHRvIGFsbG93CisgICAgICAgIHRoZSBub2RlIHRvIGVpdGhl ciBiZSBhIENoZWNrU3RydWN0dXJlIG9yIENoZWNrU3RydWN0dXJlT3JFbXB0eS4KKworICAgICAg ICAqIGRmZy9ERkdOb2RlLmg6CisgICAgICAgIChKU0M6OkRGRzo6Tm9kZTo6Y29udmVydFRvQ2hl Y2tTdHJ1Y3R1cmVJbW1lZGlhdGUpOgorCiAyMDE3LTA5LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIGlzTm90Q2VsbFNwZWN1bGF0aW9uIGlzIHdyb25nIHdp dGggcmVzcGVjdCB0byBTcGVjRW1wdHkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHTm9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9k ZS5oCShyZXZpc2lvbiAyMjE2ODkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05v ZGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDQwLDcgKzQ0MCw3IEBAIHB1YmxpYzoKIAogICAgIHZv aWQgY29udmVydFRvQ2hlY2tTdHJ1Y3R1cmVJbW1lZGlhdGUoTm9kZSogc3RydWN0dXJlKQogICAg IHsKLSAgICAgICAgQVNTRVJUKG9wKCkgPT0gQ2hlY2tTdHJ1Y3R1cmUpOworICAgICAgICBBU1NF UlQob3AoKSA9PSBDaGVja1N0cnVjdHVyZSB8fCBvcCgpID09IENoZWNrU3RydWN0dXJlT3JFbXB0 eSk7CiAgICAgICAgIG1fb3AgPSBDaGVja1N0cnVjdHVyZUltbWVkaWF0ZTsKICAgICAgICAgY2hp bGRyZW4uc2V0Q2hpbGQxKEVkZ2Uoc3RydWN0dXJlLCBDZWxsVXNlKSk7CiAgICAgfQo=