176429 2017-09-05 16:21:09 -0700 isNotCellSpeculation is wrong with respect to SpecEmpty 2017-09-27 12:37:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1345695 0 saam 2017-09-05 16:21:09 -0700 this may lead to OSR exit loops. 1345698 1 saam 2017-09-05 16:26:17 -0700 Consider something like this: a: JSConstant(JSValue()) If we ask @a in Fixup if shouldSpeculateNotCell, it'll return true. NotCellUse on @a will OSR exit, since it passes the cell check. 1345714 2 319956 saam 2017-09-05 16:48:12 -0700 Created attachment 319956 patch 1345715 3 319956 msaboff 2017-09-05 16:50:58 -0700 Comment on attachment 319956 patch View in context: https://bugs.webkit.org/attachment.cgi?id=319956&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + the SpecEmpty in the set for t. It should return false when the SpecEmpty is present, nit - Is "the" before the second SpecEmpty unnecessary? 1345717 4 319956 saam 2017-09-05 16:52:31 -0700 Comment on attachment 319956 patch View in context: https://bugs.webkit.org/attachment.cgi?id=319956&action=review >> Source/JavaScriptCore/ChangeLog:9 >> + the SpecEmpty in the set for t. It should return false when the SpecEmpty is present, > > nit - Is "the" before the second SpecEmpty unnecessary? it is. removed. 1345721 5 319959 saam 2017-09-05 16:54:39 -0700 Created attachment 319959 patch for landing 1345742 6 319959 commit-queue 2017-09-05 18:18:19 -0700 Comment on attachment 319959 patch for landing Clearing flags on attachment: 319959 Committed r221657: <http://trac.webkit.org/changeset/221657> 1345743 7 commit-queue 2017-09-05 18:18:21 -0700 All reviewed patches have been landed. Closing bug. 1353543 8 webkit-bug-importer 2017-09-27 12:37:43 -0700 <rdar://problem/34693636> 319956 2017-09-05 16:48:12 -0700 2017-09-05 16:54:39 -0700 patch c-backup.diff text/plain 2763 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjE2NDgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIGlzTm90Q2VsbFNwZWN1bGF0aW9uIGlzIHdyb25nIHcuci50IFNwZWND ZWxsQ2hlY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3NjQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogbWljcm9iZW5jaG1hcmtzL2lzLW5vdC1jZWxsLXNwZWN1bGF0aW9uLWZvci1lbXB0eS12YWx1 ZS5qczogQWRkZWQuCisgICAgICAgIChGb28pOgorCiAyMDE3LTA5LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgdGVzdDI2MjogQ29tcGxldGlvbiB2 YWx1ZXMgZm9yIGNvbnRyb2wgZmxvdyBkbyBub3QgbWF0Y2ggdGhlIHNwZWMKSW5kZXg6IEpTVGVz dHMvbWljcm9iZW5jaG1hcmtzL2lzLW5vdC1jZWxsLXNwZWN1bGF0aW9uLWZvci1lbXB0eS12YWx1 ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9pcy1ub3QtY2VsbC1z cGVjdWxhdGlvbi1mb3ItZW1wdHktdmFsdWUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9t aWNyb2JlbmNobWFya3MvaXMtbm90LWNlbGwtc3BlY3VsYXRpb24tZm9yLWVtcHR5LXZhbHVlLmpz CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMgQEAKK2NsYXNzIEZvbyBleHRlbmRzIE9iamVj dCB7CisgICAgY29uc3RydWN0b3IoKSB7CisgICAgICAgIHN1cGVyKCk7CisgICAgICAgIGxldCBh cnJvdyA9ICgpID0+IHsKKyAgICAgICAgICAgIHRoaXMuZm9vID0gMjA7CisgICAgICAgIH07Cisg ICAgICAgIHRoaXMuYXJyb3cgPSBhcnJvdzsKKyAgICB9Cit9Citub0lubGluZShGb28pOworCitm b3IgKGxldCBpID0gMDsgaSA8IDQwMDAwMDsgKytpKQorICAgIG5ldyBGb28oKTsKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxNjQyKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA5 LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIGlzTm90Q2Vs bFNwZWN1bGF0aW9uIGlzIHdyb25nIHcuci50IFNwZWNDZWxsQ2hlY2sKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjQyOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBpc05vdENlbGxTcGVjdWxhdGlv bihTcGVjdWxhdGVkVHlwZSB0KSBmdW5jdGlvbiB3YXMgbm90IHRha2luZyBpbnRvIGFjY291bnQK KyAgICAgICAgdGhlIFNwZWNFbXB0eSBpbiB0aGUgc2V0IGZvciB0LiBJdCBzaG91bGQgcmV0dXJu IGZhbHNlIHdoZW4gdGhlIFNwZWNFbXB0eSBpcyBwcmVzZW50LAorICAgICAgICBzaW5jZSB0aGUg ZW1wdHkgdmFsdWUgd2lsbCBmYWlsIGEgTm90Q2VsbCBjaGVjay4gVGhpcyBidWcgd291bGQgY2F1 c2UgdXMgdG8gZXJyb25lb3VzbHkKKyAgICAgICAgZ2VuZXJhdGUgTm90Q2VsbFVzZSBVc2VLaW5k cyBmb3IgaW5wdXRzIHRoYXQgYXJlIHRoZSBlbXB0eSB2YWx1ZSwgY2F1c2luZyByZXBlYXRlZCBP U1IgZXhpdHMuCisKKyAgICAgICAgKiBieXRlY29kZS9TcGVjdWxhdGVkVHlwZS5oOgorICAgICAg ICAoSlNDOjppc05vdENlbGxTcGVjdWxhdGlvbik6CisKIDIwMTctMDktMDUgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSB0aGUgZGlzdGluY3Rpb24gYmV0 d2VlbiBlbnRyeXBvaW50cyBhbmQgQ0ZHIHJvb3RzIG1vcmUgY2xlYXIgYnkgbmFtaW5nIHRoaW5n cyBiZXR0ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVjdWxhdGVk VHlwZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TcGVj dWxhdGVkVHlwZS5oCShyZXZpc2lvbiAyMjE2NDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE5LDcgKzExOSw3 IEBAIGlubGluZSBib29sIGlzQ2VsbE9yT3RoZXJTcGVjdWxhdGlvbihTcGUKIAogaW5saW5lIGJv b2wgaXNOb3RDZWxsU3BlY3VsYXRpb24oU3BlY3VsYXRlZFR5cGUgdmFsdWUpCiB7Ci0gICAgcmV0 dXJuICEodmFsdWUgJiBTcGVjQ2VsbCkgJiYgdmFsdWU7CisgICAgcmV0dXJuICEodmFsdWUgJiBT cGVjQ2VsbENoZWNrKSAmJiB2YWx1ZTsKIH0KIAogaW5saW5lIGJvb2wgaXNPYmplY3RTcGVjdWxh dGlvbihTcGVjdWxhdGVkVHlwZSB2YWx1ZSkK 319959 2017-09-05 16:54:39 -0700 2017-09-05 18:18:19 -0700 patch for landing c-backup.diff text/plain 2767 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjE2NDgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE3LTA5LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIGlzTm90Q2VsbFNwZWN1bGF0aW9uIGlzIHdyb25nIHdpdGggcmVzcGVj dCB0byBTcGVjRW1wdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3NjQyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgU2Fib2ZmLgorCisg ICAgICAgICogbWljcm9iZW5jaG1hcmtzL2lzLW5vdC1jZWxsLXNwZWN1bGF0aW9uLWZvci1lbXB0 eS12YWx1ZS5qczogQWRkZWQuCisgICAgICAgIChGb28pOgorCiAyMDE3LTA5LTA1ICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgdGVzdDI2MjogQ29tcGxl dGlvbiB2YWx1ZXMgZm9yIGNvbnRyb2wgZmxvdyBkbyBub3QgbWF0Y2ggdGhlIHNwZWMKSW5kZXg6 IEpTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2lzLW5vdC1jZWxsLXNwZWN1bGF0aW9uLWZvci1lbXB0 eS12YWx1ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9pcy1ub3Qt Y2VsbC1zcGVjdWxhdGlvbi1mb3ItZW1wdHktdmFsdWUuanMJKG5vbmV4aXN0ZW50KQorKysgSlNU ZXN0cy9taWNyb2JlbmNobWFya3MvaXMtbm90LWNlbGwtc3BlY3VsYXRpb24tZm9yLWVtcHR5LXZh bHVlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTMgQEAKK2NsYXNzIEZvbyBleHRlbmRz IE9iamVjdCB7CisgICAgY29uc3RydWN0b3IoKSB7CisgICAgICAgIHN1cGVyKCk7CisgICAgICAg IGxldCBhcnJvdyA9ICgpID0+IHsKKyAgICAgICAgICAgIHRoaXMuZm9vID0gMjA7CisgICAgICAg IH07CisgICAgICAgIHRoaXMuYXJyb3cgPSBhcnJvdzsKKyAgICB9Cit9Citub0lubGluZShGb28p OworCitmb3IgKGxldCBpID0gMDsgaSA8IDQwMDAwMDsgKytpKQorICAgIG5ldyBGb28oKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIxNjQyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisy MDE3LTA5LTA1ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIGlz Tm90Q2VsbFNwZWN1bGF0aW9uIGlzIHdyb25nIHdpdGggcmVzcGVjdCB0byBTcGVjRW1wdHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjQyOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgU2Fib2ZmLgorCisgICAgICAgIFRoZSBpc05vdENl bGxTcGVjdWxhdGlvbihTcGVjdWxhdGVkVHlwZSB0KSBmdW5jdGlvbiB3YXMgbm90IHRha2luZyBp bnRvIGFjY291bnQKKyAgICAgICAgU3BlY0VtcHR5IGluIHRoZSBzZXQgZm9yIHQuIEl0IHNob3Vs ZCByZXR1cm4gZmFsc2Ugd2hlbiBTcGVjRW1wdHkgaXMgcHJlc2VudCwgc2luY2UKKyAgICAgICAg dGhlIGVtcHR5IHZhbHVlIHdpbGwgZmFpbCBhIE5vdENlbGwgY2hlY2suIFRoaXMgYnVnIHdvdWxk IGNhdXNlIHVzIHRvIGVycm9uZW91c2x5CisgICAgICAgIGdlbmVyYXRlIE5vdENlbGxVc2UgVXNl S2luZHMgZm9yIGlucHV0cyB0aGF0IGFyZSB0aGUgZW1wdHkgdmFsdWUsIGNhdXNpbmcgcmVwZWF0 ZWQgT1NSIGV4aXRzLgorCisgICAgICAgICogYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUuaDoKKyAg ICAgICAgKEpTQzo6aXNOb3RDZWxsU3BlY3VsYXRpb24pOgorCiAyMDE3LTA5LTA1ICBTYWFtIEJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIGRpc3RpbmN0aW9u IGJldHdlZW4gZW50cnlwb2ludHMgYW5kIENGRyByb290cyBtb3JlIGNsZWFyIGJ5IG5hbWluZyB0 aGluZ3MgYmV0dGVyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3Vs YXRlZFR5cGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv U3BlY3VsYXRlZFR5cGUuaAkocmV2aXNpb24gMjIxNjQyKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmgJKHdvcmtpbmcgY29weSkKQEAgLTExOSw3ICsx MTksNyBAQCBpbmxpbmUgYm9vbCBpc0NlbGxPck90aGVyU3BlY3VsYXRpb24oU3BlCiAKIGlubGlu ZSBib29sIGlzTm90Q2VsbFNwZWN1bGF0aW9uKFNwZWN1bGF0ZWRUeXBlIHZhbHVlKQogewotICAg IHJldHVybiAhKHZhbHVlICYgU3BlY0NlbGwpICYmIHZhbHVlOworICAgIHJldHVybiAhKHZhbHVl ICYgU3BlY0NlbGxDaGVjaykgJiYgdmFsdWU7CiB9CiAKIGlubGluZSBib29sIGlzT2JqZWN0U3Bl Y3VsYXRpb24oU3BlY3VsYXRlZFR5cGUgdmFsdWUpCg==