176427 2017-09-05 15:36:45 -0700 Copy WebKit Permalink may generate wrong URL with SVN checkout 2017-09-27 12:39:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Mac macOS 10.12.4 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates darin lforschler webkit-bug-importer oldest_to_newest 1345671 0 dbates 2017-09-05 15:36:45 -0700 Using a SVN checkout of WebKit, Copy WebKit Permalink always generates a URL of the form https://trac.webkit.org/browser/trunk/X where X is the name of a file regardless the actual location of the file with name X. Steps to reproduce: 1. Open file Source/WebCore/rendering/style/RenderStyle.h in Xcode. 2. Place the text insertion point at the start of line 1. 3. Choose Xcode > Services > Copy WebKit Permalink Then the clipboard has a URL of the form: https://trac.webkit.org/browser/trunk/RenderStyle.h?rev=221617 But it should have a URL of the form: https://trac.webkit.org/browser/trunk/Source/WebCore/rendering/style/RenderStyle.h?rev=221617 1345675 1 319944 dbates 2017-09-05 15:45:05 -0700 Created attachment 319944 Patch 1345976 2 dbates 2017-09-06 09:55:57 -0700 Committed r221679: <http://trac.webkit.org/changeset/221679> 1353577 3 webkit-bug-importer 2017-09-27 12:39:40 -0700 <rdar://problem/34693705> 319944 2017-09-05 15:45:05 -0700 2017-09-05 19:02:27 -0700 Patch bug-176427-20170905154504.patch text/plain 6319 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNjM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRiZWU0MDQ1NDExODM1MjAyYjQ4OWZlZmUyYjMxMmY0 M2EwZjQzMy4uZmJmM2JjOTVhNDYwNTIxZTRmZGVmYzEzYTljNDExNTQwZWI0ODdlMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE3LTA5LTA1ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBDb3B5IFdlYktpdCBQZXJtYWxpbmsgbWF5IGdlbmVyYXRlIHdyb25nIFVSTCB3aXRoIFNW TiBjaGVja291dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc2NDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgQ29weSBXZWJLaXQgUGVybWFsaW5rIHdvdWxkIGdlbmVy YXRlIGFuIGluY29ycmVjdCBVUkwgZm9yCisgICAgICAgIGFueSBmaWxlIG5vdCBpbiB0aGUgdG9w LWxldmVsIGRpcmVjdG9yeSBvZiB0aGUgcmVwb3NpdG9yeSB3aGVuIHVzaW5nIGFuIFNWTgorICAg ICAgICBjaGVja291dCBvZiBXZWJLaXQuCisKKyAgICAgICAgQ29weSBXZWJLaXQgUGVybWFsaW5r IGNoYW5nZXMgZGlyZWN0b3JpZXMgdG8gdGhlIGNvbnRhaW5pbmcgZGlyZWN0b3J5IEQgb2YgdGhl CisgICAgICAgIGFjdGl2ZSBYY29kZSBkb2N1bWVudCBGIGJlZm9yZSBydW5uaW5nICJzdm4gaW5m byA8cGF0aCB0byBGPiIuIEN1cnJlbnRseSB3ZSB1c2UKKyAgICAgICAgdGhlIHZhbHVlIG9mICJQ YXRoIiBmcm9tIHRoZSBvdXRwdXQgb2YgInN2biBpbmZvIiB3aGVuIGdlbmVyYXRpbmcgdGhlIHBl cm1hbGluay4KKyAgICAgICAgVGhpcyBwYXRoIGlzIHJlbGF0aXZlIHRvIEQuIEJ1dCB3ZSB3YW50 IHRoZSBwYXRoIHRvIEYgcmVsYXRpdmUgdG8gdGhlIHRvcC1sZXZlbAorICAgICAgICBjaGVja291 dCBkaXJlY3RvcnkuIFdlIG5lZWQgdG8gZXhwbGljaXRseSBjb21wdXRlIHRoaXMuCisKKyAgICAg ICAgKiBDb3B5UGVybWFsaW5rL0NvcHkgV2ViS2l0IFBlcm1hbGluay53b3JrZmxvdy9Db250ZW50 cy9kb2N1bWVudC53ZmxvdzoKKwogMjAxNy0wOS0wNSAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4 ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIFdTTCBzaG91bGQgc3VwcG9ydCB0aGUgYm9vbCB0 eXBlCmRpZmYgLS1naXQgYS9Ub29scy9Db3B5UGVybWFsaW5rL0NvcHkgV2ViS2l0IFBlcm1hbGlu ay53b3JrZmxvdy9Db250ZW50cy9kb2N1bWVudC53ZmxvdyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsv Q29weSBXZWJLaXQgUGVybWFsaW5rLndvcmtmbG93L0NvbnRlbnRzL2RvY3VtZW50LndmbG93Cmlu ZGV4IDM4YzMxMmJkZTI5MDJjZjdhMmZkYjVhZTVhOTdjNTNiMjEyNDU4NWQuLjczNjhjMTg3Mjlm MDg1OGViYzUzNzdhOWE2MzdjY2JiZWYzZmI1YTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJt YWxpbmsvQ29weSBXZWJLaXQgUGVybWFsaW5rLndvcmtmbG93L0NvbnRlbnRzL2RvY3VtZW50Lndm bG93CQorKysgYi9Ub29scy9Db3B5UGVybWFsaW5rL0NvcHkgV2ViS2l0IFBlcm1hbGluay53b3Jr Zmxvdy9Db250ZW50cy9kb2N1bWVudC53ZmxvdwkKQEAgLTIwMCw1MCArMjAwLDUwIEBAIGZ1bmN0 aW9uIGRldGVybWluZVZDU0Zyb21QYXRoKHBhdGgpCiAKIGZ1bmN0aW9uIHBhdGhSZWxhdGl2ZVRv UmVwb3NpdG9yeVJvb3RGb3JQYXRoKHBhdGgpCiB7Ci0gICAgdmFyIGNoZWNrb3V0RGlyZWN0b3J5 ID0gaXNEaXJlY3RvcnkocGF0aCkgPyBwYXRoIDogZGlybmFtZShwYXRoKTsKKyAgICB2YXIgZGly ZWN0b3J5SW5DaGVja291dCA9IGlzRGlyZWN0b3J5KHBhdGgpID8gcGF0aCA6IGRpcm5hbWUocGF0 aCk7CiAgICAgaWYgKGdfaXNTVk4pCi0gICAgICAgIHJldHVybiBzdm5QYXRoUmVsYXRpdmVUb1Jl cG9zaXRvcnlSb290Rm9yUGF0aChwYXRoLCBjaGVja291dERpcmVjdG9yeSk7CisgICAgICAgIHJl dHVybiBzdm5QYXRoUmVsYXRpdmVUb1JlcG9zaXRvcnlSb290Rm9yUGF0aChwYXRoLCBkaXJlY3Rv cnlJbkNoZWNrb3V0KTsKICAgICBpZiAoZ19pc0dpdCkKLSAgICAgICAgcmV0dXJuIGdpdFBhdGhS ZWxhdGl2ZVRvUmVwb3NpdG9yeVJvb3RGb3JQYXRoKHBhdGgsIGNoZWNrb3V0RGlyZWN0b3J5KTsK KyAgICAgICAgcmV0dXJuIGdpdFBhdGhSZWxhdGl2ZVRvUmVwb3NpdG9yeVJvb3RGb3JQYXRoKHBh dGgsIGRpcmVjdG9yeUluQ2hlY2tvdXQpOwogICAgIHJldHVybiAiIjsKIH0KIAotZnVuY3Rpb24g Z2l0UGF0aFJlbGF0aXZlVG9SZXBvc2l0b3J5Um9vdEZvclBhdGgocGF0aCwgY2hlY2tvdXREaXJl Y3RvcnkpCitmdW5jdGlvbiBnaXRQYXRoUmVsYXRpdmVUb1JlcG9zaXRvcnlSb290Rm9yUGF0aChw YXRoLCBkaXJlY3RvcnlJbkNoZWNrb3V0KQogewotICAgIHJldHVybiBBcHAuZG9TaGVsbFNjcmlw dChgZ2l0IC1DICcke2NoZWNrb3V0RGlyZWN0b3J5fScgbHMtdHJlZSAtLWZ1bGwtbmFtZSAtLW5h bWUtb25seSBIRUFEICcke3BhdGh9J2ApOworICAgIHJldHVybiBBcHAuZG9TaGVsbFNjcmlwdChg Z2l0IC1DICcke2RpcmVjdG9yeUluQ2hlY2tvdXR9JyBscy10cmVlIC0tZnVsbC1uYW1lIC0tbmFt ZS1vbmx5IEhFQUQgJyR7cGF0aH0nYCk7CiB9CiAKLWZ1bmN0aW9uIHN2blBhdGhSZWxhdGl2ZVRv UmVwb3NpdG9yeVJvb3RGb3JQYXRoKHBhdGgsIGNoZWNrb3V0RGlyZWN0b3J5KQorZnVuY3Rpb24g c3ZuUGF0aFJlbGF0aXZlVG9SZXBvc2l0b3J5Um9vdEZvclBhdGgocGF0aCwgZGlyZWN0b3J5SW5D aGVja291dCkKIHsKLSAgICByZXR1cm4gc3ZuSW5mb0ZvclBhdGgocGF0aCwgY2hlY2tvdXREaXJl Y3RvcnkpLnBhdGg7CisgICAgcmV0dXJuIHN2bkluZm9Gb3JQYXRoKHBhdGgsIGRpcmVjdG9yeUlu Q2hlY2tvdXQpLnBhdGg7CiB9CiAKIGZ1bmN0aW9uIHJldmlzaW9uSW5mb0ZvclBhdGgocGF0aCkK IHsKLSAgICB2YXIgY2hlY2tvdXREaXJlY3RvcnkgPSBpc0RpcmVjdG9yeShwYXRoKSA/IHBhdGgg OiBkaXJuYW1lKHBhdGgpOworICAgIHZhciBkaXJlY3RvcnlJbkNoZWNrb3V0ID0gaXNEaXJlY3Rv cnkocGF0aCkgPyBwYXRoIDogZGlybmFtZShwYXRoKTsKICAgICBpZiAoZ19pc1NWTiB8fCBnX2lz R2l0U1ZOKQotICAgICAgICByZXR1cm4gc3ZuUmV2aXNpb25JbmZvRm9yUGF0aChwYXRoLCBjaGVj a291dERpcmVjdG9yeSk7CisgICAgICAgIHJldHVybiBzdm5SZXZpc2lvbkluZm9Gb3JQYXRoKHBh dGgsIGRpcmVjdG9yeUluQ2hlY2tvdXQpOwogICAgIGlmIChnX2lzR2l0KQotICAgICAgICByZXR1 cm4gZ2l0UmV2aXNpb25JbmZvRm9yUGF0aChwYXRoLCBjaGVja291dERpcmVjdG9yeSk7CisgICAg ICAgIHJldHVybiBnaXRSZXZpc2lvbkluZm9Gb3JQYXRoKHBhdGgsIGRpcmVjdG9yeUluQ2hlY2tv dXQpOwogICAgIHJldHVybiAiIjsKIH0KIAotZnVuY3Rpb24gc3ZuUmV2aXNpb25JbmZvRm9yUGF0 aChwYXRoLCBjaGVja291dERpcmVjdG9yeSkKK2Z1bmN0aW9uIHN2blJldmlzaW9uSW5mb0ZvclBh dGgocGF0aCwgZGlyZWN0b3J5SW5DaGVja291dCkKIHsKLSAgICB2YXIgc3ZuSW5mbyA9IHN2bklu Zm9Gb3JQYXRoKHBhdGgsIGNoZWNrb3V0RGlyZWN0b3J5KTsKKyAgICB2YXIgc3ZuSW5mbyA9IHN2 bkluZm9Gb3JQYXRoKHBhdGgsIGRpcmVjdG9yeUluQ2hlY2tvdXQpOwogICAgIHJldHVybiB7ICJi cmFuY2giOiBzdm5JbmZvLmJyYW5jaCwgInJldmlzaW9uIjogc3ZuSW5mby5yZXZpc2lvbiwgInJl cG9zaXRvcnlVUkwiOiBzdm5JbmZvLnJlcG9zaXRvcnlSb290IH07CiB9CiAKLWZ1bmN0aW9uIGdp dFJldmlzaW9uSW5mb0ZvclBhdGgocGF0aCwgY2hlY2tvdXREaXJlY3RvcnkpCitmdW5jdGlvbiBn aXRSZXZpc2lvbkluZm9Gb3JQYXRoKHBhdGgsIGRpcmVjdG9yeUluQ2hlY2tvdXQpCiB7Ci0gICAg dmFyIHJlcG9zaXRvcnlVUkwgPSBBcHAuZG9TaGVsbFNjcmlwdChgZ2l0IC1DICcke2NoZWNrb3V0 RGlyZWN0b3J5fScgcmVtb3RlIGdldC11cmwgb3JpZ2luYCk7Ci0gICAgdmFyIHJldmlzaW9uID0g QXBwLmRvU2hlbGxTY3JpcHQoYGdpdCAtQyAnJHtjaGVja291dERpcmVjdG9yeX0nIGxvZyAtMSAt LWZvcm1hdD0nJUgnICcke3BhdGh9J2ApOwotICAgIHZhciBicmFuY2ggPSBBcHAuZG9TaGVsbFNj cmlwdChgZ2l0IC1DICcke2NoZWNrb3V0RGlyZWN0b3J5fScgc3ltYm9saWMtcmVmIC1xIEhFQURg KTsKKyAgICB2YXIgcmVwb3NpdG9yeVVSTCA9IEFwcC5kb1NoZWxsU2NyaXB0KGBnaXQgLUMgJyR7 ZGlyZWN0b3J5SW5DaGVja291dH0nIHJlbW90ZSBnZXQtdXJsIG9yaWdpbmApOworICAgIHZhciBy ZXZpc2lvbiA9IEFwcC5kb1NoZWxsU2NyaXB0KGBnaXQgLUMgJyR7ZGlyZWN0b3J5SW5DaGVja291 dH0nIGxvZyAtMSAtLWZvcm1hdD0nJUgnICcke3BhdGh9J2ApOworICAgIHZhciBicmFuY2ggPSBB cHAuZG9TaGVsbFNjcmlwdChgZ2l0IC1DICcke2RpcmVjdG9yeUluQ2hlY2tvdXR9JyBzeW1ib2xp Yy1yZWYgLXEgSEVBRGApOwogICAgIGJyYW5jaCA9IGJyYW5jaC5yZXBsYWNlKC9ecmVmc1wvaGVh ZHNcLy8sICIiKSB8fCAibWFzdGVyIjsKICAgICByZXR1cm4geyBicmFuY2gsIHJldmlzaW9uLCBy ZXBvc2l0b3J5VVJMIH07CiB9CiAKLWZ1bmN0aW9uIHN2bkluZm9Gb3JQYXRoKHBhdGgsIGNoZWNr b3V0RGlyZWN0b3J5KQorZnVuY3Rpb24gc3ZuSW5mb0ZvclBhdGgocGF0aCwgZGlyZWN0b3J5SW5D aGVja291dCkKIHsKICAgICBpZiAoZ19sYXN0U1ZOSW5mbyAmYW1wOyZhbXA7IGdfbGFzdFNWTklu Zm8ucGF0aCA9PT0gcGF0aCkgewogICAgICAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIGFsc28gZW5z dXJlIHRoYXQgdGhlIGNoZWNrb3V0IGRpcmVjdG9yeSBmb3IgdGhlIGNhY2hlZCBTVk4gaW5mbyBp cwpAQCAtMjU0LDcgKzI1NCw3IEBAIGZ1bmN0aW9uIHN2bkluZm9Gb3JQYXRoKHBhdGgsIGNoZWNr b3V0RGlyZWN0b3J5KQogICAgIHZhciBzdm5JbmZvQ29tbWFuZCA9ICJzdm4gaW5mbyI7CiAgICAg aWYgKGdfaXNHaXRTVk4pCiAgICAgICAgIHN2bkluZm9Db21tYW5kID0gImdpdCAiICsgc3ZuSW5m b0NvbW1hbmQ7Ci0gICAgdmFyIG91dHB1dCA9IEFwcC5kb1NoZWxsU2NyaXB0KGBjZCAnJHtjaGVj a291dERpcmVjdG9yeX0nICZhbXA7JmFtcDsgJHtzdm5JbmZvQ29tbWFuZH0gJyR7cGF0aH0nYCwg eyJhbHRlcmluZ0xpbmVFbmRpbmdzIjogZmFsc2V9KTsKKyAgICB2YXIgb3V0cHV0ID0gQXBwLmRv U2hlbGxTY3JpcHQoYGNkICcke2RpcmVjdG9yeUluQ2hlY2tvdXR9JyAmYW1wOyZhbXA7ICR7c3Zu SW5mb0NvbW1hbmR9ICcke3BhdGh9J2AsIHsiYWx0ZXJpbmdMaW5lRW5kaW5ncyI6IGZhbHNlfSk7 CiAgICAgaWYgKCFvdXRwdXQpCiAgICAgICAgIHJldHVybiB7IH07CiAKQEAgLTI2Niw3ICsyNjYs NiBAQCBmdW5jdGlvbiBzdm5JbmZvRm9yUGF0aChwYXRoLCBjaGVja291dERpcmVjdG9yeSkKICAg ICAgICAgICAgIHRlbXBba2V5XSA9IHZhbHVlOwogICAgIH0KICAgICB2YXIgc3ZuSW5mbyA9IHsK LSAgICAgICAgInBhdGgiOiB0ZW1wWyJQYXRoIl0sCiAgICAgICAgICJwYXRoQXNVUkwiOiB0ZW1w WyJVUkwiXSwKICAgICAgICAgInJlcG9zaXRvcnlSb290IjogdGVtcFsiUmVwb3NpdG9yeSBSb290 Il0sCiAgICAgICAgICJyZXZpc2lvbiI6IHRlbXBbIlJldmlzaW9uIl0sCkBAIC0yNzUsNiArMjc0 LDExIEBAIGZ1bmN0aW9uIHN2bkluZm9Gb3JQYXRoKHBhdGgsIGNoZWNrb3V0RGlyZWN0b3J5KQog ICAgIGJyYW5jaCA9IGJyYW5jaC5zdWJzdHIoMCwgYnJhbmNoLmluZGV4T2YoIi8iKSk7CiAgICAg c3ZuSW5mby5icmFuY2ggPSBicmFuY2g7CiAKKyAgICAvLyBBbHRob3VnaCB0ZW1wdGluZyB0byB1 c2UgdGVtcFsiUGF0aCJdIHdlIGNhbm5vdCBiZWNhdXNlIGl0IGlzIHJlbGF0aXZlIHRvIGRpcmVj dG9yeUluQ2hlY2tvdXQuCisgICAgLy8gQW5kIGRpcmVjdG9yeUluQ2hlY2tvdXQgbWF5IG5vdCBi ZSB0aGUgdG9wLWxldmVsIGNoZWNrb3V0IGRpcmVjdG9yeS4gV2UgbmVlZCB0byBjb21wdXRlIHRo ZQorICAgIC8vIHJlbGF0aXZlIHBhdGggd2l0aCByZXNwZWN0IHRvIHRoZSB0b3AtbGV2ZWwgY2hl Y2tvdXQgZGlyZWN0b3J5LgorICAgIHN2bkluZm8ucGF0aCA9IHN2bkluZm8ucGF0aEFzVVJMLnJl cGxhY2UoYCR7c3ZuSW5mby5yZXBvc2l0b3J5Um9vdH0vJHticmFuY2h9L2AsICIiKTsKKwogICAg IGdfbGFzdFNWTkluZm8gPSBzdm5JbmZvOwogCiAgICAgcmV0dXJuIHN2bkluZm87Cg==