176387 2017-09-05 11:26:17 -0700 [Win] Compile errors in pathByAppendingComponents. 2017-09-27 12:35:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham cdumez commit-queue webkit-bug-importer oldest_to_newest 1345538 0 pvollan 2017-09-05 11:26:17 -0700 C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): error C2440: 'initializing': cannot convert from 'WTF::StringView' to 'WTF::String' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(268): note: No constructor could take the source type, or constructor overload resolution was ambiguous C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): error C2664: 'WTF::String WebCore::pathByAppendingComponent(const WTF::String &,const WTF::String &)': cannot convert argument 2 from 'const WTF::StringView' to 'const WTF::String &' [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: Reason: cannot convert from 'const WTF::StringView' to 'const WTF::String' C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\platform\win\FileSystemWin.cpp(270): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called 1345539 1 319918 pvollan 2017-09-05 11:28:05 -0700 Created attachment 319918 Patch 1345541 2 319918 bfulgham 2017-09-05 11:30:41 -0700 Comment on attachment 319918 Patch r=me. 1345542 3 319918 pvollan 2017-09-05 11:33:04 -0700 Comment on attachment 319918 Patch Thanks for reviewing! 1345551 4 319918 commit-queue 2017-09-05 12:02:34 -0700 Comment on attachment 319918 Patch Clearing flags on attachment: 319918 Committed r221628: <http://trac.webkit.org/changeset/221628> 1345552 5 commit-queue 2017-09-05 12:02:35 -0700 All reviewed patches have been landed. Closing bug. 1345556 6 cdumez 2017-09-05 12:06:27 -0700 Thanks for fixing! 1345564 7 pvollan 2017-09-05 12:28:59 -0700 (In reply to Chris Dumez from comment #6) > Thanks for fixing! No problem :) 1353512 8 webkit-bug-importer 2017-09-27 12:35:51 -0700 <rdar://problem/34693568> 319918 2017-09-05 11:28:05 -0700 2017-09-05 12:02:34 -0700 Patch bug-176387-20170905202804.patch text/plain 1386 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMTYyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA5LTA1ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDb21waWxlIGVy cm9ycyBpbiBwYXRoQnlBcHBlbmRpbmdDb21wb25lbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2Mzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudHMg ZnVuY3Rpb24gaGFzIGNoYW5nZWQgc2lnbmF0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L0ZpbGVTeXN0ZW1XaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29t cG9uZW50cyk6CisKIDIwMTctMDktMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgRml4IGNhcGl0YWxpemF0aW9uIG9mIHNjaGVkdWxlaW52YWxpZGF0 ZVN0eWxlQW5kTGF5ZXJDb21wb3NpdGlvbgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v d2luL0ZpbGVTeXN0ZW1XaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dpbi9GaWxlU3lzdGVtV2luLmNwcAkocmV2aXNpb24gMjIxNjI3KQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vd2luL0ZpbGVTeXN0ZW1XaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y NjUsOSArMjY1LDkgQEAgU3RyaW5nIHBhdGhCeUFwcGVuZGluZ0NvbXBvbmVudChjb25zdCBTdAog CiBTdHJpbmcgcGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50cyhTdHJpbmdWaWV3IHBhdGgsIGNvbnN0 IFZlY3RvcjxTdHJpbmdWaWV3PiYgY29tcG9uZW50cykKIHsKLSAgICBTdHJpbmcgcmVzdWx0ID0g cGF0aDsKKyAgICBTdHJpbmcgcmVzdWx0ID0gcGF0aC50b1N0cmluZygpOwogICAgIGZvciAoYXV0 byYgY29tcG9uZW50IDogY29tcG9uZW50cykKLSAgICAgICAgcmVzdWx0ID0gcGF0aEJ5QXBwZW5k aW5nQ29tcG9uZW50KHJlc3VsdCwgY29tcG9uZW50KTsKKyAgICAgICAgcmVzdWx0ID0gcGF0aEJ5 QXBwZW5kaW5nQ29tcG9uZW50KHJlc3VsdCwgY29tcG9uZW50LnRvU3RyaW5nKCkpOwogICAgIHJl dHVybiByZXN1bHQ7CiB9CiAK