176324 2017-09-03 21:23:56 -0700 Use StringView in DOMFileSystem::evaluatePath() 2017-09-27 12:38:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue darin kling webkit-bug-importer oldest_to_newest 1345129 0 cdumez 2017-09-03 21:23:56 -0700 Use StringView in DOMFileSystem::evaluatePath() for performance. 1345130 1 319833 cdumez 2017-09-03 21:24:57 -0700 Created attachment 319833 Patch 1345135 2 319833 darin 2017-09-03 21:45:31 -0700 Comment on attachment 319833 Patch Seems like a good first step. But I think that virtualPathSegments and relativePathSegments can also be StringView, for example. And we can write a pathByAppendingComponents that takes StringView too. 1345139 3 cdumez 2017-09-03 22:10:28 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 319833 [details] > Patch > > Seems like a good first step. But I think that virtualPathSegments and > relativePathSegments can also be StringView, for example. And we can write a > pathByAppendingComponents that takes StringView too. This issue for virtualPathSegments is that StringView::split() does not return a Vector <StringView> but rather a StringView::SplitResult which I cannot modify (The current code relies on modifying the Vector. 1345141 4 darin 2017-09-03 22:14:49 -0700 (In reply to Chris Dumez from comment #3) > This issue for virtualPathSegments is that StringView::split() does not > return a Vector <StringView> but rather a StringView::SplitResult Here is how you turn a SplitResult into a vector: Vector<StringView> vector; for (auto substringView : overallStringView.split('/')) vector.append(substringView); 1345166 5 319833 commit-queue 2017-09-03 23:07:12 -0700 Comment on attachment 319833 Patch Clearing flags on attachment: 319833 Committed r221573: <http://trac.webkit.org/changeset/221573> 1345167 6 commit-queue 2017-09-03 23:07:14 -0700 All reviewed patches have been landed. Closing bug. 1353551 7 webkit-bug-importer 2017-09-27 12:38:09 -0700 <rdar://problem/34693652> 319833 2017-09-03 21:24:57 -0700 2017-09-03 23:07:12 -0700 Patch bug-176324-20170903212457.patch text/plain 3227 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQ5ZWZjNzQ0ODhjYTdk MzQ2NzBmNDViNWY2NDc1ZWUyZmQ1YTliZS4uZjM2MTViYjVhNzM0MGZkODliZTM2NDZhNTFiOWRm NmQ3YzQxNmNiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTA5LTAzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIFN0cmluZ1ZpZXcgaW4g RE9NRmlsZVN5c3RlbTo6ZXZhbHVhdGVQYXRoKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjMyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBTdHJpbmdWaWV3IGluIERPTUZpbGVTeXN0ZW06OmV2 YWx1YXRlUGF0aCgpIGZvciBwZXJmb3JtYW5jZS4KKworICAgICAgICAqIE1vZHVsZXMvZW50cmll c2FwaS9ET01GaWxlU3lzdGVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJlc29sdmVSZWxhdGl2 ZVZpcnR1YWxQYXRoKToKKyAgICAgICAgKFdlYkNvcmU6OkRPTUZpbGVTeXN0ZW06OmV2YWx1YXRl UGF0aCk6CisgICAgICAgICogTW9kdWxlcy9lbnRyaWVzYXBpL0RPTUZpbGVTeXN0ZW0uaDoKKwor MjAxNy0wOS0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEhh dmUgZ2V0RmlsZU1ldGFkYXRhKCkgcmV0dXJuIGEgc3RkOjpvcHRpb25hbDxGaWxlTWV0YWRhdGE+ CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYyOTMK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9lbnRyaWVzYXBpL0RPTUZpbGVT eXN0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9lbnRyaWVzYXBpL0RPTUZpbGVTeXN0 ZW0uY3BwCmluZGV4IGE0YjBjOTNjYjg3NWMzY2U5NWNiNDlmYzNhNDI3NjM5YzIxZTYwMzQuLjdm YmU2ODEzOWIzNzIyNDZkNTEyZGM4ZTg5ODgzMGRmYzA5YzM1ODYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvZW50cmllc2FwaS9ET01GaWxlU3lzdGVtLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL2VudHJpZXNhcGkvRE9NRmlsZVN5c3RlbS5jcHAKQEAgLTE5MSw3 ICsxOTEsNyBAQCBzdGF0aWMgU3RyaW5nIHJlc29sdmVSZWxhdGl2ZVZpcnR1YWxQYXRoKGNvbnN0 IFN0cmluZyYgYmFzZVZpcnR1YWxQYXRoLCBTdHJpbmdWaQogICAgICAgICAgICAgICAgIHZpcnR1 YWxQYXRoU2VnbWVudHMucmVtb3ZlTGFzdCgpOwogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIH0KLSAgICAgICAgdmlydHVhbFBhdGhTZWdtZW50cy5hcHBlbmQoc2VnbWVudC50b1N0cmlu ZygpKTsKKyAgICAgICAgdmlydHVhbFBhdGhTZWdtZW50cy5hcHBlbmQoc2VnbWVudC50b1N0cmlu Z1dpdGhvdXRDb3B5aW5nKCkpOwogICAgIH0KIAogICAgIGlmICh2aXJ0dWFsUGF0aFNlZ21lbnRz LmlzRW1wdHkoKSkKQEAgLTIwNiwxNCArMjA2LDEzIEBAIHN0YXRpYyBTdHJpbmcgcmVzb2x2ZVJl bGF0aXZlVmlydHVhbFBhdGgoY29uc3QgU3RyaW5nJiBiYXNlVmlydHVhbFBhdGgsIFN0cmluZ1Zp CiB9CiAKIC8vIGh0dHBzOi8vd2ljZy5naXRodWIuaW8vZW50cmllcy1hcGkvI2V2YWx1YXRlLWEt cGF0aAotU3RyaW5nIERPTUZpbGVTeXN0ZW06OmV2YWx1YXRlUGF0aChjb25zdCBTdHJpbmcmIHZp cnR1YWxQYXRoKQorU3RyaW5nIERPTUZpbGVTeXN0ZW06OmV2YWx1YXRlUGF0aChTdHJpbmdWaWV3 IHZpcnR1YWxQYXRoKQogewogICAgIEFTU0VSVCh2aXJ0dWFsUGF0aFswXSA9PSAnLycpOwogICAg IGF1dG8gY29tcG9uZW50cyA9IHZpcnR1YWxQYXRoLnNwbGl0KCcvJyk7CiAKICAgICBWZWN0b3I8 U3RyaW5nPiByZXNvbHZlZENvbXBvbmVudHM7Ci0gICAgcmVzb2x2ZWRDb21wb25lbnRzLnJlc2Vy dmVJbml0aWFsQ2FwYWNpdHkoY29tcG9uZW50cy5zaXplKCkpOwotICAgIGZvciAoYXV0byYgY29t cG9uZW50IDogY29tcG9uZW50cykgeworICAgIGZvciAoYXV0byBjb21wb25lbnQgOiBjb21wb25l bnRzKSB7CiAgICAgICAgIGlmIChjb21wb25lbnQgPT0gIi4iKQogICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgIGlmIChjb21wb25lbnQgPT0gIi4uIikgewpAQCAtMjIxLDcgKzIyMCw3IEBA IFN0cmluZyBET01GaWxlU3lzdGVtOjpldmFsdWF0ZVBhdGgoY29uc3QgU3RyaW5nJiB2aXJ0dWFs UGF0aCkKICAgICAgICAgICAgICAgICByZXNvbHZlZENvbXBvbmVudHMucmVtb3ZlTGFzdCgpOwog ICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KLSAgICAgICAgcmVzb2x2ZWRDb21wb25l bnRzLnVuY2hlY2tlZEFwcGVuZChjb21wb25lbnQpOworICAgICAgICByZXNvbHZlZENvbXBvbmVu dHMuYXBwZW5kKGNvbXBvbmVudC50b1N0cmluZ1dpdGhvdXRDb3B5aW5nKCkpOwogICAgIH0KIAog ICAgIHJldHVybiBwYXRoQnlBcHBlbmRpbmdDb21wb25lbnRzKG1fcm9vdFBhdGgsIHJlc29sdmVk Q29tcG9uZW50cyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2VudHJpZXNh cGkvRE9NRmlsZVN5c3RlbS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9lbnRyaWVzYXBpL0RP TUZpbGVTeXN0ZW0uaAppbmRleCAwNDdhNTc4YTNmZWYyMmQ4NWM0MWJjNmYxMWYzNTRjY2ZmNjY2 YzliLi45YjMwZDdjNzUyM2E1ODY2NTNmMDBlMTA3ZDllMWZhZDJlNTYxMjI0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2VudHJpZXNhcGkvRE9NRmlsZVN5c3RlbS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZW50cmllc2FwaS9ET01GaWxlU3lzdGVtLmgKQEAgLTY3 LDcgKzY3LDcgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICBleHBsaWNpdCBET01GaWxlU3lzdGVt KFJlZjxGaWxlPiYmKTsKIAotICAgIFN0cmluZyBldmFsdWF0ZVBhdGgoY29uc3QgU3RyaW5nJiB2 aXJ0dWFsUGF0aCk7CisgICAgU3RyaW5nIGV2YWx1YXRlUGF0aChTdHJpbmdWaWV3IHZpcnR1YWxQ YXRoKTsKICAgICBSZWY8RmlsZVN5c3RlbUVudHJ5PiBmaWxlQXNFbnRyeShTY3JpcHRFeGVjdXRp b25Db250ZXh0Jik7CiAKICAgICBTdHJpbmcgbV9uYW1lOwo=