176302 2017-09-03 06:05:06 -0700 String#utf8() allocates new CString 2017-09-27 12:42:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen commit-queue sam webkit-bug-importer youennf oldest_to_newest 1344964 0 ysuzuki 2017-09-03 06:05:06 -0700 String#utf8() allocates new CString 1344965 1 319774 ysuzuki 2017-09-03 06:08:45 -0700 Created attachment 319774 Patch 1344966 2 ysuzuki 2017-09-03 06:16:41 -0700 This issue makes me consider renaming ::utf8() more descriptive one. Like, convertToUTF8()... 1345100 3 319774 ysuzuki 2017-09-03 18:08:46 -0700 Comment on attachment 319774 Patch Thx! 1345103 4 319774 commit-queue 2017-09-03 18:38:13 -0700 Comment on attachment 319774 Patch Clearing flags on attachment: 319774 Committed r221562: <http://trac.webkit.org/changeset/221562> 1345104 5 commit-queue 2017-09-03 18:38:14 -0700 All reviewed patches have been landed. Closing bug. 1353613 6 webkit-bug-importer 2017-09-27 12:42:20 -0700 <rdar://problem/34693796> 319774 2017-09-03 06:08:45 -0700 2017-09-03 18:38:13 -0700 Patch bug-176302-20170903220844.patch text/plain 5184 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTEyZTNhMjAzNGVjZWYw MTA4ZTJiMGE5MDM1YjQ2ZjM3ZWNjY2EwYy4uYzM5NDk0OTliY2JiMGQyOWU0YWQ2OGUxM2FjYmZj NmZjY2MzNGZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA5LTAzICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFN0cmluZyN1dGY4 KCkgYWxsb2NhdGVzIG5ldyBDU3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzYzMDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZXZlcmFsIHBsYWNlcyB1c2VzIFN0cmluZyN1dGY4KCkgbGlrZSBh biBhY2Nlc3Nvci4gSW4gcmVhbGl0eSwgaXQgYWxsb2NhdGVzIG5ldyBDU3RyaW5nIHBlciBjYWxs LgorICAgICAgICBJdCBpcyB2ZXJ5IGNvc3RseS4gRnVydGhlcm1vcmUsIHNvbWUgcGxhY2VzIHVz ZXMgdGhpcyBpbmNvcnJlY3RseS4gRm9yIGV4YW1wbGUsCisgICAgICAgIGBzdGQ6OnZlY3Rvcjxj aGFyPihzcnRwQXV0aC51dGY4KCkuZGF0YSgpLCBzcnRwQXV0aC51dGY4KCkuZGF0YSgpICsgc3J0 cEF1dGgudXRmOCgpLmxlbmd0aCgpKTtgCisgICAgICAgIGlzIGluY29ycmVjdCBzaW5jZSBlYWNo IHRpbWUgc3RycEF1dGgudXRmOCgpIGFsbG9jYXRlcyBkaWZmZXJlbnQgQ1N0cmluZy4KKworICAg ICAgICBUaGlzIHBhdGNoIGNhbGxzIHV0ZjgoKSBmaXJzdCBhbmQgdXNlIGl0LgorCisgICAgICAg ICogTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6c3RhcnRDbG9zaW5nSGFuZHNoYWtlKToKKyAgICAgICAg KiBwbGF0Zm9ybS93cGUvUGxhdGZvcm1QYXN0ZWJvYXJkV1BFLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBsYXRmb3JtUGFzdGVib2FyZDo6d3JpdGUpOgorCiAyMDE3LTA5LTAzICBTYW0gV2Vpbmln ICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIENhbnZhc1Byb3h5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmlu ZGV4IDQ4MjdiYjNlOTdjMzE1ZjIwYmFkMDJhZTdjMzBkYWM0YTBmOWZiYjguLjlmOTVkNmI1Yzk3 NDY0NDNhYTNmYzA0MGE2YTE2ZGFjMDg3YjZmNGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTctMDktMDMgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CisKKyAg ICAgICAgU3RyaW5nI3V0ZjgoKSBhbGxvY2F0ZXMgbmV3IENTdHJpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjMwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvd2VicnRj L05ldHdvcmtSVENTb2NrZXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUlRDU29ja2V0 OjpzZW5kVG8pOgorCiAyMDE3LTA5LTAzICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIENhbnZhc1Byb3h5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAKaW5kZXggMGNjOWUyYjQ4MTA1 OWUwNzM3MmFhMTc1MzgyNTc2ZmIxNGVjODY4Ny4uMzlmMzEwMDdmODQ5NWViMTBlMzU5Y2VjMmY4 MWM0YTYzZmVhZjg0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJzb2Nr ZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi c29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcApAQCAtNDkyLDcgKzQ5Miw4IEBAIHZvaWQgV2Vi U29ja2V0Q2hhbm5lbDo6c3RhcnRDbG9zaW5nSGFuZHNoYWtlKGludCBjb2RlLCBjb25zdCBTdHJp bmcmIHJlYXNvbikKICAgICAgICAgdW5zaWduZWQgY2hhciBsb3dCeXRlID0gY29kZTsKICAgICAg ICAgYnVmLmFwcGVuZChzdGF0aWNfY2FzdDxjaGFyPihoaWdoQnl0ZSkpOwogICAgICAgICBidWYu YXBwZW5kKHN0YXRpY19jYXN0PGNoYXI+KGxvd0J5dGUpKTsKLSAgICAgICAgYnVmLmFwcGVuZChy ZWFzb24udXRmOCgpLmRhdGEoKSwgcmVhc29uLnV0ZjgoKS5sZW5ndGgoKSk7CisgICAgICAgIGF1 dG8gcmVhc29uVVRGOCA9IHJlYXNvbi51dGY4KCk7CisgICAgICAgIGJ1Zi5hcHBlbmQocmVhc29u VVRGOC5kYXRhKCksIHJlYXNvblVURjgubGVuZ3RoKCkpOwogICAgIH0KICAgICBlbnF1ZXVlUmF3 RnJhbWUoV2ViU29ja2V0RnJhbWU6Ok9wQ29kZUNsb3NlLCBidWYuZGF0YSgpLCBidWYuc2l6ZSgp KTsKICAgICBSZWY8V2ViU29ja2V0Q2hhbm5lbD4gcHJvdGVjdGVkVGhpcygqdGhpcyk7IC8vIEFu IGF0dGVtcHQgdG8gc2VuZCBjbG9zaW5nIGhhbmRzaGFrZSBtYXkgZmFpbCwgd2hpY2ggd2lsbCBn ZXQgdGhlIGNoYW5uZWwgY2xvc2VkIGFuZCBkZXJlZmVyZW5jZWQuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS93cGUvUGxhdGZvcm1QYXN0ZWJvYXJkV1BFLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3dwZS9QbGF0Zm9ybVBhc3RlYm9hcmRXUEUuY3BwCmluZGV4IDVm ZmI4YzNhNDRiYWYzNmJlMDViM2MwOGFiNGVjMTcwOWIxOTM5Y2QuLjQ0OWMzNjc3N2M0ZGFkZGNh ZWVlZGQ4YjVkZTIzNTZiMTM5ZjdlM2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3dwZS9QbGF0Zm9ybVBhc3RlYm9hcmRXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3dwZS9QbGF0Zm9ybVBhc3RlYm9hcmRXUEUuY3BwCkBAIC0xMDMsOCArMTAzLDExIEBA IHZvaWQgUGxhdGZvcm1QYXN0ZWJvYXJkOjp3cml0ZShjb25zdCBTdHJpbmcmIHR5cGUsIGNvbnN0 IFN0cmluZyYgc3RyaW5nKQogICAgIHN0cnVjdCB3cGVfcGFzdGVib2FyZF9zdHJpbmdfcGFpciBw YWlyc1tdID0gewogICAgICAgICB7IHsgbnVsbHB0ciwgMCB9LCB7IG51bGxwdHIsIDAgfSB9LAog ICAgIH07Ci0gICAgd3BlX3Bhc3RlYm9hcmRfc3RyaW5nX2luaXRpYWxpemUoJnBhaXJzWzBdLnR5 cGUsIHR5cGUudXRmOCgpLmRhdGEoKSwgdHlwZS51dGY4KCkubGVuZ3RoKCkpOwotICAgIHdwZV9w YXN0ZWJvYXJkX3N0cmluZ19pbml0aWFsaXplKCZwYWlyc1swXS5zdHJpbmcsIHN0cmluZy51dGY4 KCkuZGF0YSgpLCBzdHJpbmcudXRmOCgpLmxlbmd0aCgpKTsKKworICAgIGF1dG8gdHlwZVVURjgg PSB0eXBlLnV0ZjgoKTsKKyAgICBhdXRvIHN0cmluZ1VURjggPSBzdHJpbmcudXRmOCgpOworICAg IHdwZV9wYXN0ZWJvYXJkX3N0cmluZ19pbml0aWFsaXplKCZwYWlyc1swXS50eXBlLCB0eXBlVVRG OC5kYXRhKCksIHR5cGVVVEY4Lmxlbmd0aCgpKTsKKyAgICB3cGVfcGFzdGVib2FyZF9zdHJpbmdf aW5pdGlhbGl6ZSgmcGFpcnNbMF0uc3RyaW5nLCBzdHJpbmdVVEY4LmRhdGEoKSwgc3RyaW5nVVRG OC5sZW5ndGgoKSk7CiAgICAgc3RydWN0IHdwZV9wYXN0ZWJvYXJkX3N0cmluZ19tYXAgbWFwID0g eyBwYWlycywgMSB9OwogCiAgICAgd3BlX3Bhc3RlYm9hcmRfd3JpdGUobV9wYXN0ZWJvYXJkLCAm bWFwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05l dHdvcmtSVENTb2NrZXQuY3BwIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMv TmV0d29ya1JUQ1NvY2tldC5jcHAKaW5kZXggZmNkMTI0OThmNjdhZjQ2OWQ3NTkyMDgyNzNlZWI4 N2QxYzgzNWY2ZS4uZTNjOTliYjkwY2Q0ZWI3NmU5MDdhYzU2OTJmOTcyMjJjMTU2NTA5NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1Nv Y2tldC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29y a1JUQ1NvY2tldC5jcHAKQEAgLTUxLDkgKzUxLDEwIEBAIHZvaWQgTmV0d29ya1JUQ1NvY2tldDo6 c2VuZFRvKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5jZSYgZGF0YSwgY29uc3QgUlRDTmV0d29yazo6 CiAgICAgb3B0aW9ucy5wYWNrZXRfdGltZV9wYXJhbXMucnRwX3NlbmR0aW1lX2V4dGVuc2lvbl9p ZCA9IHJ0cFNlbmR0aW1lRXh0ZW5zaW9uSUQ7CiAgICAgb3B0aW9ucy5wYWNrZXRfdGltZV9wYXJh bXMuc3J0cF9wYWNrZXRfaW5kZXggPSBzcnRwUGFja2V0SW5kZXg7CiAgICAgb3B0aW9ucy5kc2Nw ID0gc3RhdGljX2Nhc3Q8cnRjOjpEaWZmU2VydkNvZGVQb2ludD4oZHNjcCk7Ci0gICAgaWYgKHNy dHBBdXRoLnV0ZjgoKS5sZW5ndGgoKSkgewotICAgICAgICBvcHRpb25zLnBhY2tldF90aW1lX3Bh cmFtcy5zcnRwX2F1dGhfa2V5ID0gc3RkOjp2ZWN0b3I8Y2hhcj4oc3J0cEF1dGgudXRmOCgpLmRh dGEoKSwgc3J0cEF1dGgudXRmOCgpLmRhdGEoKSArIHNydHBBdXRoLnV0ZjgoKS5sZW5ndGgoKSk7 Ci0gICAgICAgIG9wdGlvbnMucGFja2V0X3RpbWVfcGFyYW1zLnNydHBfYXV0aF90YWdfbGVuID0g c3J0cEF1dGgudXRmOCgpLmxlbmd0aCgpOworICAgIGF1dG8gc3J0cEF1dGhVVEY4ID0gc3J0cEF1 dGgudXRmOCgpOworICAgIGlmIChzcnRwQXV0aFVURjgubGVuZ3RoKCkpIHsKKyAgICAgICAgb3B0 aW9ucy5wYWNrZXRfdGltZV9wYXJhbXMuc3J0cF9hdXRoX2tleSA9IHN0ZDo6dmVjdG9yPGNoYXI+ KHNydHBBdXRoVVRGOC5kYXRhKCksIHNydHBBdXRoVVRGOC5kYXRhKCkgKyBzcnRwQXV0aFVURjgu bGVuZ3RoKCkpOworICAgICAgICBvcHRpb25zLnBhY2tldF90aW1lX3BhcmFtcy5zcnRwX2F1dGhf dGFnX2xlbiA9IHNydHBBdXRoVVRGOC5sZW5ndGgoKTsKICAgICB9IGVsc2UKICAgICAgICAgb3B0 aW9ucy5wYWNrZXRfdGltZV9wYXJhbXMuc3J0cF9hdXRoX3RhZ19sZW4gPSAtMTsKICAgICAK