176291 2017-09-02 20:51:20 -0700 Need an API to get the global context from JSObjectRef 2017-09-27 12:41:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 oliver oliver buildbot commit-queue keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1344915 0 oliver 2017-09-02 20:51:20 -0700 Need an API to get the global context from JSObjectRef 1344916 1 319758 oliver 2017-09-02 20:52:11 -0700 Created attachment 319758 Patch 1344917 2 buildbot 2017-09-02 20:54:54 -0700 Attachment 319758 did not pass style-queue: ERROR: Source/JavaScriptCore/API/tests/testapi.c:2054: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/API/JSObjectRefPrivate.h:72: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1344925 3 319758 commit-queue 2017-09-02 21:42:55 -0700 Comment on attachment 319758 Patch Clearing flags on attachment: 319758 Committed r221546: <http://trac.webkit.org/changeset/221546> 1344926 4 commit-queue 2017-09-02 21:42:56 -0700 All reviewed patches have been landed. Closing bug. 1353604 5 webkit-bug-importer 2017-09-27 12:41:37 -0700 <rdar://problem/34693773> 319758 2017-09-02 20:52:11 -0700 2017-09-02 21:42:55 -0700 Patch bug-176291-20170902205209.patch text/plain 3703 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MjJkY2Q5NGU4ZWZjMTQ3YTUyYzFmODJmMjQzOTE4MjFhYWMwNDMxLi4zY2VhN2RhOTBlNTMwZGVi YjFmNGNlZWI0MDY1YjdmYTMzZjg1OTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNy0wOS0wMiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIE5lZWQgYW4gQVBJIHRvIGdldCB0aGUgZ2xvYmFsIGNvbnRleHQgZnJvbSBKU09i amVjdFJlZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc2MjkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VmVyeSBzaW1wbGUgYWRkaXRpb25hbCBBUEksIHN0YXJ0aW5nIG9mZiBhcyBTUEkgb24gcHJpbmNp cGxlLgorCisgICAgICAgICogQVBJL0pTT2JqZWN0UmVmLmNwcDoKKyAgICAgICAgKEpTT2JqZWN0 R2V0R2xvYmFsQ29udGV4dCk6CisgICAgICAgICogQVBJL0pTT2JqZWN0UmVmUHJpdmF0ZS5oOgor ICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmM6CisgICAgICAgIChtYWluKToKKwogMjAxNy0w OS0wMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBb RlRMXSBGVEwgYWxsb2NhdGlvbiBmb3IgYXN5bmMgRnVuY3Rpb24gaXMgaW5jb3JyZWN0CmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3BwCmluZGV4IGNlZmVmNjYxNDVkZjJl YjU5YWYxZDAxMTdiNmNlYWFkZmE2ZGY2MWUuLmNlMzdjYzY5MGY2NWYwNzAyM2Q3ZWVhYzMxNmJm MzEyYzcyMWIyYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmpl Y3RSZWYuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWYuY3Bw CkBAIC02OTEsMyArNjkxLDEyIEBAIEpTT2JqZWN0UmVmIEpTT2JqZWN0R2V0UHJveHlUYXJnZXQo SlNPYmplY3RSZWYgb2JqZWN0UmVmKQogICAgICAgICByZXN1bHQgPSBwcm94eS0+dGFyZ2V0KCk7 CiAgICAgcmV0dXJuIHRvUmVmKHJlc3VsdCk7CiB9CisKK0pTR2xvYmFsQ29udGV4dFJlZiBKU09i amVjdEdldEdsb2JhbENvbnRleHQoSlNPYmplY3RSZWYgb2JqZWN0UmVmKQoreworICAgIEpTT2Jq ZWN0KiBvYmplY3QgPSB0b0pTKG9iamVjdFJlZik7CisgICAgaWYgKCFvYmplY3QpCisgICAgICAg IHJldHVybiBudWxscHRyOworICAgIHJldHVybiByZWludGVycHJldF9jYXN0PEpTR2xvYmFsQ29u dGV4dFJlZj4ob2JqZWN0LT5nbG9iYWxPYmplY3QoKS0+Z2xvYmFsRXhlYygpKTsKK30KKwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU09iamVjdFJlZlByaXZhdGUuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNPYmplY3RSZWZQcml2YXRlLmgKaW5kZXggZTJi ZGFkNjk3ZTM0NjUzOTE0ZTk2ZTlhMGQxNTkwZGMyYmRmMmQ1Ni4uZWI2OGI5NjdlYTczNjgyNDZh MjI3YTZkZWI4MjU5ZWE4MjRlYjIyMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU09iamVjdFJlZlByaXZhdGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTT2JqZWN0UmVmUHJpdmF0ZS5oCkBAIC02OSw2ICs2OSw4IEBAIEpTX0VYUE9SVCBib29sIEpT T2JqZWN0RGVsZXRlUHJpdmF0ZVByb3BlcnR5KEpTQ29udGV4dFJlZiBjdHgsIEpTT2JqZWN0UmVm IG9iamVjCiAKIEpTX0VYUE9SVCBKU09iamVjdFJlZiBKU09iamVjdEdldFByb3h5VGFyZ2V0KEpT T2JqZWN0UmVmKTsKIAorSlNfRVhQT1JUIEpTR2xvYmFsQ29udGV4dFJlZiBKU09iamVjdEdldEds b2JhbENvbnRleHQoSlNPYmplY3RSZWYgb2JqZWN0KTsKKyAgICAKICNpZmRlZiBfX2NwbHVzcGx1 cwogfQogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3Rz L3Rlc3RhcGkuYyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCmlu ZGV4IDkyYzIyYzU5ZDkxOWQwNmYxMjQ4YWRkYTFhYTQwMTA0ZmJmNzg3NzEuLjdiZWNkZmUwNDEx NWJmOTQ4OWVmODQxOTdjMTY3MWM1YjgzYmE0ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5jCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvdGVzdHMvdGVzdGFwaS5jCkBAIC0yMDQwLDYgKzIwNDAsMjIgQEAgaW50IG1haW4oaW50IGFy Z2MsIGNoYXIqIGFyZ3ZbXSkKICAgICAgICAgSlNHbG9iYWxDb250ZXh0UmVsZWFzZShjb250ZXh0 KTsKICAgICB9CiAKKyAgICAvLyBDaGVjayBKU09iamVjdEdldEdsb2JhbENvbnRleHQKKyAgICB7 CisgICAgICAgIEpTR2xvYmFsQ29udGV4dFJlZiBjb250ZXh0ID0gSlNHbG9iYWxDb250ZXh0Q3Jl YXRlSW5Hcm91cChOVUxMLCBOVUxMKTsKKyAgICAgICAgeworICAgICAgICAgICAgSlNPYmplY3RS ZWYgZ2xvYmFsT2JqZWN0ID0gSlNDb250ZXh0R2V0R2xvYmFsT2JqZWN0KGNvbnRleHQpOworICAg ICAgICAgICAgYXNzZXJ0VHJ1ZShKU09iamVjdEdldEdsb2JhbENvbnRleHQoZ2xvYmFsT2JqZWN0 KSA9PSBjb250ZXh0LCAiZ2xvYmFsIG9iamVjdCBjb250ZXh0IGlzIGNvcnJlY3QiKTsKKyAgICAg ICAgICAgIEpTT2JqZWN0UmVmIG9iamVjdCA9IEpTT2JqZWN0TWFrZShjb250ZXh0LCBOVUxMLCBO VUxMKTsKKyAgICAgICAgICAgIGFzc2VydFRydWUoSlNPYmplY3RHZXRHbG9iYWxDb250ZXh0KG9i amVjdCkgPT0gY29udGV4dCwgInJlZ3VsYXIgb2JqZWN0IGNvbnRleHQgaXMgY29ycmVjdCIpOwor ICAgICAgICAgICAgSlNTdHJpbmdSZWYgcmV0dXJuRnVuY3Rpb25Tb3VyY2UgPSBKU1N0cmluZ0Ny ZWF0ZVdpdGhVVEY4Q1N0cmluZygicmV0dXJuIHRoaXM7Iik7CisgICAgICAgICAgICBKU09iamVj dFJlZiB0aGVGdW5jdGlvbiA9IEpTT2JqZWN0TWFrZUZ1bmN0aW9uKGNvbnRleHQsIE5VTEwsIDAs IE5VTEwsIHJldHVybkZ1bmN0aW9uU291cmNlLCBOVUxMLCAxLCBOVUxMKTsKKyAgICAgICAgICAg IGFzc2VydFRydWUoSlNPYmplY3RHZXRHbG9iYWxDb250ZXh0KHRoZUZ1bmN0aW9uKSA9PSBjb250 ZXh0LCAiZnVuY3Rpb24gb2JqZWN0IGNvbnRleHQgaXMgY29ycmVjdCIpOworICAgICAgICAgICAg YXNzZXJ0VHJ1ZShKU09iamVjdEdldEdsb2JhbENvbnRleHQoTlVMTCkgPT0gTlVMTCwgIk5VTEwg b2JqZWN0IGNvbnRleHQgaXMgTlVMTCIpOworICAgICAgICAgICAgSlNTdHJpbmdSZWxlYXNlKHJl dHVybkZ1bmN0aW9uU291cmNlKTsKKyAgICAgICAgfQorICAgICAgICBKU0dsb2JhbENvbnRleHRS ZWxlYXNlKGNvbnRleHQpOworICAgIH0KICAgICBmYWlsZWQgPSB0ZXN0VHlwZWRBcnJheUNBUEko KSB8fCBmYWlsZWQ7CiAgICAgZmFpbGVkID0gdGVzdEV4ZWN1dGlvblRpbWVMaW1pdCgpIHx8IGZh aWxlZDsKICAgICBmYWlsZWQgPSB0ZXN0RnVuY3Rpb25PdmVycmlkZXMoKSB8fCBmYWlsZWQ7Cg==