176269 2017-09-01 21:57:19 -0700 Performance / PerformanceObserver leaks seen on bots 2017-09-27 12:40:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck achristensen ap commit-queue darin joepeck rniwa webkit-bug-importer oldest_to_newest 1344740 0 joepeck 2017-09-01 21:57:19 -0700 Performance / PerformanceObserver leaks seen on bots Steps to reproduce: 1. $ run-webkit-tests --leaks performance-api -1 => Leaks Leaks: > Leak: 0x7ff45552af20 size=224 zone: WebKit Using System Malloc_0x10d333000 WebCore::Performance C++ WebCore > 0x0ba9b348 0x00000001 0x00000000 0x00000000 H............... > 0x00000001 0xaaaaaaaa 0x0ba9b390 0x00000001 ................ > 0x00000000 0x00000000 0x5552af58 0x00007ff4 ........X.RU.... > 0x00000002 0x00000000 0xaaaaaaaa 0xaaaaaaaa ................ > 0xaaaaaaaa 0xaaaaaaaa 0xaaaaaaaa 0xaaaaaaaa ................ > 0xaaaaaaaa 0xaaaaaaaa 0xaaaaaa00 0xaaaaaaaa ................ > 0xaaaaaa00 0xaaaaaaaa 0x00000000 0x00000000 ................ > 0x00000000 0x00000000 0x00000000 0x00000000 ................ > ... > Call stack: [thread 0x700004870000]: > | thread_start > | _pthread_body > | _pthread_body > | WTF::wtfThreadEntryPoint(void*) ThreadingPthreads.cpp:229 > | WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) memory:2602 > | WebCore::WorkerThread::workerThread() WorkerThread.cpp:163 > | WebCore::DedicatedWorkerThread::createWorkerGlobalScope(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::ContentSecurityPolicyResponseHeaders const&, bool, WTF::Ref<WebCore::SecurityOrigin>&&, WTF::MonotonicTime, PAL::SessionID) DedicatedWorkerThread.cpp:53 > | WebCore::DedicatedWorkerGlobalScope::create(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::DedicatedWorkerThread&, WebCore::ContentSecurityPolicyResponseHeaders const&, bool, WTF::Ref<WebCore::SecurityOrigin>&&, WTF::MonotonicTime, WebCore::IDBClient::IDBConnectionProxy*, WebCore::SocketProvider*, PAL::SessionID) DedicatedWorkerGlobalScope.cpp:53 > | WebCore::WorkerGlobalScope::WorkerGlobalScope(WebCore::URL const&, WTF::String const&, WTF::String const&, WebCore::WorkerThread&, bool, WTF::Ref<WebCore::SecurityOrigin>&&, WTF::MonotonicTime, WebCore::IDBClient::IDBConnectionProxy*, WebCore::SocketProvider*, PAL::SessionID) RefCounted.h:140 > | WTF::fastMalloc(unsigned long) FastMalloc.cpp:258 > | bmalloc::DebugHeap::malloc(unsigned long) DebugHeap.cpp:49 > | malloc_zone_malloc > > Leak: 0x7ff4555471a0 size=64 zone: WebKit Using System Malloc_0x10d333000 > 0x00000000 0x00000000 0x00000000 0x00000000 ................ > 0x00000000 0x00000000 0x00000000 0x00000000 ................ > 0x00000000 0x00000000 0xffffffff 0xffffffff ................ > 0x5554fa50 0x00007ff4 0x00000000 0x00000000 P.TU............ > Call stack: [thread 0x700004870000]: > | thread_start > | _pthread_body > | _pthread_body > | WTF::wtfThreadEntryPoint(void*) ThreadingPthreads.cpp:229 > | WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) memory:2602 > | WebCore::WorkerThread::workerThread() utility:889 > | WebCore::WorkerScriptController::evaluate(WebCore::ScriptSourceCode const&) WorkerScriptController.cpp:110 > | WebCore::WorkerScriptController::evaluate(WebCore::ScriptSourceCode const&, WTF::NakedPtr<JSC::Exception>&) WorkerScriptController.cpp:0 > | JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) Completion.cpp:102 > | JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) Interpreter.cpp:912 > | JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) JITCode.cpp:82 > | vmEntryToJavaScript LowLevelInterpreter64.asm:258 > | llint_entry LowLevelInterpreter.asm:789 > | 0x5c0607c0c368 > | WebCore::jsPerformanceObserverPrototypeFunctionObserve(JSC::ExecState*) ExceptionOr.h:162 > | WebCore::PerformanceObserver::observe(WebCore::PerformanceObserver::Init&&) PerformanceObserver.cpp:72 > | WebCore::Performance::registerPerformanceObserver(WebCore::PerformanceObserver&) utility:889 > | WTF::ListHashSet<WTF::RefPtr<WebCore::PerformanceObserver>, WTF::PtrHash<WTF::RefPtr<WebCore::PerformanceObserver> > >::add(WTF::RefPtr<WebCore::PerformanceObserver>&&) HashTable.h:1196 > | WTF::fastZeroedMalloc(unsigned long) Allocator.h:91 > | bmalloc::DebugHeap::malloc(unsigned long) DebugHeap.cpp:49 > | malloc_zone_malloc Notes: Performance has: ListHashSet<RefPtr<PerformanceObserver>> m_observers; PerformanceObserver has: RefPtr<Performance> m_performance; This appears to be a cycle between these RefCounted objects. We have to break that cycle at some point. It seems a time similar to removeAllEventListeners() would be appropriate. 1344741 1 319691 joepeck 2017-09-01 21:59:05 -0700 Created attachment 319691 [PATCH] Proposed Fix 1344829 2 319691 commit-queue 2017-09-02 11:31:03 -0700 Comment on attachment 319691 [PATCH] Proposed Fix Clearing flags on attachment: 319691 Committed r221539: <http://trac.webkit.org/changeset/221539> 1344830 3 commit-queue 2017-09-02 11:31:05 -0700 All reviewed patches have been landed. Closing bug. 1353591 4 webkit-bug-importer 2017-09-27 12:40:53 -0700 <rdar://problem/34693742> 319691 2017-09-01 21:59:05 -0700 2017-09-02 11:31:03 -0700 [PATCH] Proposed Fix performance-leaks-1.patch text/plain 4456 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NTVmOGU0Y2I1Zi4uZDA1YTg2ZDcyM2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzMCBAQAogMjAxNy0wOS0wMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIFBlcmZvcm1hbmNlIC8gUGVyZm9ybWFuY2VPYnNlcnZlciBsZWFrcyBz ZWVuIG9uIGJvdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3NjI2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogcGFnZS9ET01XaW5kb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93Ojpy ZW1vdmVBbGxFdmVudExpc3RlbmVycyk6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJHbG9iYWxT Y29wZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJHbG9iYWxTY29wZTo6cmVtb3ZlQWxs RXZlbnRMaXN0ZW5lcnMpOgorICAgICAgICBBbHNvIHVzZSB0aGlzIG9wcG9ydHVuaXR5IHRvIGJy ZWFrIHVwIHRoZSByZWZlcmVuY2UgY3ljbGUKKyAgICAgICAgYmV0d2VlbiBQZXJmb3JtYW5jZU9i c2VydmVycyBhbmQgdGhlIFBlcmZvcm1hbmNlIG9iamVjdC4KKworICAgICAgICAqIHBhZ2UvUGVy Zm9ybWFuY2UuaDoKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlBlcmZvcm1hbmNlOjpyZW1vdmVBbGxPYnNlcnZlcnMpOgorICAgICAgICBEaXNhc3Nv Y2lhdGUgYW5kIGNsZWFyIG9ic2VydmVycy4KKworICAgICAgICAqIHBhZ2UvUGVyZm9ybWFuY2VP YnNlcnZlci5oOgorICAgICAgICAqIHBhZ2UvUGVyZm9ybWFuY2VPYnNlcnZlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpQZXJmb3JtYW5jZU9ic2VydmVyOjpkaXNhc3NvY2lhdGUpOgorICAgICAg ICBDbGVhciB0aGUgYmFjay1yZWZlcmVuY2UgdG8gdGhlIFBlcmZvcm1hbmNlIG9iamVjdCB0bwor ICAgICAgICBicmVhayB0aGUgY3ljbGUuCisKKzIwMTctMDktMDEgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWJLaXQgc2hvdWxkIGNsYWltIHRoYXQg aXQgY2FuIHNob3cgcmVzcG9uc2VzIGEgYnJvYWRlciByYW5nZSBvZiBKU09OIE1JTUVUeXBlcwog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MjUyCiAg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDIxMjg4NT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNw cAppbmRleCAxY2Q1ZDRjYmUxNC4uYjIzOWM4YWZlNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRv dy5jcHAKQEAgLTIwNDEsOCArMjA0MSwxMCBAQCB2b2lkIERPTVdpbmRvdzo6cmVtb3ZlQWxsRXZl bnRMaXN0ZW5lcnMoKQogICAgICAgICBkb2N1bWVudC0+ZGlkUmVtb3ZlRXZlbnRUYXJnZXROb2Rl KCpkb2N1bWVudCk7CiAjZW5kaWYKIAotICAgIGlmIChtX3BlcmZvcm1hbmNlKQorICAgIGlmICht X3BlcmZvcm1hbmNlKSB7CiAgICAgICAgIG1fcGVyZm9ybWFuY2UtPnJlbW92ZUFsbEV2ZW50TGlz dGVuZXJzKCk7CisgICAgICAgIG1fcGVyZm9ybWFuY2UtPnJlbW92ZUFsbE9ic2VydmVycygpOwor ICAgIH0KIAogICAgIHJlbW92ZUFsbFVubG9hZEV2ZW50TGlzdGVuZXJzKHRoaXMpOwogICAgIHJl bW92ZUFsbEJlZm9yZVVubG9hZEV2ZW50TGlzdGVuZXJzKHRoaXMpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Bl cmZvcm1hbmNlLmNwcAppbmRleCA0YjhlNTM2ODI4YS4uMWFmYTM2NDU5MTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvUGVyZm9ybWFuY2UuY3BwCkBAIC0yMzEsNiArMjMxLDEzIEBAIHZvaWQgUGVyZm9ybWFu Y2U6OmNsZWFyTWVhc3VyZXMoY29uc3QgU3RyaW5nJiBtZWFzdXJlTmFtZSkKICAgICBtX3VzZXJU aW1pbmctPmNsZWFyTWVhc3VyZXMobWVhc3VyZU5hbWUpOwogfQogCit2b2lkIFBlcmZvcm1hbmNl OjpyZW1vdmVBbGxPYnNlcnZlcnMoKQoreworICAgIGZvciAoYXV0byYgb2JzZXJ2ZXIgOiBtX29i c2VydmVycykKKyAgICAgICAgb2JzZXJ2ZXItPmRpc2Fzc29jaWF0ZSgpOworICAgIG1fb2JzZXJ2 ZXJzLmNsZWFyKCk7Cit9CisKIHZvaWQgUGVyZm9ybWFuY2U6OnJlZ2lzdGVyUGVyZm9ybWFuY2VP YnNlcnZlcihQZXJmb3JtYW5jZU9ic2VydmVyJiBvYnNlcnZlcikKIHsKICAgICBtX29ic2VydmVy cy5hZGQoJm9ic2VydmVyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9y bWFuY2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2UuaAppbmRleCAyZDUwMzcy ZGZjZC4uOWE2MGVjMGFiMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9y bWFuY2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlLmgKQEAgLTc2LDYg Kzc2LDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBhZGRSZXNvdXJjZVRpbWluZyhSZXNvdXJjZVRp bWluZyYmKTsKIAorICAgIHZvaWQgcmVtb3ZlQWxsT2JzZXJ2ZXJzKCk7CiAgICAgdm9pZCByZWdp c3RlclBlcmZvcm1hbmNlT2JzZXJ2ZXIoUGVyZm9ybWFuY2VPYnNlcnZlciYpOwogICAgIHZvaWQg dW5yZWdpc3RlclBlcmZvcm1hbmNlT2JzZXJ2ZXIoUGVyZm9ybWFuY2VPYnNlcnZlciYpOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlT2JzZXJ2ZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU9ic2VydmVyLmNwcAppbmRleCBkYjRhZjE4 MDgyZi4uNGI3Njg2YmNmOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9y bWFuY2VPYnNlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU9i c2VydmVyLmNwcApAQCAtNDgsNiArNDgsMTEgQEAgUGVyZm9ybWFuY2VPYnNlcnZlcjo6UGVyZm9y bWFuY2VPYnNlcnZlcihTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBzY3JpcHRFeGVjdXRpb24KICAg ICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKK3ZvaWQgUGVyZm9ybWFuY2VPYnNlcnZl cjo6ZGlzYXNzb2NpYXRlKCkKK3sKKyAgICBtX3BlcmZvcm1hbmNlID0gbnVsbHB0cjsKK30KKwog RXhjZXB0aW9uT3I8dm9pZD4gUGVyZm9ybWFuY2VPYnNlcnZlcjo6b2JzZXJ2ZShJbml0JiYgaW5p dCkKIHsKICAgICBpZiAoIW1fcGVyZm9ybWFuY2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BlcmZvcm1hbmNlT2JzZXJ2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9y bWFuY2VPYnNlcnZlci5oCmluZGV4IGIyYWI1Y2M3MTVmLi5hZmM1ZGZhOGVlYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU9ic2VydmVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU9ic2VydmVyLmgKQEAgLTQ5LDYgKzQ5LDggQEAgcHVi bGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBQZXJmb3JtYW5jZU9ic2VydmVyKGNv bnRleHQsIFdURk1vdmUoY2FsbGJhY2spKSk7CiAgICAgfQogCisgICAgdm9pZCBkaXNhc3NvY2lh dGUoKTsKKwogICAgIEV4Y2VwdGlvbk9yPHZvaWQ+IG9ic2VydmUoSW5pdCYmKTsKICAgICB2b2lk IGRpc2Nvbm5lY3QoKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3Jr ZXJHbG9iYWxTY29wZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckdsb2JhbFNj b3BlLmNwcAppbmRleCA2OWEwNTJhMDdlNi4uZGI2Y2IxOTM2MGQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyR2xvYmFsU2NvcGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvV29ya2VyR2xvYmFsU2NvcGUuY3BwCkBAIC0xMDQsNiArMTA0LDcgQEAgdm9p ZCBXb3JrZXJHbG9iYWxTY29wZTo6cmVtb3ZlQWxsRXZlbnRMaXN0ZW5lcnMoKQogewogICAgIEV2 ZW50VGFyZ2V0OjpyZW1vdmVBbGxFdmVudExpc3RlbmVycygpOwogICAgIG1fcGVyZm9ybWFuY2Ut PnJlbW92ZUFsbEV2ZW50TGlzdGVuZXJzKCk7CisgICAgbV9wZXJmb3JtYW5jZS0+cmVtb3ZlQWxs T2JzZXJ2ZXJzKCk7CiB9CiAKIGJvb2wgV29ya2VyR2xvYmFsU2NvcGU6OmlzU2VjdXJlQ29udGV4 dCgpIGNvbnN0Cg==