176268 2017-09-01 21:06:51 -0700 Web Automation: -[_WKAutomationSession init] leaks 2017-09-27 12:39:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue darin inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1344734 0 joepeck 2017-09-01 21:06:51 -0700 Web Automation: -[_WKAutomationSession init] leaks: > - (instancetype)init > { > return [self initWithConfiguration:[_WKAutomationSessionConfiguration new]]; > } because we are not in ARC, the -new is a +1 but we should be passing an autoreleased object here. This was caught by the static analyzer. Test: > // shell> xcrun clang -framework Foundation -framework WebKit leak.m > > #import <WebKit/WebKit.h> > @interface _WKAutomationSession : NSObject > @end > > static void leak() { > [[[_WKAutomationSession alloc] init] release]; > } > > int main() { > @autoreleasepool { leak(); } > sleep(1000); > return 0; > } Leak: Process 68184: 1 leak for 16 total leaked bytes. Leak: 0x7fdd1b506ff0 size=16 zone: DefaultMallocZone_0x112fbd000 _WKAutomationSessionConfiguration ObjC WebKit 0x0eb156d9 0x001d8001 0x00000001 0x00000000 .V.............. Call stack: [thread 0x7fffa41cc340]: | 0x1 | start | main | leak | -[_WKAutomationSession init] _WKAutomationSession.mm:46 | +[NSObject new] | class_createInstance | calloc | malloc_zone_calloc 1344736 1 319689 joepeck 2017-09-01 21:19:59 -0700 Created attachment 319689 [PATCH] Proposed Fix 1344827 2 319689 commit-queue 2017-09-02 11:29:43 -0700 Comment on attachment 319689 [PATCH] Proposed Fix Clearing flags on attachment: 319689 Committed r221538: <http://trac.webkit.org/changeset/221538> 1344828 3 commit-queue 2017-09-02 11:29:45 -0700 All reviewed patches have been landed. Closing bug. 1353575 4 webkit-bug-importer 2017-09-27 12:39:34 -0700 <rdar://problem/34693703> 319689 2017-09-01 21:19:59 -0700 2017-09-02 11:29:43 -0700 [PATCH] Proposed Fix leak-1.patch text/plain 1295 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmNmYTEzNmRkNjQuLjM0ZmE4ODNlZGYzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDE3LTA5LTAxICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IC1bX1dLQXV0b21hdGlvblNlc3Npb24gaW5pdF0g bGVha3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjI2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdXRvbWF0aW9uU2Vzc2lvbi5tbToKKyAgICAgICAgKC1b X1dLQXV0b21hdGlvblNlc3Npb24gaW5pdF0pOgorCiAyMDE3LTA5LTAxICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBEbyBub3QgUmVqZWN0IENhY2hlU3RvcmFn ZSBwcm9taXNlcyB3aGVuIHVwZGF0aW5nIHRoZSBwZXJzaXN0ZW50IGZpbGVzeXN0ZW0gZGF0YSBm YWlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0F1 dG9tYXRpb25TZXNzaW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19X S0F1dG9tYXRpb25TZXNzaW9uLm1tCmluZGV4IDcwZGRkNDFhMTc4Li5iNDAwZmFlOGNmMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0F1dG9tYXRpb25T ZXNzaW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tBdXRv bWF0aW9uU2Vzc2lvbi5tbQpAQCAtNDMsNyArNDMsNyBAQCBAaW1wbGVtZW50YXRpb24gX1dLQXV0 b21hdGlvblNlc3Npb24gewogCiAtIChpbnN0YW5jZXR5cGUpaW5pdAogewotICAgIHJldHVybiBb c2VsZiBpbml0V2l0aENvbmZpZ3VyYXRpb246W19XS0F1dG9tYXRpb25TZXNzaW9uQ29uZmlndXJh dGlvbiBuZXddXTsKKyAgICByZXR1cm4gW3NlbGYgaW5pdFdpdGhDb25maWd1cmF0aW9uOltbW19X S0F1dG9tYXRpb25TZXNzaW9uQ29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0gYXV0b3JlbGVhc2Vd XTsKIH0KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29uZmlndXJhdGlvbjooX1dLQXV0b21h dGlvblNlc3Npb25Db25maWd1cmF0aW9uICopY29uZmlndXJhdGlvbgo=