176210 2017-08-31 20:16:14 -0700 Ensure RenderStyle and SameSizeAsRenderStyle have the same size 2017-09-27 12:43:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build PC Unspecified RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 176171 1 dbates dbates bfulgham commit-queue don.olmstead pvollan webkit-bug-importer yoshiaki.jitsukawa oldest_to_newest 1344289 0 dbates 2017-08-31 20:16:14 -0700 We should look to revert the Apple Windows build fix in <http://trac.webkit.org/changeset/221469> (build fix for bug #176171). The following is the error that led to change made in r221469: [[ c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\style\RenderStyle.cpp(84): error C2338: RenderStyle should stay small (compiling source file C:\cygwin\home\buildbot\slave\win-debug\build\Source\WebCore\rendering\style\StyleAllInOne.cpp) [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\WebCore\WebCore.vcxproj] ]] <https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/3683/steps/compile-webkit/logs/stdio> This error only occurs on the Apple Windows Debug and Release bots. It does not occur when building on any other port. The Apple Windows Debug and Release bots are using VS 2015. Another data point, Don Olmstead was not able to reproduce this compile-time failure on VS 2015 when building the WinCairo port. 1344290 1 319566 dbates 2017-08-31 20:19:26 -0700 Created attachment 319566 For EWS I expect this patch to fail on the Windows EWS. This is for my sanity. 1344325 2 yoshiaki.jitsukawa 2017-08-31 23:05:19 -0700 The size of RenderStyle and SameSizeAsRenderStyle are 0x34 and 0x38 bytes respectively on AppleWin (32 bit). static_assert(sizeof(RenderStyle) == 0x34, "0x34"); static_assert(sizeof(SameSizeAsRenderStyle) == 0x38, "0x38"); 1344328 3 yoshiaki.jitsukawa 2017-08-31 23:27:34 -0700 There's a 4 byte padding between SameSizeAsRenderStyle::m_inheritedFlags and SameSizeAsRenderStyle::m_nonInheritedFlags due to 64 bit align requirement for m_nonInheritedFlags (uint64_t). static_assert(offsetof(SameSizeAsRenderStyle, m_inheritedFlags) == 0x24, "0x24"); static_assert(offsetof(SameSizeAsRenderStyle, m_nonInheritedFlags) == 0x30, "0x30"); 1344337 4 319582 yoshiaki.jitsukawa 2017-08-31 23:55:50 -0700 Created attachment 319582 Patch 1344440 5 319582 commit-queue 2017-09-01 10:17:36 -0700 Comment on attachment 319582 Patch Clearing flags on attachment: 319582 Committed r221480: <http://trac.webkit.org/changeset/221480> 1344441 6 commit-queue 2017-09-01 10:17:37 -0700 All reviewed patches have been landed. Closing bug. 1353620 7 webkit-bug-importer 2017-09-27 12:43:05 -0700 <rdar://problem/34693819> 319566 2017-08-31 20:19:26 -0700 2017-08-31 20:19:26 -0700 For EWS bug-176210-20170831201925.patch text/plain 1405 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdiYjNlYjZlZWJjMGU0 YjgyMzM4NjU4Mzk5Nzk2MjFiYWM4OWI1Mi4uMmY3MWFhMDA1NWQ1NWIxNzQwZjFhNzFkZjdkOGUw ZWE0ZTNmNGFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA4LTMxICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBFbnN1cmUgUmVuZGVyU3R5 bGUgYW5kIFNhbWVTaXplQXNSZW5kZXJTdHlsZSBoYXZlIHRoZSBzYW1lIHNpemUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NjIxMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydCByMjIxNDY5Lgor CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKworMjAxNy0wOC0z MSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKICAgICAgICAgQW5vdGhlciBh dHRlbXB0IHRvIGZpeCB0aGUgQXBwbGUgV2luZG93cyBidWlsZCBmb2xsb3dpbmcgPGh0dHBzOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMjE0NTk+CiAgICAgICAgIChodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MTcxKQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCBlZjk2MWM4MDY5OGRjNmQ1ZDcy OTczMDc5NmZjOTNlZGE2ZmY3YzJjLi40MDk1NzcxMTQzYjU3YjRkYTU2YWMwMWExZjU1Y2M2OTBm MDNmZGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVy U3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZS5jcHAKQEAgLTgxLDcgKzgxLDcgQEAgc3RydWN0IFNhbWVTaXplQXNSZW5kZXJTdHlsZSB7CiAj ZW5kaWYKIH07CiAKLXN0YXRpY19hc3NlcnQoc2l6ZW9mKFJlbmRlclN0eWxlKSA8PSBzaXplb2Yo U2FtZVNpemVBc1JlbmRlclN0eWxlKSwgIlJlbmRlclN0eWxlIHNob3VsZCBzdGF5IHNtYWxsIik7 CitzdGF0aWNfYXNzZXJ0KHNpemVvZihSZW5kZXJTdHlsZSkgPT0gc2l6ZW9mKFNhbWVTaXplQXNS ZW5kZXJTdHlsZSksICJSZW5kZXJTdHlsZSBzaG91bGQgc3RheSBzbWFsbCIpOwogCiBSZW5kZXJT dHlsZSYgUmVuZGVyU3R5bGU6OmRlZmF1bHRTdHlsZSgpCiB7Cg== 319582 2017-08-31 23:55:50 -0700 2017-09-01 10:17:36 -0700 Patch bug-176210-20170901155549.patch text/plain 1762 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNmNjE0ZmZmMzUzODM2 Mjg0MTIwMzJkMzk0M2FkZDllOGNjOWJmNS4uZmUzMmQ5MTE1MDNhYTljOGNkMzY2YmY3OTc3YTNi NmVmOTVhMDE3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA4LTMxICBZb3No aWFraSBKaXRzdWthd2EgIDxZb3NoaWFraS5KaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAg RW5zdXJlIFJlbmRlclN0eWxlIGFuZCBTYW1lU2l6ZUFzUmVuZGVyU3R5bGUgaGF2ZSB0aGUgc2Ft ZSBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzYyMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBT YW1lU2l6ZUFzUmVuZGVyU3R5bGU6Om1fbm9uSW5oZXJpdGVkRmxhZ3MgcmVxdWlyZXMgYSA2NCBi aXQgYWxpZ25tZW50LAorICAgICAgICB3aGljaCBjdXJyZW50bHkgcHJvZHVjZXMgYW4gZXh0cmEg MzIgYml0IHBhZGRpbmcgd2l0aCAzMiBiaXQgYnVpbGQuCisKKyAgICAgICAgKiByZW5kZXJpbmcv c3R5bGUvUmVuZGVyU3R5bGUuY3BwOgorICAgICAgICBNYWtlIG1fbm9uSW5oZXJpdGVkRmxhZ3Mg MzIgYml0IGFsaWduZWQgYW5kIHJlc3RvcmUgdGhlIHNpemUgY2hlY2suCisKIDIwMTctMDgtMzEg IEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIFVwc3RyZWFt IEFwcEtpdC1yZWxhdGVkIFdlYktpdFN5c3RlbUludGVyZmFjZSBmdW5jdGlvbnMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwCmluZGV4IGVmOTYxYzgw Njk4ZGM2ZDVkNzI5NzMwNzk2ZmM5M2VkYTZmZjdjMmMuLjdlNWM4NDMyOTRhOTc2MjdlOGIyMGVl NjQ4NGY5ZWMyYWQ0NmQ1MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9z dHlsZS9SZW5kZXJTdHlsZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxl L1JlbmRlclN0eWxlLmNwcApAQCAtNzQsMTQgKzc0LDE0IEBAIHN0cnVjdCBTYW1lU2l6ZUFzUmVu ZGVyU3R5bGUgewogICAgIH0gbV9pbmhlcml0ZWRGbGFnczsKIAogICAgIHN0cnVjdCBOb25Jbmhl cml0ZWRGbGFncyB7Ci0gICAgICAgIHVpbnQ2NF90IG1fYml0ZmllbGRzOworICAgICAgICB1bnNp Z25lZCBtX2JpdGZpZWxkc1syXTsKICAgICB9IG1fbm9uSW5oZXJpdGVkRmxhZ3M7CiAjaWYgIUFT U0VSVF9ESVNBQkxFRCB8fCBFTkFCTEUoU0VDVVJJVFlfQVNTRVJUSU9OUykKICAgICBib29sIGRl bGV0aW9uQ2hlY2s7CiAjZW5kaWYKIH07CiAKLXN0YXRpY19hc3NlcnQoc2l6ZW9mKFJlbmRlclN0 eWxlKSA8PSBzaXplb2YoU2FtZVNpemVBc1JlbmRlclN0eWxlKSwgIlJlbmRlclN0eWxlIHNob3Vs ZCBzdGF5IHNtYWxsIik7CitzdGF0aWNfYXNzZXJ0KHNpemVvZihSZW5kZXJTdHlsZSkgPT0gc2l6 ZW9mKFNhbWVTaXplQXNSZW5kZXJTdHlsZSksICJSZW5kZXJTdHlsZSBzaG91bGQgc3RheSBzbWFs bCIpOwogCiBSZW5kZXJTdHlsZSYgUmVuZGVyU3R5bGU6OmRlZmF1bHRTdHlsZSgpCiB7Cg==