176208 2017-08-31 19:35:28 -0700 WSL Rewriter should be an identity on things that aren't inside function bodies 2018-10-13 19:57:42 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 176199 1 fpizlo fpizlo mmaxfield webkit-bug-importer oldest_to_newest 1344280 0 fpizlo 2017-08-31 19:35:28 -0700 That way, if we ever short-circuit a TypeRef, it'll be OK. And Rewriter will be able to rewrite TypeRef.type. 1344484 1 319623 fpizlo 2017-09-01 11:22:32 -0700 Created attachment 319623 the patch 1344505 2 fpizlo 2017-09-01 11:49:08 -0700 Landed in https://trac.webkit.org/changeset/221487/webkit 1353612 3 webkit-bug-importer 2017-09-27 12:42:12 -0700 <rdar://problem/34693792> 1469007 4 mmaxfield 2018-10-13 19:57:42 -0700 Migrated to https://github.com/gpuweb/WHLSL/issues/201 319623 2017-09-01 11:22:32 -0700 2017-09-01 11:25:11 -0700 the patch blah.patch text/plain 6577 fpizlo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTQ4MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDM3IEBACisyMDE3LTA5LTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisK KyAgICAgICAgV1NMIFJld3JpdGVyIHNob3VsZCBiZSBhbiBpZGVudGl0eSBvbiB0aGluZ3MgdGhh dCBhcmVuJ3QgaW5zaWRlIGZ1bmN0aW9uIGJvZGllcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBQcmV2aW91c2x5LCBpZiB0aGUgUmV3cml0 ZXIgZW5jb3VudGVyZWQgYSBGdW5jdGlvbkRlZiwgU3RydWN0VHlwZSwgTmF0aXZlVHlwZSwgZXRj LiwgdGhlbiBpdAorICAgICAgICB3b3VsZCBlaXRoZXIgY3Jhc2ggb3IgdHJ5IHRvIHJld3JpdGUg dGhlbS4gVGhhdCdzIHVuZm9ydHVuYXRlIGJlY2F1c2Ugd2UgdXNlIHRoZSBSZXdyaXRlciB0bwor ICAgICAgICByZXdyaXRlIHN0cnVjdCBhbmQgZnVuY3Rpb24gYm9kaWVzLiBJZiBhIGZ1bmN0aW9u IGNhbGxzIGFub3RoZXIgZnVuY3Rpb24sIHRoZW4gcmV3cml0aW5nIHRoZQorICAgICAgICBjYWxs ZXIgc2hvdWxkIG5vdCBtZWFuIGFsc28gcmV3cml0aW5nIHRoZSBjYWxsZWUuIFByZXZpb3VzbHkg d2UgImZpeGVkIiB0aGlzIGJ5IHJlbGlnaW91c2x5CisgICAgICAgIHdyYXBwaW5nIHJlZmVyZW5j ZXMgdG8gdHlwZXMgd2l0aCBUeXBlRGVmIGFuZCBkb2luZyBvdGhlciBzdWNoIGhhY2tzLiBCdXQg dGhhdCdzIHN1YnRseSB3cm9uZy4KKyAgICAgICAgSXQgb25seSB3b3JrZWQgYmVjYXVzZSBSZXdy aXRlciB3YXNuJ3QgcmV3cml0aW5nIFR5cGVSZWYudHlwZS4gSSB0aGluayB0aGF0IFJld3JpdGVy IGhhcyB0bworICAgICAgICByZXdyaXRlIHRoYXQgaW4gdGhlIGxvbmcgcnVuIGJlY2F1c2UgaXQg bWF5IHJlZmVyIHRvIGFub3RoZXIgVHlwZVJlZiwgYW5kIGl0IG1heSBiZSBhbgorICAgICAgICBp bnN0YW50aWF0aW9uIHRoYXQgaXMgdXNpbmcgdHlwZXMgdGhhdCB0aGVtc2VsdmVzIG5lZWQgdG8g YmUgcmV3cml0dGVuLgorCisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvQ2hlY2tl ci5qczoKKyAgICAgICAgKENoZWNrZXIucHJvdG90eXBlLnZpc2l0UHJvdG9jb2xEZWNsLnNldCB0 aHJvdyk6CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvTnVsbFR5cGUuanM6Cisg ICAgICAgIChOdWxsVHlwZSk6CisgICAgICAgICogV2ViR1BVU2hhZGluZ0xhbmd1YWdlUkkvUmV3 cml0ZXIuanM6CisgICAgICAgIChSZXdyaXRlci5wcm90b3R5cGUudmlzaXRGdW5jRGVmKToKKyAg ICAgICAgKFJld3JpdGVyLnByb3RvdHlwZS52aXNpdE5hdGl2ZUZ1bmMpOgorICAgICAgICAoUmV3 cml0ZXIucHJvdG90eXBlLnZpc2l0TmF0aXZlRnVuY0luc3RhbmNlKToKKyAgICAgICAgKFJld3Jp dGVyLnByb3RvdHlwZS52aXNpdE5hdGl2ZVR5cGUpOgorICAgICAgICAoUmV3cml0ZXIucHJvdG90 eXBlLnZpc2l0VHlwZURlZik6CisgICAgICAgIChSZXdyaXRlci5wcm90b3R5cGUudmlzaXRTdHJ1 Y3RUeXBlKToKKyAgICAgICAgKFJld3JpdGVyLnByb3RvdHlwZS52aXNpdFR5cGVWYXJpYWJsZSk6 CisgICAgICAgIChSZXdyaXRlci5wcm90b3R5cGUudmlzaXRDb25zdGV4cHJUeXBlUGFyYW1ldGVy KToKKyAgICAgICAgKFJld3JpdGVyLnByb3RvdHlwZS52aXNpdE5hdGl2ZVR5cGVJbnN0YW5jZSk6 CisgICAgICAgIChSZXdyaXRlci5wcm90b3R5cGUudmlzaXRUeXBlUmVmKToKKyAgICAgICAgKiBX ZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yLmpzOgorICAgICAgICAoVmlzaXRvci5wcm90 b3R5cGUudmlzaXROYXRpdmVUeXBlSW5zdGFuY2UpOgorCiAyMDE3LTA4LTMxICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBJbXByb3Zl IHRoZSB3YXkgdW5pdCB0ZXN0IGFyZSBydW4gYW5kIHRoZSByZXN1bHRzIHJlcG9ydGVkCkluZGV4 OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9DaGVja2VyLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0NoZWNrZXIuanMJKHJldmlzaW9uIDIyMTQ2 OCkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL0NoZWNrZXIuanMJKHdvcmtpbmcg Y29weSkKQEAgLTEyOSw3ICsxMjksNyBAQCBjbGFzcyBDaGVja2VyIGV4dGVuZHMgVmlzaXRvciB7 CiAgICAgICAgIGxldCByaHNUeXBlID0gbm9kZS5yaHMudmlzaXQodGhpcyk7CiAgICAgICAgIGlm ICghbGhzVHlwZS5lcXVhbHMocmhzVHlwZSkpCiAgICAgICAgICAgICB0aHJvdyBuZXcgV1R5cGVF cnJvcihub2RlLm9yaWdpbi5vcmlnaW5TdHJpbmcsICJUeXBlIG1pc21hdGNoIGluIGFzc2lnbm1l bnQ6ICIgKyBsaHNUeXBlICsgIiB2ZXJzdXMgIiArIHJoc1R5cGUpOwotICAgICAgICBub2RlLnR5 cGUgPSBUeXBlUmVmLndyYXAobGhzVHlwZSk7CisgICAgICAgIG5vZGUudHlwZSA9IGxoc1R5cGU7 CiAgICAgICAgIHJldHVybiBsaHNUeXBlOwogICAgIH0KICAgICAKQEAgLTEzOCw3ICsxMzgsNyBA QCBjbGFzcyBDaGVja2VyIGV4dGVuZHMgVmlzaXRvciB7CiAgICAgICAgIGxldCB0eXBlID0gbm9k ZS5wdHIudmlzaXQodGhpcykudW5pZnlOb2RlOwogICAgICAgICBpZiAoIXR5cGUuaXNQdHIpCiAg ICAgICAgICAgICB0aHJvdyBuZXcgV1R5cGVFcnJvcihub2RlLm9yaWdpbi5vcmlnaW5TdHJpbmcs ICJUeXBlIHBhc3NlZCB0byBkZXJlZmVyZW5jZSBpcyBub3QgYSBwb2ludGVyOiAiICsgdHlwZSk7 Ci0gICAgICAgIG5vZGUudHlwZSA9IFR5cGVSZWYud3JhcCh0eXBlLmVsZW1lbnRUeXBlKTsKKyAg ICAgICAgbm9kZS50eXBlID0gdHlwZS5lbGVtZW50VHlwZTsKICAgICAgICAgbm9kZS5hZGRyZXNz U3BhY2UgPSB0eXBlLmFkZHJlc3NTcGFjZTsKICAgICAgICAgcmV0dXJuIG5vZGUudHlwZTsKICAg ICB9CkBAIC0yMzcsNyArMjM3LDcgQEAgY2xhc3MgQ2hlY2tlciBleHRlbmRzIFZpc2l0b3Igewog ICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgICAgIG5vZGUuZnVuYyA9IG92ZXJsb2FkLmZ1 bmM7Ci0gICAgICAgIG5vZGUuYWN0dWFsVHlwZUFyZ3VtZW50cyA9IG92ZXJsb2FkLnR5cGVBcmd1 bWVudHMubWFwKFR5cGVSZWYud3JhcCk7CisgICAgICAgIG5vZGUuYWN0dWFsVHlwZUFyZ3VtZW50 cyA9IG92ZXJsb2FkLnR5cGVBcmd1bWVudHM7CiAgICAgICAgIGxldCByZXN1bHQgPSBvdmVybG9h ZC5mdW5jLnJldHVyblR5cGUuc3Vic3RpdHV0ZVRvVW5pZmljYXRpb24oCiAgICAgICAgICAgICBv dmVybG9hZC5mdW5jLnR5cGVQYXJhbWV0ZXJzLCBvdmVybG9hZC51bmlmaWNhdGlvbkNvbnRleHQp OwogICAgICAgICBpZiAoIXJlc3VsdCkKSW5kZXg6IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFn ZVJJL051bGxUeXBlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFn ZVJJL051bGxUeXBlLmpzCShyZXZpc2lvbiAyMjE0MzUpCisrKyBUb29scy9XZWJHUFVTaGFkaW5n TGFuZ3VhZ2VSSS9OdWxsVHlwZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMjgsNSArMjgsNiBAQCBj bGFzcyBOdWxsVHlwZSBleHRlbmRzIFR5cGUgewogICAgIC8vIEZJWE1FOiBUaGlzIHdpbGwgaGF2 ZSB0byBiZWhhdmUgbGlrZSBhIHR5cGUgdmFyaWFibGUgZm9yIHRoZSBwdXJwb3NlcyBvZiB1bmlm aWNhdGlvbiwgc28gdGhhdAogICAgIC8vIGl0IGNhbiBiZSB1bmlmaWVkIHdpdGggYW55IHBvaW50 ZXIgdHlwZS4gVGhlbiwgd2UgY2FuIGRvIGEgdmVyaWZpY2F0aW9uIGF0IHRoZSBlbmQgdG8gc2Vl IGlmCiAgICAgLy8gd2UgZ290IHVuaWZpZWQgd2l0aCBhIHBvaW50ZXIgdHlwZS4KKyAgICAvLyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MjM1CiB9CiAKSW5kZXg6 IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Jld3JpdGVyLmpzCShyZXZpc2lvbiAyMjE0 NjgpCisrKyBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9SZXdyaXRlci5qcwkod29ya2lu ZyBjb3B5KQpAQCAtNDcsNiArNDcsMjYgQEAgY2xhc3MgUmV3cml0ZXIgewogICAgICAgICByZXR1 cm4gb2xkSXRlbTsKICAgICB9CiAgICAgCisgICAgLy8gV2UgcmV0dXJuIGlkZW50aXR5IGZvciBh bnl0aGluZyB0aGF0IGlzIG5vdCBpbnNpZGUgYSBmdW5jdGlvbi9zdHJ1Y3QgYm9keS4gV2hlbiBw cm9jZXNzaW5nCisgICAgLy8gZnVuY3Rpb24gYm9kaWVzLCB3ZSBvbmx5IHJlY3Vyc2UgaW50byB0 aGVtIGFuZCBuZXZlciBvdXQgb2YgdGhlbSAtIGZvciBleGFtcGxlIGlmIHRoZXJlIGlzIGEKKyAg ICAvLyBmdW5jdGlvbiBjYWxsIHRvIGFub3RoZXIgZnVuY3Rpb24gdGhlbiB3ZSBkb24ndCByZXdy aXRlIHRoZSBvdGhlciBmdW5jdGlvbi4gVGhpcyBpcyBob3cgd2Ugc3RvcAorICAgIC8vIHRoYXQu CisgICAgdmlzaXRGdW5jRGVmKG5vZGUpIHsgcmV0dXJuIG5vZGU7IH0KKyAgICB2aXNpdE5hdGl2 ZUZ1bmMobm9kZSkgeyByZXR1cm4gbm9kZTsgfQorICAgIHZpc2l0TmF0aXZlRnVuY0luc3RhbmNl KG5vZGUpIHsgcmV0dXJuIG5vZGU7IH0KKyAgICB2aXNpdE5hdGl2ZVR5cGUobm9kZSkgeyByZXR1 cm4gbm9kZTsgfQorICAgIHZpc2l0VHlwZURlZihub2RlKSB7IHJldHVybiBub2RlOyB9CisgICAg dmlzaXRTdHJ1Y3RUeXBlKG5vZGUpIHsgcmV0dXJuIG5vZGU7IH0KKyAgICB2aXNpdFR5cGVWYXJp YWJsZShub2RlKSB7IHJldHVybiBub2RlOyB9CisgICAgdmlzaXRDb25zdGV4cHJUeXBlUGFyYW1l dGVyKG5vZGUpIHsgcmV0dXJuIG5vZGU7IH0KKyAgICAKKyAgICB2aXNpdE5hdGl2ZVR5cGVJbnN0 YW5jZShub2RlKQorICAgIHsKKyAgICAgICAgcmV0dXJuIG5ldyBOYXRpdmVUeXBlSW5zdGFuY2Uo CisgICAgICAgICAgICBub2RlLnR5cGUudmlzaXQodGhpcyksCisgICAgICAgICAgICBub2RlLnR5 cGVBcmd1bWVudHMubWFwKGFyZ3VtZW50ID0+IGFyZ3VtZW50LnZpc2l0KHRoaXMpKSk7CisgICAg fQorICAgIAogICAgIHZpc2l0RnVuY1BhcmFtZXRlcihub2RlKQogICAgIHsKICAgICAgICAgbGV0 IHJlc3VsdCA9IG5ldyBGdW5jUGFyYW1ldGVyKG5vZGUub3JpZ2luLCBub2RlLm5hbWUsIG5vZGUu dHlwZS52aXNpdCh0aGlzKSk7CkBAIC05Miw5ICsxMTIsNyBAQCBjbGFzcyBSZXdyaXRlciB7CiAg ICAgdmlzaXRUeXBlUmVmKG5vZGUpCiAgICAgewogICAgICAgICBsZXQgcmVzdWx0ID0gbmV3IFR5 cGVSZWYobm9kZS5vcmlnaW4sIG5vZGUubmFtZSwgbm9kZS50eXBlQXJndW1lbnRzLm1hcCh0eXBl QXJndW1lbnQgPT4gdHlwZUFyZ3VtZW50LnZpc2l0KHRoaXMpKSk7Ci0gICAgICAgIC8vIFdlIHNo b3VsZCBwcm9iYWJseSB2aXNpdCB0aGlzIHR5cGUuCi0gICAgICAgIC8vIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYyMDgKLSAgICAgICAgcmVzdWx0LnR5cGUgPSBu b2RlLnR5cGU7CisgICAgICAgIHJlc3VsdC50eXBlID0gbm9kZS50eXBlID8gbm9kZS50eXBlLnZp c2l0KHRoaXMpIDogbnVsbDsKICAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAgICAgCklu ZGV4OiBUb29scy9XZWJHUFVTaGFkaW5nTGFuZ3VhZ2VSSS9WaXNpdG9yLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Zpc2l0b3IuanMJKHJldmlzaW9uIDIy MTQ2OCkKKysrIFRvb2xzL1dlYkdQVVNoYWRpbmdMYW5ndWFnZVJJL1Zpc2l0b3IuanMJKHdvcmtp bmcgY29weSkKQEAgLTk2LDYgKzk2LDEzIEBAIGNsYXNzIFZpc2l0b3IgewogICAgICAgICAgICAg dHlwZVBhcmFtZXRlci52aXNpdCh0aGlzKTsKICAgICB9CiAgICAgCisgICAgdmlzaXROYXRpdmVU eXBlSW5zdGFuY2Uobm9kZSkKKyAgICB7CisgICAgICAgIG5vZGUudHlwZS52aXNpdChub2RlKTsK KyAgICAgICAgZm9yIChsZXQgdHlwZUFyZ3VtZW50IG9mIG5vZGUudHlwZUFyZ3VtZW50cykKKyAg ICAgICAgICAgIHR5cGVBcmd1bWVudC52aXNpdCh0aGlzKTsKKyAgICB9CisgICAgCiAgICAgdmlz aXRUeXBlRGVmKG5vZGUpCiAgICAgewogICAgICAgICBmb3IgKGxldCB0eXBlUGFyYW1ldGVyIG9m IG5vZGUudHlwZVBhcmFtZXRlcnMpCg==