176206 2017-08-31 18:31:56 -0700 Graph::methodOfGettingAValueProfileFor compares NodeOrigin instead of the semantic CodeOrigin 2017-09-27 12:48:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1344261 0 saam 2017-08-31 18:31:56 -0700 This is a followup to: https://bugs.webkit.org/show_bug.cgi?id=164600 That patch says we should only write to the result bits of the ArithProfile of the operand when it's not generated from the same byte code as the current node. However, it's comparing NodeOrigin, not NodeOrigin::semantic. 1344269 1 319562 saam 2017-08-31 18:48:35 -0700 Created attachment 319562 patch 1344272 2 319562 keith_miller 2017-08-31 18:50:21 -0700 Comment on attachment 319562 patch r=me. 1344286 3 319562 commit-queue 2017-08-31 20:05:42 -0700 Comment on attachment 319562 patch Clearing flags on attachment: 319562 Committed r221470: <http://trac.webkit.org/changeset/221470> 1344287 4 commit-queue 2017-08-31 20:05:44 -0700 All reviewed patches have been landed. Closing bug. 1353661 5 webkit-bug-importer 2017-09-27 12:48:15 -0700 <rdar://problem/34694054> 319562 2017-08-31 18:48:35 -0700 2017-08-31 20:05:42 -0700 patch c-backup.diff text/plain 3800 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMjE0NjQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDE3LTA4LTMxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIEdyYXBoOjptZXRob2RPZkdldHRpbmdBVmFsdWVQcm9maWxlRm9yIGNv bXBhcmVzIE5vZGVPcmlnaW4gaW5zdGVhZCBvZiB0aGUgc2VtYW50aWMgQ29kZU9yaWdpbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MjA2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvY29t cGFyZS1zZW1hbnRpYy1vcmlnaW4tb3AtbmVnYXRlLW1ldGhvZC1vZi1nZXR0aW5nLWEtdmFsdWUt cHJvZmlsZS5qczogQWRkZWQuCisgICAgICAgIChhKToKKyAgICAgICAgKGIpOgorICAgICAgICAo Zm9vKToKKwogMjAxNy0wOC0zMSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4K IAogICAgICAgICBTa2lwIHR3byBzbG93IEpTQyB0ZXN0cyBhZnRlciByMjIxNDIyLgpJbmRleDog SlNUZXN0cy9zdHJlc3MvY29tcGFyZS1zZW1hbnRpYy1vcmlnaW4tb3AtbmVnYXRlLW1ldGhvZC1v Zi1nZXR0aW5nLWEtdmFsdWUtcHJvZmlsZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVz cy9jb21wYXJlLXNlbWFudGljLW9yaWdpbi1vcC1uZWdhdGUtbWV0aG9kLW9mLWdldHRpbmctYS12 YWx1ZS1wcm9maWxlLmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL2NvbXBhcmUt c2VtYW50aWMtb3JpZ2luLW9wLW5lZ2F0ZS1tZXRob2Qtb2YtZ2V0dGluZy1hLXZhbHVlLXByb2Zp bGUuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxOCBAQAorbGV0IGZsYWcgPSBmYWxzZTsK K2Z1bmN0aW9uIGEoKSB7IHJldHVybiBmbGFnID8ge30gOiAxMDsgfQorbm9JbmxpbmUoYSk7Citm dW5jdGlvbiBiKCkgeyByZXR1cm4gMTAuMjsgfQorbm9JbmxpbmUoYik7CisKK2Z1bmN0aW9uIGZv byh4KSB7CisgICAgbGV0IHIgPSAtKHggPyBhKCkgOiBiKCkpOworICAgIHJldHVybiByOworfQor bm9JbmxpbmUoZm9vKTsKKworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkKKyAgICBm b28oISEoaSUyKSk7CisKK2ZsYWcgPSB0cnVlOworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDA7 ICsraSkKKyAgICBmb28oISEoaSUyKSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMTQ2NCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwyNyBAQAorMjAxNy0wOC0zMSAgU2FhbSBCYXJhdGkgIDxzYmFy YXRpQGFwcGxlLmNvbT4KKworICAgICAgICBHcmFwaDo6bWV0aG9kT2ZHZXR0aW5nQVZhbHVlUHJv ZmlsZUZvciBjb21wYXJlcyBOb2RlT3JpZ2luIGluc3RlYWQgb2YgdGhlIHNlbWFudGljIENvZGVP cmlnaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 NjIwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h cmsgZml4ZWQgdGhlIG1haW4gaXNzdWUgaW4gR3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVBy b2ZpbGVGb3IgaW4gcjIwODU2MAorICAgICAgICB3aGVuIGhlIGZpeGVkIGl0IGZyb20gb3Zlcndy aXRpbmcgaW52YWxpZCBwYXJ0cyBvZiB0aGUgQXJpdGhQcm9maWxlIHdoZW4gdGhlCisgICAgICAg IGN1cnJlbnROb2RlIGFuZCB0aGUgb3BlcmFuZE5vZGUgYXJlIGZyb20gdGhlIHNhbWUgYnl0ZWNv ZGUuIEhvd2V2ZXIsIHRoZQorICAgICAgICBtZWNoYW5pc20gdXNlZCB0byBkZXRlcm1pbmUgc2Ft ZSBieXRlY29kZSB3YXMgY29tcGFyaW5nIE5vZGVPcmlnaW4uIFRoYXQncworICAgICAgICBzbGln aHRseSB3cm9uZy4gV2UgbmVlZCB0byBjb21wYXJlIHNlbWFudGljIG9yaWdpbiwgc2luY2UgdHdv IE5vZGVPcmlnaW5zIGNhbgorICAgICAgICBoYXZlIHRoZSBzYW1lIHNlbWFudGljIG9yaWdpbiwg YnV0IGRpZmZlciBvbmx5IGluIGV4aXRPSy4gRm9yIGV4YW1wbGUsCisgICAgICAgIGluIHRoZSBi ZWxvdyBJUiwgdGhlIERvdWJsZVJlcCBhbmQgdGhlIFBoaSBoYXZlIHRoZSBzYW1lIHNlbWFudGlj CisgICAgICAgIG9yaWdpbiwgYnV0IGRpZmZlcmVudCBOb2RlT3JpZ2lucy4KKworICAgICAgICA0 MyBQaGkoSlN8UHVyZUludCwgTm9uQm9vbEludDMyfE5vbkludEFzZG91YmxlLCBXOlNpZGVTdGF0 ZSwgYmMjNjMsIEV4aXRJbnZhbGlkKQorICAgICAgICA1OCBFeGl0T0soTXVzdEdlbiwgVzpTaWRl U3RhdGUsIGJjIzYzKQorICAgICAgICA1MSBEb3VibGVSZXAoQ2hlY2s6TnVtYmVyOktpbGw6QDQz LCBEb3VibGV8UHVyZUludCwgQnl0ZWNvZGVEb3VibGUsIEV4aXRzLCBiYyM2MykKKyAgICAgICAg NTQgQXJpdGhOZWdhdGUoRG91YmxlUmVwOktpbGw6QDUxPERvdWJsZT4sIERvdWJsZXxVc2VBc090 aGVyfE1heUhhdmVEb3VibGVSZXN1bHQsIEFueUludEFzRG91YmxlfE5vbkludEFzZG91YmxlLCBO b3RTZXQsIEV4aXRzLCBiYyM2MykKKworICAgICAgICAqIGRmZy9ERkdHcmFwaC5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6R3JhcGg6Om1ldGhvZE9mR2V0dGluZ0FWYWx1ZVByb2ZpbGVGb3IpOgor CiAyMDE3LTA4LTMxICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAg ICAgICAgW0NNYWtlXSBNYWtlIFVTRV9DRiBjb25kaXRpb25hbCB3aXRoaW4gV2luZG93cwpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlzaW9uIDIyMTQ0NCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNjA2LDcgKzE2MDYsNyBAQCBNZXRob2RPZkdldHRpbmdBVmFsdWVQcm9maWxlIEdyYXBo OjptZXRoCiB7CiAgICAgZm9yIChOb2RlKiBub2RlID0gb3BlcmFuZE5vZGU7IG5vZGU7KSB7CiAg ICAgICAgIC8vIGN1cnJlbnROb2RlIGlzIG51bGwgd2hlbiB3ZSdyZSBkb2luZyBzcGVjdWxhdGlv biBjaGVja3MgZm9yIGNoZWNrQXJndW1lbnRUeXBlcygpLgotICAgICAgICBpZiAoIWN1cnJlbnRO b2RlIHx8IG5vZGUtPm9yaWdpbiAhPSBjdXJyZW50Tm9kZS0+b3JpZ2luKSB7CisgICAgICAgIGlm ICghY3VycmVudE5vZGUgfHwgbm9kZS0+b3JpZ2luLnNlbWFudGljICE9IGN1cnJlbnROb2RlLT5v cmlnaW4uc2VtYW50aWMpIHsKICAgICAgICAgICAgIENvZGVCbG9jayogcHJvZmlsZWRCbG9jayA9 IGJhc2VsaW5lQ29kZUJsb2NrRm9yKG5vZGUtPm9yaWdpbi5zZW1hbnRpYyk7CiAKICAgICAgICAg ICAgIGlmIChub2RlLT5hY2Nlc3Nlc1N0YWNrKCp0aGlzKSkgewo=