176198 2017-08-31 17:07:55 -0700 tab-size: 0px asserts 2017-11-15 13:11:55 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser hyatt jonlee koivisto simon.fraser webkit-bug-importer oldest_to_newest 1344208 0 simon.fraser 2017-08-31 17:07:55 -0700 "tab-size: 0px asserts" triggers an assertion in CSSPrimitiveValue::operator unsigned() const: template<> inline CSSPrimitiveValue::operator unsigned() const { if (primitiveType() == CSS_NUMBER) return value<unsigned>(); ASSERT_NOT_REACHED(); return 0; } 1344209 1 319544 simon.fraser 2017-08-31 17:08:22 -0700 Created attachment 319544 Testcase 1366084 2 325360 simon.fraser 2017-10-30 11:18:42 -0700 Created attachment 325360 Patch 1366086 3 325360 koivisto 2017-10-30 11:20:33 -0700 Comment on attachment 325360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325360&action=review > Source/WebCore/css/parser/CSSPropertyParser.cpp:1116 > +static RefPtr<CSSValue> consumeTabSize(CSSParserTokenRange& range, CSSParserMode) > { > - RefPtr<CSSPrimitiveValue> parsedValue = consumeInteger(range, 0); > - if (parsedValue) > - return parsedValue; > - return consumeLength(range, cssParserMode, ValueRangeNonNegative); > + return consumeInteger(range, 0); You could add a FIXME mentioning we lack support for length values. 1366092 4 simon.fraser 2017-10-30 11:24:41 -0700 https://trac.webkit.org/changeset/224193/webkit 1366093 5 simon.fraser 2017-10-30 11:26:26 -0700 Filed bug 179022 to support tab-size with units. 1372401 6 webkit-bug-importer 2017-11-15 13:11:55 -0800 <rdar://problem/35568975> 319544 2017-08-31 17:08:22 -0700 2017-08-31 17:08:22 -0700 Testcase tab-size.html text/html 140 simon.fraser PCFET0NUWVBFIGh0bWw+Cgo8aHRtbD4KPGhlYWQ+CiAgICA8c3R5bGU+CiAgICAgICAgYm9keSB7 CiAgICAgICAgICAgIHRhYi1zaXplOiAwcHg7CiAgICAgICAgfQogICAgPC9zdHlsZT4KPC9oZWFk Pgo8Ym9keT4KCjwvYm9keT4KPC9odG1sPgo= 325360 2017-10-30 11:18:42 -0700 2017-10-30 11:20:33 -0700 Patch bug-176198-20171030111841.patch text/plain 4011 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MDc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzA2MDNlYTRhMGI4NzA0 MDNmZmY4OTAxNWU2OTA4Y2MyMWMzOGI3MS4uMmE2MzM0NWQ1YmM0YTkyN2Y0MTE1NjAyYTZmY2Jm YzM2MmNkMDE2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHRhYi1zaXplOiAw cHggYXNzZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc2MTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG9uJ3QgY2xhaW0gdG8gc3VwcG9ydCB0YWItc2l6ZSB2YWx1ZXMgd2l0aCB1bml0cy4gV2Ug ZG9uJ3QsIGFuZCB0aGV5IHdvdWxkIGJlY29tZSAwLCByYXRoZXIKKyAgICAgICAgdGhhbiBmYWxs IGJhY2sgdG8gdGhlIGRlZmF1bHQgYXMgc2hvdWxkIGhhcHBlbi4KKworICAgICAgICBFbmhhbmNl ZCBmYXN0L2Nzcy90YWItc2l6ZS5odG1sIHRvIHRlc3QuCisKKyAgICAgICAgKiBjc3MvcGFyc2Vy L0NTU1Byb3BlcnR5UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbnN1bWVUYWJTaXpl KToKKwogMjAxNy0xMC0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K IAogICAgICAgICBXaGVuIG5hdmlnYXRpbmcgYmFjayB0byBhIHBhZ2UsIGNvbXBvc2l0aW5nIGxh eWVycyBtYXkgbm90IHVzZSBhY2NlbGVyYXRlZCBkcmF3aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCmluZGV4IDk3MzU0MjA5ODdjMzNlOTc3 ZjZhYTg5YzRkODcxMmVhN2I2NTZhN2EuLmMxNjc4NzliZDkxNDBjMDE0YmY2ZWJmMzhhZjEyOTdk YmViYjEyMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVy dHlQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQ YXJzZXIuY3BwCkBAIC0xMTExLDEyICsxMTExLDkgQEAgc3RhdGljIFJlZlB0cjxDU1NWYWx1ZT4g Y29uc3VtZVdvcmRTcGFjaW5nKENTU1BhcnNlclRva2VuUmFuZ2UmIHJhbmdlLCBDU1NQYXJzZXIK ICAgICByZXR1cm4gY29uc3VtZUxlbmd0aE9yUGVyY2VudChyYW5nZSwgY3NzUGFyc2VyTW9kZSwg VmFsdWVSYW5nZUFsbCwgVW5pdGxlc3NRdWlyazo6QWxsb3cpOwogfQogICAgIAotc3RhdGljIFJl ZlB0cjxDU1NWYWx1ZT4gY29uc3VtZVRhYlNpemUoQ1NTUGFyc2VyVG9rZW5SYW5nZSYgcmFuZ2Us IENTU1BhcnNlck1vZGUgY3NzUGFyc2VyTW9kZSkKK3N0YXRpYyBSZWZQdHI8Q1NTVmFsdWU+IGNv bnN1bWVUYWJTaXplKENTU1BhcnNlclRva2VuUmFuZ2UmIHJhbmdlLCBDU1NQYXJzZXJNb2RlKQog ewotICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gcGFyc2VkVmFsdWUgPSBjb25zdW1lSW50 ZWdlcihyYW5nZSwgMCk7Ci0gICAgaWYgKHBhcnNlZFZhbHVlKQotICAgICAgICByZXR1cm4gcGFy c2VkVmFsdWU7Ci0gICAgcmV0dXJuIGNvbnN1bWVMZW5ndGgocmFuZ2UsIGNzc1BhcnNlck1vZGUs IFZhbHVlUmFuZ2VOb25OZWdhdGl2ZSk7CisgICAgcmV0dXJuIGNvbnN1bWVJbnRlZ2VyKHJhbmdl LCAwKTsKIH0KIAogI2lmIEVOQUJMRShURVhUX0FVVE9TSVpJTkcpCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWY1ZGYwOTk2 ZTQyNzFmMmJkM2JhZDRkMDE5YTJlYTZkYjMyZDQ2Yi4uNzJhODRhMGRhZWRhMTg4Y2MxYjVjZGI2 ZGUyMzgzZTA5NTg0MTY5NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIHRhYi1zaXplOiAw cHggYXNzZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc2MTk4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRG9uJ3QgY2xhaW0gdG8gc3VwcG9ydCB0YWItc2l6ZSB2YWx1ZXMgd2l0aCB1bml0cy4gV2Ug ZG9uJ3QsIGFuZCB0aGV5IHdvdWxkIGJlY29tZSAwLCByYXRoZXIKKyAgICAgICAgdGhhbiBmYWxs IGJhY2sgdG8gdGhlIGRlZmF1bHQgYXMgc2hvdWxkIGhhcHBlbi4KKworICAgICAgICAqIGZhc3Qv Y3NzL3RhYi1zaXplLWV4cGVjdGVkLmh0bWw6CisgICAgICAgICogZmFzdC9jc3MvdGFiLXNpemUu aHRtbDoKKwogMjAxNy0xMC0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBXaGVuIG5hdmlnYXRpbmcgYmFjayB0byBhIHBhZ2UsIGNvbXBvc2l0aW5n IGxheWVycyBtYXkgbm90IHVzZSBhY2NlbGVyYXRlZCBkcmF3aW5nCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2Nzcy90YWItc2l6ZS1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9jc3MvdGFiLXNpemUtZXhwZWN0ZWQuaHRtbAppbmRleCBkNmZmMDJlYTVjNjdhNzFhNmRjNTIx ZGIxNTE1OTBjM2E0MDA3MDBjLi4yYzdhYTVjNzk4MTIxMDVkNjk5ZDAxYzA1NWUwZWQxOWQ3MjU0 N2E3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy90YWItc2l6ZS1leHBlY3RlZC5o dG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3RhYi1zaXplLWV4cGVjdGVkLmh0bWwKQEAg LTI5LDYgKzI5LDE0IEBAIHByZSB7IG1hcmdpbjogMC4xZW07IH0KIDxwcmU+eHggIHh4ICB4PC9w cmU+CiA8cHJlPnh4eHh4eHh4eCB4eCAgeDwvcHJlPgogPC9kaXY+Cis8Yj5UYWIgc2l6ZSA9IDIw cHgsIHNob3VsZCBub3QgYXNzZXJ0LCBhbmQgZmFsbCBiYWNrIHRvIDguPC9iPgorPGRpdj4KKzxw cmU+ICAgICAgICB4PC9wcmU+Cis8cHJlPiAgICAgICAgICAgICAgICB4PC9wcmU+Cis8cHJlPiAg ICAgICAgeCAgICAgICB4PC9wcmU+Cis8cHJlPnh4ICAgICAgeHggICAgICB4PC9wcmU+Cis8cHJl Pnh4eHh4eHh4eCAgICAgICB4eCAgICAgIHg8L3ByZT4KKzwvZGl2PgogPGI+VGFiIHNpemUgYmVj b21lcyAyIGR5bmFtaWNhbGx5LjwvYj4KIDxkaXY+CiA8cHJlPiAgeDwvcHJlPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL3RhYi1zaXplLmh0bWwKaW5kZXggOTBhYWUwNzk2NTI5NWNjYjUxMTIwZTBhNDYxNTEyNTg0 ZmMzM2I1Yy4uYWMwNTJhZGU2YTk1MjQzZjE4ZWFlZWU1ZjZkZThmOWIyNjA2NGIyYyAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvdGFiLXNpemUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy90YWItc2l6ZS5odG1sCkBAIC0yNSw2ICsyNSw3IEBAIGZ1bmN0aW9uIHRlc3Qo KQogICAgIHNldHVwQmxvY2soIkRlZmF1bHQgdGFiIHNpemUgKDgpLiIsIG51bGwpOwogICAgIHNl dHVwQmxvY2soIlRhYiBzaXplID0gLTEwLCBzaG91bGQgZmFsbCBiYWNrIHRvIHRoZSBkZWZhdWx0 LiIsICJ0YWItc2l6ZTogLTEwOyIpOwogICAgIHNldHVwQmxvY2soIlRhYiBzaXplID0gMi4iLCAi dGFiLXNpemU6IDI7Iik7CisgICAgc2V0dXBCbG9jaygiVGFiIHNpemUgPSAyMHB4LCBzaG91bGQg bm90IGFzc2VydCwgYW5kIGZhbGwgYmFjayB0byA4LiIsICJ0YWItc2l6ZTogMjBweDsiKTsKIAog ICAgIHZhciBkeW5hbWljQmxvY2sgPSBzZXR1cEJsb2NrKCJUYWIgc2l6ZSBiZWNvbWVzIDIgZHlu YW1pY2FsbHkuIiwgbnVsbCk7CiAK