176164 2017-08-31 09:34:53 -0700 Take into account removed caches in Caches::remove assertion 2017-09-27 12:46:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=175995 InRadar P2 Normal --- 1 youennf youennf achristensen buildbot cdumez cgarcia commit-queue jlewis3 ryanhaddad webkit-bug-importer oldest_to_newest 1343950 0 youennf 2017-08-31 09:34:53 -0700 Caches may be asked to remove an already removed cache. The assertion in Caches::remove should take that into account. 1343993 1 319479 youennf 2017-08-31 10:48:22 -0700 Created attachment 319479 Patch 1343995 2 buildbot 2017-08-31 10:50:53 -0700 Attachment 319479 did not pass style-queue: ERROR: Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:131: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1344026 3 319479 commit-queue 2017-08-31 11:31:26 -0700 Comment on attachment 319479 Patch Clearing flags on attachment: 319479 Committed r221428: <http://trac.webkit.org/changeset/221428> 1344027 4 commit-queue 2017-08-31 11:31:27 -0700 All reviewed patches have been landed. Closing bug. 1344622 5 jlewis3 2017-09-01 15:39:24 -0700 The test added in this patch has consistently failed on windows testers since being added according to the flakiness dashboard. it has also failed on Sierra debug: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r221490%20(2818)/results.html 1353646 6 webkit-bug-importer 2017-09-27 12:46:47 -0700 <rdar://problem/34693934> 319479 2017-08-31 10:48:22 -0700 2017-08-31 11:31:26 -0700 Patch bug-176164-20170831104822.patch text/plain 5298 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIxNDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQ4MWIwYWNlOWRhZjY0M2Qz ZmZlNjQxYjc5ZTBmMDVkOGQyOTg0YTkuLjViMjRjNjI5Njc3N2JiMTIxODZlMjg3MmRlNjI4NDM0 NDE4M2ViYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMDgtMzEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFRha2UgaW50byBhY2NvdW50IHJl bW92ZWQgY2FjaGVzIGluIENhY2hlczo6cmVtb3ZlIGFzc2VydGlvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MTY0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNoZS9D YWNoZVN0b3JhZ2VFbmdpbmVDYWNoZXMuY3BwOgorICAgICAgICAoV2ViS2l0OjpDYWNoZVN0b3Jh Z2U6OkNhY2hlczo6cmVtb3ZlKToKKwogMjAxNy0wOC0zMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gU2V2ZXJhbCBJbnB1dE1ldGhv ZEZpbHRlciB0ZXN0cyBhcmUgZmFpbGluZyBhbmQgY3Jhc2hpbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5lQ2FjaGVzLmNw cCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY2FjaGUvQ2FjaGVTdG9yYWdlRW5naW5l Q2FjaGVzLmNwcAppbmRleCA5MGQ2YTEwNzlkODliZjgzMmFkYzJmN2QxZjU1OGFhZWY0Yjg4NDU3 Li5iMzZmZjU2MGZhY2Q4NDNjYmViYzU0MjJkMDllMTUzNWI5YmY0ZWFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NhY2hlL0NhY2hlU3RvcmFnZUVuZ2luZUNhY2hl cy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9DYWNoZVN0b3Jh Z2VFbmdpbmVDYWNoZXMuY3BwCkBAIC0xMjcsNyArMTI3LDExIEBAIHZvaWQgQ2FjaGVzOjpyZW1v dmUodWludDY0X3QgaWRlbnRpZmllciwgQ29tcGxldGlvbkNhbGxiYWNrJiYgY2FsbGJhY2spCiAK ICAgICBhdXRvIHBvc2l0aW9uID0gbV9jYWNoZXMuZmluZE1hdGNoaW5nKFsmXShjb25zdCBhdXRv JiBpdGVtKSB7IHJldHVybiBpdGVtLmlkZW50aWZpZXIgPT0gaWRlbnRpZmllcjsgfSk7CiAKLSAg ICBBU1NFUlQocG9zaXRpb24gIT0gbm90Rm91bmQpOworICAgIGlmIChwb3NpdGlvbiA9PSBub3RG b3VuZCkgeworICAgICAgICBBU1NFUlQobV9yZW1vdmVkQ2FjaGVzLmZpbmRNYXRjaGluZyhbJl0o Y29uc3QgYXV0byYgaXRlbSkgeyByZXR1cm4gaXRlbS5pZGVudGlmaWVyID09IGlkZW50aWZpZXI7 IH0pICE9IG5vdEZvdW5kKTsKKyAgICAgICAgY2FsbGJhY2soc3RkOjpudWxsb3B0KTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KIAogICAgIGF1dG8gY2FjaGUgPSBXVEZNb3ZlKG1fY2FjaGVzW3Bv c2l0aW9uXSk7CiAgICAgbV9jYWNoZXMucmVtb3ZlKHBvc2l0aW9uKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0YWFmMWI4 MDIyZDBkYzYxMzg1YzBkY2I4OTkyODg4ZjE3ZDFmODg2Li44ZjJlODE2ZGVkY2U1Njg3NGYzY2Rh N2E5MzNmMjNiZDZhZWQ1NDJlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDgtMzEgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFRha2UgaW50byBhY2Nv dW50IHJlbW92ZWQgY2FjaGVzIGluIENhY2hlczo6cmVtb3ZlIGFzc2VydGlvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2MTY0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3dwdC9jYWNoZS1z dG9yYWdlL2NhY2hlLXJlbW92ZS10d2ljZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGh0dHAvd3B0L2NhY2hlLXN0b3JhZ2UvY2FjaGUtcmVtb3ZlLXR3aWNlLmh0bWw6IEFkZGVkLgor ICAgICAgICAqIGh0dHAvd3B0L2NhY2hlLXN0b3JhZ2UvcmVzb3VyY2VzL2NhY2hlLXJlbW92ZS10 d2ljZS1pZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTctMDgtMzEgIE1zMmdlciAgPE1zMmdlckBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1hcmsgc29tZSB0ZXN0cyBhcyBwYXNzaW5nLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvY2FjaGUtc3RvcmFnZS9jYWNoZS1yZW1v dmUtdHdpY2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvY2FjaGUtc3RvcmFn ZS9jYWNoZS1yZW1vdmUtdHdpY2UtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE0NTM1NmJlNmRh ZWViNDUyYmI0MTczNmM3N2QxNjNlM2NiOGYwNDQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3dwdC9jYWNoZS1zdG9yYWdlL2NhY2hlLXJlbW92ZS10d2ljZS1leHBlY3RlZC50 eHQKQEAgLTAsMCArMSw2IEBACisKKworUEFTUyBDbGVhbmluZyBleGlzdGluZyBjYWNoZXMgCitQ QVNTIFJlbW92aW5nIHRoZSBzYW1lIGNhY2hlIGZyb20gdHdvIGRpZmZlcmVudCBkb2N1bWVudHMg CitQQVNTIENsZWFuaW5nIGFkZGVkIGNhY2hlcyAKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC93cHQvY2FjaGUtc3RvcmFnZS9jYWNoZS1yZW1vdmUtdHdpY2UuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvd3B0L2NhY2hlLXN0b3JhZ2UvY2FjaGUtcmVtb3ZlLXR3aWNlLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uYmVjZWFhZjQxOTFhMzczNmNmODM3ODc3MzY1ZTkzMDI5OGFmNzRhMwotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvd3B0L2NhY2hlLXN0b3JhZ2UvY2FjaGUtcmVtb3Zl LXR3aWNlLmh0bWwKQEAgLTAsMCArMSw0NSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxo ZWFkPgorPHRpdGxlPkNhY2hlIFN0b3JhZ2U6IHRlc3RpbmcgcGVyc2lzdGVuY3k8L3RpdGxlPgor PHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0PgorPHNjcmlw dCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3NyZXBvcnQuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+CisgICAgPGRpdiBpZD0iY2hlY2siPgorICAgIDwvZGl2PgorICAgIDxzY3JpcHQ+ CisgICAgcHJvbWlzZV90ZXN0KHRlc3QgPT4geworICAgICAgICByZXR1cm4gc2VsZi5jYWNoZXMu a2V5cygpLnRoZW4oa2V5cyA9PiB7CisgICAgICAgICAgICB2YXIgcGVuZGluZyA9IFtdOworICAg ICAgICAgICAgZm9yIChrZXkgb2Yga2V5cykKKyAgICAgICAgICAgICAgICBwZW5kaW5nLnB1c2go c2VsZi5jYWNoZXMuZGVsZXRlKGtleXNbMF0pKTsKKyAgICAgICAgICAgIHJldHVybiBQcm9taXNl LmFsbChwZW5kaW5nKTsKKyAgICAgICAgfSk7CisgICAgfSwgIkNsZWFuaW5nIGV4aXN0aW5nIGNh Y2hlcyIpOworCisgICAgcHJvbWlzZV90ZXN0KHRlc3QgPT4geworICAgICAgICBjaGVjay5pbm5l ckhUTUwgPSAiPGlmcmFtZSBpZD0nY2FjaGVGcmFtZScgc3JjPSdyZXNvdXJjZXMvY2FjaGUtcmVt b3ZlLXR3aWNlLWlmcmFtZS5odG1sJz48L2lmcmFtZT4iOworICAgICAgICAKKyAgICAgICAgdmFy IGNhY2hlTmFtZSA9ICJ0ZXN0LXJlbW92ZS10d2ljZSI7CisgICAgICAgIHJldHVybiBuZXcgUHJv bWlzZSgocmVzb2x2ZSwgcmVqZWN0KSA9PiB7CisgICAgICAgICAgICB3aW5kb3cuYWRkRXZlbnRM aXN0ZW5lcigibWVzc2FnZSIsIHRlc3Quc3RlcF9mdW5jKChldmVudCkgPT4geworICAgICAgICAg ICAgICAgIHJldHVybiBQcm9taXNlLmFsbChbc2VsZi5jYWNoZXMub3BlbihjYWNoZU5hbWUpLCBj YWNoZUZyYW1lLndpbmRvdy5jYWNoZXMub3BlbihjYWNoZU5hbWUpIF0pLnRoZW4oKCkgPT4gewor ICAgICAgICAgICAgICAgICAgICByZXR1cm4gUHJvbWlzZS5hbGwoW3NlbGYuY2FjaGVzLmRlbGV0 ZShjYWNoZU5hbWUpLCBjYWNoZUZyYW1lLndpbmRvdy5jYWNoZXMuZGVsZXRlKGNhY2hlTmFtZSld KTsKKyAgICAgICAgICAgICAgICB9KS50aGVuKHJlc29sdmUsIHJlamVjdCk7CisJICAgIH0pKTsK Kwl9KTsKKyAgICB9LCAiUmVtb3ZpbmcgdGhlIHNhbWUgY2FjaGUgZnJvbSB0d28gZGlmZmVyZW50 IGRvY3VtZW50cyIpOworCisgICBwcm9taXNlX3Rlc3QodGVzdCA9PiB7CisgICAgICAgIHJldHVy biBzZWxmLmNhY2hlcy5rZXlzKCkudGhlbihrZXlzID0+IHsKKyAgICAgICAgICAgIHZhciBwZW5k aW5nID0gW107CisgICAgICAgICAgICBmb3IgKGtleSBvZiBrZXlzKQorICAgICAgICAgICAgICAg IHBlbmRpbmcucHVzaChzZWxmLmNhY2hlcy5kZWxldGUoa2V5c1swXSkpOworICAgICAgICAgICAg cmV0dXJuIFByb21pc2UuYWxsKHBlbmRpbmcpOworICAgICAgICB9KTsKKyAgICB9LCAiQ2xlYW5p bmcgYWRkZWQgY2FjaGVzIik7CisgICAgPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2NhY2hlLXN0b3JhZ2UvcmVzb3VyY2VzL2Nh Y2hlLXJlbW92ZS10d2ljZS1pZnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvd3B0L2NhY2hl LXN0b3JhZ2UvcmVzb3VyY2VzL2NhY2hlLXJlbW92ZS10d2ljZS1pZnJhbWUuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi5lZjE4MDA5NzRkMzQyMGNkNzhiYzRhOGQxOWJhYTZjNDdkZGMxYTYwCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvY2FjaGUtc3RvcmFnZS9yZXNvdXJjZXMvY2Fj aGUtcmVtb3ZlLXR3aWNlLWlmcmFtZS5odG1sCkBAIC0wLDAgKzEsOSBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxib2R5PgorICAgIDxzY3JpcHQ+Cit3aW5kb3cucGFyZW50LnBvc3RNZXNz YWdlKCJyZWFkeSIsICIqIik7CisgICAgPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CisK