176163 2017-08-31 08:07:00 -0700 [Win] Crash under WorkQueue::performWorkOnRegisteredWorkThread in layout tests. 2017-09-27 12:47:10 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen benjamin bfulgham buildbot cdumez cmarcelo commit-queue dbates saam webkit-bug-importer oldest_to_newest 1343927 0 pvollan 2017-08-31 08:07:00 -0700 My previous attempt at fixing this crash in <http://trac.webkit.org/changeset/221323> was incorrect, since it is still crashing on the bot(s). The current theory of why this is failing is that the WorkQueue object deletes itself in the middle of the performWorkOnRegisteredWorkThread method when calling deref(). 1343929 1 319462 pvollan 2017-08-31 08:15:40 -0700 Created attachment 319462 Patch 1343992 2 319462 pvollan 2017-08-31 10:47:20 -0700 Comment on attachment 319462 Patch Thanks for reviewing! 1344007 3 319462 commit-queue 2017-08-31 11:15:51 -0700 Comment on attachment 319462 Patch Clearing flags on attachment: 319462 Committed r221425: <http://trac.webkit.org/changeset/221425> 1344008 4 commit-queue 2017-08-31 11:15:53 -0700 All reviewed patches have been landed. Closing bug. 1353649 5 webkit-bug-importer 2017-09-27 12:47:10 -0700 <rdar://problem/34693984> 319462 2017-08-31 08:15:40 -0700 2017-08-31 11:15:51 -0700 Patch bug-176163-20170831171540.patch text/plain 3527 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjE0MjApCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA4LTMxICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBDcmFzaCB1bmRlciBXb3JrUXVldWU6 OnBlcmZvcm1Xb3JrT25SZWdpc3RlcmVkV29ya1RocmVhZCBpbiBsYXlvdXQgdGVzdHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzYxNjMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNeSBwcmV2aW91cyBh dHRlbXB0IGF0IGZpeGluZyB0aGlzIGNyYXNoIGluIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2No YW5nZXNldC8yMjEzMjM+CisgICAgICAgIHdhcyBpbmNvcnJlY3QsIHNpbmNlIGl0IGlzIHN0aWxs IGNyYXNoaW5nIG9uIHRoZSBib3QocykuIFRoZSBjdXJyZW50IHRoZW9yeSBvZiB3aHkgdGhpcwor ICAgICAgICBpcyBmYWlsaW5nIGlzIHRoYXQgdGhlIFdvcmtRdWV1ZSBvYmplY3QgZGVsZXRlcyBp dHNlbGYgaW4gdGhlIG1pZGRsZSBvZiB0aGUKKyAgICAgICAgcGVyZm9ybVdvcmtPblJlZ2lzdGVy ZWRXb3JrVGhyZWFkIG1ldGhvZCB3aGVuIGNhbGxpbmcgZGVyZWYoKS4gVGhlcmUgaXMgbm8gbmVl ZCB0bworICAgICAgICBpbmNyZWFzZSB0aGUgcmVmZXJlbmNlIGNvdW50IG9mIHRoZSB3b3JrIHF1 ZXVlIGZvciBlYWNoIGZ1bmN0aW9uIHdlIHdhbnQgdG8gY2FsbCBvbiB0aGUKKyAgICAgICAgd29y ayB0aHJlYWQuIEl0IGlzIHN1ZmZpY2llbnQgdG8gaW5jcmVhc2UgaXQgZm9yIGV2ZXJ5IHdvcmsg dGhyZWFkIHdlIHN0YXJ0LCBhbmQgdGhlbgorICAgICAgICBkZXJlZmVyZW5jZSBpdCB3aGVuIHRo ZSB0aHJlYWQgZW5kcy4gV2Ugc2hvdWxkIGFsc28gbm90IGF0dGVtcHQgdG8gYWNjZXNzIG1lbWJl cnMgYWZ0ZXIKKyAgICAgICAgdGhlIGRlcmVmKCkgY2FsbCwgd2hpY2ggY2FuIHBvdGVudGlhbGx5 IGJlIHVuc2FmZS4KKyAKKyAgICAgICAgKiB3dGYvd2luL1dvcmtRdWV1ZVdpbi5jcHA6CisgICAg ICAgIChXVEY6OldvcmtRdWV1ZTo6d29ya1RocmVhZENhbGxiYWNrKToKKyAgICAgICAgKFdURjo6 V29ya1F1ZXVlOjpwZXJmb3JtV29ya09uUmVnaXN0ZXJlZFdvcmtUaHJlYWQpOgorICAgICAgICAo V1RGOjpXb3JrUXVldWU6OmRpc3BhdGNoKToKKwogMjAxNy0wOC0zMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBGaWxlU3lzdGVtRGlyZWN0b3J5 UmVhZGVyLnJlYWRFbnRyaWVzKCkKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVX aW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3dpbi9Xb3JrUXVldWVXaW4uY3Bw CShyZXZpc2lvbiAyMjEzODEpCisrKyBTb3VyY2UvV1RGL3d0Zi93aW4vV29ya1F1ZXVlV2luLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzcsMTAgKzM3LDExIEBAIERXT1JEIFdvcmtRdWV1ZTo6d29y a1RocmVhZENhbGxiYWNrKHZvaWQKIAogICAgIFdvcmtRdWV1ZSogcXVldWUgPSBzdGF0aWNfY2Fz dDxXb3JrUXVldWUqPihjb250ZXh0KTsKIAotICAgIGlmICghcXVldWUtPnRyeVJlZ2lzdGVyQXNX b3JrVGhyZWFkKCkpCi0gICAgICAgIHJldHVybiAwOworICAgIGlmIChxdWV1ZS0+dHJ5UmVnaXN0 ZXJBc1dvcmtUaHJlYWQoKSkKKyAgICAgICAgcXVldWUtPnBlcmZvcm1Xb3JrT25SZWdpc3RlcmVk V29ya1RocmVhZCgpOworCisgICAgcXVldWUtPmRlcmVmKCk7CiAKLSAgICBxdWV1ZS0+cGVyZm9y bVdvcmtPblJlZ2lzdGVyZWRXb3JrVGhyZWFkKCk7CiAgICAgcmV0dXJuIDA7CiB9CiAKQEAgLTU2 LDEwICs1Nyw4IEBAIHZvaWQgV29ya1F1ZXVlOjpwZXJmb3JtV29ya09uUmVnaXN0ZXJlZFcKIAog ICAgICAgICAvLyBBbGxvdyBtb3JlIHdvcmsgdG8gYmUgc2NoZWR1bGVkIHdoaWxlIHdlJ3JlIG5v dCB1c2luZyB0aGUgcXVldWUgZGlyZWN0bHkuCiAgICAgICAgIG1fZnVuY3Rpb25RdWV1ZUxvY2su dW5sb2NrKCk7Ci0gICAgICAgIGZvciAoYXV0byYgZnVuY3Rpb24gOiBmdW5jdGlvblF1ZXVlKSB7 CisgICAgICAgIGZvciAoYXV0byYgZnVuY3Rpb24gOiBmdW5jdGlvblF1ZXVlKQogICAgICAgICAg ICAgZnVuY3Rpb24oKTsKLSAgICAgICAgICAgIGRlcmVmKCk7Ci0gICAgICAgIH0KICAgICAgICAg bV9mdW5jdGlvblF1ZXVlTG9jay5sb2NrKCk7CiAgICAgfQogCkBAIC0xMDAsMTQgKzk5LDcgQEAg dm9pZCBXb3JrUXVldWU6OnBsYXRmb3JtSW52YWxpZGF0ZSgpCiAKIHZvaWQgV29ya1F1ZXVlOjpk aXNwYXRjaChGdW5jdGlvbjx2b2lkKCk+JiYgZnVuY3Rpb24pCiB7Ci0gICAgLy8gRklYTUU6IER1 cmluZyBsYXlvdXQgdGVzdHMsIHRoaXMgbWV0aG9kIGlzIHNvbWV0aW1lcyBjYWxsZWQgd2l0aCBh IG51bGxwdHIgZnVuY3Rpb24gcGFyYW1ldGVyLgotICAgIC8vIFRoaXMgaXMgdHJhY2tlZCBpbiA8 aHR0cDovL3dlYmtpdC5vcmcvYi8xNzYwNzI+LgotICAgIEFTU0VSVChmdW5jdGlvbik7Ci0gICAg aWYgKCFmdW5jdGlvbikKLSAgICAgICAgcmV0dXJuOwotCiAgICAgTXV0ZXhMb2NrZXIgbG9ja2Vy KG1fZnVuY3Rpb25RdWV1ZUxvY2spOwotICAgIHJlZigpOwogICAgIG1fZnVuY3Rpb25RdWV1ZS5h cHBlbmQoV1RGTW92ZShmdW5jdGlvbikpOwogCiAgICAgLy8gU3Bhd24gYSB3b3JrIHRocmVhZCB0 byBwZXJmb3JtIHRoZSB3b3JrIHdlIGp1c3QgYWRkZWQuIEFzIGFuIG9wdGltaXphdGlvbiwgd2Ug YXZvaWQKQEAgLTExNiw4ICsxMDgsMTAgQEAgdm9pZCBXb3JrUXVldWU6OmRpc3BhdGNoKEZ1bmN0 aW9uPHZvaWQoKQogICAgIC8vIGhhc24ndCByZWdpc3RlcmVkIGl0c2VsZiB5ZXQsIG1faXNXb3Jr VGhyZWFkUmVnaXN0ZXJlZCB3aWxsIGJlIGZhbHNlIGFuZCB3ZSdsbCBlbmQgdXAKICAgICAvLyBz cGF3bmluZyBhIHNlY29uZCB3b3JrIHRocmVhZCBoZXJlLiBCdXQgd29yayB0aHJlYWQgcmVnaXN0 cmF0aW9uIHByb2Nlc3Mgd2lsbCBlbnN1cmUgdGhhdAogICAgIC8vIG9ubHkgb25lIHRocmVhZCBh Y3R1YWxseSBlbmRzIHVwIHBlcmZvcm1pbmcgd29yay4pCi0gICAgaWYgKCFtX2lzV29ya1RocmVh ZFJlZ2lzdGVyZWQpCisgICAgaWYgKCFtX2lzV29ya1RocmVhZFJlZ2lzdGVyZWQpIHsKKyAgICAg ICAgcmVmKCk7CiAgICAgICAgIDo6UXVldWVVc2VyV29ya0l0ZW0od29ya1RocmVhZENhbGxiYWNr LCB0aGlzLCBXVF9FWEVDVVRFREVGQVVMVCk7CisgICAgfQogfQogCiBzdHJ1Y3QgVGltZXJDb250 ZXh0IDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPFRpbWVyQ29udGV4dD4gewo=